Add APSS clock controller support for IPQ6018
v8 cover Add APSS clock controller support for IPQ6018
The CPU on Qualcomm's IPQ6018 devices are primarily fed by APSS PLL and XO, these are connected to a clock mux and enable block.
This patch series adds support for these clocks and inturn enables clocks required for CPU freq.
[V8]
* In patch 1 changed compatible string from const to enum
* Since this change is minimal retained Review tag from Rob
* In patch 3 re added Ack from Rob
[V7]
* Removed dts patch from this series, will send that separately
* Addressed Rob's minor comment on the binding
* Patch 1 depends on a53 pll bindings
https://lkml.org/lkml/2020/5/4/60
[V6]
* Split mailbox driver from this series, mailbox changes will sent as a separate series
* Addressed review comments from Stephen
[V5]
* Addressed Bjorn comments on apss clk and dt-bindings
* Patch 2 depends on a53 pll dt-bindings
https://www.spinics.net/lists/linux-clk/msg48358.html
[V4]
* Re-written PLL found on IPQ platforms as a separate driver
* Addressed stephen's comments on apss clock controller and pll
* Addressed Rob's review comments on bindings
* moved a53 pll binding from this series as it is not applicable, will send it separately.
[V3]
* Fixed dt binding check error in patch2
dt-bindings: clock: Add YAML schemas for QCOM A53 PLL
[V2]
* Restructred the patch series as there are two different HW blocks, the mux and enable belongs to the apcs block and PLL has a separate HW block.
* Converted qcom mailbox and qcom a53 pll documentation to yaml.
* Addressed review comments from Stephen, Rob and Sibi where it is applicable.
* Changed this cover letter to state the purpose of this patch series
Sivaprakash Murugesan (4):
dt-bindings: clock: add ipq6018 a53 pll compatible
clk: qcom: Add ipq apss pll driver
clk: qcom: Add DT bindings for ipq6018 apss clock controller
clk: qcom: Add ipq6018 apss clock controller
.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++ drivers/clk/qcom/Kconfig | 19 ++++ drivers/clk/qcom/Makefile | 2 + drivers/clk/qcom/apss-ipq-pll.c | 95 ++++++++++++++++++ drivers/clk/qcom/apss-ipq6018.c | 106 +++++++++++++++++++++ include/dt-bindings/clock/qcom,apss-ipq.h | 12 +++ 6 files changed, 252 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq-pll.c create mode 100644 drivers/clk/qcom/apss-ipq6018.c create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
Signature · 1 line
2.7.4
PATCH v8 1/4 dt-bindings: clock: add ipq6018 a53 pll compatible
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
---
[V8]
* converted compatible strings from const to enum to avoid dt binding error
* retained Rob's review tag as the change is minimal
.../devicetree/bindings/clock/qcom,a53pll.yaml | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +20 -1
@@ -15,7 +15,9 @@ description: properties: compatible: - const: qcom,msm8916-a53pll + enum: + - qcom,ipq6018-a53pll + - qcom,msm8916-a53pll reg: maxItems: 1
@@ -23,6 +25,14 @@ properties: '#clock-cells': const: 0 + clocks: + items: + - description: board XO clock + + clock-names: + items: + - const: xo + required: - compatible - reg
@@ -38,3 +48,12 @@ examples: reg = <0xb016000 0x40>; #clock-cells = <0>; }; + #Example 2 - A53 PLL found on IPQ6018 devices + - | + a53pll_ipq: clock-controller@b116000 { + compatible = "qcom,ipq6018-a53pll"; + reg = <0x0b116000 0x40>; + #clock-cells = <0>; + clocks = <&xo>; + clock-names = "xo"; + };
Signature · 1 line
2.7.4
Re: [PATCH V8 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
Quoting Sivaprakash Murugesan (2020-06-21 21:28:09)
Quoted 6 lines
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
Reviewed-by Rob Herring <[email protected]>Signed-off-by Sivaprakash Murugesan <[email protected]>---
Applied to clk-next
PATCH v8 2/4 clk: qcom: Add ipq apss pll driver
In reply to Sivaprakash MurugesanThe CPUs on Qualcomm ipq based devices are clocked by an alpha PLL. Add support for the apss pll found on ipq based devices which can support CPU frequencies above 1Ghz.
--- drivers/clk/qcom/Kconfig | 8 ++++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/apss-ipq-pll.c | 95 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 104 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq-pll.c
drivers/clk/qcom/Kconfig +8 -0
@@ -89,6 +89,14 @@ config APQ_MMCC_8084 Say Y if you want to support multimedia devices such as display, graphics, video encode/decode, camera, etc. +config IPQ_APSS_PLL + tristate "IPQ APSS PLL" + help + Support for APSS PLL on ipq devices. The APSS PLL is the main + clock that feeds the CPUs on ipq based devices. + Say Y if you want to support CPU frequency scaling on ipq based + devices. + config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" help
drivers/clk/qcom/Makefile +1 -0
@@ -19,6 +19,7 @@ clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o # Keep alphabetically sorted by config obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o +obj-$(CONFIG_IPQ_APSS_PLL) += apss-ipq-pll.o obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
drivers/clk/qcom/apss-ipq-pll.c new file +95 -0
95 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH V8 2/4] clk: qcom: Add ipq apss pll driver
Quoting Sivaprakash Murugesan (2020-06-21 21:28:10)
Quoted 6 lines
The CPUs on Qualcomm ipq based devices are clocked by an alpha PLL. Add support for the apss pll found on ipq based devices which can support CPU frequencies above 1Ghz.
Signed-off-by Sivaprakash Murugesan <[email protected]>---
Applied to clk-next
PATCH v8 3/4 clk: qcom: Add DT bindings for ipq6018 apss clock controller
In reply to Sivaprakash MurugesanAdd dt-binding for ipq6018 apss clock controller
---
[V8]
* took Ack from Rob
include/dt-bindings/clock/qcom,apss-ipq.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
include/dt-bindings/clock/qcom,apss-ipq.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2018, The Linux Foundation. All rights reserved. +*/ + +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H + +#define APCS_ALIAS0_CLK_SRC 0 +#define APCS_ALIAS0_CORE_CLK 1 + +#endif
Signature · 1 line
2.7.4
Re: [PATCH V8 3/4] clk: qcom: Add DT bindings for ipq6018 apss clock controller
Quoting Sivaprakash Murugesan (2020-06-21 21:28:11)
Quoted 5 lines
Add dt-binding for ipq6018 apss clock controller
Acked-by Rob Herring <[email protected]>Signed-off-by Sivaprakash Murugesan <[email protected]>---
Applied to clk-next
PATCH v8 4/4 clk: qcom: Add ipq6018 apss clock controller
In reply to Sivaprakash MurugesanThe CPU on Qualcomm ipq6018 devices are clocked primarily by a aplha PLL and xo which are connected to a mux and enable block.
Add support for the mux and enable block which feeds the CPU on ipq6018 devices.
--- drivers/clk/qcom/Kconfig | 11 +++++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/apss-ipq6018.c | 106 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq6018.c
drivers/clk/qcom/Kconfig +11 -0
@@ -97,6 +97,17 @@ config IPQ_APSS_PLL Say Y if you want to support CPU frequency scaling on ipq based devices. +config IPQ_APSS_6018 + tristate "IPQ APSS Clock Controller" + select IPQ_APSS_PLL + depends on QCOM_APCS_IPC || COMPILE_TEST + help + Support for APSS clock controller on IPQ platforms. The + APSS clock controller manages the Mux and enable block that feeds the + CPUs. + Say Y if you want to support CPU frequency scaling on + ipq based devices. + config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" help
drivers/clk/qcom/Makefile +1 -0
@@ -20,6 +20,7 @@ clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o obj-$(CONFIG_IPQ_APSS_PLL) += apss-ipq-pll.o +obj-$(CONFIG_IPQ_APSS_6018) += apss-ipq6018.o obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
drivers/clk/qcom/apss-ipq6018.c new file +106 -0
106 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH V8 4/4] clk: qcom: Add ipq6018 apss clock controller
Quoting Sivaprakash Murugesan (2020-06-21 21:28:12)
Quoted 9 lines
The CPU on Qualcomm ipq6018 devices are clocked primarily by a aplha PLL and xo which are connected to a mux and enable block.
Add support for the mux and enable block which feeds the CPU on ipq6018 devices.
Reviewed-by Stephen Boyd <[email protected]>Signed-off-by Sivaprakash Murugesan <[email protected]>---
Applied to clk-next