Skip to content

Add APSS clock controller support for IPQ6018

Sivaprakash Murugesan linux-arm-msm linux-clk linux-devicetree lkml 8 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest4 patches 4 repliesApplied
  2. v74 patches 7 repliesSuperseded
  3. v65 patches 8 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v58 patches7 repliesSuperseded
v48 patches10 repliesSuperseded
v38 patches12 repliesSuperseded
v28 patches1 replySuperseded
v12 patches10 repliesSuperseded

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: clock: add ipq6018 a53 pll compatibleDocumentation/devicetree/bindings/clock/qcom,a53pll.yaml+20 -11 reply
2/4clk: qcom: Add ipq apss pll driverdrivers/clk/qcom/Kconfig drivers/clk/qcom/Makefile drivers/clk/qcom/apss-ipq-pll.c+104 -01 reply
3/4clk: qcom: Add DT bindings for ipq6018 apss clock controllerinclude/dt-bindings/clock/qcom,apss-ipq.h+12 -01 reply
4/4clk: qcom: Add ipq6018 apss clock controllerdrivers/clk/qcom/Kconfig drivers/clk/qcom/Makefile drivers/clk/qcom/apss-ipq6018.c+118 -01 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchStephen BoydRob Herring
1/4R-b
2/4
3/4A-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH V8 0/4] Add APSS clock controller support for IPQ6018

The CPU on Qualcomm's IPQ6018 devices are primarily fed by APSS PLL and XO, these are connected to a clock mux and enable block.

This patch series adds support for these clocks and inturn enables clocks required for CPU freq.

[V8]
* In patch 1 changed compatible string from const to enum
* Since this change is minimal retained Review tag from Rob
* In patch 3 re added Ack from Rob
[V7]
* Removed dts patch from this series, will send that separately
* Addressed Rob's minor comment on the binding
* Patch 1 depends on a53 pll bindings
https://lkml.org/lkml/2020/5/4/60
[V6]
* Split mailbox driver from this series, mailbox changes will sent as a separate series
* Addressed review comments from Stephen
[V5]
* Addressed Bjorn comments on apss clk and dt-bindings
* Patch 2 depends on a53 pll dt-bindings
https://www.spinics.net/lists/linux-clk/msg48358.html
[V4]
* Re-written PLL found on IPQ platforms as a separate driver
* Addressed stephen's comments on apss clock controller and pll
* Addressed Rob's review comments on bindings
* moved a53 pll binding from this series as it is not applicable, will send it separately.
[V3]
* Fixed dt binding check error in patch2
dt-bindings: clock: Add YAML schemas for QCOM A53 PLL
[V2]
* Restructred the patch series as there are two different HW blocks, the mux and enable belongs to the apcs block and PLL has a separate HW block.
* Converted qcom mailbox and qcom a53 pll documentation to yaml.
* Addressed review comments from Stephen, Rob and Sibi where it is applicable.
* Changed this cover letter to state the purpose of this patch series

Sivaprakash Murugesan (4):
dt-bindings: clock: add ipq6018 a53 pll compatible
clk: qcom: Add ipq apss pll driver
clk: qcom: Add DT bindings for ipq6018 apss clock controller
clk: qcom: Add ipq6018 apss clock controller

 .../devicetree/bindings/clock/qcom,a53pll.yaml     |  18 ++++
 drivers/clk/qcom/Kconfig                           |  19 ++++
 drivers/clk/qcom/Makefile                          |   2 +
 drivers/clk/qcom/apss-ipq-pll.c                    |  95 ++++++++++++++++++
 drivers/clk/qcom/apss-ipq6018.c                    | 106 +++++++++++++++++++++
 include/dt-bindings/clock/qcom,apss-ipq.h          |  12 +++
 6 files changed, 252 insertions(+)
 create mode 100644 drivers/clk/qcom/apss-ipq-pll.c
 create mode 100644 drivers/clk/qcom/apss-ipq6018.c
 create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
Signature · 1 line
2.7.4