Fix return value check
v3 cover Fix return value check
In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.
---v2->v3
- Modify formatv3->v4
- Change commit number to 12 characters
Lu Wei (2):
intel-hid: Fix return value check in check_acpi_dev()
intel-vbtn: Fix return value check in check_acpi_dev()
drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
PATCH v3 1/2 intel-hid: Fix return value check in check_acpi_dev()
In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.
---
drivers/platform/x86/intel-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel-hid.c +1 -1
@@ -564,7 +564,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)return AE_OK ;if (acpi_match_device_ids (dev, ids) ==0 ) -if (acpi_create_platform_device (dev,NULL )) +if (!IS_ERR_OR_NULL (acpi_create_platform_device (dev,NULL )))dev_info (&dev->dev,"intel-hid: created platform device\n" );
--
2.7.4
PATCH v3 2/2 intel-vbtn: Fix return value check in check_acpi_dev()
In reply to Lu WeiIn the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.
---
drivers/platform/x86/intel-vbtn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel-vbtn.c +1 -1
@@ -251,7 +251,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)return AE_OK ;if (acpi_match_device_ids (dev, ids) ==0 ) -if (acpi_create_platform_device (dev,NULL )) +if (!IS_ERR_OR_NULL (acpi_create_platform_device (dev,NULL )))dev_info (&dev->dev,"intel-vbtn: created platform device\n" );
--
2.7.4
Quoted 5 lines · Lu Wei
In the function
check_acpi_dev(), if it fails to create platform device, the return value isERR_PTR()or NULL. Thus it must useIS_ERR_OR_NULLto check return value.
Pushed to my review and testing queue, thanks!
Quoted 17 lines
---
v2->v3
- Modify formatv3->v4
- Change commit number to 12 charactersLu Wei (2):
intel-hid: Fix return value check incheck_acpi_dev()
intel-vbtn: Fix return value check incheck_acpi_dev()drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)--
2.7.4
Signature · 2 lines
With Best Regards, Andy Shevchenko