Skip to contentSkip to conversation

Fix return value check

PATCH Superseded Lu Wei 1 participant 3 messages Jul 10, 2020 x86 platform drivers

lore
Share & tools
lore

Lu Wei

author
#0 lore raw

v3 cover Fix return value check

In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.

*** BLURB HERE ***

Lu Wei (2):
intel-hid: Fix return value check in check_acpi_dev()
intel-vbtn: Fix return value check in check_acpi_dev()

 drivers/platform/x86/intel-hid.c  | 2 +-
 drivers/platform/x86/intel-vbtn.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/2 intel-hid: Fix return value check in check_acpi_dev()

In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.

Fixes ecc83e52b28c ("intel-hid: new hid event driver for hotkeys")

---
v2->v3
- Modify format

 drivers/platform/x86/intel-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel-hid.c +1 -1
index cc7dd4d..c45250c 100644
@@ -564,7 +564,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
 		return AE_OK;
 
 	if (acpi_match_device_ids(dev, ids) == 0)
-		if (acpi_create_platform_device(dev, NULL))
+		if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
 			dev_info(&dev->dev,
 				 "intel-hid: created platform device\n");
 
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH v3 2/2 intel-vbtn: Fix return value check in check_acpi_dev()

In reply to Lu Wei

In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.

Fixes 332e0812 ("intel-vbtn: new driver for Intel Virtual Button")

---
v2->v3
- Modify format

 drivers/platform/x86/intel-vbtn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel-vbtn.c +1 -1
index b588093..e1aa526 100644
@@ -251,7 +251,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
 		return AE_OK;
 
 	if (acpi_match_device_ids(dev, ids) == 0)
-		if (acpi_create_platform_device(dev, NULL))
+		if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
 			dev_info(&dev->dev,
 				 "intel-vbtn: created platform device\n");
 

--
2.7.4