regulator: add missing call to of_node_put()
Subsystems (2)
PATCH v2 1/1 regulator: add missing call to of_node_put()
In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 347.
---
Changes in v2:
-add braces for if
drivers/regulator/scmi-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/regulator/scmi-regulator.c +3 -1
@@ -343,8 +343,10 @@ static int scmi_regulator_probe(struct scmi_device *sdev)for_each_child_of_node (np, child) { ret =process_scmi_regulator_of_node (sdev, child, rinfo);/* abort on any mem issue */ -if (ret == -ENOMEM ) +if (ret == -ENOMEM ) { +of_node_put (child);return ret; + } }/*
Signature · 1 line
1.8.3.1
Mark Brown
maintainerQuoted 7 lines · Yang Li
In one of the error paths of the
for_each_child_of_node()loop, add missing call toof_node_put().Fix the following coccicheck warning:
./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function "for_each_child_of_node" should haveof_node_put()before return around line 347.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: add missing call to of_node_put()
commit: 755a74fc655ee95ce37bb0f552cbd39b52978a05
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel