Skip to contentSkip to conversation

pinctrl: ingenic: add missing call to of_node_put()

PATCH Superseded Yang Li 3 participants 3 messages Feb 26, 2021 – Mar 3, 2021

Subsystems (4)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 pinctrl: ingenic: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop in ingenic_gpio_probe, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2489.

---

Changes in v2:
-add braces for if

 drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-ingenic.c +3 -1
index f274612..c8ecd01 100644
@@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
 	for_each_child_of_node(dev->of_node, node) {
 		if (of_match_node(ingenic_gpio_of_match, node)) {
 			err = ingenic_gpio_probe(jzpc, node);
-			if (err)
+			if (err) {
+				of_node_put(node);
 				return err;
+			}
 		}
 	}
 
Signature · 1 line
1.8.3.1
maintainer Acked-by on v2 1/1
#1 lore raw

Hi,

Quoted 10 lines · Yang Li

In one of the error paths of the for_each_child_of_node() loop in ingenic_gpio_probe, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2489.

Cheers,
-Paul

Quoted 28 lines

---

Changes in v2:

(quoted diff) +0 -1
-add braces for if
 
 drivers/pinctrl/pinctrl-ingenic.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-ingenic.c +3 -2
index f274612..c8ecd01 100644
@@ -2485,8 +2485,10 @@ static int __init ingenic_pinctrl_probe(struct 
 platform_device *pdev)
 	for_each_child_of_node(dev->of_node, node) {
 		if (of_match_node(ingenic_gpio_of_match, node)) {
 			err = ingenic_gpio_probe(jzpc, node);
-			if (err)
+			if (err) {
+				of_node_put(node);
 				return err;
+			}
 		}
 	}
 
--

1.8.3.1

#2 lore raw
In reply to Yang Li
Quoted 10 lines · Yang Li

In one of the error paths of the for_each_child_of_node() loop in ingenic_gpio_probe, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2489.

Oops applied this rather than v1.

Yours,
Linus Walleij