Skip to contentSkip to conversation

arm64: dts: qcom: sc7280: Add WPSS remoteproc node

PATCH Superseded Rakesh Pillai 2 participants 3 messages Sep 16, 2021 – Sep 17, 2021

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Rakesh Pillai

author
#0 lore raw

PATCH v3 1/1 arm64: dts: qcom: sc7280: Add WPSS remoteproc node

Add the WPSS remoteproc node in dts for
PIL loading.

Signed-off-by Rakesh Pillai <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  4 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 63 +++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
index 64fc22a..2b8bbcd 100644
@@ -68,3 +68,7 @@
 		qcom,pre-scaling = <1 1>;
 	};
 };
+
+&remoteproc_wpss {
+	status = "okay";
+};
arch/arm64/boot/dts/qcom/sc7280.dtsi +63 -0

79 lines not on this page · raw message

Signature · 1 line
2.7.4
#1 lore raw

Quoting Rakesh Pillai (2021-09-16 09:52:01)

Quoted 36 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +28 -0
index 64fc22a..2b8bbcd 100644
@@ -1423,6 +1433,59 @@
                        #power-domain-cells = <1>;
                };
 
+               remoteproc_wpss: remoteproc@8a00000 {
+                       compatible = "qcom,sc7280-wpss-pil";
+                       reg = <0 0x08a00000 0 0x10000>;
+
+                       interrupts-extended = <&intc GIC_SPI 587 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
+                       interrupt-names = "wdog", "fatal", "ready", "handover",
+                                         "stop-ack", "shutdown-ack";
+
+                       clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>,
+                                <&gcc GCC_WPSS_AHB_CLK>,
+                                <&gcc GCC_WPSS_RSCP_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK>;
+                       clock-names = "gcc_wpss_ahb_bdg_mst_clk",
+                                     "gcc_wpss_ahb_clk",
+                                     "gcc_wpss_rscp_clk",
+                                     "xo";
+
+                       power-domains = <&rpmhpd SC7280_CX>,
+                                       <&rpmhpd SC7280_MX>;
+                       power-domain-names = "cx", "mx";
+
+                       memory-region = <&wpss_mem>;
+

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 1473

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +10 -0
+                       qcom,qmp = <&aoss_qmp>;
+
+                       qcom,smem-states = <&wpss_smp2p_out 0>;
+                       qcom,smem-state-names = "stop";
+
+                       resets = <&aoss_reset AOSS_CC_WCSS_RESTART>,
+                                <&pdc_reset PDC_WPSS_SYNC_RESET>;
+                       reset-names = "restart", "pdc_sync";
+
+                       qcom,halt-regs = <&tcsr_mutex_regs 0x37000>;

Where is this node defined? I don't see it on the mailing list for sc7280. Can you indicate what patches this depends on, and use git format-patch --base= so we can try to find them ourselves.

author
#2 lore raw
Quoted 58 lines

-----Original Message-----
From: Stephen Boyd <[email protected]>
Sent: Friday, September 17, 2021 6:25 AM
To: Rakesh Pillai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

Quoting Rakesh Pillai (2021-09-16 09:52:01)

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -0
index 64fc22a..2b8bbcd 100644

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 1440

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +5 -0
@@ -1423,6 +1433,59 @@
                        #power-domain-cells = <1>;
                };
 
+               remoteproc_wpss: remoteproc@8a00000 {
+                       compatible = "qcom,sc7280-wpss-pil";
+                       reg = <0 0x08a00000 0 0x10000>;
+
+                       interrupts-extended = <&intc GIC_SPI 587

IRQ_TYPE_EDGE_RISING>,

Quoted 29 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +29 -0
+                                             <&wpss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
+                                             <&wpss_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
+                       interrupt-names = "wdog", "fatal", "ready", "handover",
+                                         "stop-ack", "shutdown-ack";
+
+                       clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>,
+                                <&gcc GCC_WPSS_AHB_CLK>,
+                                <&gcc GCC_WPSS_RSCP_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK>;
+                       clock-names = "gcc_wpss_ahb_bdg_mst_clk",
+                                     "gcc_wpss_ahb_clk",
+                                     "gcc_wpss_rscp_clk",
+                                     "xo";
+
+                       power-domains = <&rpmhpd SC7280_CX>,
+                                       <&rpmhpd SC7280_MX>;
+                       power-domain-names = "cx", "mx";
+
+                       memory-region = <&wpss_mem>;
+
+                       qcom,qmp = <&aoss_qmp>;
+
+                       qcom,smem-states = <&wpss_smp2p_out 0>;
+                       qcom,smem-state-names = "stop";
+
+                       resets = <&aoss_reset AOSS_CC_WCSS_RESTART>,
Quoted 8 lines

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 1473

Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
+                                <&pdc_reset PDC_WPSS_SYNC_RESET>;
+                       reset-names = "restart", "pdc_sync";
+
+                       qcom,halt-regs = <&tcsr_mutex_regs 0x37000>;

Where is this node defined? I don't see it on the mailing list for sc7280. Can you indicate what patches this depends on, and use git format-patch --base= so we can try to find them ourselves.

Hi Stephen,
My bad, it shud be "tcsr_mutex" instead of "tcsr_mutex_regs". I will correct it and send v4.