Skip to contentSkip to conversation

media: staging: ipu3-imgu: clarify the limitation of grid config

PATCH In review Bingbu Cao 3 participants 3 messages Oct 18, 2021 – Oct 19, 2021

Subsystems (3)
lore
Share & tools
lore

Bingbu Cao

author
#0 lore raw

PATCH v2 1/1 media: staging: ipu3-imgu: clarify the limitation of grid config

There are some grid configuration limitations for ImgU, which was not described clearly in current uAPI header file, add the description to help user to set the grid configuration correctly.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +8 -2
index fa3d6ee5adf2..6d3ebb880a64 100644
@@ -34,11 +34,17 @@
  * struct ipu3_uapi_grid_config - Grid plane config
  *
  * @width:	Grid horizontal dimensions, in number of grid blocks(cells).
+ *		For AWB, the range is (16, 80).
+ *		For AF/AE, the range is (16, 32).
  * @height:	Grid vertical dimensions, in number of grid cells.
+ *		For AWB, the range is (16, 60).
+ *		For AF/AE, the range is (16, 24).
  * @block_width_log2:	Log2 of the width of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is [3, 6].
+ *			For AF/AE, the range is [3, 7].
  * @block_height_log2:	Log2 of the height of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is [3, 6].
+ *			For AF/AE, the range is [3, 7].
  * @height_per_slice:	The number of blocks in vertical axis per slice.
  *			Default 2.
  * @x_start: X value of top left corner of Region of Interest(ROI).
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1
#1 lore raw

Quoting Bingbu Cao (2021-10-18 03:48:15)

Quoted 6 lines

There are some grid configuration limitations for ImgU, which was not described clearly in current uAPI header file, add the description to help user to set the grid configuration correctly.

Quoted 31 lines
---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +8 -2
index fa3d6ee5adf2..6d3ebb880a64 100644
@@ -34,11 +34,17 @@
  * struct ipu3_uapi_grid_config - Grid plane config
  *
  * @width:     Grid horizontal dimensions, in number of grid blocks(cells).
+ *             For AWB, the range is (16, 80).
+ *             For AF/AE, the range is (16, 32).
  * @height:    Grid vertical dimensions, in number of grid cells.
+ *             For AWB, the range is (16, 60).
+ *             For AF/AE, the range is (16, 24).
  * @block_width_log2:  Log2 of the width of each cell in pixels.
- *                     for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *                     For AWB, the range is [3, 6].
+ *                     For AF/AE, the range is [3, 7].
  * @block_height_log2: Log2 of the height of each cell in pixels.
- *                     for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *                     For AWB, the range is [3, 6].
+ *                     For AF/AE, the range is [3, 7].
  * @height_per_slice:  The number of blocks in vertical axis per slice.
  *                     Default 2.
  * @x_start: X value of top left corner of Region of Interest(ROI).
Signature · 1 line
2.7.4
#2 lore raw

Hi Bingbu !

Quoted 9 lines · Kieran Bingham

Quoting Bingbu Cao (2021-10-18 03:48:15)

Quoted 6 lines

There are some grid configuration limitations for ImgU, which was not described clearly in current uAPI header file, add the description to help user to set the grid configuration correctly.

Thanks a lot, it helps :-) !

Quoted 32 lines
Quoted 32 lines
---
  drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +8 -2
index fa3d6ee5adf2..6d3ebb880a64 100644
@@ -34,11 +34,17 @@
   * struct ipu3_uapi_grid_config - Grid plane config
   *
   * @width:     Grid horizontal dimensions, in number of grid blocks(cells).
+ *             For AWB, the range is (16, 80).
+ *             For AF/AE, the range is (16, 32).
   * @height:    Grid vertical dimensions, in number of grid cells.
+ *             For AWB, the range is (16, 60).
+ *             For AF/AE, the range is (16, 24).
   * @block_width_log2:  Log2 of the width of each cell in pixels.
- *                     for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *                     For AWB, the range is [3, 6].
+ *                     For AF/AE, the range is [3, 7].
   * @block_height_log2: Log2 of the height of each cell in pixels.
- *                     for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *                     For AWB, the range is [3, 6].
+ *                     For AF/AE, the range is [3, 7].
   * @height_per_slice:  The number of blocks in vertical axis per slice.
   *                     Default 2.
   * @x_start: X value of top left corner of Region of Interest(ROI).
Signature · 1 line
2.7.4