Skip to contentSkip to conversation

media: staging: ipu3-imgu: clarify the limitation of grid config

PATCH Superseded Bingbu Cao 2 participants 2 messages Oct 14, 2021 – Oct 16, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bingbu Cao

author
#0 lore raw

PATCH 1/1 media: staging: ipu3-imgu: clarify the limitation of grid config

There are some grid configuration limitations for ImgU, which was not described clearly in current uAPI header file, add the description to help user to set the grid configuration correctly.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +12 -2
index fa3d6ee5adf2..65290c1b1892 100644
@@ -34,11 +34,21 @@
  * struct ipu3_uapi_grid_config - Grid plane config
  *
  * @width:	Grid horizontal dimensions, in number of grid blocks(cells).
+ *		For AWB, the range is (16, 80),
+ *		for AF/AE, the range is (16, 32).
  * @height:	Grid vertical dimensions, in number of grid cells.
+ *		For AWB, the range is (16, 60),
+ *		For AF/AE, the range is (16, 24).
  * @block_width_log2:	Log2 of the width of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @block_height_log2:	Log2 of the height of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @height_per_slice:	The number of blocks in vertical axis per slice.
  *			Default 2.
  * @x_start: X value of top left corner of Region of Interest(ROI).
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Bingbu,

Thank you for the patch.

Quoted 17 lines · Bingbu Cao

There are some grid configuration limitations for ImgU, which was not described clearly in current uAPI header file, add the description to help user to set the grid configuration correctly.

---
 drivers/staging/media/ipu3/include/uapi/intel-ipu3.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +0 -0
index fa3d6ee5adf2..65290c1b1892 100644
@@ -34,11 +34,21 @@
  * struct ipu3_uapi_grid_config - Grid plane config
  *

drivers/staging/media/ipu3/include/uapi/intel-ipu3.h line 44

Quoted 10 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +6 -1
  * @width:	Grid horizontal dimensions, in number of grid blocks(cells).
+ *		For AWB, the range is (16, 80),
+ *		for AF/AE, the range is (16, 32).
  * @height:	Grid vertical dimensions, in number of grid cells.
+ *		For AWB, the range is (16, 60),
+ *		For AF/AE, the range is (16, 24).
  * @block_width_log2:	Log2 of the width of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].

I would have written

* For AWB, the range is [3, 6].

(and similarly below) as I don't think enumerating all the power of two values brings any additional clarity. This predates this patch though, so with or without that change,

Quoted 11 lines
drivers/staging/media/ipu3/include/uapi/intel-ipu3.h +6 -1
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @block_height_log2:	Log2 of the height of each cell in pixels.
- *			for (2^3, 2^4, 2^5, 2^6, 2^7), values [3, 7].
+ *			For AWB, the range is (2^3, 2^4, 2^5, 2^6),
+ *			values [3, 6].
+ *			For AF/AE, the range is (2^3, 2^4, 2^5, 2^6, 2^7),
+ *			values [3, 7].
  * @height_per_slice:	The number of blocks in vertical axis per slice.
  *			Default 2.
  * @x_start: X value of top left corner of Region of Interest(ROI).
Signature · 3 lines
Regards,

Laurent Pinchart