dt-bindings: display: Turn lvds.yaml into a generic schema
Subsystems (5)
PATCH 1/2 dt-bindings: display: Turn lvds.yaml into a generic schema
The lvds.yaml file so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.
That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
--- .../display/panel/advantech,idk-1110wr.yaml | 17 ++++++++++- .../display/panel/innolux,ee101ia-01d.yaml | 21 +++++++++++++- .../bindings/display/panel/lvds.yaml | 29 +------------------ .../display/panel/mitsubishi,aa104xd12.yaml | 17 ++++++++++- .../display/panel/mitsubishi,aa121td01.yaml | 17 ++++++++++- .../display/panel/sgd,gktw70sdae4se.yaml | 17 ++++++++++- 6 files changed, 85 insertions(+), 33 deletions(-)
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +16 -1
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatible + properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24
@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +20 -1
@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible + properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true
@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: false ...
Documentation/devicetree/bindings/display/panel/lvds.yaml +1 -28
@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/panel/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common Properties maintainers: - Laurent Pinchart <[email protected]>
@@ -26,18 +26,7 @@ description: |+ Device compatible with those specifications have been marketed under the FPD-Link and FlatLink brands. -allOf: - - $ref: panel-common.yaml# - properties: - compatible: - contains: - const: panel-lvds - description: - Shall contain "panel-lvds" in addition to a mandatory panel-specific - compatible string defined in individual panel bindings. The "panel-lvds" - value shall never be used on its own. - data-mapping: enum: - jeida-18
@@ -96,22 +85,6 @@ properties: If set, reverse the bit order described in the data mappings below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. - port: true - ports: true - -required: - - compatible - - data-mapping - - width-mm - - height-mm - - panel-timing - -oneOf: - - required: - - port - - required: - - ports - additionalProperties: true ...
Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +16 -1
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: mitsubishi,aa104xd12 + + required: + - compatible + properties: compatible: items: - const: mitsubishi,aa104xd12 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.
@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml +16 -1
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: mitsubishi,aa121td01 + + required: + - compatible + properties: compatible: items: - const: mitsubishi,aa121td01 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.
@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+
Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml +16 -1
@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: sgd,gktw70sdae4se + + required: + - compatible + properties: compatible: items: - const: sgd,gktw70sdae4se - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-18
@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - port + - data-mapping + - width-mm + - height-mm + - panel-timing examples: - |+
Signature · 1 line
2.33.1
PATCH 2/2 dt-bindings: panel: Introduce a panel-lvds binding
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
--- .../bindings/display/panel/panel-lvds.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +56 -0
@@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: lvds.yaml# + +select: + properties: + compatible: + contains: + const: panel-lvds + + not: + properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4se + + required: + - compatible + +properties: + compatible: + items: + - enum: + - auo,b101ew05 + - tbs,a711-panel + + - const: panel-lvds + +unevaluatedProperties: false + +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + +...
Signature · 1 line
2.33.1
Rob Herring
maintainerRe: [PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding
Quoted 10 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Signed-off-by Maxime Ripard <[email protected]>--- .../bindings/display/panel/panel-lvds.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:./Documentation/devicetree/bindings/display/panel/panel-lvds.yaml:28:15: [warning] wrong indentation: expected 12 but found 14 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: compatible:0: 'advantech,idk-2121wr' is not one of ['auo,b101ew05', 'tbs,a711-panel']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1555849
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Re: [PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding
In reply to Maxime RipardQuoted 9 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Signed-off-by Maxime Ripard <[email protected]>--- .../bindings/display/panel/panel-lvds.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
Laurent Pinchart
maintainerRe: [PATCH 2/2] dt-bindings: panel: Introduce a panel-lvds binding
In reply to Maxime RipardHi Maxime,
Thank you for the patch.
Quoted 38 lines · Maxime Ripard
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Signed-off-by Maxime Ripard <[email protected]>--- .../bindings/display/panel/panel-lvds.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yamlDocumentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +22
-0@@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic LVDS Display Panel Device Tree Bindings + +maintainers: + - Lad Prabhakar <[email protected]> + - Thierry Reding <[email protected]> + +allOf: + - $ref: panel-common.yaml# + - $ref: lvds.yaml# + +select: + properties: + compatible: + contains: + const: panel-lvds +
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml line 32
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +10
-0+ not: + properties: + compatible: + contains: + enum: + - advantech,idk-1110wr + - innolux,ee101ia-01d + - mitsubishi,aa104xd12 + - mitsubishi,aa121td01 + - sgd,gktw70sdae4se
This will be annoying to maintain, I'm pretty sure authors will forget to update this file when adding bindings for other panels. Is there any way we could select this binding with a positive rule instead of a negative rule ?
Quoted 24 lines
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file +24
-0+ + required: + - compatible + +properties: + compatible: + items: + - enum: + - auo,b101ew05 + - tbs,a711-panel + + - const: panel-lvds + +unevaluatedProperties: false + +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + +...
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 124 lines · Maxime Ripard
The
lvds.yamlfile so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
Signed-off-by Maxime Ripard <[email protected]>--- .../display/panel/advantech,idk-1110wr.yaml | 17 ++++++++++- .../display/panel/innolux,ee101ia-01d.yaml | 21 +++++++++++++- .../bindings/display/panel/lvds.yaml | 29 +------------------ .../display/panel/mitsubishi,aa104xd12.yaml | 17 ++++++++++- .../display/panel/mitsubishi,aa121td01.yaml | 17 ++++++++++- .../display/panel/sgd,gktw70sdae4se.yaml | 17 ++++++++++- 6 files changed, 85 insertions(+), 33 deletions(-)Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +16
-1@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatible + properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +20
-1@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible + properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: falseDocumentation/devicetree/bindings/display/panel/lvds.yaml +1
-1@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/panel/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common Properties maintainers: - Laurent Pinchart <[email protected]>
Documentation/devicetree/bindings/display/panel/lvds.yaml description: |+ · line 31
Quoted 6 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +0
-3@@ -26,18 +26,7 @@ description: |+ Device compatible with those specifications have been marketed under the FPD-Link and FlatLink brands. -allOf: - - $ref: panel-common.yaml# -
I think you can leave this instead of adding everywhere you include lvds.yaml. Either way,
Laurent Pinchart
maintainerHi Maxime,
Thank you for the patch.
Quoted 32 lines · Maxime Ripard
The
lvds.yamlfile so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
Signed-off-by Maxime Ripard <[email protected]>--- .../display/panel/advantech,idk-1110wr.yaml | 17 ++++++++++- .../display/panel/innolux,ee101ia-01d.yaml | 21 +++++++++++++- .../bindings/display/panel/lvds.yaml | 29 +------------------ .../display/panel/mitsubishi,aa104xd12.yaml | 17 ++++++++++- .../display/panel/mitsubishi,aa121td01.yaml | 17 ++++++++++- .../display/panel/sgd,gktw70sdae4se.yaml | 17 ++++++++++- 6 files changed, 85 insertions(+), 33 deletions(-)Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +1
-0@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml#
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml maintainers: · line 24
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +8
-0- $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatible
I've never encountered this before, what does it do ?
Quoted 73 lines
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +7
-1+ properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +20
-1@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible + properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: falseDocumentation/devicetree/bindings/display/panel/lvds.yaml +0
-0
Documentation/devicetree/bindings/display/panel/lvds.yaml line 7
Quoted 5 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +1
-1@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/panel/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common Properties
Maybe
title: LVDS Display Panel Common Properties
or do you foresee this being useful for non-panel LBDS sinks too ? In that case the title is fine, but the file could be moved in the parent directory.
I'm also wondering what we should do with the data-mapping and data-mirror properties. For an LVDS panel they're fine at the device level, but for an LVDS sink, they may be better placed at the port or endpoint level.
Quoted 168 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +0
-27maintainers: - Laurent Pinchart <[email protected]>@@ -26,18 +26,7 @@ description: |+ Device compatible with those specifications have been marketed under the FPD-Link and FlatLink brands. -allOf: - - $ref: panel-common.yaml# - properties: - compatible: - contains: - const: panel-lvds - description: - Shall contain "panel-lvds" in addition to a mandatory panel-specific - compatible string defined in individual panel bindings. The "panel-lvds" - value shall never be used on its own. - data-mapping: enum: - jeida-18@@ -96,22 +85,6 @@ properties: If set, reverse the bit order described in the data mappings below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. - port: true - ports: true - -required: - - compatible - - data-mapping - - width-mm - - height-mm - - panel-timing - -oneOf: - - required: - - port - - required: - - ports - additionalProperties: trueDocumentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml +16
-1@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: mitsubishi,aa104xd12 + + required: + - compatible + properties: compatible: items: - const: mitsubishi,aa104xd12 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml +16
-1@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: mitsubishi,aa121td01 + + required: + - compatible + properties: compatible: items: - const: mitsubishi,aa121td01 - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds vcc-supply: description: Reference to the regulator powering the panel VCC pins.@@ -39,6 +49,11 @@ additionalProperties: false required: - compatible - vcc-supply + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml +16
-1@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: sgd,gktw70sdae4se + + required: + - compatible + properties: compatible: items: - const: sgd,gktw70sdae4se - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-18@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - port + - data-mapping + - width-mm + - height-mm + - panel-timing examples: - |+
Signature · 3 lines
Regards, Laurent Pinchart
Hi,
Quoted 35 lines · Laurent Pinchart
Quoted 34 lines · Maxime Ripard
The
lvds.yamlfile so far was both defining the generic LVDS properties (such as data-mapping) that could be used for any LVDS sink, but also the panel-lvds binding.That last binding was to describe LVDS panels simple enough, and had a number of other bindings using it as a base to specialise it further.
However, this situation makes it fairly hard to extend and reuse both the generic parts, and the panel-lvds itself.
Let's remove the panel-lvds parts and leave only the generic LVDS properties.
Signed-off-by Maxime Ripard <[email protected]>--- .../display/panel/advantech,idk-1110wr.yaml | 17 ++++++++++- .../display/panel/innolux,ee101ia-01d.yaml | 21 +++++++++++++- .../bindings/display/panel/lvds.yaml | 29 +------------------ .../display/panel/mitsubishi,aa104xd12.yaml | 17 ++++++++++- .../display/panel/mitsubishi,aa121td01.yaml | 17 ++++++++++- .../display/panel/sgd,gktw70sdae4se.yaml | 17 ++++++++++- 6 files changed, 85 insertions(+), 33 deletions(-)Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +1
-0@@ -11,13 +11,23 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml#
Quoted 10 lines
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml maintainers: · line 24
Quoted 8 lines
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +8
-0+select: + properties: + compatible: + contains: + const: advantech,idk-1110wr + + required: + - compatibleI've never encountered this before, what does it do ?
select dictates if the schema is applied to a node or not.
It takes a schema, and if this schema is valid, the rest of the schema will be applied to the current node.
It's mostly unused in the kernel because the dt-validate tool will add a select clause from the compatible list in most case that would expand in this case to:
select:
properties:
contains:
enum:
- advantech,idk-1110wr
- panel-lvds
required:
- compatible
ie, it tries to validate with this schema any node that has either the panel compatible or the generic compatible.
That means we would have that schema applied to all the nodes that have panel-lvds, including the ones with a different compatible than the advantech one.
With this clause, we make sure that we ignore the other panels, while ensuring that the compatible list for the advantech compatible is correct.
Quoted 83 lines
Quoted 73 lines
Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml +7
-1+ properties: compatible: items: - const: advantech,idk-1110wr - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds data-mapping: const: jeida-24@@ -35,6 +45,11 @@ additionalProperties: false required: - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port examples: - |+Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml +20
-1@@ -11,15 +11,26 @@ maintainers: - Thierry Reding <[email protected]> allOf: + - $ref: panel-common.yaml# - $ref: lvds.yaml# +select: + properties: + compatible: + contains: + const: innolux,ee101ia-01d + + required: + - compatible + properties: compatible: items: - const: innolux,ee101ia-01d - - {} # panel-lvds, but not listed here to avoid false select + - const: panel-lvds backlight: true + data-mapping: true enable-gpios: true power-supply: true width-mm: true@@ -27,5 +38,13 @@ properties: panel-timing: true port: true +required: + - compatible + - data-mapping + - width-mm + - height-mm + - panel-timing + - port + additionalProperties: falseDocumentation/devicetree/bindings/display/panel/lvds.yaml +0
-0Documentation/devicetree/bindings/display/panel/lvds.yaml line 7
Quoted 5 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +1
-1@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/panel/lvds.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: LVDS Display Panel +title: LVDS Display Common PropertiesMaybe
title: LVDS Display Panel Common Properties
Quoted 8 lines
or do you foresee this being useful for non-panel LBDS sinks too ? In that case the title is fine, but the file could be moved in the parent directory.
I'm also wondering what we should do with the data-mapping and data-mirror properties. For an LVDS panel they're fine at the device level, but for an LVDS sink, they may be better placed at the port or endpoint level.
That was my intent, but it might not be relevant indeed. Honestly at this point I just want to have the tbs,a711-panel compatible documented somewhere :)
Maxime