Skip to contentSkip to conversation

eth: r8152: try to use a normal budget

PATCH Applied Jakub Kicinski 3 participants 3 messages Aug 14, 2023 – Aug 16, 2023

Subsystems (4)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 eth: r8152: try to use a normal budget

Mario reports that loading r8152 on his system leads to a:

netif_napi_add_weight() called with weight 256

warning getting printed. We don't have any solid data on why such high budget was chosen, and it may cause stalls in processing other softirqs and rt threads. So try to switch back to the default (64) weight.

If this slows down someone's system we should investigate which part of stopping starting the NAPI poll in this driver are expensive.

---
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 drivers/net/usb/r8152.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/usb/r8152.c +1 -2
index db9897e825b4..bb234cf0cea0 100644
@@ -9760,8 +9760,7 @@ static int rtl8152_probe(struct usb_interface *intf,
 
 	usb_set_intfdata(intf, tp);
 
-	netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
-			      tp->support_2500full ? 256 : 64);
+	netif_napi_add(netdev, &tp->napi, r8152_poll);
 
 	ret = register_netdev(netdev);
 	if (ret != 0) {
Signature · 1 line
2.41.0
Acked-by on v1 1/1
#1 lore raw

akub Kicinski <[email protected]>

Quoted 1 line

Sent: Monday, August 14, 2023 11:35 PM

[...]

Quoted 13 lines

Mario reports that loading r8152 on his system leads to a:

netif_napi_add_weight() called with weight 256

warning getting printed. We don't have any solid data on why such high budget was chosen, and it may cause stalls in processing other softirqs and rt threads. So try to switch back to the default (64) weight.

If this slows down someone's system we should investigate which part of stopping starting the NAPI poll in this driver are expensive.

Quoted 5 lines

Link:
https://lore.kernel.org/all/[email protected]
/

Best Regards,
Hayes

#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Mon, 14 Aug 2023 08:35:21 -0700 you wrote:

Mario reports that loading r8152 on his system leads to a:

netif_napi_add_weight() called with weight 256

warning getting printed. We don't have any solid data on why such high budget was chosen, and it may cause stalls in processing other softirqs and rt threads. So try to switch back to the default (64) weight.

[...]

Here is the summary with links:
- [net-next] eth: r8152: try to use a normal budget

    https://git.kernel.org/netdev/net-next/c/cf74eb5a5bc8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html