devlink: remove redundant health state set to error
Subsystems (2)
PATCH 1/1 devlink: remove redundant health state set to error
Reporter health_state is set twice to error in devlink_health_report(). Remove second time as it is redundant.
Signed-off-by Moshe Shemesh <[email protected]>
Reviewed-by Eran Ben Elisha <[email protected]>
--- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-)
net/core/devlink.c +0 -2
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,return -ECANCELED ; } - reporter->health_state =DEVLINK_HEALTH_REPORTER_STATE_ERROR ; -if (reporter->auto_dump) {mutex_lock (&reporter->dump_lock);/* store current dump of current error, for later analysis */
Signature · 1 line
2.26.3
Quoted 9 lines · Moshe Shemesh
Reporter
health_stateis set twice to error indevlink_health_report(). Remove second time as it is redundant.Signed-off-by Moshe Shemesh <[email protected]>Reviewed-by Eran Ben Elisha <[email protected]>--- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-)
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Sun, 20 Nov 2022 10:36:52 +0200 you wrote:
Reporter
health_stateis set twice to error indevlink_health_report(). Remove second time as it is redundant.Signed-off-by Moshe Shemesh <[email protected]>Reviewed-by Eran Ben Elisha <[email protected]>--- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] devlink: remove redundant health state set to error
https://git.kernel.org/netdev/net-next/c/815bc3ac75e9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html