Skip to contentSkip to conversation

devlink: remove redundant health state set to error

PATCH Applied Moshe Shemesh 3 participants 3 messages Nov 20, 2022 – Nov 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devlink: remove redundant health state set to error

Reporter health_state is set twice to error in devlink_health_report(). Remove second time as it is redundant.

---
 net/core/devlink.c | 2 --
 1 file changed, 2 deletions(-)
net/core/devlink.c +0 -2
index d93bc95cd7cb..cea154ddce7a 100644
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,
 		return -ECANCELED;
 	}
 
-	reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
 	if (reporter->auto_dump) {
 		mutex_lock(&reporter->dump_lock);
 		/* store current dump of current error, for later analysis */
Signature · 1 line
2.26.3
#2 lore raw
In reply to Moshe Shemesh
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Sun, 20 Nov 2022 10:36:52 +0200 you wrote:

Reporter health_state is set twice to error in devlink_health_report(). Remove second time as it is redundant.

---
 net/core/devlink.c | 2 --
 1 file changed, 2 deletions(-)

Here is the summary with links:
- [net-next] devlink: remove redundant health state set to error

    https://git.kernel.org/netdev/net-next/c/815bc3ac75e9

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html