Skip to contentSkip to conversation

net: phy: meson-gxl: Add generic dummy stubs for MMD register access

PATCH Applied Chris Healy 4 participants 6 messages Jan 30, 2023 – Feb 1, 2023

Subsystems (4)
Networking Network drivers Arm/Amlogic Meson SoC support Ethernet PHY
lore
Share & tools
lore

Chris Healy

author
#0 lore raw

PATCH v3 1/1 net: phy: meson-gxl: Add generic dummy stubs for MMD register access

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")
Reviewed-by Heiner Kallweit <[email protected]>
Signed-off-by Chris Healy <[email protected]>

---

Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
Signature · 1 line
2.39.1
reviewer
#1 lore raw
Quoted 7 lines · Chris Healy

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

This is definitely something that should be done, Thx !

Quoted 2 lines
Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

This commit does not seems appropriate, especially since only the GXL ops are changed, not the g12a variant.

This brings a 2nd point, any reason for not changing the g12 variant ? I'm fairly confident it does support EEE either.

Quoted 25 lines
Reviewed-by Heiner Kallweit <[email protected]>
Signed-off-by Chris Healy <[email protected]>

---

Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
maintainer
#2 lore raw
Quoted 11 lines · Jerome Brunet
Quoted 7 lines · Chris Healy

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Quoted 8 lines

This is definitely something that should be done, Thx !

Quoted 2 lines
Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

This commit does not seems appropriate, especially since only the GXL ops are changed, not the g12a variant.

The diff is a little bit misleading. The patch affects the G12A PHY.

Quoted 3 lines

This brings a 2nd point, any reason for not changing the g12 variant ? I'm fairly confident it does support EEE either.

Supposedly it's a typo and you mean "doesn't". Neither Chris nor me have GXL HW and we didn't want to submit a patch just based on speculation.

Quoted 26 lines
Quoted 25 lines
Reviewed-by Heiner Kallweit <[email protected]>
Signed-off-by Chris Healy <[email protected]>

---

Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
reviewer Reviewed-by
#3 lore raw
Quoted 20 lines · Heiner Kallweit
Quoted 11 lines · Jerome Brunet
Quoted 7 lines · Chris Healy

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Quoted 8 lines

This is definitely something that should be done, Thx !

Quoted 2 lines
Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

This commit does not seems appropriate, especially since only the GXL ops are changed, not the g12a variant.

Quoted 6 lines

The diff is a little bit misleading. The patch affects the G12A PHY.

Quoted 3 lines

This brings a 2nd point, any reason for not changing the g12 variant ? I'm fairly confident it does support EEE either.

Supposedly it's a typo and you mean "doesn't". Neither Chris nor me

Indeed ;)

Quoted 2 lines

have GXL HW and we didn't want to submit a patch just based on speculation.

Ah - Ok.
I've tested something similar recently while working on the PHY. I confirm that both GXL and G12a should stub those calls.

... maybe in separate patches to help stable backports.

Do you want to handle this or should I ?

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Reviewed-by Heiner Kallweit <[email protected]>
Signed-off-by Chris Healy <[email protected]>
Reviewed-by Jerome Brunet <[email protected]>
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines

---

Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
maintainer
#4 lore raw
Quoted 35 lines · Jerome Brunet
Quoted 20 lines · Heiner Kallweit
Quoted 11 lines · Jerome Brunet
Quoted 7 lines · Chris Healy

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Quoted 8 lines

This is definitely something that should be done, Thx !

Quoted 2 lines
Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

This commit does not seems appropriate, especially since only the GXL ops are changed, not the g12a variant.

Quoted 6 lines

The diff is a little bit misleading. The patch affects the G12A PHY.

Quoted 3 lines

This brings a 2nd point, any reason for not changing the g12 variant ? I'm fairly confident it does support EEE either.

Supposedly it's a typo and you mean "doesn't". Neither Chris nor me

Indeed ;)

Quoted 2 lines

have GXL HW and we didn't want to submit a patch just based on speculation.

Quoted 8 lines

Ah - Ok.
I've tested something similar recently while working on the PHY. I confirm that both GXL and G12a should stub those calls.

... maybe in separate patches to help stable backports.

Do you want to handle this or should I ?

I can take it, will add your Suggested-by.

Quoted 30 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Reviewed-by Heiner Kallweit <[email protected]>
Signed-off-by Chris Healy <[email protected]>
Reviewed-by Jerome Brunet <[email protected]>
Quoted 23 lines
Quoted 23 lines
Quoted 22 lines

---

Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
CI Applied
#5 lore raw
In reply to Chris Healy
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 30 Jan 2023 15:14:02 -0800 you wrote:

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

[...]

Here is the summary with links:
- [v3] net: phy: meson-gxl: Add generic dummy stubs for MMD register access

    https://git.kernel.org/netdev/net/c/afc2336f89dc

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html