Skip to contentSkip to conversation

net: phy: meson-gxl: Add generic dummy stubs for MMD register access

PATCH Superseded Chris Healy 2 participants 2 messages Jan 30, 2023

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: phy: meson-gxl: Add generic dummy stubs for MMD register access

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

---

Change in v2:
* Add fixes tag

 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/meson-gxl.c +2 -0
index c49062ad72c6..5e41658b1e2f 100644
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
 
Signature · 1 line
2.39.1
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Chris Healy

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended register access, therefore add generic dummy stubs to fail the read and write MMD calls. This is necessary to prevent the core PHY code from erroneously believing that EEE is supported by this PHY even though this PHY does not support EEE, as MMD register access returns all FFFFs.

Quoted 7 lines
Fixes 5c3407abb338 ("net: phy: meson-gxl: add g12a support")

---

Change in v2:
* Add fixes tag