Skip to contentSkip to conversation

net: phy: marvell: Fix inconsistent indenting in led_blink_set

PATCH Applied Christian Marangi 3 participants 3 messages Apr 23, 2023 – Apr 25, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: marvell: Fix inconsistent indenting in led_blink_set

Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel test robot, probably done by the presence of an if condition dropped in later revision of the same code.

Cc Andrew Lunn <[email protected]>
Fixes 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")
---
 drivers/net/phy/marvell.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/phy/marvell.c +4 -4
index cd5d0ed9c5e5..43b6cb725551 100644
@@ -2880,10 +2880,10 @@ static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
 	case 1:
 	case 2:
 		reg &= ~(0xf << (4 * index));
-			reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
-			/* Reset default is 84ms */
-			*delay_on = 84 / 2;
-			*delay_off = 84 / 2;
+		reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
+		/* Reset default is 84ms */
+		*delay_on = 84 / 2;
+		*delay_off = 84 / 2;
 		break;
 	default:
 		return -EINVAL;
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Christian Marangi

Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel test robot, probably done by the presence of an if condition dropped in later revision of the same code.

Cc Andrew Lunn <[email protected]>
Fixes 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")

Andrew

#2 lore raw
In reply to Christian Marangi
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Sun, 23 Apr 2023 19:28:00 +0200 you wrote:

Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel test robot, probably done by the presence of an if condition dropped in later revision of the same code.

Cc Andrew Lunn <[email protected]>
Fixes 46969f66e928 ("net: phy: marvell: Implement led_blink_set()")

[...]

Here is the summary with links:
- [net-next] net: phy: marvell: Fix inconsistent indenting in led_blink_set

    https://git.kernel.org/netdev/net-next/c/4774ad841bef

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html