Skip to contentSkip to conversation

dt-bindings: vendor-prefixes: add ShenZhen New Display Co.

PATCH In review Luca Ceresoli 3 participants 8 messages Aug 10, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 dt-bindings: vendor-prefixes: add ShenZhen New Display Co.

ShenZhen New Display Co., Limited is the manufacturer of the NDS040480800-V3 LCD panel according the datasheet.

---

Changes in v2: none

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index af60bf1a6664..f73d6d4eabbe 100644
@@ -929,6 +929,8 @@ patternProperties:
     description: Netronix, Inc.
   "^netxeon,.*":
     description: Shenzhen Netxeon Technology CO., LTD
+  "^newdisplay,.*":
+    description: ShenZhen New Display Co., Limited
   "^neweast,.*":
     description: Guangdong Neweast Optoelectronics CO., LTD
   "^newhaven,.*":
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 2/3 dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" 480x800 panel based on it.

---

Changes in v2:
- remove T: line form MAINTAINERS entry
- reference spi-peripheral-props.yaml
- add 'maxItems: 1' to reg
- use unevaluatedProperties
- remove out of scope backlight node

---
 .../display/panel/ilitek,ili9806e.yaml        | 63 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml new file +63 -0
new file mode 100644
index 000000000000..83d177be4e7d
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Ilitek ILI9806E display panels
+
+maintainers:
+  - Luca Ceresoli <[email protected]>
+
+description:
+  This binding is for display panels using an Ilitek ILI9806E controller in
+  SPI mode.
+
+allOf:
+  - $ref: panel-common.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD
+          - newdisplay,nds040480800-v3
+      - const: ilitek,ili9806e
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        display@0 {
+            compatible = "newdisplay,nds040480800-v3", "ilitek,ili9806e";
+            reg = <0>;
+            spi-max-frequency = <1000000>;
+            pinctrl-names = "default";
+            pinctrl-0 = <&pinctrl_lcdgpios>;
+            reset-gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
+            backlight = <&backlight>;
+
+            port {
+                ili9806e_in: endpoint {
+                    remote-endpoint = <&lcdif_out>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +5 -0
index 0f966f05fb0d..085e44a7b5e1 100644
@@ -6516,6 +6516,11 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
 F:	Documentation/devicetree/bindings/display/ilitek,ili9486.yaml
 F:	drivers/gpu/drm/tiny/ili9486.c
 
+DRM DRIVER FOR ILITEK ILI9806E PANELS
+M:	Luca Ceresoli <[email protected]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
+
 DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS
 M:	Jagan Teki <[email protected]>
 S:	Maintained
Signature · 1 line
2.34.1
maintainer
#2 lore raw

Re: [PATCH v2 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

Quoted 14 lines · Luca Ceresoli

Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" 480x800 panel based on it.

---

Changes in v2:
- remove T: line form MAINTAINERS entry
- reference spi-peripheral-props.yaml
- add 'maxItems: 1' to reg
- use unevaluatedProperties
- remove out of scope backlight node

Quoted 6 lines
---
 .../display/panel/ilitek,ili9806e.yaml        | 63 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.

maintainer Reviewed-by on v2 2/3
#3 lore raw

Re: [PATCH v2 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

In reply to Luca Ceresoli
Quoted 14 lines · Luca Ceresoli

Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" 480x800 panel based on it.

---

Changes in v2:
- remove T: line form MAINTAINERS entry
- reference spi-peripheral-props.yaml
- add 'maxItems: 1' to reg
- use unevaluatedProperties
- remove out of scope backlight node

Quoted 6 lines
---
 .../display/panel/ilitek,ili9806e.yaml        | 63 +++++++++++++++++++
 MAINTAINERS                                   |  5 ++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
#4 lore raw

PATCH v2 3/3 DRM: panel: add Ilitek ILI9806E driver

In reply to Luca Ceresoli

Add a driver for the ILITEK ILI9806E 480x864 RGB LCD controller connected over SPI, and implement the ShenZhen New Display Co NDS040480800-V3 480x800 panel.

---

Changes in v2:
- add ILI9806E_P1_DISCTRL1 bit description

---
 MAINTAINERS                                   |   1 +
 drivers/gpu/drm/panel/Kconfig                 |  13 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-ilitek-ili9806e.c | 385 ++++++++++++++++++
 4 files changed, 400 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9806e.c
MAINTAINERS +1 -0
index 085e44a7b5e1..602dc866c2e3 100644
@@ -6520,6 +6520,7 @@ DRM DRIVER FOR ILITEK ILI9806E PANELS
 M:	Luca Ceresoli <[email protected]>
 S:	Maintained
 F:	Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml
+F:	drivers/gpu/drm/panel/panel-ilitek-ili9806e.c
 
 DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS
 M:	Jagan Teki <[email protected]>
drivers/gpu/drm/panel/Kconfig +13 -0
index 203c0ef0bbfd..e3e89d86668a 100644
@@ -194,6 +194,19 @@ config DRM_PANEL_ILITEK_ILI9341
 	  QVGA (240x320) RGB panels. support serial & parallel rgb
 	  interface.
 
+config DRM_PANEL_ILITEK_ILI9806E
+	tristate "Ilitek ILI9806E panel"
+	depends on OF
+	depends on BACKLIGHT_CLASS_DEVICE
+	select VIDEOMODE_HELPERS
+	select DRM_MIPI_DBI
+	help
+	  Say Y here if you want to enable support for LCD panels connected
+	  over SPI and based on the Ilitek ILI9806E controller.
+
+	  The ILI9806E is an LCD controller capable of driving 18-bit a-Si
+	  TFT LCDs up to a resolution of 480x800.
+
 config DRM_PANEL_ILITEK_ILI9881C
 	tristate "Ilitek ILI9881C-based panels"
 	depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
index 30cf553c8d1d..f465140ae7df 100644
@@ -17,6 +17,7 @@ obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d
 obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) += panel-himax-hx8394.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o
+obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E) += panel-ilitek-ili9806e.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o
 obj-$(CONFIG_DRM_PANEL_INNOLUX_EJ030NA) += panel-innolux-ej030na.o
 obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o
drivers/gpu/drm/panel/panel-ilitek-ili9806e.c new file +385 -0

385 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#5 lore raw
In reply to Luca Ceresoli
Quoted 12 lines · Luca Ceresoli

ShenZhen New Display Co., Limited is the manufacturer of the NDS040480800-V3 LCD panel according the datasheet.

---

Changes in v2: none

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.