Add Intel LJCA device driver
Subsystems (5)
v17 cover Add Intel LJCA device driver
Add driver for Intel La Jolla Cove Adapter (LJCA) device. This IO-expander adds additional functions to the host system such as GPIO, I2C and SPI with USB host interface. We add 4 drivers to support this device: a USB driver, a GPIO chip driver, a I2C controller driver and a SPI controller driver.
---
v17:
- change valid_pins type to __le32 and access valid_pins with get_unaligned_le32
- remove COMPILE_TEST for USB_LJCA Kconfig
v16:
- drop all void * and use real types in the exported apis and internal ljca_send()
- remove #ifdef in usb-ljca.c file
- add documentation in ljca.h for the public structures
- add error message in ljca_handle_cmd_ack() if error happens and remove blank line
- use the functionality in cleanup.h for spinlock to make function much simpler
- change the type of ex_buf in struct ljca_adapter to u8 *
v15:
- enhance disconnect() of usb-ljca driver
- change memchr to strchr in ljca_match_device_ids() of usb-ljca driver
v14:
- fix build error: implicit declaration of function 'acpi_dev_clear_dependencies'
v13:
- make ljca-usb more robust with the help of Hans de Goede
- call acpi_dev_clear_dependencies() to mark _DEP ACPI dependencies on the I2C controller as satisfied, and patch is from Hans de Goede
v12:
- switch dev_err to dev_dbg for i2c-ljca driver
- avoid err printing because of calling usb_kill_urb when attempts to resubmit the rx urb
v11:
- switch dev_err to dev_dbg for i2c-ljca driver
- remove message length check because of defined quirk structure
- remove I2C_FUNC_SMBUS_EMUL support
v10:
- remove ljca_i2c_format_slave_addr
- remove memset before write write w_packet
- make ljca_i2c_stop void and print err message in case failure
- use dev_err_probe in ljca_i2c_probe function
v9:
- overhaul usb-ljca driver to make it more structured and easy understand
- fix memory leak issue for usb-ljca driver
- add spinlock to protect tx_buf and ex_buf
- change exported APIs for usb-ljca driver
- unify prefix for structures and functions for i2c-ljca driver
- unify prefix for structures and functions for spi-ljca driver
- unify prefix for structures and functions for gpio-ljca driver
- update gpio-ljca, i2c-ljca and spi-ljca drivers according to usb-ljca's changes
Wentong Wu (4):
usb: Add support for Intel LJCA device
i2c: Add support for Intel LJCA USB I2C driver
spi: Add support for Intel LJCA USB SPI driver
gpio: update Intel LJCA USB GPIO driver
drivers/gpio/Kconfig | 4 +- drivers/gpio/gpio-ljca.c | 246 +++++++------ drivers/i2c/busses/Kconfig | 11 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-ljca.c | 342 +++++++++++++++++ drivers/spi/Kconfig | 11 + drivers/spi/Makefile | 1 + drivers/spi/spi-ljca.c | 297 +++++++++++++++ drivers/usb/misc/Kconfig | 13 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/usb-ljca.c | 837 ++++++++++++++++++++++++++++++++++++++++++ include/linux/usb/ljca.h | 145 ++++++++ 12 files changed, 1804 insertions(+), 105 deletions(-) create mode 100644 drivers/i2c/busses/i2c-ljca.c create mode 100644 drivers/spi/spi-ljca.c create mode 100644 drivers/usb/misc/usb-ljca.c create mode 100644 include/linux/usb/ljca.h
Signature · 1 line
2.7.4
PATCH v17 1/4 usb: misc: Add support for Intel LJCA device
Implements the USB part of Intel USB-I2C/GPIO/SPI adapter device named "La Jolla Cove Adapter" (LJCA).
The communication between the various LJCA module drivers and the hardware will be muxed/demuxed by this driver. Three modules ( I2C, GPIO, and SPI) are supported currently.
Each sub-module of LJCA device is identified by type field within the LJCA message header.
The sub-modules of LJCA can use ljca_transfer() to issue a transfer between host and hardware. And ljca_register_event_cb is exported to LJCA sub-module drivers for hardware event subscription.
The minimum code in ASL that covers this board is
Scope (\_SB.PCI0.DWC3.RHUB.HS01)
{
Device (GPIO)
{
Name (_ADR, Zero)
Name (_STA, 0x0F)
}
Device (I2C)
{
Name (_ADR, One)
Name (_STA, 0x0F)
}
Device (SPI)
{
Name (_ADR, 0x02)
Name (_STA, 0x0F)
}
}--- drivers/usb/misc/Kconfig | 13 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/usb-ljca.c | 837 ++++++++++++++++++++++++++++++++++++++++++++ include/linux/usb/ljca.h | 145 ++++++++ 4 files changed, 996 insertions(+) create mode 100644 drivers/usb/misc/usb-ljca.c create mode 100644 include/linux/usb/ljca.h
drivers/usb/misc/Kconfig +13 -0
@@ -165,6 +165,19 @@ config APPLE_MFI_FASTCHARGE It is safe to say M here. +config USB_LJCA + tristate "Intel La Jolla Cove Adapter support" + select AUXILIARY_BUS + depends on USB && ACPI + help + This adds support for Intel La Jolla Cove USB-I2C/SPI/GPIO + Master Adapter (LJCA). Additional drivers such as I2C_LJCA, + GPIO_LJCA and SPI_LJCA must be enabled in order to use the + functionality of the device. + + This driver can also be built as a module. If so, the module + will be called usb-ljca. + source "drivers/usb/misc/sisusbvga/Kconfig" config USB_LD
drivers/usb/misc/Makefile +1 -0
@@ -11,6 +11,7 @@ obj-$(CONFIG_USB_EMI26) += emi26.o obj-$(CONFIG_USB_EMI62) += emi62.o obj-$(CONFIG_USB_EZUSB_FX2) += ezusb.o obj-$(CONFIG_APPLE_MFI_FASTCHARGE) += apple-mfi-fastcharge.o +obj-$(CONFIG_USB_LJCA) += usb-ljca.o obj-$(CONFIG_USB_IDMOUSE) += idmouse.o obj-$(CONFIG_USB_IOWARRIOR) += iowarrior.o obj-$(CONFIG_USB_ISIGHTFW) += isight_firmware.o
drivers/usb/misc/usb-ljca.c new file +837 -0
837 lines not on this page · raw message
include/linux/usb/ljca.h new file +145 -0
145 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v17 2/4 i2c: Add support for Intel LJCA USB I2C driver
In reply to Wentong WuImplements the I2C function of Intel USB-I2C/GPIO/SPI adapter device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2C module with specific protocol through interfaces exported by LJCA USB driver.
--- drivers/i2c/busses/Kconfig | 11 ++ drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-ljca.c | 342 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 354 insertions(+) create mode 100644 drivers/i2c/busses/i2c-ljca.c
drivers/i2c/busses/Kconfig +11 -0
@@ -1264,6 +1264,17 @@ config I2C_DLN2 This driver can also be built as a module. If so, the module will be called i2c-dln2. +config I2C_LJCA + tristate "I2C functionality of Intel La Jolla Cove Adapter" + depends on USB_LJCA + default USB_LJCA + help + If you say yes to this option, I2C functionality support of Intel + La Jolla Cove Adapter (LJCA) will be included. + + This driver can also be built as a module. If so, the module + will be called i2c-ljca. + config I2C_CP2615 tristate "Silicon Labs CP2615 USB sound card and I2C adapter" depends on USB
drivers/i2c/busses/Makefile +1 -0
@@ -133,6 +133,7 @@ obj-$(CONFIG_I2C_GXP) += i2c-gxp.o # External I2C/SMBus adapter drivers obj-$(CONFIG_I2C_DIOLAN_U2C) += i2c-diolan-u2c.o obj-$(CONFIG_I2C_DLN2) += i2c-dln2.o +obj-$(CONFIG_I2C_LJCA) += i2c-ljca.o obj-$(CONFIG_I2C_CP2615) += i2c-cp2615.o obj-$(CONFIG_I2C_PARPORT) += i2c-parport.o obj-$(CONFIG_I2C_PCI1XXXX) += i2c-mchp-pci1xxxx.o
drivers/i2c/busses/i2c-ljca.c new file +342 -0
342 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v17 3/4 spi: Add support for Intel LJCA USB SPI driver
In reply to Wentong WuImplements the SPI function of Intel USB-I2C/GPIO/SPI adapter device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA SPI module with specific protocol through interfaces exported by LJCA USB driver.
--- drivers/spi/Kconfig | 11 ++ drivers/spi/Makefile | 1 + drivers/spi/spi-ljca.c | 297 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 309 insertions(+) create mode 100644 drivers/spi/spi-ljca.c
drivers/spi/Kconfig +11 -0
@@ -583,6 +583,17 @@ config SPI_FSL_ESPI From MPC8536, 85xx platform uses the controller, and all P10xx, P20xx, P30xx,P40xx, P50xx uses this controller. +config SPI_LJCA + tristate "Intel La Jolla Cove Adapter SPI support" + depends on USB_LJCA + default USB_LJCA + help + Select this option to enable SPI driver for the Intel + La Jolla Cove Adapter (LJCA) board. + + This driver can also be built as a module. If so, the module + will be called spi-ljca. + config SPI_MESON_SPICC tristate "Amlogic Meson SPICC controller" depends on COMMON_CLK
drivers/spi/Makefile +1 -0
@@ -70,6 +70,7 @@ obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-pci.o obj-$(CONFIG_SPI_INTEL_PLATFORM) += spi-intel-platform.o obj-$(CONFIG_SPI_LANTIQ_SSC) += spi-lantiq-ssc.o obj-$(CONFIG_SPI_JCORE) += spi-jcore.o +obj-$(CONFIG_SPI_LJCA) += spi-ljca.o obj-$(CONFIG_SPI_LM70_LLP) += spi-lm70llp.o obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o
drivers/spi/spi-ljca.c new file +297 -0
297 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH v17 3/4] spi: Add support for Intel LJCA USB SPI driver
Hi Wentong,
Quoted 43 lines · Wentong Wu
Implements the SPI function of Intel USB-I2C/GPIO/SPI adapter device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA SPI module with specific protocol through interfaces exported by LJCA USB driver.
Signed-off-by Wentong Wu <[email protected]>Reviewed-by Sakari Ailus <[email protected]>Reviewed-by Andi Shyti <[email protected]>Tested-by Hans de Goede <[email protected]>--- drivers/spi/Kconfig | 11 ++ drivers/spi/Makefile | 1 + drivers/spi/spi-ljca.c | 297 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 309 insertions(+) create mode 100644 drivers/spi/spi-ljca.cdrivers/spi/Kconfig +11
-0@@ -583,6 +583,17 @@ config SPI_FSL_ESPI From MPC8536, 85xx platform uses the controller, and all P10xx, P20xx, P30xx,P40xx, P50xx uses this controller. +config SPI_LJCA + tristate "Intel La Jolla Cove Adapter SPI support" + depends on USB_LJCA + default USB_LJCA + help + Select this option to enable SPI driver for the Intel + La Jolla Cove Adapter (LJCA) board. + + This driver can also be built as a module. If so, the module + will be called spi-ljca. + config SPI_MESON_SPICC tristate "Amlogic Meson SPICC controller" depends on COMMON_CLKdrivers/spi/Makefile +0
-0
drivers/spi/Makefile obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-pci.o · line 76
Quoted 7 lines
drivers/spi/Makefile +1
-0@@ -70,6 +70,7 @@ obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-pci.o obj-$(CONFIG_SPI_INTEL_PLATFORM) += spi-intel-platform.o obj-$(CONFIG_SPI_LANTIQ_SSC) += spi-lantiq-ssc.o obj-$(CONFIG_SPI_JCORE) += spi-jcore.o +obj-$(CONFIG_SPI_LJCA) += spi-ljca.o obj-$(CONFIG_SPI_LM70_LLP) += spi-lm70llp.o obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o
I don't know what you are using as a base commit for these patches, but this does not apply cleanly on top of v6.6-rc1.
For the next version of these patches please rebases this on top of v6.6-rc1; or on Linus' master branch.
Regards,
Hans
Quoted 303 lines
drivers/spi/spi-ljca.c new file +297
-0@@ -0,0 +1,297 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Intel La Jolla Cove Adapter USB-SPI driver +* +* Copyright (c) 2023, Intel Corporation. +*/ + +#include <linux/auxiliary_bus.h> +#include <linux/bitfield.h> +#include <linux/bits.h> +#include <linux/dev_printk.h> +#include <linux/module.h> +#include <linux/spi/spi.h> +#include <linux/usb/ljca.h> + +#define LJCA_SPI_BUS_MAX_HZ 48000000 + +#define LJCA_SPI_BUF_SIZE 60u +#define LJCA_SPI_MAX_XFER_SIZE \ + (LJCA_SPI_BUF_SIZE - sizeof(struct ljca_spi_xfer_packet)) + +#define LJCA_SPI_CLK_MODE_POLARITY BIT(0) +#define LJCA_SPI_CLK_MODE_PHASE BIT(1) + +#define LJCA_SPI_XFER_INDICATOR_ID GENMASK(5, 0) +#define LJCA_SPI_XFER_INDICATOR_CMPL BIT(6) +#define LJCA_SPI_XFER_INDICATOR_INDEX BIT(7) + +/* SPI commands */ +enum ljca_spi_cmd { +LJCA_SPI_INIT =1 , +LJCA_SPI_READ , +LJCA_SPI_WRITE , +LJCA_SPI_WRITEREAD , +LJCA_SPI_DEINIT , +}; + +enum { +LJCA_SPI_BUS_SPEED_24M , +LJCA_SPI_BUS_SPEED_12M , +LJCA_SPI_BUS_SPEED_8M , +LJCA_SPI_BUS_SPEED_6M , +LJCA_SPI_BUS_SPEED_4_8M ,/*4.8MHz*/ +LJCA_SPI_BUS_SPEED_MIN =LJCA_SPI_BUS_SPEED_4_8M , +}; + +enum { +LJCA_SPI_CLOCK_LOW_POLARITY , +LJCA_SPI_CLOCK_HIGH_POLARITY , +}; + +enum { +LJCA_SPI_CLOCK_FIRST_PHASE , +LJCA_SPI_CLOCK_SECOND_PHASE , +}; + +struct ljca_spi_init_packet { +u8 index; +u8 speed; +u8 mode; +} __packed; + +struct ljca_spi_xfer_packet { +u8 indicator; +u8 len; +u8 data[]; +} __packed; + +struct ljca_spi_dev { +struct ljca_client *ljca; +struct spi_controller *controller; +struct ljca_spi_info *spi_info; +u8 speed; +u8 mode; + +u8 obuf[LJCA_SPI_BUF_SIZE ]; +u8 ibuf[LJCA_SPI_BUF_SIZE ]; +}; + +static int ljca_spi_read_write (struct ljca_spi_dev *ljca_spi,const u8 *w_data, +u8 *r_data,int len,int id,int complete, +int cmd) +{ +struct ljca_spi_xfer_packet *w_packet = + (struct ljca_spi_xfer_packet *)ljca_spi->obuf; +struct ljca_spi_xfer_packet *r_packet = + (struct ljca_spi_xfer_packet *)ljca_spi->ibuf; +int ret; + + w_packet->indicator =FIELD_PREP (LJCA_SPI_XFER_INDICATOR_ID , id) | +FIELD_PREP (LJCA_SPI_XFER_INDICATOR_CMPL , complete) | +FIELD_PREP (LJCA_SPI_XFER_INDICATOR_INDEX , + ljca_spi->spi_info->id); + +if (cmd ==LJCA_SPI_READ ) { + w_packet->len =sizeof (u16); + *(__le16 *)&w_packet->data[0 ] =cpu_to_le16 (len); + }else { + w_packet->len = len; +memcpy (w_packet->data, w_data, len); + } + + ret =ljca_transfer (ljca_spi->ljca, cmd, (u8 *)w_packet, +struct_size (w_packet, data, w_packet->len), + (u8 *)r_packet,LJCA_SPI_BUF_SIZE ); +if (ret <0 ) +return ret; +else if (ret <sizeof (*r_packet) || r_packet->len <=0 ) +return -EIO ; + +if (r_data) +memcpy (r_data, r_packet->data, r_packet->len); + +return 0 ; +} + +static int ljca_spi_init (struct ljca_spi_dev *ljca_spi,u8 div,u8 mode) +{ +struct ljca_spi_init_packet w_packet = {}; +int ret; + +if (ljca_spi->mode == mode && ljca_spi->speed == div) +return 0 ; + + w_packet.index = ljca_spi->spi_info->id; + w_packet.speed = div; + w_packet.mode =FIELD_PREP (LJCA_SPI_CLK_MODE_POLARITY , + (mode &SPI_CPOL ) ?LJCA_SPI_CLOCK_HIGH_POLARITY : +LJCA_SPI_CLOCK_LOW_POLARITY ) | +FIELD_PREP (LJCA_SPI_CLK_MODE_PHASE , + (mode &SPI_CPHA ) ?LJCA_SPI_CLOCK_SECOND_PHASE : +LJCA_SPI_CLOCK_FIRST_PHASE ); + + ret =ljca_transfer (ljca_spi->ljca,LJCA_SPI_INIT , (u8 *)&w_packet, +sizeof (w_packet),NULL ,0 ); +if (ret <0 ) +return ret; + + ljca_spi->mode = mode; + ljca_spi->speed = div; + +return 0 ; +} + +static int ljca_spi_deinit (struct ljca_spi_dev *ljca_spi) +{ +struct ljca_spi_init_packet w_packet = {}; +int ret; + + w_packet.index = ljca_spi->spi_info->id; + + ret =ljca_transfer (ljca_spi->ljca,LJCA_SPI_DEINIT , (u8 *)&w_packet, +sizeof (w_packet),NULL ,0 ); + +return ret <0 ? ret :0 ; +} + +static inline int ljca_spi_transfer (struct ljca_spi_dev *ljca_spi, +const u8 *tx_data,u8 *rx_data,u16 len) +{ +int complete, cur_len; +int remaining = len; +int cmd, ret, i; +int offset =0 ; + +if (tx_data && rx_data) + cmd =LJCA_SPI_WRITEREAD ; +else if (tx_data) + cmd =LJCA_SPI_WRITE ; +else if (rx_data) + cmd =LJCA_SPI_READ ; +else +return -EINVAL ; + +for (i =0 ; remaining >0 ; i++) { + cur_len = min_t(unsigned int, remaining, LJCA_SPI_MAX_XFER_SIZE); + complete = (cur_len == remaining); + + ret =ljca_spi_read_write (ljca_spi, + tx_data ? tx_data + offset :NULL , + rx_data ? rx_data + offset :NULL , + cur_len, i, complete, cmd); +if (ret) +return ret; + + offset += cur_len; + remaining -= cur_len; + } + +return 0 ; +} + +static int ljca_spi_transfer_one (struct spi_controller *controller, +struct spi_device *spi, +struct spi_transfer *xfer) +{ +u8 div =DIV_ROUND_UP (controller->max_speed_hz, xfer->speed_hz) /2 -1 ; +struct ljca_spi_dev *ljca_spi =spi_controller_get_devdata (controller); +int ret; + + div =min_t (u8,LJCA_SPI_BUS_SPEED_MIN , div); + + ret =ljca_spi_init (ljca_spi, div, spi->mode); +if (ret) { +dev_err (&ljca_spi->ljca->auxdev.dev, +"cannot initialize transfer ret %d\n" , ret); +return ret; + } + + ret =ljca_spi_transfer (ljca_spi, xfer->tx_buf, xfer->rx_buf, xfer->len); +if (ret) +dev_err (&ljca_spi->ljca->auxdev.dev, +"transfer failed len: %d\n" , xfer->len); + +return ret; +} + +static int ljca_spi_probe (struct auxiliary_device *auxdev, +const struct auxiliary_device_id *aux_dev_id) +{ +struct ljca_client *ljca =auxiliary_dev_to_ljca_client (auxdev); +struct spi_controller *controller; +struct ljca_spi_dev *ljca_spi; +int ret; + + controller =devm_spi_alloc_master (&auxdev->dev,sizeof (*ljca_spi)); +if (!controller) +return -ENOMEM ; + + ljca_spi =spi_controller_get_devdata (controller); + ljca_spi->ljca = ljca; + ljca_spi->spi_info =dev_get_platdata (&auxdev->dev); + ljca_spi->controller = controller; + + controller->bus_num =-1 ; + controller->mode_bits =SPI_CPHA |SPI_CPOL ; + controller->transfer_one = ljca_spi_transfer_one; + controller->auto_runtime_pm = false; + controller->max_speed_hz =LJCA_SPI_BUS_MAX_HZ ; + +device_set_node (&ljca_spi->controller->dev,dev_fwnode (&auxdev->dev)); +auxiliary_set_drvdata (auxdev, controller); + + ret =spi_register_controller (controller); +if (ret) +dev_err (&auxdev->dev,"Failed to register controller\n" ); + +return ret; +} + +static void ljca_spi_dev_remove (struct auxiliary_device *auxdev) +{ +struct spi_controller *controller =auxiliary_get_drvdata (auxdev); +struct ljca_spi_dev *ljca_spi =spi_controller_get_devdata (controller); + +spi_unregister_controller (controller); +ljca_spi_deinit (ljca_spi); +} + +static int ljca_spi_dev_suspend (struct device *dev) +{ +struct spi_controller *controller =dev_get_drvdata (dev); + +return spi_controller_suspend (controller); +} + +static int ljca_spi_dev_resume (struct device *dev) +{ +struct spi_controller *controller =dev_get_drvdata (dev); + +return spi_controller_resume (controller); +} + +static const struct dev_pm_ops ljca_spi_pm = { +SYSTEM_SLEEP_PM_OPS (ljca_spi_dev_suspend, ljca_spi_dev_resume) +}; + +static const struct auxiliary_device_id ljca_spi_id_table[] = { + {"usb_ljca.ljca-spi" ,0 }, + {/* sentinel */ } +}; +MODULE_DEVICE_TABLE (auxiliary, ljca_spi_id_table); + +static struct auxiliary_driver ljca_spi_driver = { + .driver.pm = &ljca_spi_pm, + .probe = ljca_spi_probe, + .remove = ljca_spi_dev_remove, + .id_table = ljca_spi_id_table, +}; +module_auxiliary_driver (ljca_spi_driver); + +MODULE_AUTHOR ("Wentong Wu <[email protected]>" ); +MODULE_AUTHOR ("Zhifeng Wang <[email protected]>" ); +MODULE_AUTHOR ("Lixu Zhang <[email protected]>" ); +MODULE_DESCRIPTION ("Intel La Jolla Cove Adapter USB-SPI driver" ); +MODULE_LICENSE ("GPL" ); +MODULE_IMPORT_NS (LJCA );
RE: [PATCH v17 3/4] spi: Add support for Intel LJCA USB SPI driver
Quoted 58 lines
From: Hans de Goede
Hi Wentong,
drivers/spi/Makefile obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-
Quoted 44 lines · Wentong Wu
Implements the SPI function of Intel USB-I2C/GPIO/SPI adapter device named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA SPI module with specific protocol through interfaces exported by LJCA USB driver.
Signed-off-by Wentong Wu <[email protected]>Reviewed-by Sakari Ailus <[email protected]>Reviewed-by Andi Shyti <[email protected]>Tested-by Hans de Goede <[email protected]>--- drivers/spi/Kconfig | 11 ++ drivers/spi/Makefile | 1 + drivers/spi/spi-ljca.c | 297 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 309 insertions(+) create mode 100644 drivers/spi/spi-ljca.cdrivers/spi/Kconfig index renamed from drivers/spi/Kconfig +0
-08962b25..ad18864 100644
drivers/spi/Kconfig +11
-0@@ -583,6 +583,17 @@ config SPI_FSL_ESPI From MPC8536, 85xx platform uses the controller, and all P10xx, P20xx, P30xx,P40xx, P50xx uses this controller. +config SPI_LJCA + tristate "Intel La Jolla Cove Adapter SPI support" + depends on USB_LJCA + default USB_LJCA + help + Select this option to enable SPI driver for the Intel + La Jolla Cove Adapter (LJCA) board. + + This driver can also be built as a module. If so, the module + will be called spi-ljca. + config SPI_MESON_SPICC tristate "Amlogic Meson SPICC controller" depends on COMMON_CLKdrivers/spi/Makefile index renamed from drivers/spi/Makefile +0
-0080c2c1..0847962 100644
drivers/spi/Makefile +0
-0@@ -70,6 +70,7 @@ obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-pci.o
drivers/spi/Makefile obj-$(CONFIG_SPI_INTEL_PCI) += spi-intel-pci.o · line 76
Quoted 7 lines
drivers/spi/Makefile +1
-0obj-$(CONFIG_SPI_INTEL_PLATFORM) += spi-intel-platform.o obj-$(CONFIG_SPI_LANTIQ_SSC) += spi-lantiq-ssc.o obj-$(CONFIG_SPI_JCORE) += spi-jcore.o +obj-$(CONFIG_SPI_LJCA) += spi-ljca.o obj-$(CONFIG_SPI_LM70_LLP) += spi-lm70llp.o obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o
Quoted 6 lines
I don't know what you are using as a base commit for these patches, but this does not apply cleanly on top of v6.6-rc1.
For the next version of these patches please rebases this on top of v6.6-rc1; or on Linus' master branch.
Thanks, v17 is based on 6.5-rc4, now v19 is based on Linus' master branch.
BR,
Wentong
Quoted 3 lines
Regards,
Hans
PATCH v17 4/4 gpio: Update Intel LJCA USB GPIO driver
In reply to Wentong WuThis driver communicate with LJCA GPIO module with specific protocol through interfaces exported by LJCA USB driver. Update the driver according to LJCA USB driver's changes.
--- drivers/gpio/Kconfig | 4 +- drivers/gpio/gpio-ljca.c | 246 +++++++++++++++++++++++++++-------------------- 2 files changed, 145 insertions(+), 105 deletions(-)
drivers/gpio/Kconfig +2 -2
@@ -1294,9 +1294,9 @@ config GPIO_KEMPLD config GPIO_LJCA tristate "INTEL La Jolla Cove Adapter GPIO support" - depends on MFD_LJCA + depends on USB_LJCA select GPIOLIB_IRQCHIP - default MFD_LJCA + default USB_LJCA help Select this option to enable GPIO driver for the INTEL La Jolla Cove Adapter (LJCA) board.
drivers/gpio/gpio-ljca.c +143 -103
473 lines not on this page · raw message
Signature · 1 line
2.7.4