Skip to content

Add Intel LJCA device driver

Wentong Wu linux-gpio linux-i2c linux-spi linux-usb lkml 14 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v20 Latest4 patches 19 repliesIn review
  2. v194 patches 20 repliesSuperseded
  3. v184 patches 0 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v174 patches2 repliesSuperseded
v164 patches6 repliesSuperseded
v154 patches3 repliesSuperseded
v144 patches14 repliesSuperseded
v13 posting 2/24 patches0 repliesSuperseded
v13 posting 1/24 patches0 repliesSuperseded
v124 patches13 repliesSuperseded
v114 patches4 repliesSuperseded
v10 posting 2/24 patches5 repliesSuperseded
v10 posting 1/21 patch3 repliesSuperseded
v94 patches6 repliesSuperseded

Changes in v20 from the cover letter

- add __counted_by attributes for all of [] arrays
- use proper kernel doc for ljca_adapter structure
- re-structure ljca_recv function to make it more clear
- remove all of scoped_guard
- check return value of usb_autopm_get_interface()
- re-structure ljca_enumerate_clients() to handle error correctly
- add comment for 'uid = "0";' in ljca_match_device_ids()
- change the parameters' type of ljca_send() to u8

Patches in v20 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4usb: Add support for Intel LJCA devicedrivers/usb/misc/Kconfig drivers/usb/misc/Makefile drivers/usb/misc/usb-ljca.c +1 more+1061 -017 replies
2/4i2c: Add support for Intel LJCA USB I2C driverdrivers/i2c/busses/Kconfig drivers/i2c/busses/Makefile drivers/i2c/busses/i2c-ljca.c+355 -01 reply
3/4spi: Add support for Intel LJCA USB SPI driverdrivers/spi/Kconfig drivers/spi/Makefile drivers/spi/spi-ljca.c+309 -01 reply
4/4gpio: update Intel LJCA USB GPIO driverdrivers/gpio/Kconfig drivers/gpio/gpio-ljca.c+145 -1050 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchSakari AilusAndi ShytiHans de GoedeLinus WalleijBartosz GolaszewskiOliver NeukumMark BrownWolfram Sang
1/4R-b R-b T-b R-b
2/4R-b R-b T-b R-b
3/4R-b R-b T-b R-b
4/4R-b T-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v20 thread

Cover letter [PATCH v20 0/4] Add Intel LJCA device driver

Add driver for Intel La Jolla Cove Adapter (LJCA) device. This IO-expander adds additional functions to the host system with host USB interface, such as GPIO, I2C and SPI. This patch set adds four drivers to support this device: a USB device driver, a GPIO chip driver, a I2C controller driver and a SPI controller driver.

---
v20:
- add __counted_by attributes for all of [] arrays
- use proper kernel doc for ljca_adapter structure
- re-structure ljca_recv function to make it more clear
- remove all of scoped_guard
- check return value of usb_autopm_get_interface()
- re-structure ljca_enumerate_clients() to handle error correctly
- add comment for 'uid = "0";' in ljca_match_device_ids()
- change the parameters' type of ljca_send() to u8

v17 - v19:
- rebase patch set on top of Linus' master branch (57d88e8a5974644039fbc47806bac7bb12025636)
- change valid_pins type to __le32 and access valid_pins with get_unaligned_le32
- remove COMPILE_TEST for USB_LJCA Kconfig

v16:
- drop all void * and use real types in the exported apis and internal ljca_send()
- remove #ifdef in usb-ljca.c file
- add documentation in ljca.h for the public structures
- add error message in ljca_handle_cmd_ack() if error happens and remove blank line
- use the functionality in cleanup.h for spinlock to make function much simpler
- change the type of ex_buf in struct ljca_adapter to u8 *

v14 - v15:
- enhance disconnect() of usb-ljca driver
- change memchr to strchr in ljca_match_device_ids() of usb-ljca driver
- fix build error: implicit declaration of function 'acpi_dev_clear_dependencies'

v13:
- make ljca-usb more robust with the help of Hans de Goede
- call acpi_dev_clear_dependencies() to mark _DEP ACPI dependencies on the I2C controller as satisfied
- avoid err printing because of calling usb_kill_urb when attempts to resubmit the rx urb

v10 - v12:
- switch dev_err to dev_dbg for i2c-ljca driver
- remove message length check because of defined quirk structure
- remove I2C_FUNC_SMBUS_EMUL support
- remove ljca_i2c_format_slave_addr
- remove memset before write write w_packet for i2c driver
- make ljca_i2c_stop void and print err message in case failure
- use dev_err_probe in ljca_i2c_probe function

v9:
- overhaul usb-ljca driver to make it more structured and easy understand
- fix memory leak issue for usb-ljca driver
- add spinlock to protect tx_buf and ex_buf
- change exported APIs for usb-ljca driver
- unify prefix for structures and functions for i2c-ljca driver
- unify prefix for structures and functions for spi-ljca driver
- unify prefix for structures and functions for gpio-ljca driver
- update gpio-ljca, i2c-ljca and spi-ljca drivers according to usb-ljca's changes

Wentong Wu (4):
usb: Add support for Intel LJCA device
i2c: Add support for Intel LJCA USB I2C driver
spi: Add support for Intel LJCA USB SPI driver
gpio: update Intel LJCA USB GPIO driver

 drivers/gpio/Kconfig          |   4 +-
 drivers/gpio/gpio-ljca.c      | 246 +++++++-----
 drivers/i2c/busses/Kconfig    |  11 +
 drivers/i2c/busses/Makefile   |   1 +
 drivers/i2c/busses/i2c-ljca.c | 343 ++++++++++++++++
 drivers/spi/Kconfig           |  11 +
 drivers/spi/Makefile          |   1 +
 drivers/spi/spi-ljca.c        | 297 ++++++++++++++
 drivers/usb/misc/Kconfig      |  13 +
 drivers/usb/misc/Makefile     |   1 +
 drivers/usb/misc/usb-ljca.c   | 902 ++++++++++++++++++++++++++++++++++++++++++
 include/linux/usb/ljca.h      | 145 +++++++
 12 files changed, 1870 insertions(+), 105 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-ljca.c
 create mode 100644 drivers/spi/spi-ljca.c
 create mode 100644 drivers/usb/misc/usb-ljca.c
 create mode 100644 include/linux/usb/ljca.h
Signature · 1 line
2.7.4