nvme: Remove unused parameter
PATCH 1/1 nvme: Remove unused parameter
The "name" field in struct nvme_ctrl is unsued so removing it. This would help save 12 bytes of space for each nvme_ctrl instance created.
--- drivers/nvme/host/nvme.h | 1 - 1 file changed, 1 deletion(-)
drivers/nvme/host/nvme.h +0 -1
@@ -301,7 +301,6 @@ struct nvme_ctrl {struct opal_dev *opal_dev; -char name[12 ];u16 cntlid;u16 mtfa;
Signature · 1 line
2.45.2
Christoph Hellwig
maintainerQuoted 3 lines · Nilay Shroff
The "name" field in struct
nvme_ctrlis unsued so removing it. This would help save 12 bytes of space for eachnvme_ctrlinstance created.
name is a structure member, not a parameter.
The code change itself look fine, though.
Hi Christoph,
Quoted 10 lines · Christoph Hellwig
Quoted 3 lines · Nilay Shroff
The "name" field in struct
nvme_ctrlis unsued so removing it. This would help save 12 bytes of space for eachnvme_ctrlinstance created.name is a structure member, not a parameter.
The code change itself look fine, though.
Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?
Thanks,
--Nilay
Christoph Hellwig
maintainerQuoted 2 lines · Nilay Shroff
Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?
Maybe Keith can just fix it up.
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Nilay Shroff
Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?
Maybe Keith can just fix it up.
OK thanks!
--Nilay
Thanks, applied to nvme-6.11 with subject change "parameter" to "field".