Skip to contentSkip to conversation

nvme: Remove unused parameter

PATCH Applied Nilay Shroff 4 participants 7 messages Aug 14, 2024 – Aug 20, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: Remove unused parameter

The "name" field in struct nvme_ctrl is unsued so removing it. This would help save 12 bytes of space for each nvme_ctrl instance created.

---
 drivers/nvme/host/nvme.h | 1 -
 1 file changed, 1 deletion(-)
drivers/nvme/host/nvme.h +0 -1
index ae5314d32943..da57947130cc 100644
@@ -301,7 +301,6 @@ struct nvme_ctrl {
 
 	struct opal_dev *opal_dev;
 
-	char name[12];
 	u16 cntlid;
 
 	u16 mtfa;
Signature · 1 line
2.45.2
#2 lore raw
In reply to Nilay Shroff
Quoted 3 lines · Nilay Shroff

The "name" field in struct nvme_ctrl is unsued so removing it. This would help save 12 bytes of space for each nvme_ctrl instance created.

name is a structure member, not a parameter.

The code change itself look fine, though.

#3 lore raw

Hi Christoph,

Quoted 10 lines · Christoph Hellwig
Quoted 3 lines · Nilay Shroff

The "name" field in struct nvme_ctrl is unsued so removing it. This would help save 12 bytes of space for each nvme_ctrl instance created.

name is a structure member, not a parameter.

The code change itself look fine, though.

Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?

Thanks,
--Nilay

#4 lore raw
Quoted 2 lines · Nilay Shroff

Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?

Maybe Keith can just fix it up.

#5 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Nilay Shroff

Yeah ok, if you prefer, shall I update the patch subject line and resend the patch?

Maybe Keith can just fix it up.

OK thanks!

--Nilay