ncurses: Fix install conflict when enable multilib.
PATCH v3 1/1 ncurses: Fix install conflict when enable multilib.
From: Wang Mingyu <[email protected]>
The setting of want_xterm_kbs is as following:
case $host_os in
(*linux-gnu|*cygwin|*mingw32|*msys)
want_xterm_kbs=DEL
;;
(*)
want_xterm_kbs=BS
;;esac
The host_os when enable multilib is as folloing:host_os of aarch64 : linux-gnuhost_os of aarch32 : linux-gnueabi
So in lib64 package, want_xterm_kbs=DEL, and in lib32 package, want_xterm_kbs=BS. It results the differences in the terminfo files between lib32 and lib64 packages.
Using --with-xterm-kbs=del to unify the packages of lib32 and lib64 into "want_xterm_kbs=DEL".
--- meta/recipes-core/ncurses/ncurses.inc | 1 + 1 file changed, 1 insertion(+)
meta/recipes-core/ncurses/ncurses.inc +1 -0
@@ -70,6 +70,7 @@ ncurses_configure() { --without-debug \ --without-ada \ --without-gpm \ + --with-xterm-kbs=del \ --enable-hard-tabs \ --enable-xmc-glitch \ --enable-colorfgbg \
Signature · 1 line
2.43.0
Quoted 13 lines · wangmy via lists.openembedded.org
From: Wang Mingyu <[email protected]>
The setting of
want_xterm_kbsis as following:
case $host_os in
(*linux-gnu|*cygwin|*mingw32|*msys)
want_xterm_kbs=DEL
;;
(*)
want_xterm_kbs=BS
;;
esac
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabi
Seems like the proper fix would be to change the glob to *linux-gnu* (and sent that upstream first, obviously)?
Ross
Quoted 5 lines · Ross Burton via lists.openembedded.org
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabiSeems like the proper fix would be to change the glob to *linux-gnu* (and sent that upstream first, obviously)?
This is an outcome of my review; in the end of it I had asked to send that proper fix upstream, but provide the oe-core fix as a tweak to configure flags. Basically because we don't know if upstream will take the proper fix.
What would help is to include the link to that upstream submission into this commit message.
Alex
This issue has been raised to the upstream, who stated that in addition to linux-gnueabi, there are many other types that need to be matched, so they have included the modifications in the to-do list.
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]
Quoted 27 lines
-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Tuesday, January 21, 2025 11:40 PM
To: [email protected]
Cc: Wang, Mingyu/王 鸣瑜 <[email protected]>; [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when enable multilib.Quoted 5 lines · Ross Burton via lists.openembedded.org
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabiSeems like the proper fix would be to change the glob to *linux-gnu* (and sent
that upstream first, obviously)?
This is an outcome of my review; in the end of it I had asked to send that proper fix upstream, but provide the oe-core fix as a tweak to configure flags. Basically because we don't know if upstream will take the proper fix.
What would help is to include the link to that upstream submission into this commit message.
Alex
Please remember to include the links to upstream discussions into commit messages. This always helps when at some point in the future someone would need to understand the issue, do additional fixing or other follow up work.
If it’s on the mailing list, those typically have web based archives with stable links to individual messages.
Alex
Quoted 48 lines · Mingyu Wang (Fujitsu)
This issue has been raised to the upstream, who stated that in addition to linux-gnueabi, there are many other types that need to be matched, so they have included the modifications in the to-do list.
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]Quoted 8 lines
-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Tuesday, January 21, 2025 11:40 PM
To: [email protected]
Cc: Wang, Mingyu/王 鸣瑜 <[email protected]>; [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflictwhen
Quoted 9 lines
enable multilib.
Quoted 5 lines · Ross Burton via lists.openembedded.org
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabiSeems like the proper fix would be to change the glob to *linux-gnu*
(and sent
Quoted 3 lines
that upstream first, obviously)?
This is an outcome of my review; in the end of it I had asked to send
that proper
Quoted 1 line
fix upstream, but provide the oe-core fix as a tweak to configure flags.
Basically
Quoted 3 lines
because we don't know if upstream will take the proper fix.
What would help is to include the link to that upstream submission into
this
Quoted 3 lines
commit message.
Alex
The upstream of ncurses has fixed this issue.
But I'm not sure if it has been completely modified.
I can submit an upgrade patch, do I still need to specify --with-xterm-kbs=del in this patch?
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]<mailto:[email protected]>
From: Alexander Kanavin <[email protected]>
Sent: Wednesday, January 22, 2025 4:29 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: [email protected]; [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when enable multilib.
Please remember to include the links to upstream discussions into commit messages. This always helps when at some point in the future someone would need to understand the issue, do additional fixing or other follow up work.
If it’s on the mailing list, those typically have web based archives with stable links to individual messages.
Alex
On Wed 22. Jan 2025 at 1.17, Mingyu Wang (Fujitsu) <[email protected]<mailto:[email protected]>> wrote:
This issue has been raised to the upstream, who stated that in addition to linux-gnueabi, there are many other types that need to be matched, so they have included the modifications in the to-do list.
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]<mailto:[email protected]>
Quoted 27 lines
-----Original Message-----
From: Alexander Kanavin <[email protected]<mailto:[email protected]>>
Sent: Tuesday, January 21, 2025 11:40 PM
To: [email protected]<mailto:[email protected]>
Cc: Wang, Mingyu/王 鸣瑜 <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Lei, Maohui/雷 茂慧 <[email protected]<mailto:[email protected]>>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when
enable multilib.Quoted 5 lines · On Tue, 21 Jan 2025 at 16:31, Ross Burton via…
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabiSeems like the proper fix would be to change the glob to *linux-gnu* (and sent
that upstream first, obviously)?
This is an outcome of my review; in the end of it I had asked to send that proper fix upstream, but provide the oe-core fix as a tweak to configure flags. Basically because we don't know if upstream will take the proper fix.
What would help is to include the link to that upstream submission into this commit message.
Alex
Quoted 6 lines · Mingyu Wang (Fujitsu)
The upstream of ncurses has fixed this issue.
But I'm not sure if it has been completely modified.
I can submit an upgrade patch, do I still need to specify --with-xterm-kbs=del in this patch?
Unfortunately the upgrade patch is not acceptable (I wrote a separate response why). Can you point to the upstream fix that they added to their repo?
Alex
Quoted 1 line
why). Can you point to the upstream fix that they added to their repo?
The upstream modify the file configure to fix this bug:
@@ -659,7 +659,7 @@ WHICH_XTERM=$with_xterm_newAC_SUBST(WHICH_XTERM)
case $host_os in
- (*linux-gnu|*cygwin|*mingw32|*msys) +(linux*gnu|linux*gnuabi64|linux*gnuabin32|linux*gnueabi|linux*gnueabihf|linux*gnux32|uclinux*|gnu*|mint*|k*bsd*-gnu|cygwin|msys|mingw*|linux*uclibc|linux*musl) want_xterm_kbs=DEL
;;
(*)
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]
Quoted 23 lines
-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Friday, January 24, 2025 6:46 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: [email protected]; [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when enable multilib.Quoted 7 lines · Mingyu Wang (Fujitsu)
The upstream of ncurses has fixed this issue.
But I'm not sure if it has been completely modified.
I can submit an upgrade patch, do I still need to specify --with-xterm-kbs=del in this patch?
Unfortunately the upgrade patch is not acceptable (I wrote a separate response why). Can you point to the upstream fix that they added to their repo?
Alex
Quoted 6 lines · Mingyu Wang (Fujitsu)
Quoted 2 lines
why). Can you point to the upstream fix that they added to their repo?
The upstream modify the file configure to fix this bug:
Review WHICH_XTERM=$with_xterm_new · line 665
Quoted 8 lines
(quoted diff) +1
-1@@ -659,7 +659,7 @@ WHICH_XTERM=$with_xterm_new AC_SUBST(WHICH_XTERM) case $host_os in - (*linux-gnu|*cygwin|*mingw32|*msys) +(linux*gnu|linux*gnuabi64|linux*gnuabin32|linux*gnueabi|linux*gnueabihf|linux*gnux32|uclinux*|gnu*|mint*|k*bsd*-gnu|cygwin|msys|mingw*|linux*uclibc|linux*musl) want_xterm_kbs=DEL ;; (*)
The problem is that upstream doesn't publish individual commits, they just roll everything into 'snapshots', so you need to extract that one change, and make a commit with it. I'd say let's leave the --with-xterm-kbs=del, and wait for the next major release, 6.6 or so when we can drop the setting perhaps.
Alex
I discussed this issue directly with the maintainer through email, so he only mentioned it in the changelog and did not leave a record of the discussion on the web.
If necessary, I can forward this discussion to mail list to record the detail.
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]<mailto:[email protected]>
From: Alexander Kanavin <[email protected]>
Sent: Wednesday, January 22, 2025 4:29 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: [email protected]; [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when enable multilib.
Please remember to include the links to upstream discussions into commit messages. This always helps when at some point in the future someone would need to understand the issue, do additional fixing or other follow up work.
If it’s on the mailing list, those typically have web based archives with stable links to individual messages.
Alex
On Wed 22. Jan 2025 at 1.17, Mingyu Wang (Fujitsu) <[email protected]<mailto:[email protected]>> wrote:
This issue has been raised to the upstream, who stated that in addition to linux-gnueabi, there are many other types that need to be matched, so they have included the modifications in the to-do list.
--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]<mailto:[email protected]>
Quoted 27 lines
-----Original Message-----
From: Alexander Kanavin <[email protected]<mailto:[email protected]>>
Sent: Tuesday, January 21, 2025 11:40 PM
To: [email protected]<mailto:[email protected]>
Cc: Wang, Mingyu/王 鸣瑜 <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Lei, Maohui/雷 茂慧 <[email protected]<mailto:[email protected]>>
Subject: Re: [PATCH] [OE-core] [PATCH v3] ncurses: Fix install conflict when
enable multilib.Quoted 5 lines · On Tue, 21 Jan 2025 at 16:31, Ross Burton via…
Quoted 3 lines
The
host_oswhen enable multilib is as folloing:host_osof aarch64 : linux-gnuhost_osof aarch32 : linux-gnueabiSeems like the proper fix would be to change the glob to *linux-gnu* (and sent
that upstream first, obviously)?
This is an outcome of my review; in the end of it I had asked to send that proper fix upstream, but provide the oe-core fix as a tweak to configure flags. Basically because we don't know if upstream will take the proper fix.
What would help is to include the link to that upstream submission into this commit message.
Alex
Quoted 1 line · Mingyu Wang (Fujitsu)
I discussed this issue directly with the maintainer through email, so he only mentioned it in the changelog and did not leave a record of the discussion on the web.
That's ok; generally it's preferred to hold such discussions through a public channel. If it was via private email, please mention that explicitly in the future.
Alex