Skip to contentSkip to conversation

ncurses: Fix install conflict when enable multilib.

PATCH Superseded [email protected] 2 participants 4 messages Jan 14, 2025 – Jan 15, 2025

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ncurses: Fix install conflict when enable multilib.

From: Wang Mingyu <[email protected]>

After enable multilib in armv8, there are differences in the terminfo files between lib32 and lib64 packages.

The differences of kbs between ncurses-terminfo nad lib32-ncurses-terminfo are as follows:

ncurses/6.5/image/usr/share/terminfo/x/xterm+kbs2025-01-14 01:18:20.497366368 +0000 renamed from lib32-ncurses/6.5/image/usr/share/terminfo/x/xterm+kbs2025-01-14 03:45:45.669478283 +0000 +1 -1
@@ -1 +1 @@
-%8xterm+kbs|fragment for backspace key??????????????????????????????????????????????????????????????????????????????????????????????????????????????
\ No newline at end of file
+%8xterm+kbs|fragment for backspace key??????????????????????????????????????????????????????????????????????????????????????????????????????????????
\ No newline at end of file

After consulting with the upstream of ncurses, it is possible to specify kbs by setting --with-xterm-kbs=XXX. Based on the instructions in https://github.com/ThomasDickey/ncurses-snapshots/blob/master/configure#L9810,
it is appropriate to add --with-xterm-kbs=del.

---
 meta/recipes-core/ncurses/ncurses.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/ncurses/ncurses.inc +1 -0
index e96ee075bd..3f93550cf9 100644
@@ -70,6 +70,7 @@ ncurses_configure() {
 	        --without-debug \
 	        --without-ada \
 	        --without-gpm \
+		--with-xterm-kbs=del \
 	        --enable-hard-tabs \
 	        --enable-xmc-glitch \
 	        --enable-colorfgbg \
Signature · 1 line
2.43.0
#1 lore raw
Quoted 3 lines · wangmy via lists.openembedded.org

After consulting with the upstream of ncurses, it is possible to specify kbs by setting --with-xterm-kbs=XXX. Based on the instructions in https://github.com/ThomasDickey/ncurses-snapshots/blob/master/configure#L9810,
it is appropriate to add --with-xterm-kbs=del.

I'd like to dig a little bit deeper into this, because I'm not sure how the mismatch could happen. The configure script does this autodetection:

case $host_os in
(*linux-gnu|*cygwin|*mingw32|*msys)

    want_xterm_kbs=DEL
    ;;
(*)
    want_xterm_kbs=BS
    ;;

esac

Presumably it chooses BS option in one of your multilib configurations, but I do not understand why would that be. Can you share log.do_configure for both of them, particularly interesting would be the part where it sets host_os:

checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-poky-linux-gnu checking target system type... x86_64-poky-linux-gnu Configuring for linux-gnu

Thanks,
Alex

#2 lore raw
Quoted 8 lines

case $host_os in
(*linux-gnu|*cygwin|*mingw32|*msys)

    want_xterm_kbs=DEL
    ;;
(*)
    want_xterm_kbs=BS
    ;;

esac

We check the output of host_os when enable multilib:
$host_os of aarch64 : linux-gnu
$host_os of aarch32: linux-gnueabi

We think about two solutions:
1. Use the v2 patch to specify --with-xterm-kbs=del
2. Temporarily modify the following code in Yocto. And submit patches to upstream:

configure +1 -1
@@ -9470,7 +9470,7 @@ echo "${ECHO_T}$with_xterm_new" >&6
 WHICH_XTERM=$with_xterm_new
 
 case $host_os in
-(*linux-gnu|*cygwin|*mingw32|*msys)
+(*linux-gnu*|*cygwin|*mingw32|*msys)
        want_xterm_kbs=DEL
        ;;
 (*)

Which plan do you think is better?

--
Best Regards
---------------------------------------------------
Wang Mingyu
FUJITSU NANJING SOFTWARE TECHNOLOGY CO., LTD. (FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL:+86+25-86630566--8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]

Quoted 42 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Alexander Kanavin via lists.openembedded.org
Sent: Tuesday, January 14, 2025 7:00 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: [email protected]; Lei, Maohui/雷 茂慧 <[email protected]>
Subject: Re: [PATCH] [OE-core] [PATCH v2] ncurses: Fix install conflict when enable multilib.

Quoted 1 line · wangmy via lists.openembedded.org

After consulting with the upstream of ncurses, it is possible to specify kbs by

setting --with-xterm-kbs=XXX.

Quoted 3 lines

Based on the instructions in
https://github.com/ThomasDickey/ncurses-snapshots/blob/master/configur
e#L9810, it is appropriate to add --with-xterm-kbs=del.

I'd like to dig a little bit deeper into this, because I'm not sure how the mismatch could happen. The configure script does this
autodetection:

case $host_os in
(*linux-gnu|*cygwin|*mingw32|*msys)

    want_xterm_kbs=DEL
    ;;
(*)
    want_xterm_kbs=BS
    ;;

esac

Presumably it chooses BS option in one of your multilib configurations, but I do not understand why would that be. Can you share log.do_configure for both of them, particularly interesting would be the part where it sets host_os:

checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-poky-linux-gnu checking target system type... x86_64-poky-linux-gnu Configuring for linux-gnu

Thanks,
Alex

#3 lore raw
Quoted 15 lines · Mingyu Wang (Fujitsu)

We think about two solutions:
1. Use the v2 patch to specify --with-xterm-kbs=del
2. Temporarily modify the following code in Yocto. And submit patches to upstream:

configure +1 -1
@@ -9470,7 +9470,7 @@ echo "${ECHO_T}$with_xterm_new" >&6
 WHICH_XTERM=$with_xterm_new
 
 case $host_os in
-(*linux-gnu|*cygwin|*mingw32|*msys)
+(*linux-gnu*|*cygwin|*mingw32|*msys)
        want_xterm_kbs=DEL
        ;;
 (*)
Quoted 1 line

Which plan do you think is better?

I think this plan with two action points:
1. Specify --with-xterm-kbs=del in the recipe. You can adjust the commit message to explain the above problem with linux-gnueabi.
2. At the same time, propose the above patch upstream, without adding it to Yocto.

Alex