libmad: force architecture-specific optimisations on AVR32
PATCH 1/1 libmad: force architecture-specific optimisations on AVR32
Fixes:
http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5d
--- package/libmad/Config.in | 1 + package/libmad/libmad.mk | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-)
package/libmad/Config.in +1 -0
@@ -37,6 +37,7 @@ config BR2_PACKAGE_LIBMAD_SSO config BR2_PACKAGE_LIBMAD_ASO bool "Architecture-specific optimizations" + depends on !BR2_avr32 default y help Use certain architecture-specific optimizations.
package/libmad/libmad.mk +7 -1
@@ -35,7 +35,13 @@ LIBMAD_CONF_OPT = \ $(if $(BR2_PACKAGE_LIBMAD_OPTIMIZATION_SPEED),--enable-speed) \ $(if $(BR2_PACKAGE_LIBMAD_OPTIMIZATION_ACCURACY),--enable-accuracy) \ --$(if $(BR2_PACKAGE_LIBMAD_SSO),enable,disable)-sso \ - --$(if $(BR2_PACKAGE_LIBMAD_ASO),enable,disable)-aso \ --$(if $(BR2_PACKAGE_LIBMAD_STRICT_ISO),enable,disable)-strict-iso +ifeq ($(BR2_avr32),y) +# AVR32: Force architecture-specific optimisations +LIBMAD_CONF_OPT += --enable-aso +else +LIBMAD_CONF_OPT += --$(if $(BR2_PACKAGE_LIBMAD_ASO),enable,disable)-aso +endif + $(eval $(autotools-package))
Signature · 1 line
1.7.10.4
PATCH 1/1 libmad: force architecture-specific optimisations on AVR32
Hi Gilles,
Quoted 5 lines · Gilles Talis
Fixes:
http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5dSigned-off-by Gilles Talis <[email protected]>
This looks fine, but wouldn't it be simpler to just do
config BR2_PACKAGE_LIBMAD
bool "libmad"
select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32
in the libmad Config.in?
Simon.
PATCH 1/1 libmad: force architecture-specific optimisations on AVR32
Quoted 9 lines · Simon Dawson
Hi Gilles,
Quoted 5 lines · Gilles Talis
Fixes:
http://autobuild.buildroot.net/results/e01f5a5484299dce1797966445f3972583c67b22
http://autobuild.buildroot.net/results/7ed0563fbbfc19c93ec5be35d3b6a95e496b4c5dSigned-off-by Gilles Talis <[email protected]>
Quoted 7 lines
This looks fine, but wouldn't it be simpler to just do
config
BR2_PACKAGE_LIBMAD
bool "libmad"
selectBR2_PACKAGE_LIBMAD_ASOifBR2_avr32in the libmad Config.in?
I agree, all the more looking only at Config.in, one could think that this is doing exactly the opposite.
Best regards,
Beno?t
PATCH 1/1 libmad: force architecture-specific optimisations on AVR32
In reply to Simon DawsonQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Simon" == Simon Dawson <[email protected]> writes:
Simon> Hi Gilles,
Quoted 5 lines · Gilles Talis
Simon> This looks fine, but wouldn't it be simpler to just do
Simon> config BR2_PACKAGE_LIBMAD
Simon> bool "libmad"
Simon> select BR2_PACKAGE_LIBMAD_ASO if BR2_avr32
Simon> in the libmad Config.in?
Indeed. That or simply hiding (forcing) the option on avr32, E.G.:
config BR2_PACKAGE_LIBMAD_ASO
bool "Architecture-specific optimizations" if !BR2_avr32 default y
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 libmad: force architecture-specific optimisations on AVR32
Dear Simon, Benoit and Peter,
2013/2/22 Peter Korsgaard <[email protected]>:
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Simon" == Simon Dawson <[email protected]> writes:
Simon> Hi Gilles,
Quoted 5 lines · Gilles Talis
Simon> This looks fine, but wouldn't it be simpler to just do
Simon> config
BR2_PACKAGE_LIBMAD
Simon> bool "libmad"
Simon> selectBR2_PACKAGE_LIBMAD_ASOifBR2_avr32Simon> in the libmad Config.in?
Quoted 8 lines
Indeed. That or simply hiding (forcing) the option on avr32, E.G.:
config
BR2_PACKAGE_LIBMAD_ASO
bool "Architecture-specific optimizations" if !BR2_avr32 default y--
Bye, Peter Korsgaard
Thanks for your valuable comments. Will send a second version of the patch with your suggestions later on.
Gilles.