pinctrl: sunxi: Add Allwinner A523 support
Subsystems (4)
v3 cover pinctrl: sunxi: Add Allwinner A523 support
Hi,
this is the third drop of the series introducing pinctrl support for the Allwinner A523 family of SoCs (comprising A523, A527, T527, H728). [1] Only small changes this time: renaming a symbol, fixing the DT binding example, add adding the accrued tags. Many thanks to the reviewers, in particular Jernej for biting the bullet and looking at patch 5/8! Changelog below.
==============
The first four patches extend the sunxi pinctrl core code to deal with some specialities of the new SoC: it uses every of the 11 possible banks except the first one, which required some register remapping. The first patch here is some cleanup, which we should take regardless, I think, since it fixes some hack we introduced with the D1 support.
The main feature is actually patch 5, which introduces a new way to express the required pinmux values for each function/pin pair. Traditionally, we dumped a rather large table of data into the (single image!) kernel for that, but this approach now puts that value into the DT, and builds the table at runtime. This patch was posted twice before [2][3], the last time LinusW seemed to be fine with the idea, just complained about the abuse of the generic pinmux property. I changed that to allwinner,pinmux now.
The rest of the patches are the usual suspects: the two files for the two pinctrl instances of the new SoC (now very small), and the DT binding.
Based on v6.14-rc1. Please have a look, review and test!
Cheers,
Andre
[1] https://linux-sunxi.org/A523#Family_of_sun55iw3
[2] https://patchwork.ozlabs.org/project/linux-gpio/cover/[email protected]/
[3] https://lore.kernel.org/linux-arm-kernel/[email protected]/
Changelog v2 .. v3:
- rename POW_MOD_SEL symbol
- drop CCU binding header inclusion in DT binding example
- add review tags (with thanks!)
Changelog v1 .. v2:
- rebased on v6.14-rc1
- extend regulator array to cover PortK as well
- increase number of pins in A523 PortJ from 18 to 28
- extend comment for new pinctrl DT code
- move DT binding into separate yaml file
- Add Jernej's Reviewed-by (with thanks!)
Andre Przywara (8):
pinctrl: sunxi: refactor pinctrl variants into flags
pinctrl: sunxi: increase number of GPIO bank regulators
pinctrl: sunxi: move bank K register offset
pinctrl: sunxi: support moved power configuration registers
pinctrl: sunxi: allow reading mux values from DT
dt-bindings: pinctrl: add compatible for Allwinner A523/T527
pinctrl: sunxi: Add support for the Allwinner A523
pinctrl: sunxi: Add support for the secondary A523 GPIO ports
.../allwinner,sun55i-a523-pinctrl.yaml | 175 ++++++++ drivers/pinctrl/sunxi/Kconfig | 10 + drivers/pinctrl/sunxi/Makefile | 3 + drivers/pinctrl/sunxi/pinctrl-sun20i-d1.c | 6 +- drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 8 +- drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c | 54 +++ drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c | 54 +++ drivers/pinctrl/sunxi/pinctrl-sun5i.c | 8 +- drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c | 8 +- drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 7 +- drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c | 374 ++++++++++++++++++ drivers/pinctrl/sunxi/pinctrl-sunxi.c | 54 ++- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 47 ++- 13 files changed, 758 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c create mode 100644 drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c
Signature · 1 line
2.46.3
PATCH v3 1/8 pinctrl: sunxi: refactor pinctrl variants into flags
For some Allwinner SoCs we have one pinctrl driver caring for multiple very similar chips, and are tagging certain pins with a variant bitmask. The Allwinner D1 introduced a slightly extended register layout, and we were abusing this variant mask to convey this bit of information into the common code part.
Now there will be more pinctrl device properties to consider (has PortF voltage switch, for instance), so shoehorning this into the variant bitmask will not fly anymore.
Refactor the "variant" field into a more generic "flags" field. It turns out that we don't need the variant bits to be unique across all SoCs, but only among those SoCs that share one driver (table), of which there are at most three variants at the moment. So the actual variant field can be limited to say 8 bits, and the other bits in the flag register can be re-purposed to hold other information, like this extended register layout.
As a side effect we can move the variant definition into the per-SoC pinctrl driver file, which makes it more obvious that this is just a private definition, only relevant for this particular table. This also changes the artificial sun20i-d1 "variant" into the actual flag bit that we are after.
--- drivers/pinctrl/sunxi/pinctrl-sun20i-d1.c | 6 ++---- drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 8 ++++++-- drivers/pinctrl/sunxi/pinctrl-sun5i.c | 8 ++++++-- drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c | 8 +++++--- drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 7 +++++-- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 10 +++++----- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 23 +++++++---------------- 7 files changed, 36 insertions(+), 34 deletions(-)
drivers/pinctrl/sunxi/pinctrl-sun20i-d1.c +2 -4
@@ -820,15 +820,13 @@ static const struct sunxi_pinctrl_desc d1_pinctrl_data = {static int d1_pinctrl_probe (struct platform_device *pdev) { -unsigned long variant = (unsigned long )of_device_get_match_data (&pdev->dev); - -return sunxi_pinctrl_init_with_variant (pdev, &d1_pinctrl_data, variant); +return sunxi_pinctrl_init_with_flags (pdev, &d1_pinctrl_data, +SUNXI_PINCTRL_NEW_REG_LAYOUT ); }static const struct of_device_id d1_pinctrl_match[] = { { .compatible ="allwinner,sun20i-d1-pinctrl" , - .data = (void *)PINCTRL_SUN20I_D1 }, {} };
drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c +6 -2
@@ -17,6 +17,10 @@#include "pinctrl-sunxi.h" +#define PINCTRL_SUN4I_A10 BIT(0) +#define PINCTRL_SUN7I_A20 BIT(1) +#define PINCTRL_SUN8I_R40 BIT(2) +static const struct sunxi_desc_pin sun4i_a10_pins[] = { SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 0), SUNXI_FUNCTION(0x0, "gpio_in"),
@@ -1295,8 +1299,8 @@ static int sun4i_a10_pinctrl_probe(struct platform_device *pdev) {unsigned long variant = (unsigned long )of_device_get_match_data (&pdev->dev); -return sunxi_pinctrl_init_with_variant (pdev, &sun4i_a10_pinctrl_data, - variant); +return sunxi_pinctrl_init_with_flags (pdev, &sun4i_a10_pinctrl_data, + variant); }static const struct of_device_id sun4i_a10_pinctrl_match[] = {
drivers/pinctrl/sunxi/pinctrl-sun5i.c +6 -2
@@ -16,6 +16,10 @@#include "pinctrl-sunxi.h" +#define PINCTRL_SUN5I_A10S BIT(0) +#define PINCTRL_SUN5I_A13 BIT(1) +#define PINCTRL_SUN5I_GR8 BIT(2) +static const struct sunxi_desc_pin sun5i_pins[] = { SUNXI_PIN_VARIANT(SUNXI_PINCTRL_PIN(A, 0), PINCTRL_SUN5I_A10S,
@@ -719,8 +723,8 @@ static int sun5i_pinctrl_probe(struct platform_device *pdev) {unsigned long variant = (unsigned long )of_device_get_match_data (&pdev->dev); -return sunxi_pinctrl_init_with_variant (pdev, &sun5i_pinctrl_data, - variant); +return sunxi_pinctrl_init_with_flags (pdev, &sun5i_pinctrl_data, + variant); }static const struct of_device_id sun5i_pinctrl_match[] = {
drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c +5 -3
@@ -17,6 +17,9 @@#include "pinctrl-sunxi.h" +#define PINCTRL_SUN6I_A31 BIT(0) +#define PINCTRL_SUN6I_A31S BIT(1) +static const struct sunxi_desc_pin sun6i_a31_pins[] = { SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 0), SUNXI_FUNCTION(0x0, "gpio_in"),
@@ -972,9 +975,8 @@ static int sun6i_a31_pinctrl_probe(struct platform_device *pdev)unsigned long variant = (unsigned long )of_device_get_match_data (&pdev->dev); -return sunxi_pinctrl_init_with_variant (pdev, - &sun6i_a31_pinctrl_data, - variant); +return sunxi_pinctrl_init_with_flags (pdev, &sun6i_a31_pinctrl_data, + variant); }static const struct of_device_id sun6i_a31_pinctrl_match[] = {
drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c +5 -2
@@ -22,6 +22,9 @@#include "pinctrl-sunxi.h" +#define PINCTRL_SUN8I_V3 BIT(0) +#define PINCTRL_SUN8I_V3S BIT(1) +static const struct sunxi_desc_pin sun8i_v3s_pins[] = {/* Hole */ SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
@@ -552,8 +555,8 @@ static int sun8i_v3s_pinctrl_probe(struct platform_device *pdev) {unsigned long variant = (unsigned long )of_device_get_match_data (&pdev->dev); -return sunxi_pinctrl_init_with_variant (pdev, &sun8i_v3s_pinctrl_data, - variant); +return sunxi_pinctrl_init_with_flags (pdev, &sun8i_v3s_pinctrl_data, + variant); }static const struct of_device_id sun8i_v3s_pinctrl_match[] = {
drivers/pinctrl/sunxi/pinctrl-sunxi.c +5 -5
@@ -1472,9 +1472,9 @@ static int sunxi_pinctrl_setup_debounce(struct sunxi_pinctrl *pctl,return 0 ; } -int sunxi_pinctrl_init_with_variant (struct platform_device *pdev, -const struct sunxi_pinctrl_desc *desc, -unsigned long variant) +int sunxi_pinctrl_init_with_flags (struct platform_device *pdev, +const struct sunxi_pinctrl_desc *desc, +unsigned long flags) {struct device_node *node = pdev->dev.of_node;struct pinctrl_desc *pctrl_desc;
@@ -1497,8 +1497,8 @@ int sunxi_pinctrl_init_with_variant(struct platform_device *pdev, pctl->dev = &pdev->dev; pctl->desc = desc; - pctl->variant = variant; -if (pctl->variant >=PINCTRL_SUN20I_D1 ) { + pctl->variant = flags &SUNXI_PINCTRL_VARIANT_MASK ; +if (flags &SUNXI_PINCTRL_NEW_REG_LAYOUT ) { pctl->bank_mem_size =D1_BANK_MEM_SIZE ; pctl->pull_regs_offset =D1_PULL_REGS_OFFSET ; pctl->dlevel_field_width =D1_DLEVEL_FIELD_WIDTH ;
drivers/pinctrl/sunxi/pinctrl-sunxi.h +7 -16
@@ -82,18 +82,9 @@#define SUN4I_FUNC_INPUT 0#define SUN4I_FUNC_IRQ 6 -#define PINCTRL_SUN5I_A10S BIT(1) -#define PINCTRL_SUN5I_A13 BIT(2) -#define PINCTRL_SUN5I_GR8 BIT(3) -#define PINCTRL_SUN6I_A31 BIT(4) -#define PINCTRL_SUN6I_A31S BIT(5) -#define PINCTRL_SUN4I_A10 BIT(6) -#define PINCTRL_SUN7I_A20 BIT(7) -#define PINCTRL_SUN8I_R40 BIT(8) -#define PINCTRL_SUN8I_V3 BIT(9) -#define PINCTRL_SUN8I_V3S BIT(10) -/* Variants below here have an updated register layout. */ -#define PINCTRL_SUN20I_D1 BIT(11) +#define SUNXI_PINCTRL_VARIANT_MASK GENMASK(7, 0) +#define SUNXI_PINCTRL_NEW_REG_LAYOUT BIT(8) +#define SUNXI_PINCTRL_PORTF_SWITCH BIT(9)#define PIO_POW_MOD_SEL_REG 0x340#define PIO_POW_MOD_CTL_REG 0x344
@@ -299,11 +290,11 @@ static inline u32 sunxi_grp_config_reg(u16 pin) return GRP_CFG_REG + bank * 0x4; } -int sunxi_pinctrl_init_with_variant (struct platform_device *pdev, -const struct sunxi_pinctrl_desc *desc, -unsigned long variant); +int sunxi_pinctrl_init_with_flags (struct platform_device *pdev, +const struct sunxi_pinctrl_desc *desc, +unsigned long flags);#define sunxi_pinctrl_init (_dev, _desc) \ - sunxi_pinctrl_init_with_variant(_dev, _desc, 0) + sunxi_pinctrl_init_with_flags(_dev, _desc, 0)#endif /* __PINCTRL_SUNXI_H */
Signature · 1 line
2.46.3
PATCH v3 2/8 pinctrl: sunxi: increase number of GPIO bank regulators
In reply to Andre PrzywaraBy design, the Allwinner pinctrl IP always supported up to 11 GPIO banks, though no SoC ever used more than 9 banks so far.
The Allwinner A523 has pins in all 11 banks, which exceeds the number of per-bank regulators that we currently support, as this was set to 9.
Increase the size of the array to hold up to 11 regulator structs, to support pins in bank J and K as well.
--- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/sunxi/pinctrl-sunxi.h +1 -1
@@ -155,7 +155,7 @@ struct sunxi_pinctrl {struct gpio_chip *chip;const struct sunxi_pinctrl_desc *desc;struct device *dev; -struct sunxi_pinctrl_regulator regulators[9 ]; +struct sunxi_pinctrl_regulator regulators[11 ];struct irq_domain *domain;struct sunxi_pinctrl_function *functions;unsigned nfunctions;
Signature · 1 line
2.46.3
PATCH v3 3/8 pinctrl: sunxi: move bank K register offset
In reply to Andre PrzywaraThe Allwinner pincontroller register layout used to allow for at least 11 banks per controller, any more banks would reside at a second controller instance.
When the per-bank register map size was increased with the D1, it turned out that the last bank (port K) of those maximum 11 banks actually would not fit anymore in the 512 bytes reserved for the pincontroller registers. On new SoCs Allwinner thus moved the last bank beyond the existing registers, at offset 0x500.
So far SoCs never used more than 9 banks per controller, but the new Allwinner A523 actually uses all 11 banks. Since that SoC also uses the extended layout, its PortK needs to be programmed at offset 0x500.
Factor out the bank offset calculation into a new function, and handle the case for the last bank separately. Since none of the older SoCs ever used PortK, we can ignore this case, and just always use offset 0x500 for the last bank.
--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 29 +++++++++++++++++++-------- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 4 ++++ 2 files changed, 25 insertions(+), 8 deletions(-)
drivers/pinctrl/sunxi/pinctrl-sunxi.c +21 -8
@@ -58,13 +58,29 @@ static struct irq_chip sunxi_pinctrl_level_irq_chip;* The following functions calculate the register and the bit offset to access. * They take a pin number which is relative to the start of the current device. */ + +/* +* When using the extended register layout, Bank K does not fit into the +* space used for the other banks. Instead it lives at offset 0x500. +*/ +static u32 sunxi_bank_offset (const struct sunxi_pinctrl *pctl,u32 pin) +{ +u32 offset =0 ; + +if (pin >=PK_BASE ) { + pin -=PK_BASE ; + offset =PIO_BANK_K_OFFSET ; + } + +return offset + (pin /PINS_PER_BANK ) * pctl->bank_mem_size; +} +static void sunxi_mux_reg (const struct sunxi_pinctrl *pctl,u32 pin,u32 *reg,u32 *shift,u32 *mask) { -u32 bank = pin /PINS_PER_BANK ;u32 offset = pin %PINS_PER_BANK *MUX_FIELD_WIDTH ; - *reg = bank * pctl->bank_mem_size +MUX_REGS_OFFSET + + *reg =sunxi_bank_offset (pctl, pin) +MUX_REGS_OFFSET + offset /BITS_PER_TYPE (u32) *sizeof (u32); *shift = offset %BITS_PER_TYPE (u32); *mask = (BIT (MUX_FIELD_WIDTH ) -1 ) << *shift;
@@ -73,10 +89,9 @@ static void sunxi_mux_reg(const struct sunxi_pinctrl *pctl,static void sunxi_data_reg (const struct sunxi_pinctrl *pctl,u32 pin,u32 *reg,u32 *shift,u32 *mask) { -u32 bank = pin /PINS_PER_BANK ;u32 offset = pin %PINS_PER_BANK *DATA_FIELD_WIDTH ; - *reg = bank * pctl->bank_mem_size +DATA_REGS_OFFSET + + *reg =sunxi_bank_offset (pctl, pin) +DATA_REGS_OFFSET + offset /BITS_PER_TYPE (u32) *sizeof (u32); *shift = offset %BITS_PER_TYPE (u32); *mask = (BIT (DATA_FIELD_WIDTH ) -1 ) << *shift;
@@ -85,10 +100,9 @@ static void sunxi_data_reg(const struct sunxi_pinctrl *pctl,static void sunxi_dlevel_reg (const struct sunxi_pinctrl *pctl,u32 pin,u32 *reg,u32 *shift,u32 *mask) { -u32 bank = pin /PINS_PER_BANK ;u32 offset = pin %PINS_PER_BANK * pctl->dlevel_field_width; - *reg = bank * pctl->bank_mem_size +DLEVEL_REGS_OFFSET + + *reg =sunxi_bank_offset (pctl, pin) +DLEVEL_REGS_OFFSET + offset /BITS_PER_TYPE (u32) *sizeof (u32); *shift = offset %BITS_PER_TYPE (u32); *mask = (BIT (pctl->dlevel_field_width) -1 ) << *shift;
@@ -97,10 +111,9 @@ static void sunxi_dlevel_reg(const struct sunxi_pinctrl *pctl,static void sunxi_pull_reg (const struct sunxi_pinctrl *pctl,u32 pin,u32 *reg,u32 *shift,u32 *mask) { -u32 bank = pin /PINS_PER_BANK ;u32 offset = pin %PINS_PER_BANK *PULL_FIELD_WIDTH ; - *reg = bank * pctl->bank_mem_size + pctl->pull_regs_offset + + *reg =sunxi_bank_offset (pctl, pin) + pctl->pull_regs_offset + offset /BITS_PER_TYPE (u32) *sizeof (u32); *shift = offset %BITS_PER_TYPE (u32); *mask = (BIT (PULL_FIELD_WIDTH ) -1 ) << *shift;
drivers/pinctrl/sunxi/pinctrl-sunxi.h +4 -0
@@ -25,6 +25,8 @@#define PG_BASE 192#define PH_BASE 224#define PI_BASE 256 +#define PJ_BASE 288 +#define PK_BASE 320#define PL_BASE 352#define PM_BASE 384#define PN_BASE 416
@@ -89,6 +91,8 @@#define PIO_POW_MOD_SEL_REG 0x340#define PIO_POW_MOD_CTL_REG 0x344 +#define PIO_BANK_K_OFFSET 0x500 +enum sunxi_desc_bias_voltage {BIAS_VOLTAGE_NONE ,/*
Signature · 1 line
2.46.3
PATCH v3 4/8 pinctrl: sunxi: support moved power configuration registers
In reply to Andre PrzywaraThe Allwinner pincontroller IP features some registers to control the withstand voltage of each pin group. So far those registers were always located at the same offset, but the A523 SoC has moved them (probably to accommodate all eleven pin banks).
Add a flag to note this feature, and use that to program the registers either at offset 0x340 or 0x380. So far no pincontroller driver uses this flag, but we need it for the upcoming A523 support.
--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 15 +++++++++++---- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 7 +++++-- 2 files changed, 16 insertions(+), 6 deletions(-)
drivers/pinctrl/sunxi/pinctrl-sunxi.c +11 -4
@@ -736,9 +736,9 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV >1800000 && uV <=2500000 ?BIT (bank) :0 ;raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_CTL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset); reg &= ~BIT (bank); -writel (reg | val, pctl->membase +PIO_POW_MOD_CTL_REG ); +writel (reg | val, pctl->membase + pctl->pow_mod_sel_offset);raw_spin_unlock_irqrestore (&pctl->lock, flags); fallthrough;
@@ -746,9 +746,12 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV <=1800000 ?1 :0 ;raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_SEL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS ); reg &= ~(1 << bank); -writel (reg | val << bank, pctl->membase +PIO_POW_MOD_SEL_REG ); +writel (reg | val << bank, + pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS );raw_spin_unlock_irqrestore (&pctl->lock, flags);return 0 ;default :
@@ -1520,6 +1523,10 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev, pctl->pull_regs_offset =PULL_REGS_OFFSET ; pctl->dlevel_field_width =DLEVEL_FIELD_WIDTH ; } +if (flags &SUNXI_PINCTRL_ELEVEN_BANKS ) + pctl->pow_mod_sel_offset =PIO_11B_POW_MOD_SEL_REG ; +else + pctl->pow_mod_sel_offset =PIO_POW_MOD_SEL_REG ; pctl->irq_array = devm_kcalloc(&pdev->dev, IRQ_PER_BANK * pctl->desc->irq_banks,
drivers/pinctrl/sunxi/pinctrl-sunxi.h +5 -2
@@ -87,9 +87,11 @@#define SUNXI_PINCTRL_VARIANT_MASK GENMASK(7, 0)#define SUNXI_PINCTRL_NEW_REG_LAYOUT BIT(8)#define SUNXI_PINCTRL_PORTF_SWITCH BIT(9) +#define SUNXI_PINCTRL_ELEVEN_BANKS BIT(10) -#define PIO_POW_MOD_SEL_REG 0x340 -#define PIO_POW_MOD_CTL_REG 0x344 +#define PIO_POW_MOD_SEL_REG 0x340 +#define PIO_11B_POW_MOD_SEL_REG 0x380 +#define PIO_POW_MOD_CTL_OFS 0x004#define PIO_BANK_K_OFFSET 0x500
@@ -173,6 +175,7 @@ struct sunxi_pinctrl {u32 bank_mem_size;u32 pull_regs_offset;u32 dlevel_field_width; +u32 pow_mod_sel_offset; };#define SUNXI_PIN (_pin, ...) \
Signature · 1 line
2.46.3
Jernej Škrabec
maintainerRe: [PATCH v3 4/8] pinctrl: sunxi: support moved power configuration registers
Dne petek, 28. februar 2025 ob 00:14:43 Srednjeevropski standardni čas je Andre Przywara napisal(a):
Quoted 20 lines
The Allwinner pincontroller IP features some registers to control the withstand voltage of each pin group. So far those registers were always located at the same offset, but the A523 SoC has moved them (probably to accommodate all eleven pin banks).
Add a flag to note this feature, and use that to program the registers either at offset
0x340or0x380. So far no pincontroller driver uses this flag, but we need it for the upcoming A523 support.Signed-off-by Andre Przywara <[email protected]>--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 15 +++++++++++---- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 7 +++++-- 2 files changed, 16 insertions(+), 6 deletions(-)drivers/pinctrl/sunxi/pinctrl-sunxi.c +0
-0
drivers/pinctrl/sunxi/pinctrl-sunxi.c static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, · line 741
Quoted 8 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +2
-2@@ -736,9 +736,9 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV >1800000 && uV <=2500000 ?BIT (bank) :0 ;raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_CTL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset); reg &= ~BIT (bank); -writel (reg | val, pctl->membase +PIO_POW_MOD_CTL_REG ); +writel (reg | val, pctl->membase + pctl->pow_mod_sel_offset);
These two are missing "+ PIO_POW_MOD_CTL_OFS" right?
Quoted 5 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +0
-0raw_spin_unlock_irqrestore (&pctl->lock, flags); fallthrough;@@ -746,9 +746,12 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV <=1800000 ?1 :0 ;
drivers/pinctrl/sunxi/pinctrl-sunxi.c static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, · line 754
Quoted 10 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +5
-2raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_SEL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS ); reg &= ~(1 << bank); -writel (reg | val << bank, pctl->membase +PIO_POW_MOD_SEL_REG ); +writel (reg | val << bank, + pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS );
And these two have "+ PIO_POW_MOD_CTL_OFS" too much, right?
Best regards,
Jernej
Quoted 41 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +4
-0raw_spin_unlock_irqrestore (&pctl->lock, flags);return 0 ;default :@@ -1520,6 +1523,10 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev, pctl->pull_regs_offset =PULL_REGS_OFFSET ; pctl->dlevel_field_width =DLEVEL_FIELD_WIDTH ; } +if (flags &SUNXI_PINCTRL_ELEVEN_BANKS ) + pctl->pow_mod_sel_offset =PIO_11B_POW_MOD_SEL_REG ; +else + pctl->pow_mod_sel_offset =PIO_POW_MOD_SEL_REG ; pctl->irq_array = devm_kcalloc(&pdev->dev, IRQ_PER_BANK * pctl->desc->irq_banks,drivers/pinctrl/sunxi/pinctrl-sunxi.h +5
-2@@ -87,9 +87,11 @@#define SUNXI_PINCTRL_VARIANT_MASK GENMASK(7, 0)#define SUNXI_PINCTRL_NEW_REG_LAYOUT BIT(8)#define SUNXI_PINCTRL_PORTF_SWITCH BIT(9) +#define SUNXI_PINCTRL_ELEVEN_BANKS BIT(10) -#define PIO_POW_MOD_SEL_REG 0x340 -#define PIO_POW_MOD_CTL_REG 0x344 +#define PIO_POW_MOD_SEL_REG 0x340 +#define PIO_11B_POW_MOD_SEL_REG 0x380 +#define PIO_POW_MOD_CTL_OFS 0x004#define PIO_BANK_K_OFFSET 0x500@@ -173,6 +175,7 @@ struct sunxi_pinctrl {u32 bank_mem_size;u32 pull_regs_offset;u32 dlevel_field_width; +u32 pow_mod_sel_offset; };#define SUNXI_PIN (_pin, ...) \
Re: [PATCH v3 4/8] pinctrl: sunxi: support moved power configuration registers
On Wed, 05 Mar 2025 18:50:34 +0100
Jernej Škrabec <[email protected]> wrote:
Hi,
Quoted 23 lines
Dne petek, 28. februar 2025 ob 00:14:43 Srednjeevropski standardni čas je Andre Przywara napisal(a):
Quoted 22 lines
The Allwinner pincontroller IP features some registers to control the withstand voltage of each pin group. So far those registers were always located at the same offset, but the A523 SoC has moved them (probably to accommodate all eleven pin banks).
Add a flag to note this feature, and use that to program the registers either at offset
0x340or0x380. So far no pincontroller driver uses this flag, but we need it for the upcoming A523 support.Signed-off-by Andre Przywara <[email protected]>--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 15 +++++++++++---- drivers/pinctrl/sunxi/pinctrl-sunxi.h | 7 +++++-- 2 files changed, 16 insertions(+), 6 deletions(-)drivers/pinctrl/sunxi/pinctrl-sunxi.c +0
-0@@ -736,9 +736,9 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV >1800000 && uV <=2500000 ?BIT (bank) :0 ;
Quoted 8 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, · line 741
Quoted 6 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +2
-2raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_CTL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset); reg &= ~BIT (bank); -writel (reg | val, pctl->membase +PIO_POW_MOD_CTL_REG ); +writel (reg | val, pctl->membase + pctl->pow_mod_sel_offset);These two are missing "+
PIO_POW_MOD_CTL_OFS" right?
Ah, you are right, I mixed that up. Nice catch!
Quoted 6 lines
Quoted 6 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +0
-0raw_spin_unlock_irqrestore (&pctl->lock, flags); fallthrough;@@ -746,9 +746,12 @@ static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, val = uV <=1800000 ?1 :0 ;
Quoted 11 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c static int sunxi_pinctrl_set_io_bias_cfg(struct sunxi_pinctrl *pctl, · line 754
Quoted 9 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +5
-2raw_spin_lock_irqsave (&pctl->lock, flags); - reg =readl (pctl->membase +PIO_POW_MOD_SEL_REG ); + reg =readl (pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS ); reg &= ~(1 << bank); -writel (reg | val << bank, pctl->membase +PIO_POW_MOD_SEL_REG ); +writel (reg | val << bank, + pctl->membase + pctl->pow_mod_sel_offset + +PIO_POW_MOD_CTL_OFS );And these two have "+
PIO_POW_MOD_CTL_OFS" too much, right?
Indeed, fixed now.
Thanks,
Andre
Quoted 49 lines
Best regards,
JernejQuoted 41 lines
drivers/pinctrl/sunxi/pinctrl-sunxi.c +4
-0raw_spin_unlock_irqrestore (&pctl->lock, flags);return 0 ;default :@@ -1520,6 +1523,10 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev, pctl->pull_regs_offset =PULL_REGS_OFFSET ; pctl->dlevel_field_width =DLEVEL_FIELD_WIDTH ; } +if (flags &SUNXI_PINCTRL_ELEVEN_BANKS ) + pctl->pow_mod_sel_offset =PIO_11B_POW_MOD_SEL_REG ; +else + pctl->pow_mod_sel_offset =PIO_POW_MOD_SEL_REG ; pctl->irq_array = devm_kcalloc(&pdev->dev, IRQ_PER_BANK * pctl->desc->irq_banks,drivers/pinctrl/sunxi/pinctrl-sunxi.h +5
-2@@ -87,9 +87,11 @@#define SUNXI_PINCTRL_VARIANT_MASK GENMASK(7, 0)#define SUNXI_PINCTRL_NEW_REG_LAYOUT BIT(8)#define SUNXI_PINCTRL_PORTF_SWITCH BIT(9) +#define SUNXI_PINCTRL_ELEVEN_BANKS BIT(10) -#define PIO_POW_MOD_SEL_REG 0x340 -#define PIO_POW_MOD_CTL_REG 0x344 +#define PIO_POW_MOD_SEL_REG 0x340 +#define PIO_11B_POW_MOD_SEL_REG 0x380 +#define PIO_POW_MOD_CTL_OFS 0x004#define PIO_BANK_K_OFFSET 0x500@@ -173,6 +175,7 @@ struct sunxi_pinctrl {u32 bank_mem_size;u32 pull_regs_offset;u32 dlevel_field_width; +u32 pow_mod_sel_offset; };#define SUNXI_PIN (_pin, ...) \
PATCH v3 5/8 pinctrl: sunxi: allow reading mux values from DT
In reply to Andre PrzywaraSo far every Allwinner SoC needs a large table in the kernel code, to describe the mapping between the pinctrl function names ("uart") and the actual pincontroller mux value to be written into the registers. This adds a lot of data into a single image kernel, and also looks somewhat weird, as the DT can easily store the mux value.
Add some code that allows to avoid that table: the struct that describes the existing pins will be build at *runtime*, based on very basic information provided by the respective SoC's pinctrl driver. This consists of the number of pins per bank, plus information which bank provides IRQ support, along with the mux value to use for that. The code will then iterate over all children of the pincontroller DT node (which describe each pin group), and populate that struct with the mapping between function names and mux values. The only thing that needs adding in the DT is a property with that value, per pin group.
When this table is built, it will be handed over to the existing sunxi pinctrl driver, which cannot tell a difference between a hardcoded struct and this new one built at runtime. It will take care of registering the pinctrl device with the pinctrl subsystem.
All a new SoC driver would need to do is to provide two arrays, and then call the sunxi_pinctrl_dt_table_init() function.
--- drivers/pinctrl/sunxi/Makefile | 1 + drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c | 374 +++++++++++++++++++++++ drivers/pinctrl/sunxi/pinctrl-sunxi.h | 9 + 3 files changed, 384 insertions(+) create mode 100644 drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c
drivers/pinctrl/sunxi/Makefile +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 # Core obj-y += pinctrl-sunxi.o +obj-y += pinctrl-sunxi-dt.o # SoC Drivers obj-$(CONFIG_PINCTRL_SUNIV_F1C100S) += pinctrl-suniv-f1c100s.o
drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c new file +374 -0
374 lines not on this page · raw message
drivers/pinctrl/sunxi/pinctrl-sunxi.h +9 -0
@@ -31,6 +31,9 @@#define PM_BASE 384#define PN_BASE 416 +/* maximum number of banks per controller (PA -> PK) */ +#define SUNXI_PINCTRL_MAX_BANKS 11 +#define SUNXI_PINCTRL_PIN (bank, pin) \ PINCTRL_PIN(P ## bank ## _BASE + (pin), "P" #bank #pin)
@@ -304,4 +307,10 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev,#define sunxi_pinctrl_init (_dev, _desc) \ sunxi_pinctrl_init_with_flags(_dev, _desc, 0) +int sunxi_pinctrl_dt_table_init (struct platform_device *pdev, +const u8 *pins_per_bank, +const u8 *irq_bank_muxes, +struct sunxi_pinctrl_desc *desc, +unsigned long flags); +#endif /* __PINCTRL_SUNXI_H */
Signature · 1 line
2.46.3
PATCH v3 6/8 dt-bindings: pinctrl: add compatible for Allwinner A523/T527
In reply to Andre PrzywaraThe A523 contains a pin controller similar to previous SoCs, although using 10 GPIO banks (PortB-PortK), all of them being IRQ capable. With this SoC we introduce a new style of binding, where the pinmux values for each pin group are stored in the new "allwinner,pinmux" property in the DT node, instead of requiring every driver to store a mapping between the function names and the required pinmux.
Add a new binding file, since all the different variants of the old binding are making the file a bit unwieldy to handle already, and the new property would make the situation worse.
--- .../allwinner,sun55i-a523-pinctrl.yaml | 175 ++++++++++++++++++ 1 file changed, 175 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml new file +175 -0
@@ -0,0 +1,175 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/allwinner,sun55i-a523-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner A523 Pin Controller + +maintainers: + - Andre Przywara <[email protected]> + +properties: + "#gpio-cells": + const: 3 + description: + GPIO consumers must use three arguments, first the number of the + bank, then the pin number inside that bank, and finally the GPIO + flags. + + "#interrupt-cells": + const: 3 + description: + Interrupts consumers must use three arguments, first the number + of the bank, then the pin number inside that bank, and finally + the interrupts flags. + + compatible: + enum: + - allwinner,sun55i-a523-pinctrl + - allwinner,sun55i-a523-r-pinctrl + + reg: + maxItems: 1 + + interrupts: + minItems: 2 + maxItems: 10 + description: + One interrupt per external interrupt bank supported on the + controller, sorted by bank number ascending order. + + clocks: + items: + - description: Bus Clock + - description: High Frequency Oscillator + - description: Low Frequency Oscillator + + clock-names: + items: + - const: apb + - const: hosc + - const: losc + + gpio-controller: true + interrupt-controller: true + gpio-line-names: true + + input-debounce: + description: + Debouncing periods in microseconds, one period per interrupt + bank found in the controller + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 10 + +patternProperties: + # It's pretty scary, but the basic idea is that: + # - One node name can start with either s- or r- for PRCM nodes, + # - Then, the name itself can be any repetition of <string>- (to + # accommodate with nodes like uart4-rts-cts-pins), where each + # string can be either starting with 'p' but in a string longer + # than 3, or something that doesn't start with 'p', + # - Then, the bank name is optional and will be between pa and pm. + # Some pins groups that have several options will have the pin + # numbers then, + # - Finally, the name will end with either -pin or pins. + + "^([rs]-)?(([a-z0-9]{3,}|[a-oq-z][a-z0-9]*?)?-)+?(p[a-m][0-9]*?-)??pins?$": + type: object + + properties: + pins: true + function: true + bias-disable: true + bias-pull-up: true + bias-pull-down: true + + drive-strength: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [10, 20, 30, 40] + + allwinner,pinmux: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + Pinmux selector value, for each pin. Almost every time this value + is the same for all pins, so any array shorter than the number of + pins will repeat the last value, to allow just specifying a single + cell, for all cells. + + required: + - pins + - allwinner,pinmux + - function + + additionalProperties: false + + "^vcc-p[a-m]-supply$": + description: + Power supplies for pin banks. + +required: + - "#gpio-cells" + - compatible + - reg + - clocks + - clock-names + - gpio-controller + - "#interrupt-cells" + - interrupts + - interrupt-controller + +allOf: + - $ref: pinctrl.yaml# + - if: + properties: + compatible: + enum: + - allwinner,sun55i-a523-pinctrl + + then: + properties: + interrupts: + minItems: 10 + maxItems: 10 + + - if: + properties: + compatible: + enum: + - allwinner,sun55i-a523-r-pinctrl + + then: + properties: + interrupts: + minItems: 2 + maxItems: 2 + +additionalProperties: false + +examples: + - | + r_pio: pinctrl@7022000 { + compatible = "allwinner,sun55i-a523-r-pinctrl"; + reg = <0x7022000 0x800>; + interrupts = <0 159 4>, <0 161 4>; + clocks = <&r_ccu 1>, <&osc24M>, <&osc32k>; + clock-names = "apb", "hosc", "losc"; + gpio-controller; + #gpio-cells = <3>; + interrupt-controller; + #interrupt-cells = <3>; + + r_i2c_pins: r-i2c-pins { + pins = "PL0", "PL1"; + allwinner,pinmux = <2>; + function = "r_i2c0"; + bias-pull-up; + }; + + r_spi_pins: r-spi-pins { + pins = "PL11" ,"PL12", "PL13"; + allwinner,pinmux = <6>; + function = "r_spi"; + }; + };
Signature · 1 line
2.46.3
Re: [PATCH v3 6/8] dt-bindings: pinctrl: add compatible for Allwinner A523/T527
Quoted 11 lines · Andre Przywara
The A523 contains a pin controller similar to previous SoCs, although using 10 GPIO banks (PortB-PortK), all of them being IRQ capable. With this SoC we introduce a new style of binding, where the pinmux values for each pin group are stored in the new "allwinner,pinmux" property in the DT node, instead of requiring every driver to store a mapping between the function names and the required pinmux.
Add a new binding file, since all the different variants of the old binding are making the file a bit unwieldy to handle already, and the new property would make the situation worse.
Quoted 6 lines
Signed-off-by Andre Przywara <[email protected]>--- .../allwinner,sun55i-a523-pinctrl.yaml | 175 ++++++++++++++++++ 1 file changed, 175 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml
PATCH v3 7/8 pinctrl: sunxi: Add support for the Allwinner A523
In reply to Andre PrzywaraThe Allwinner A523 contains pins in 10 out of the 11 possible pin banks; it just skips port A.
Use the newly introduced DT based pinctrl driver to describe just the generic pinctrl properties, so advertise the number of pins per bank and the interrupt capabilities. The actual function/mux assignment is taken from the devicetree.
--- drivers/pinctrl/sunxi/Kconfig | 5 ++ drivers/pinctrl/sunxi/Makefile | 1 + drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c | 54 +++++++++++++++++++++ 3 files changed, 60 insertions(+) create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c
drivers/pinctrl/sunxi/Kconfig +5 -0
@@ -131,4 +131,9 @@ config PINCTRL_SUN50I_H616_R default ARM64 && ARCH_SUNXI select PINCTRL_SUNXI +config PINCTRL_SUN55I_A523 + bool "Support for the Allwinner A523 PIO" + default ARM64 && ARCH_SUNXI + select PINCTRL_SUNXI + endif
drivers/pinctrl/sunxi/Makefile +1 -0
@@ -27,5 +27,6 @@ obj-$(CONFIG_PINCTRL_SUN50I_H6) += pinctrl-sun50i-h6.o obj-$(CONFIG_PINCTRL_SUN50I_H6_R) += pinctrl-sun50i-h6-r.o obj-$(CONFIG_PINCTRL_SUN50I_H616) += pinctrl-sun50i-h616.o obj-$(CONFIG_PINCTRL_SUN50I_H616_R) += pinctrl-sun50i-h616-r.o +obj-$(CONFIG_PINCTRL_SUN55I_A523) += pinctrl-sun55i-a523.o obj-$(CONFIG_PINCTRL_SUN9I_A80) += pinctrl-sun9i-a80.o obj-$(CONFIG_PINCTRL_SUN9I_A80_R) += pinctrl-sun9i-a80-r.o
drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c new file +54 -0
54 lines not on this page · raw message
Signature · 1 line
2.46.3
Re: [PATCH v3 7/8] pinctrl: sunxi: Add support for the Allwinner A523
Dne petek, 28. februar 2025 ob 00:14:46 Srednjeevropski standardni čas je Andre Przywara napisal(a):
Quoted 8 lines
The Allwinner A523 contains pins in 10 out of the 11 possible pin banks; it just skips port A.
Use the newly introduced DT based pinctrl driver to describe just the generic pinctrl properties, so advertise the number of pins per bank and the interrupt capabilities. The actual function/mux assignment is taken from the devicetree.Signed-off-by Andre Przywara <[email protected]>
Best regards,
Jernej
PATCH v3 8/8 pinctrl: sunxi: Add support for the secondary A523 GPIO ports
In reply to Andre PrzywaraAs most other Allwinner SoCs before, the A523 chip contains a second GPIO controller, managing banks PL and PM.
Use the newly introduced DT based pinctrl driver to describe just the generic pinctrl properties, so advertise the number of pins per bank and the interrupt capabilities. The actual function/mux assignment is taken from the devicetree.
--- drivers/pinctrl/sunxi/Kconfig | 5 ++ drivers/pinctrl/sunxi/Makefile | 1 + drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c | 54 +++++++++++++++++++ 3 files changed, 60 insertions(+) create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c
drivers/pinctrl/sunxi/Kconfig +5 -0
@@ -136,4 +136,9 @@ config PINCTRL_SUN55I_A523 default ARM64 && ARCH_SUNXI select PINCTRL_SUNXI +config PINCTRL_SUN55I_A523_R + bool "Support for the Allwinner A523 R-PIO" + default ARM64 && ARCH_SUNXI + select PINCTRL_SUNXI + endif
drivers/pinctrl/sunxi/Makefile +1 -0
@@ -28,5 +28,6 @@ obj-$(CONFIG_PINCTRL_SUN50I_H6_R) += pinctrl-sun50i-h6-r.o obj-$(CONFIG_PINCTRL_SUN50I_H616) += pinctrl-sun50i-h616.o obj-$(CONFIG_PINCTRL_SUN50I_H616_R) += pinctrl-sun50i-h616-r.o obj-$(CONFIG_PINCTRL_SUN55I_A523) += pinctrl-sun55i-a523.o +obj-$(CONFIG_PINCTRL_SUN55I_A523_R) += pinctrl-sun55i-a523-r.o obj-$(CONFIG_PINCTRL_SUN9I_A80) += pinctrl-sun9i-a80.o obj-$(CONFIG_PINCTRL_SUN9I_A80_R) += pinctrl-sun9i-a80-r.o
drivers/pinctrl/sunxi/pinctrl-sun55i-a523-r.c new file +54 -0
54 lines not on this page · raw message
Signature · 1 line
2.46.3
Re: [PATCH v3 8/8] pinctrl: sunxi: Add support for the secondary A523 GPIO ports
Dne petek, 28. februar 2025 ob 00:14:47 Srednjeevropski standardni čas je Andre Przywara napisal(a):
Quoted 8 lines
As most other Allwinner SoCs before, the A523 chip contains a second GPIO controller, managing banks PL and PM.
Use the newly introduced DT based pinctrl driver to describe just the generic pinctrl properties, so advertise the number of pins per bank and the interrupt capabilities. The actual function/mux assignment is taken from the devicetree.Signed-off-by Andre Przywara <[email protected]>
Best regards,
Jernej