Skip to contentSkip to conversation

ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag

PATCH Superseded Bartlomiej Zolnierkiewicz 3 participants 3 messages Sep 30, 2013 – Oct 1, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: shmobile: ape6evm: fix incorrect placement of __initdata tag

__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section.

---
v2:
- use __initdata as it is OK to do it

 arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-shmobile/board-ape6evm.c +1 -1
index 7627385..8954f55 100644
@@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
 	GPIO_KEY(KEY_VOLUMEDOWN,	329,	"S21"),
 };
 
-static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
+static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
 	.buttons	= gpio_buttons,
 	.nbuttons	= ARRAY_SIZE(gpio_buttons),
 };
Signature · 1 line
1.8.2.3
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote:

__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section.

Quoted 20 lines

---
v2:
- use __initdata as it is OK to do it

 arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644

arch/arm/mach-shmobile/board-ape6evm.c +1 -1
@@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
 	GPIO_KEY(KEY_VOLUMEDOWN,	329,	"S21"),
 };
 
-static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
+static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
 	.buttons	= gpio_buttons,
 	.nbuttons	= ARRAY_SIZE(gpio_buttons),
 };
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
Quoted 8 lines · Laurent Pinchart
Quoted 5 lines · On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote:

__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section.

Thanks, I will queue this up.

Quoted 31 lines
Quoted 21 lines

---
v2:
- use __initdata as it is OK to do it

 arch/arm/mach-shmobile/board-ape6evm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644

arch/arm/mach-shmobile/board-ape6evm.c +1 -1
@@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = {
 	GPIO_KEY(KEY_VOLUMEDOWN,	329,	"S21"),
 };
 
-static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = {
+static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = {
 	.buttons	= gpio_buttons,
 	.nbuttons	= ARRAY_SIZE(gpio_buttons),
 };
Signature · 8 lines
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html