Skip to contentSkip to conversation

ARM: at91: cam60: fix incorrect placement of __initdata tag

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Sep 30, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: at91: cam60: fix incorrect placement of __initdata tag

__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section.

---
v2:
- use __initdata as it is OK to do it

 arch/arm/mach-at91/board-cam60.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-at91/board-cam60.c +1 -3
index ade948b..ecabbed 100644
@@ -108,16 +108,14 @@ static struct spi_board_info cam60_spi_devices[] __initdata = {
 #endif
 };
 
-
 /*
  * MACB Ethernet device
  */
-static struct __initdata macb_platform_data cam60_macb_data = {
+static struct macb_platform_data cam60_macb_data __initdata = {
 	.phy_irq_pin	= AT91_PIN_PB5,
 	.is_rmii	= 0,
 };
 
-
 /*
  * NAND Flash
  */
Signature · 1 line
1.8.2.3
Acked-by on v2 1/1
#1 lore raw

On 30/09/2013 17:38, Bartlomiej Zolnierkiewicz :

Quoted 2 lines

__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section.

Yes, okay. But please do not mix the removal of white lines with your modification.

Quoted 2 lines

Anyway, no need to resend it:

Quoted 30 lines

---
v2:
- use __initdata as it is OK to do it

  arch/arm/mach-at91/board-cam60.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-at91/board-cam60.c +1 -3
index ade948b..ecabbed 100644
@@ -108,16 +108,14 @@ static struct spi_board_info cam60_spi_devices[] __initdata = {
  #endif
  };
 
-
  /*
   * MACB Ethernet device
   */
-static struct __initdata macb_platform_data cam60_macb_data = {
+static struct macb_platform_data cam60_macb_data __initdata = {
  	.phy_irq_pin	= AT91_PIN_PB5,
  	.is_rmii	= 0,
  };
 
-
  /*
   * NAND Flash
   */
Signature · 1 line
Nicolas Ferre