drm/i915: Convert fbdev to DRM client
Thomas Zimmermann
maintainerv5 cover drm/i915: Convert fbdev to DRM client
Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. The patchset also enables unloading of driver modules with in-kernel DRM clients; a feature required by i915.
As with the other drivers' fbdev emulation, fbdev in i915 is now an in-kernel DRM client that runs after the DRM device has been registered. This allows to remove the asynchronous initialization.
i915 is the last driver with an fbdev emulation that is not build upon struct drm_client. Once reviewed, the patches would ideally go into drm-misc-next, so that the old fbdev helper code can be removed. We can also attempt to add additional in-kernel clients. A DRM-based dmesg log or a bootsplash are commonly mentioned. DRM can then switch easily among the existing clients if/when required.
v5:
* style fixes (checkpatch)
v4:
<no changes>
v3:
* support module unloading (Jani, CI bot)
* as before, silently ignore devices without displays (CI bot)
v2:
* fix error handling (Jani)
* fix non-fbdev builds
* various minor fixes and cleanups
Thomas Zimmermann (7):
drm/i915: Unregister in-kernel clients
drm/client: Do not acquire module reference drm/client: Export drm_client_dev_unregister() drm/i915: Move fbdev functions
drm/i915: Initialize fbdev DRM client with callback functions drm/i915: Implement fbdev client callbacks drm/i915: Implement fbdev emulation as in-kernel client
drivers/gpu/drm/drm_client.c | 25 +- drivers/gpu/drm/i915/display/intel_display.c | 1 - .../drm/i915/display/intel_display_driver.c | 19 -- drivers/gpu/drm/i915/display/intel_fbdev.c | 250 ++++++++++-------- drivers/gpu/drm/i915/display/intel_fbdev.h | 29 +- drivers/gpu/drm/i915/i915_driver.c | 27 +- 6 files changed, 156 insertions(+), 195 deletions(-)
Signature · 1 line
2.42.0
Thomas Zimmermann
maintainerPATCH v5 1/7 drm/i915: Unregister in-kernel clients
Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915 does not use this helper, it has to perform the call by itself.
Note that there are currently no in-kernel clients in i915. The patch prepares the driver for a related update of its fbdev support.
--- drivers/gpu/drm/i915/i915_driver.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_driver.c +3 -0
@@ -41,6 +41,7 @@#include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_client.h> #include <drm/drm_ioctl.h> #include <drm/drm_managed.h> #include <drm/drm_probe_helper.h>
@@ -855,6 +856,8 @@ void i915_driver_remove(struct drm_i915_private *i915) {intel_wakeref_t wakeref; +drm_client_dev_unregister (&i915->drm); + wakeref =intel_runtime_pm_get (&i915->runtime_pm);i915_driver_unregister (i915);
Signature · 1 line
2.42.0
Re: [Intel-gfx] [PATCH v5 1/7] drm/i915: Unregister in-kernel clients
Quoted 7 lines · Thomas Zimmermann
Unregister all in-kernel clients before unloading the i915 driver. For
other drivers,drm_dev_unregister()does this automatically. As i915 does not use this helper, it has to perform the call by itself.Note that there are currently no in-kernel clients in i915. The patch prepares the driver for a related update of its fbdev support.
Hi Thomas. You need to move patch 3/7 before this one. Otherwise this doesn't build.
BR,
Jouni Högander
Quoted 29 lines
Signed-off-by Thomas Zimmermann <[email protected]>---
drivers/gpu/drm/i915/i915_driver.c | 3 +++1 file changed, 3 insertions(+)drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -41,6 +41,7 @@
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
#include <drm/drm_ioctl.h>
#include <drm/drm_managed.h>
#include <drm/drm_probe_helper.h>drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -855,6 +856,8 @@ void i915_driver_remove(struct drm_i915_private *i915) { intel_wakeref_t wakeref;
+ drm_client_dev_unregister(&i915->drm);
+
wakeref =intel_runtime_pm_get(&i915->runtime_pm);
i915_driver_unregister(i915);
Thomas Zimmermann
maintainerPATCH v5 2/7 drm/client: Do not acquire module reference
In reply to Thomas ZimmermannDo not acquire a reference on the module that provides a client's callback functions in drm_client_init(). The additional reference prevents the user from unloading the callback functions' module and thus creating dangling pointers.
This is only necessary if there is no direct dependency between the caller of drm_client_init() and the provider of the callbacks in struct drm_client_funcs. If this case ever existed, it has been removed from the DRM code. Callers of drm_client_init() also provide the callback implementation. The lifetime of the clients is tied to the dependency chain's outer-most module, which is the hardware's DRM driver. Before client helpers could be unloaded, the driver module would have to be unloaded, which also unregisters all clients.
Driver modules that set up DRM clients can now be unloaded.
--- drivers/gpu/drm/drm_client.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/gpu/drm/drm_client.c +1 -11
@@ -5,7 +5,6 @@#include <linux/iosys-map.h> #include <linux/list.h> -#include <linux/module.h> #include <linux/mutex.h> #include <linux/seq_file.h> #include <linux/slab.h>
@@ -84,16 +83,13 @@ int drm_client_init(struct drm_device *dev, struct drm_client_dev *client,if (!drm_core_check_feature (dev,DRIVER_MODESET ) || !dev->driver->dumb_create)return -EOPNOTSUPP ; -if (funcs && !try_module_get (funcs->owner)) -return -ENODEV ; - client->dev = dev; client->name = name; client->funcs = funcs; ret =drm_client_modeset_create (client);if (ret) - goto err_put_module; +return ret; ret =drm_client_open (client);if (ret)
@@ -105,10 +101,6 @@ int drm_client_init(struct drm_device *dev, struct drm_client_dev *client, err_free:drm_client_modeset_free (client); -err_put_module: -if (funcs) -module_put (funcs->owner); -return ret; }EXPORT_SYMBOL (drm_client_init);
@@ -177,8 +169,6 @@ void drm_client_release(struct drm_client_dev *client)drm_client_modeset_free (client);drm_client_close (client);drm_dev_put (dev); -if (client->funcs) -module_put (client->funcs->owner); }EXPORT_SYMBOL (drm_client_release);
Signature · 1 line
2.42.0
Re: [PATCH v5 2/7] drm/client: Do not acquire module reference
Quoted 14 lines · Thomas Zimmermann
Do not acquire a reference on the module that provides a client's callback functions in
drm_client_init(). The additional reference prevents the user from unloading the callback functions' module and thus creating dangling pointers.This is only necessary if there is no direct dependency between the caller of
drm_client_init()and the provider of the callbacks in structdrm_client_funcs. If this case ever existed, it has been removed from the DRM code. Callers ofdrm_client_init()also provide the callback implementation. The lifetime of the clients is tied to the dependency chain's outer-most module, which is the hardware's DRM driver. Before client helpers could be unloaded, the driver module would have to be unloaded, which also unregisters all clients.
Quoted 4 lines
Driver modules that set up DRM clients can now be unloaded.
Signed-off-by Thomas Zimmermann <[email protected]>---
The change makes sense to me.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Thomas Zimmermann
maintainerPATCH v5 3/7 drm/client: Export drm_client_dev_unregister()
In reply to Thomas ZimmermannExport drm_client_dev_unregister() for use by the i915 driver. The driver does not use drm_dev_unregister(), so it has to clean up the in-kernel DRM clients by itself.
--- drivers/gpu/drm/drm_client.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/gpu/drm/drm_client.c +13 -0
@@ -172,6 +172,18 @@ void drm_client_release(struct drm_client_dev *client) }EXPORT_SYMBOL (drm_client_release); +/** +* drm_client_dev_unregister - Unregister clients +* @dev: DRM device +* +* This function releases all clients by calling each client's +* &drm_client_funcs.unregister callback. The callback function +* is responsibe for releaseing all resources including the client +* itself. +* +* The helper drm_dev_unregister() calls this function. Drivers +* that use it don't need to call this function themselves. +*/ void drm_client_dev_unregister (struct drm_device *dev) {struct drm_client_dev *client, *tmp;
@@ -191,6 +203,7 @@ void drm_client_dev_unregister(struct drm_device *dev) }mutex_unlock (&dev->clientlist_mutex); } +EXPORT_SYMBOL (drm_client_dev_unregister);/** * drm_client_dev_hotplug - Send hotplug event to clients
Signature · 1 line
2.42.0
Thomas Zimmermann
maintainerPATCH v5 4/7 drm/i915: Move fbdev functions
In reply to Thomas ZimmermannMove functions within intel_fbdev.c to simplify later updates. Minor style fixes to make checkpatch happy, but no functional changes.
v5:
* style fixes (checkpatch)
--- drivers/gpu/drm/i915/display/intel_fbdev.c | 154 ++++++++++----------- 1 file changed, 77 insertions(+), 77 deletions(-)
drivers/gpu/drm/i915/display/intel_fbdev.c +77 -77
@@ -545,58 +545,6 @@ static void intel_fbdev_suspend_worker(struct work_struct *work) true); } -int intel_fbdev_init (struct drm_device *dev) -{ -struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_fbdev *ifbdev; -int ret; - -if (drm_WARN_ON (dev, !HAS_DISPLAY (dev_priv))) -return -ENODEV ; - - ifbdev =kzalloc (sizeof (struct intel_fbdev ),GFP_KERNEL ); -if (ifbdev ==NULL ) -return -ENOMEM ; - -mutex_init (&ifbdev->hpd_lock); -drm_fb_helper_prepare (dev, &ifbdev->helper,32 , &intel_fb_helper_funcs); - -if (intel_fbdev_init_bios (dev, ifbdev)) - ifbdev->helper.preferred_bpp = ifbdev->preferred_bpp; -else - ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp; - - ret =drm_fb_helper_init (dev, &ifbdev->helper); -if (ret) { -kfree (ifbdev); -return ret; - } - - dev_priv->display.fbdev.fbdev = ifbdev; -INIT_WORK (&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); - -return 0 ; -} - -static void intel_fbdev_initial_config (void *data,async_cookie_t cookie) -{ -struct intel_fbdev *ifbdev = data; - -/* Due to peculiar init order wrt to hpd handling this is separate. */ -if (drm_fb_helper_initial_config (&ifbdev->helper)) -intel_fbdev_unregister (to_i915 (ifbdev->helper.dev)); -} - -void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) -{ -struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - -if (!ifbdev) -return ; - - ifbdev->cookie =async_schedule (intel_fbdev_initial_config, ifbdev); -} -static void intel_fbdev_sync (struct intel_fbdev *ifbdev) {if (!ifbdev->cookie)
@@ -607,31 +555,6 @@ static void intel_fbdev_sync(struct intel_fbdev *ifbdev) ifbdev->cookie =0 ; } -void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ -struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - -if (!ifbdev) -return ; - -intel_fbdev_set_suspend (&dev_priv->drm,FBINFO_STATE_SUSPENDED , true); - -if (!current_is_async ()) -intel_fbdev_sync (ifbdev); - -drm_fb_helper_unregister_info (&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ -struct intel_fbdev *ifbdev =fetch_and_zero (&dev_priv->display.fbdev.fbdev); - -if (!ifbdev) -return ; - -intel_fbdev_destroy (ifbdev); -} -/* Suspends/resumes fbdev processing of incoming HPD events. When resuming HPD * processing, fbdev will perform a full connector reprobe if a hotplug event * was received while HPD was suspended.
@@ -748,6 +671,83 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv)intel_fbdev_invalidate (ifbdev); } +int intel_fbdev_init (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); +struct intel_fbdev *ifbdev; +int ret; + +if (drm_WARN_ON (dev, !HAS_DISPLAY (dev_priv))) +return -ENODEV ; + + ifbdev =kzalloc (sizeof (*ifbdev),GFP_KERNEL ); +if (!ifbdev) +return -ENOMEM ; + +mutex_init (&ifbdev->hpd_lock); +drm_fb_helper_prepare (dev, &ifbdev->helper,32 , &intel_fb_helper_funcs); + +if (intel_fbdev_init_bios (dev, ifbdev)) + ifbdev->helper.preferred_bpp = ifbdev->preferred_bpp; +else + ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp; + + ret =drm_fb_helper_init (dev, &ifbdev->helper); +if (ret) { +kfree (ifbdev); +return ret; + } + + dev_priv->display.fbdev.fbdev = ifbdev; +INIT_WORK (&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + +return 0 ; +} + +static void intel_fbdev_initial_config (void *data,async_cookie_t cookie) +{ +struct intel_fbdev *ifbdev = data; + +/* Due to peculiar init order wrt to hpd handling this is separate. */ +if (drm_fb_helper_initial_config (&ifbdev->helper)) +intel_fbdev_unregister (to_i915 (ifbdev->helper.dev)); +} + +void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) +{ +struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; + +if (!ifbdev) +return ; + + ifbdev->cookie =async_schedule (intel_fbdev_initial_config, ifbdev); +} + +void intel_fbdev_unregister (struct drm_i915_private *dev_priv) +{ +struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; + +if (!ifbdev) +return ; + +intel_fbdev_set_suspend (&dev_priv->drm,FBINFO_STATE_SUSPENDED , true); + +if (!current_is_async ()) +intel_fbdev_sync (ifbdev); + +drm_fb_helper_unregister_info (&ifbdev->helper); +} + +void intel_fbdev_fini (struct drm_i915_private *dev_priv) +{ +struct intel_fbdev *ifbdev =fetch_and_zero (&dev_priv->display.fbdev.fbdev); + +if (!ifbdev) +return ; + +intel_fbdev_destroy (ifbdev); +} +struct intel_framebuffer *intel_fbdev_framebuffer (struct intel_fbdev *fbdev) {if (!fbdev || !fbdev->helper.fb)
Signature · 1 line
2.42.0
Re: [PATCH v5 4/7] drm/i915: Move fbdev functions
Quoted 7 lines · Thomas Zimmermann
Move functions within
intel_fbdev.cto simplify later updates. Minor style fixes to make checkpatch happy, but no functional changes.v5:
* style fixes (checkpatch)Signed-off-by Thomas Zimmermann <[email protected]>
Quoted 207 lines
---
drivers/gpu/drm/i915/display/intel_fbdev.c | 154 ++++++++++--------- --1 file changed, 77 insertions(+), 77 deletions(-)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -545,58 +545,6 @@ static void intel_fbdev_suspend_worker(struct work_struct *work) true); }drivers/gpu/drm/i915/display/intel_fbdev.c +0
-15-int intel_fbdev_init (struct drm_device *dev) -{ - struct drm_i915_private *dev_priv = to_i915(dev); - struct intel_fbdev *ifbdev; - int ret; - - if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv))) - return -ENODEV; - - ifbdev = kzalloc(sizeof(struct intel_fbdev), GFP_KERNEL); - if (ifbdev == NULL) - return -ENOMEM; - - mutex_init(&ifbdev->hpd_lock); - drm_fb_helper_prepare(dev, &ifbdev->helper, 32,
&intel_fb_helper_funcs);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-14- - if (intel_fbdev_init_bios(dev, ifbdev)) - ifbdev->helper.preferred_bpp = ifbdev->preferred_bpp; - else - ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp; - - ret = drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) { - kfree(ifbdev); - return ret; - } - - dev_priv->display.fbdev.fbdev = ifbdev; - INIT_WORK(&dev_priv->display.fbdev.suspend_work,
intel_fbdev_suspend_worker);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-5- - return 0; -} - -static void intel_fbdev_initial_config(void *data, async_cookie_tcookie)
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-4-{ - struct intel_fbdev *ifbdev = data; - - /* Due to peculiar init order wrt to hpd handling this isseparate. */
- if (drm_fb_helper_initial_config(&ifbdev->helper)) - intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7-{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-2-} -static void
intel_fbdev_sync(struct intel_fbdev *ifbdev){
if (!ifbdev->cookie)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -607,31 +555,6 @@ static void intel_fbdev_sync(struct intel_fbdev *ifbdev) ifbdev->cookie = 0; }drivers/gpu/drm/i915/display/intel_fbdev.c +0
-8-void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10- - if (!current_is_async()) - intel_fbdev_sync(ifbdev); - - drm_fb_helper_unregister_info(&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7- - if (!ifbdev) - return; - - intel_fbdev_destroy(ifbdev); -} -/* Suspends/resumes fbdev processing of incoming HPD events. When resuming HPD
* processing, fbdev will perform a full connector reprobe if a hotplug event
* was received while HPD was suspended.drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -748,6 +671,83 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv) intel_fbdev_invalidate(ifbdev); }drivers/gpu/drm/i915/display/intel_fbdev.c +15
-0+int intel_fbdev_init (struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = to_i915(dev); + struct intel_fbdev *ifbdev; + int ret; + + if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv))) + return -ENODEV; + + ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); + if (!ifbdev) + return -ENOMEM; + + mutex_init(&ifbdev->hpd_lock); + drm_fb_helper_prepare(dev, &ifbdev->helper, 32,
&intel_fb_helper_funcs);drivers/gpu/drm/i915/display/intel_fbdev.c +14
-0+ + if (intel_fbdev_init_bios(dev, ifbdev)) + ifbdev->helper.preferred_bpp = ifbdev->preferred_bpp; + else + ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp; + + ret = drm_fb_helper_init(dev, &ifbdev->helper); + if (ret) { + kfree(ifbdev); + return ret; + } + + dev_priv->display.fbdev.fbdev = ifbdev; + INIT_WORK(&dev_priv->display.fbdev.suspend_work,
intel_fbdev_suspend_worker);drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+ + return 0; +} + +static void intel_fbdev_initial_config(void *data, async_cookie_tcookie)
drivers/gpu/drm/i915/display/intel_fbdev.c +4
-0+{ + struct intel_fbdev *ifbdev = data; + + /* Due to peculiar init order wrt to hpd handling this isseparate. */
+ if (drm_fb_helper_initial_config(&ifbdev->helper)) + intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +3
-0+} + +void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+{ + struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; + + if (!ifbdev) + return; + + ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +10
-0+} + +void intel_fbdev_unregister (struct drm_i915_private *dev_priv) +{ + struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; + + if (!ifbdev) + return; + + intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +10
-0+ + if (!current_is_async()) + intel_fbdev_sync(ifbdev); + + drm_fb_helper_unregister_info(&ifbdev->helper); +} + +void intel_fbdev_fini (struct drm_i915_private *dev_priv) +{ + struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+ + if (!ifbdev) + return; + + intel_fbdev_destroy(ifbdev); +} +struct
intel_framebuffer*intel_fbdev_framebuffer(structintel_fbdev*fbdev)
{
if (!fbdev || !fbdev->helper.fb)
Thomas Zimmermann
maintainerPATCH v5 5/7 drm/i915: Initialize fbdev DRM client with callback functions
In reply to Thomas ZimmermannInitialize i915's fbdev client by giving an instance of struct drm_client_funcs to drm_client_init(). Also clean up with drm_client_release().
Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see drm_fb_helper_init()). No functional change yet; the client callbacks will be filled later.
v2:
* call drm_fb_helper_unprepare() in error handling (Jani)
* fix typo in commit message (Sam)
--- drivers/gpu/drm/i915/display/intel_fbdev.c | 43 ++++++++++++++++++++-- 1 file changed, 39 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_fbdev.c +39 -4
@@ -378,6 +378,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev)if (ifbdev->fb)drm_framebuffer_remove (&ifbdev->fb->base); +drm_client_release (&ifbdev->helper.client);drm_fb_helper_unprepare (&ifbdev->helper);kfree (ifbdev); }
@@ -671,6 +672,30 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv)intel_fbdev_invalidate (ifbdev); } +/* +* Fbdev client and struct drm_client_funcs +*/ + +static void intel_fbdev_client_unregister (struct drm_client_dev *client) +{ } + +static int intel_fbdev_client_restore (struct drm_client_dev *client) +{ +return 0 ; +} + +static int intel_fbdev_client_hotplug (struct drm_client_dev *client) +{ +return 0 ; +} + +static const struct drm_client_funcs intel_fbdev_client_funcs = { + .owner =THIS_MODULE , + .unregister = intel_fbdev_client_unregister, + .restore = intel_fbdev_client_restore, + .hotplug = intel_fbdev_client_hotplug, +}; +int intel_fbdev_init (struct drm_device *dev) {struct drm_i915_private *dev_priv =to_i915 (dev);
@@ -692,16 +717,26 @@ int intel_fbdev_init(struct drm_device *dev)else ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp; + ret =drm_client_init (dev, &ifbdev->helper.client,"i915-fbdev" , + &intel_fbdev_client_funcs); +if (ret) + goto err_drm_fb_helper_unprepare; + ret =drm_fb_helper_init (dev, &ifbdev->helper); -if (ret) { -kfree (ifbdev); -return ret; - } +if (ret) + goto err_drm_client_release; dev_priv->display.fbdev.fbdev = ifbdev;INIT_WORK (&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker);return 0 ; + +err_drm_client_release: +drm_client_release (&ifbdev->helper.client); +err_drm_fb_helper_unprepare: +drm_fb_helper_unprepare (&ifbdev->helper); +kfree (ifbdev); +return ret; }static void intel_fbdev_initial_config (void *data,async_cookie_t cookie)
Signature · 1 line
2.42.0
Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions
Hi Thomas, One minor comment inline below.
Quoted 66 lines · Thomas Zimmermann
Initialize i915's fbdev client by giving an instance of struct
drm_client_funcstodrm_client_init(). Also clean up withdrm_client_release().Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see
drm_fb_helper_init()). No functional change yet; the client callbacks will be filled later.v2:
* calldrm_fb_helper_unprepare()in error handling (Jani)
* fix typo in commit message (Sam)Signed-off-by Thomas Zimmermann <[email protected]>---
drivers/gpu/drm/i915/display/intel_fbdev.c | 43
++++++++++++++++++++--1 file changed, 39 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -378,6 +378,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev) if (ifbdev->fb) drm_framebuffer_remove(&ifbdev->fb->base);
+ drm_client_release(&ifbdev->helper.client);drm_fb_helper_unprepare(&ifbdev->helper); kfree(ifbdev);
}drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -671,6 +672,30 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv) intel_fbdev_invalidate(ifbdev); }drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+/* +* Fbdev client and struct drm_client_funcs +*/ + +static void intel_fbdev_client_unregister(struct drm_client_dev*client)
drivers/gpu/drm/i915/display/intel_fbdev.c +19
-0+{ } + +static int intel_fbdev_client_restore (struct drm_client_dev *client) +{ + return 0; +} + +static int intel_fbdev_client_hotplug (struct drm_client_dev *client) +{ + return 0; +} + +static const struct drm_client_funcs intel_fbdev_client_funcs = { + .owner = THIS_MODULE, + .unregister = intel_fbdev_client_unregister, + .restore = intel_fbdev_client_restore, + .hotplug = intel_fbdev_client_hotplug, +}; +int
intel_fbdev_init(struct drm_device *dev)
{
structdrm_i915_private*dev_priv=to_i915(dev);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -692,16 +717,26 @@ int intel_fbdev_init(struct drm_device *dev)
Quoted 5 lines
else
ifbdev->preferred_bpp =ifbdev->helper.preferred_bpp;
+ ret = drm_client_init(dev,&ifbdev->helper.client, "i915- fbdev",
We are currently working on new driver named as Xe. Due to this it might actually make sense to use intel-fbdev here rather than i915- fbdev.
BR,
Jouni Högander
Quoted 28 lines
+
&intel_fbdev_client_funcs); + if (ret)
+ gotoerr_drm_fb_helper_unprepare; +
ret =drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) {
- kfree(ifbdev);
- return ret;
- }
+ if (ret)
+ gotoerr_drm_client_release;
dev_priv->display.fbdev.fbdev = ifbdev;INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker);
return 0;drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+ +err_drm_client_release: + drm_client_release(&ifbdev->helper.client); +err_drm_fb_helper_unprepare: + drm_fb_helper_unprepare(&ifbdev->helper); + kfree(ifbdev); + return ret;}
static voidintel_fbdev_initial_config(void *data, async_cookie_t cookie)
Thomas Zimmermann
maintainerRe: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions
Hi
Am 25.10.23 um 10:36 schrieb Hogander, Jouni:
Quoted 1 line
Hi Thomas, One minor comment inline below.
Thank you so much for taking the time to review these patches.
Quoted 71 lines · Thomas Zimmermann
Quoted 69 lines
Initialize i915's fbdev client by giving an instance of struct
drm_client_funcstodrm_client_init(). Also clean up withdrm_client_release().Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see
drm_fb_helper_init()). No functional change yet; the client callbacks will be filled later.v2:
* calldrm_fb_helper_unprepare()in error handling (Jani)
* fix typo in commit message (Sam)Signed-off-by Thomas Zimmermann <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbdev.c | 43 ++++++++++++++++++++-- 1 file changed, 39 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_fbdev.c +1
-0@@ -378,6 +378,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev) if (ifbdev->fb) drm_framebuffer_remove(&ifbdev->fb->base); + drm_client_release(&ifbdev->helper.client); drm_fb_helper_unprepare(&ifbdev->helper); kfree(ifbdev);}
drivers/gpu/drm/i915/display/intel_fbdev.c +24
-0@@ -671,6 +672,30 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv) intel_fbdev_invalidate(ifbdev); } +/* +* Fbdev client and struct drm_client_funcs +*/ + +static void intel_fbdev_client_unregister (struct drm_client_dev *client) +{ } + +static int intel_fbdev_client_restore (struct drm_client_dev *client) +{ + return 0; +} + +static int intel_fbdev_client_hotplug (struct drm_client_dev *client) +{ + return 0; +} + +static const struct drm_client_funcs intel_fbdev_client_funcs = { + .owner = THIS_MODULE, + .unregister = intel_fbdev_client_unregister, + .restore = intel_fbdev_client_restore, + .hotplug = intel_fbdev_client_hotplug, +}; + int intel_fbdev_init(struct drm_device *dev){
structdrm_i915_private*dev_priv=to_i915(dev);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -692,16 +717,26 @@ int intel_fbdev_init(struct drm_device *dev) else ifbdev->preferred_bpp = ifbdev->helper.preferred_bpp;
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_fbdev.c int intel_fbdev_init(struct drm_device *dev) · line 721
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-0+ ret = drm_client_init(dev, &ifbdev->helper.client, "i915- fbdev",We are currently working on new driver named as Xe. Due to this it
I've always thought that it's an entirely new driver. But I'm not really up-to-date. So the Xe driver is located under i915/ and also shares code with the existing i915 driver?
Quoted 2 lines
might actually make sense to use intel-fbdev here rather than i915- fbdev.
That change could break user-space programs. See the comment at [1] and the commit 842470c4e211 ("Revert "drm/fb-helper: improve DRM fbdev emulation device names""). I'd rather leave the string as it is.
Best regards
Thomas
[1] https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_fb_helper.c#L1755
Quoted 34 lines
BR,
Jouni Högander
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +13
-4+ &intel_fbdev_client_funcs); + if (ret) + goto err_drm_fb_helper_unprepare; + ret = drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) { - kfree(ifbdev); - return ret; - } + if (ret) + goto err_drm_client_release; dev_priv->display.fbdev.fbdev = ifbdev; INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); return 0; + +err_drm_client_release: + drm_client_release(&ifbdev->helper.client); +err_drm_fb_helper_unprepare: + drm_fb_helper_unprepare(&ifbdev->helper); + kfree(ifbdev); + return ret; }static void intel_fbdev_initial_config(void *data,
async_cookie_t
cookie)
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Re: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions
Quoted 87 lines · Thomas Zimmermann
Hi
Am 25.10.23 um 10:36 schrieb Hogander, Jouni:
Quoted 1 line
Hi Thomas, One minor comment inline below.
Thank you so much for taking the time to review these patches.
Quoted 80 lines · Thomas Zimmermann
Quoted 77 lines
Initialize i915's fbdev client by giving an instance of struct
drm_client_funcstodrm_client_init(). Also clean up withdrm_client_release().Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see
drm_fb_helper_init()). No functional change yet; the client callbacks will be filled later.v2:
* calldrm_fb_helper_unprepare()in error handling (Jani)
* fix typo in commit message (Sam)Signed-off-by Thomas Zimmermann <[email protected]>---
drivers/gpu/drm/i915/display/intel_fbdev.c | 43
++++++++++++++++++++--1 file changed, 39 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -378,6 +378,7 @@ static void intel_fbdev_destroy(struct intel_fbdev *ifbdev) if (ifbdev->fb) drm_framebuffer_remove(&ifbdev->fb->base);
+ drm_client_release(&ifbdev->helper.client);drm_fb_helper_unprepare(&ifbdev->helper); kfree(ifbdev);
}drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -671,6 +672,30 @@ void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv) intel_fbdev_invalidate(ifbdev); }drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+/* +* Fbdev client and struct drm_client_funcs +*/ + +static void intel_fbdev_client_unregister(struct drm_client_dev*client)
drivers/gpu/drm/i915/display/intel_fbdev.c +3
-0+{ } + +static int intel_fbdev_client_restore(struct drm_client_dev*client)
drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+{ + return 0; +} + +static int intel_fbdev_client_hotplug(struct drm_client_dev*client)
drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+{ + return 0; +} + +static const struct drm_client_funcs intel_fbdev_client_funcs ={
+ .owner =THIS_MODULE,
+ .unregister =intel_fbdev_client_unregister, + .restore =intel_fbdev_client_restore, + .hotplug =intel_fbdev_client_hotplug,drivers/gpu/drm/i915/display/intel_fbdev.c +2
-0+}; +int
intel_fbdev_init(struct drm_device *dev)
{
structdrm_i915_private*dev_priv=to_i915(dev);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -692,16 +717,26 @@ int intel_fbdev_init(struct drm_device *dev)else
ifbdev->preferred_bpp = ifbdev-Quoted 1 line
helper.preferred_bpp;
+ ret = drm_client_init(dev,&ifbdev->helper.client, "i915- fbdev",
Quoted 7 lines
Quoted 1 line
We are currently working on new driver named as Xe. Due to this it
I've always thought that it's an entirely new driver. But I'm not really
up-to-date. So the Xe driver is located under i915/ and also shares code
with the existing i915 driver?
It will mainly share display code with i915.
Quoted 8 lines
Quoted 3 lines
might actually make sense to use intel-fbdev here rather than i915- fbdev.
That change could break user-space programs. See the comment at [1] and
the commit842470c4e211("Revert "drm/fb-helper: improve DRM fbdev emulation device names""). I'd rather leave the string as it is.
Client name doesn't affect name used in fbinfo. For i915 it is i915drmfb as earlier and for xe its xedrmfb. Also this client name is completely new added by your patches. I'm not sure where it will visible. I was originally thinking using driver->name as done in drm_fb_helper_fill_info, but I think common intel-fbdev is just fine.
BR,
Jouni Högander
Quoted 50 lines
Best regards
Thomas[1]
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_fb_helper.c#L1755Quoted 35 lines
BR,
Jouni Högander
Quoted 29 lines
+
&intel_fbdev_client_funcs); + if (ret)
+ gotoerr_drm_fb_helper_unprepare; +
ret =drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) {
- kfree(ifbdev);
- return ret;
- }
+ if (ret)
+ gotoerr_drm_client_release;
dev_priv->display.fbdev.fbdev = ifbdev;INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker);
return 0;drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+ +err_drm_client_release: + drm_client_release(&ifbdev->helper.client); +err_drm_fb_helper_unprepare: + drm_fb_helper_unprepare(&ifbdev->helper); + kfree(ifbdev); + return ret;}
static void intel_fbdev_initial_config(void *data,async_cookie_t
cookie)Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Thomas Zimmermann
maintainerRe: [Intel-gfx] [PATCH v5 5/7] drm/i915: Initialize fbdev DRM client with callback functions
Hi
Am 01.11.23 um 10:10 schrieb Hogander, Jouni:
[...]
Quoted 19 lines
Quoted 7 lines
Quoted 1 line
We are currently working on new driver named as Xe. Due to this it
I've always thought that it's an entirely new driver. But I'm not really
up-to-date. So the Xe driver is located under i915/ and also shares code
with the existing i915 driver?It will mainly share display code with i915.
Quoted 8 lines
Quoted 3 lines
might actually make sense to use intel-fbdev here rather than i915- fbdev.
That change could break user-space programs. See the comment at [1] and
the commit842470c4e211("Revert "drm/fb-helper: improve DRM fbdev emulation device names""). I'd rather leave the string as it is.
Quoted 5 lines
Client name doesn't affect name used in fbinfo. For i915 it is i915drmfb as earlier and for xe its xedrmfb. Also this client name is completely new added by your patches. I'm not sure where it will visible. I was originally thinking using
driver->nameas done indrm_fb_helper_fill_info, but I think common intel-fbdev is just fine.
Right, I was confusing the names. The client name is the name of the framebuffer in various places.
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_client.c#L421
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_framebuffer.c#L1182
But it appears to be overwritten by fbdev later during initialization:
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_fb_helper.c#L1672
I'll change the name then, but I'm not sure if it'll make a difference in the end.
Best regards
Thomas
Quoted 56 lines
BR,
Jouni Högander
Quoted 50 lines
Best regards
Thomas[1]
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/drm_fb_helper.c#L1755Quoted 35 lines
BR,
Jouni Högander
Quoted 29 lines
+
&intel_fbdev_client_funcs); + if (ret)
+ gotoerr_drm_fb_helper_unprepare; +
ret =drm_fb_helper_init(dev, &ifbdev->helper);
- if (ret) {
- kfree(ifbdev);
- return ret;
- }
+ if (ret)
+ gotoerr_drm_client_release;dev_priv->display.fbdev.fbdev = ifbdev; INIT_WORK(&dev_priv->display.fbdev.suspend_work,
intel_fbdev_suspend_worker);return 0;
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0+ +err_drm_client_release: + drm_client_release(&ifbdev->helper.client); +err_drm_fb_helper_unprepare: + drm_fb_helper_unprepare(&ifbdev->helper); + kfree(ifbdev); + return ret; } static void intel_fbdev_initial_config(void *data,
async_cookie_t
cookie)Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Thomas Zimmermann
maintainerPATCH v5 6/7 drm/i915: Implement fbdev client callbacks
In reply to Thomas ZimmermannMove code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display.
The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform the same operation as before, so there's no change in functionality.
--- .../drm/i915/display/intel_display_driver.c | 1 - drivers/gpu/drm/i915/display/intel_fbdev.c | 11 ++++++++-- drivers/gpu/drm/i915/display/intel_fbdev.h | 9 -------- drivers/gpu/drm/i915/i915_driver.c | 22 ------------------- 4 files changed, 9 insertions(+), 34 deletions(-)
drivers/gpu/drm/i915/display/intel_display_driver.c +0 -1
@@ -96,7 +96,6 @@ void intel_display_driver_init_hw(struct drm_i915_private *i915)static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, .get_format_info = intel_fb_get_format_info, - .output_poll_changed = intel_fbdev_output_poll_changed, .mode_valid = intel_mode_valid, .atomic_check = intel_atomic_check, .atomic_commit = intel_atomic_commit,
drivers/gpu/drm/i915/display/intel_fbdev.c +9 -2
@@ -638,7 +638,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronousintel_fbdev_hpd_set_suspend (dev_priv, state); } -void intel_fbdev_output_poll_changed (struct drm_device *dev) +static void intel_fbdev_output_poll_changed (struct drm_device *dev) {struct intel_fbdev *ifbdev =to_i915 (dev)->display.fbdev.fbdev;bool send_hpd;
@@ -657,7 +657,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev)drm_fb_helper_hotplug_event (&ifbdev->helper); } -void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv) +static void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv) {struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev;
@@ -681,11 +681,18 @@ static void intel_fbdev_client_unregister(struct drm_client_dev *client)static int intel_fbdev_client_restore (struct drm_client_dev *client) { +struct drm_i915_private *dev_priv =to_i915 (client->dev); + +intel_fbdev_restore_mode (dev_priv); +vga_switcheroo_process_delayed_switch (); +return 0 ; }static int intel_fbdev_client_hotplug (struct drm_client_dev *client) { +intel_fbdev_output_poll_changed (client->dev); +return 0 ; }
drivers/gpu/drm/i915/display/intel_fbdev.h +0 -9
@@ -19,8 +19,6 @@ void intel_fbdev_initial_config_async(struct drm_i915_private *dev_priv);void intel_fbdev_unregister (struct drm_i915_private *dev_priv);void intel_fbdev_fini (struct drm_i915_private *dev_priv);void intel_fbdev_set_suspend (struct drm_device *dev,int state,bool synchronous); -void intel_fbdev_output_poll_changed (struct drm_device *dev); -void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv);struct intel_framebuffer *intel_fbdev_framebuffer (struct intel_fbdev *fbdev);#else static inline int intel_fbdev_init (struct drm_device *dev)
@@ -44,13 +42,6 @@ static inline void intel_fbdev_set_suspend(struct drm_device *dev, int state, bo { } -static inline void intel_fbdev_output_poll_changed (struct drm_device *dev) -{ -} - -static inline void intel_fbdev_restore_mode (struct drm_i915_private *i915) -{ -}static inline struct intel_framebuffer *intel_fbdev_framebuffer (struct intel_fbdev *fbdev) {return NULL ;
drivers/gpu/drm/i915/i915_driver.c +0 -22
@@ -924,27 +924,6 @@ static int i915_driver_open(struct drm_device *dev, struct drm_file *file)return 0 ; } -/** -* i915_driver_lastclose - clean up after all DRM clients have exited -* @dev: DRM device -* -* Take care of cleaning up after all DRM clients have exited. In the -* mode setting case, we want to restore the kernel's initial mode (just -* in case the last client left us in a bad state). -* -* Additionally, in the non-mode setting case, we'll tear down the GTT -* and DMA structures, since the kernel won't be using them, and clea -* up any GEM state. -*/ -static void i915_driver_lastclose (struct drm_device *dev) -{ -struct drm_i915_private *i915 =to_i915 (dev); - -intel_fbdev_restore_mode (i915); - -vga_switcheroo_process_delayed_switch (); -} -static void i915_driver_postclose (struct drm_device *dev,struct drm_file *file) {struct drm_i915_file_private *file_priv = file->driver_priv;
@@ -1822,7 +1801,6 @@ static const struct drm_driver i915_drm_driver = { DRIVER_SYNCOBJ_TIMELINE, .release = i915_driver_release, .open = i915_driver_open, - .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS), i915_drm_client_fdinfo),
Signature · 1 line
2.42.0
Re: [Intel-gfx] [PATCH v5 6/7] drm/i915: Implement fbdev client callbacks
Hi Thomas, couple of inline commments/suggestions below.
Quoted 41 lines · Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display.
The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform the same operation as before, so there's no change in functionality.
Signed-off-by Thomas Zimmermann <[email protected]>---
.../drm/i915/display/intel_display_driver.c | 1 - drivers/gpu/drm/i915/display/intel_fbdev.c | 11 ++++++++-- drivers/gpu/drm/i915/display/intel_fbdev.h | 9 -------- drivers/gpu/drm/i915/i915_driver.c | 22 ----------------- --4 files changed, 9 insertions(+), 34 deletions(-)drivers/gpu/drm/i915/display/intel_display_driver.c +0
-1@@ -96,7 +96,6 @@ void intel_display_driver_init_hw(struct drm_i915_private *i915) static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, .get_format_info = intel_fb_get_format_info, - .output_poll_changed = intel_fbdev_output_poll_changed, .mode_valid = intel_mode_valid, .atomic_check = intel_atomic_check,.atomic_commit =
intel_atomic_commit,drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -638,7 +638,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous intel_fbdev_hpd_set_suspend(dev_priv, state); }
drivers/gpu/drm/i915/display/intel_fbdev.c void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous · line 641
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1-void intel_fbdev_output_poll_changed (struct drm_device *dev) +static void intel_fbdev_output_poll_changed (struct drm_device *dev)
Now as this isn't drm_mode_config_funcs callback anymore: Maybe you could return error value/0 ?
drivers/gpu/drm/i915/display/intel_fbdev.c
Quoted 11 lines
{
structintel_fbdev*ifbdev = to_i915(dev)-Quoted 1 line
display.fbdev.fbdev;
bool
send_hpd;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -657,7 +657,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev) drm_fb_helper_hotplug_event(&ifbdev->helper); }drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1-void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv) +static void intel_fbdev_restore_mode(struct drm_i915_private
Similar comment as above. I.e. return error value/0 ?
BR,
Jouni Högander
Quoted 109 lines
*dev_priv)
{
structintel_fbdev*ifbdev =dev_priv->display.fbdev.fbdev;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -681,11 +681,18 @@ static void intel_fbdev_client_unregister(struct drm_client_dev *client)
static intintel_fbdev_client_restore(struct drm_client_dev *client){
+ structdrm_i915_private*dev_priv=to_i915(client->dev);drivers/gpu/drm/i915/display/intel_fbdev.c +4
-0+ + intel_fbdev_restore_mode(dev_priv); + vga_switcheroo_process_delayed_switch(); +return 0;
}
static intintel_fbdev_client_hotplug(struct drm_client_dev *client){
+ intel_fbdev_output_poll_changed(client->dev);
+
return 0;
}drivers/gpu/drm/i915/display/intel_fbdev.h +0
-0@@ -19,8 +19,6 @@ void intel_fbdev_initial_config_async(struct drm_i915_private *dev_priv); void intel_fbdev_unregister(struct drm_i915_private *dev_priv); void intel_fbdev_fini(struct drm_i915_private *dev_priv);void
intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous);drivers/gpu/drm/i915/display/intel_fbdev.h +0
-2-void intel_fbdev_output_poll_changed (struct drm_device *dev); -void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv);struct
intel_framebuffer*intel_fbdev_framebuffer(structintel_fbdev*fbdev);
#else
static inline intintel_fbdev_init(struct drm_device *dev)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-0@@ -44,13 +42,6 @@ static inline void intel_fbdev_set_suspend(struct
drm_device*dev, int state, bo
{
}
-static inline voidintel_fbdev_output_poll_changed(struct drm_device *dev)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_restore_mode(struct drm_i915_private*i915)
drivers/gpu/drm/i915/display/intel_fbdev.h +0
-2-{ -}static inline struct
intel_framebuffer*intel_fbdev_framebuffer(structintel_fbdev*fbdev) {
return NULL;drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -924,27 +924,6 @@ static int i915_driver_open(struct drm_device *dev, struct drm_file *file) return 0; }
-/**
- *i915_driver_lastclose- clean up after all DRM clients have exited
- * @dev: DRM device
- *
- * Take care of cleaning up after all DRM clients have exited. In the
- * mode setting case, we want to restore the kernel's initial mode (just
- * in case the last client left us in a bad state).
- *
- * Additionally, in the non-mode setting case, we'll tear down the GTT
- * and DMA structures, since the kernel won't be using them, and clea
- * up any GEM state.
- */drivers/gpu/drm/i915/i915_driver.c +0
-9-static void i915_driver_lastclose (struct drm_device *dev) -{ - struct drm_i915_private *i915 = to_i915(dev); - - intel_fbdev_restore_mode(i915); - - vga_switcheroo_process_delayed_switch(); -} -static void
i915_driver_postclose(struct drm_device *dev, struct drm_file *file)
{
structdrm_i915_file_private*file_priv=file->driver_priv;drivers/gpu/drm/i915/i915_driver.c +0
-1@@ -1822,7 +1801,6 @@ static const struct drm_driver i915_drm_driver = { DRIVER_SYNCOBJ_TIMELINE, .release = i915_driver_release, .open = i915_driver_open, - .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS),
i915_drm_client_fdinfo),
Thomas Zimmermann
maintainerRe: [Intel-gfx] [PATCH v5 6/7] drm/i915: Implement fbdev client callbacks
Hi
Am 25.10.23 um 11:36 schrieb Hogander, Jouni:
Quoted 44 lines
Hi Thomas, couple of inline commments/suggestions below.
Quoted 41 lines · Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display.
The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform the same operation as before, so there's no change in functionality.
Signed-off-by Thomas Zimmermann <[email protected]>--- .../drm/i915/display/intel_display_driver.c | 1 - drivers/gpu/drm/i915/display/intel_fbdev.c | 11 ++++++++-- drivers/gpu/drm/i915/display/intel_fbdev.h | 9 -------- drivers/gpu/drm/i915/i915_driver.c | 22 ----------------- -- 4 files changed, 9 insertions(+), 34 deletions(-)drivers/gpu/drm/i915/display/intel_display_driver.c +0
-1@@ -96,7 +96,6 @@ void intel_display_driver_init_hw(struct drm_i915_private *i915) static const struct drm_mode_config_funcs intel_mode_funcs = { .fb_create = intel_user_framebuffer_create, .get_format_info = intel_fb_get_format_info, - .output_poll_changed = intel_fbdev_output_poll_changed, .mode_valid = intel_mode_valid, .atomic_check = intel_atomic_check,.atomic_commit =
intel_atomic_commit,drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -638,7 +638,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous intel_fbdev_hpd_set_suspend(dev_priv, state); }
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_fbdev.c void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous · line 641
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1-void intel_fbdev_output_poll_changed (struct drm_device *dev) +static void intel_fbdev_output_poll_changed (struct drm_device *dev)Now as this isn't
drm_mode_config_funcscallback anymore: Maybe you could return error value/0 ?
Yes, of course. After i915 has been converted to use drm_client, we can turn all this into consistent error handling across all the various drivers' fbdev emulation.
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0{ struct intel_fbdev *ifbdev = to_i915(dev)-Quoted 1 line
display.fbdev.fbdev;
bool
send_hpd;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -657,7 +657,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev) drm_fb_helper_hotplug_event(&ifbdev->helper); }
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_fbdev.c void intel_fbdev_output_poll_changed(struct · line 661
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1-void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv) +static void intel_fbdev_restore_mode(struct drm_i915_privateSimilar comment as above. I.e. return error value/0 ?
Same here.
Best regards
Thomas
Quoted 115 lines
BR,
Jouni Högander
Quoted 109 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0*dev_priv) {struct
intel_fbdev*ifbdev =dev_priv->display.fbdev.fbdev;drivers/gpu/drm/i915/display/intel_fbdev.c +7
-0@@ -681,11 +681,18 @@ static void intel_fbdev_client_unregister(struct drm_client_dev *client) static int intel_fbdev_client_restore(struct drm_client_dev *client) { + struct drm_i915_private *dev_priv = to_i915(client->dev); + + intel_fbdev_restore_mode(dev_priv); + vga_switcheroo_process_delayed_switch(); + return 0; } static int intel_fbdev_client_hotplug(struct drm_client_dev *client) { + intel_fbdev_output_poll_changed(client->dev); + return 0; }drivers/gpu/drm/i915/display/intel_fbdev.h +0
-2@@ -19,8 +19,6 @@ void intel_fbdev_initial_config_async(struct drm_i915_private *dev_priv); void intel_fbdev_unregister(struct drm_i915_private *dev_priv); void intel_fbdev_fini(struct drm_i915_private *dev_priv); void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous); -void intel_fbdev_output_poll_changed (struct drm_device *dev); -void intel_fbdev_restore_mode (struct drm_i915_private *dev_priv); struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev*fbdev);
#else
static inline intintel_fbdev_init(struct drm_device *dev)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-0@@ -44,13 +42,6 @@ static inline void intel_fbdev_set_suspend(struct
drm_device*dev, int state, bo
{
}-static inline void
intel_fbdev_output_poll_changed(struct drm_device *dev)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_restore_mode(struct drm_i915_private*i915)
drivers/gpu/drm/i915/display/intel_fbdev.h +0
-2-{ -} static inline struct intel_framebuffer*intel_fbdev_framebuffer(struct
intel_fbdev*fbdev)
{
return NULL;drivers/gpu/drm/i915/i915_driver.c +0
-2@@ -924,27 +924,6 @@ static int i915_driver_open(struct drm_device *dev, struct drm_file *file) return 0; } -/** -* i915_driver_lastclose - clean up after all DRM clients have exited
- * @dev: DRM device
- *
- * Take care of cleaning up after all DRM clients have exited. In the
- * mode setting case, we want to restore the kernel's initial mode (just
- * in case the last client left us in a bad state).
- *
- * Additionally, in the non-mode setting case, we'll tear down the GTT
- * and DMA structures, since the kernel won't be using them, and clea
- * up any GEM state.
- */drivers/gpu/drm/i915/i915_driver.c +0
-9-static void i915_driver_lastclose (struct drm_device *dev) -{ - struct drm_i915_private *i915 = to_i915(dev); - - intel_fbdev_restore_mode(i915); - - vga_switcheroo_process_delayed_switch(); -} - static void i915_driver_postclose(struct drm_device *dev, struct
drm_file*file)
{
structdrm_i915_file_private*file_priv=file->driver_priv;drivers/gpu/drm/i915/i915_driver.c +0
-1@@ -1822,7 +1801,6 @@ static const struct drm_driver i915_drm_driver = { DRIVER_SYNCOBJ_TIMELINE, .release = i915_driver_release, .open = i915_driver_open, - .lastclose = i915_driver_lastclose, .postclose = i915_driver_postclose, .show_fdinfo = PTR_IF(IS_ENABLED(CONFIG_PROC_FS),
i915_drm_client_fdinfo),
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Thomas Zimmermann
maintainerPATCH v5 7/7 drm/i915: Implement fbdev emulation as in-kernel client
In reply to Thomas ZimmermannReplace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to i915_fbdev_setup() after i915 has registered its DRM device. Just like similar code in other drivers, i915 fbdev emulation now acts as a regular DRM client.
The fbdev client setup consists of the initial preparation and the hot-plugging of the display. The latter creates the fbdev device and sets up the fbdev framebuffer. The setup performs display hot-plugging once. If no display can be detected, DRM probe helpers re-run the detection on each hotplug event.
A call to drm_dev_unregister() releases the client automatically. No further action is required within i915. If the fbdev framebuffer has been fully set up, struct fb_ops.fb_destroy implements the release. For partially initialized emulation, the fbdev client reverts the initial setup.
v3:
* as before, silently ignore devices without displays
v2:
* let drm_client_register() handle initial hotplug
* fix driver name in error message (Jani)
* fix non-fbdev build (kernel test robot)
--- drivers/gpu/drm/i915/display/intel_display.c | 1 - .../drm/i915/display/intel_display_driver.c | 18 -- drivers/gpu/drm/i915/display/intel_fbdev.c | 180 ++++++++---------- drivers/gpu/drm/i915/display/intel_fbdev.h | 20 +- drivers/gpu/drm/i915/i915_driver.c | 2 + 5 files changed, 83 insertions(+), 138 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -1
@@ -81,7 +81,6 @@#include "intel_dvo.h" #include "intel_fb.h" #include "intel_fbc.h" -#include "intel_fbdev.h" #include "intel_fdi.h" #include "intel_fifo_underrun.h" #include "intel_frontbuffer.h"
drivers/gpu/drm/i915/display/intel_display_driver.c +0 -18
@@ -364,10 +364,6 @@ int intel_display_driver_probe(struct drm_i915_private *i915)intel_overlay_setup (i915); - ret =intel_fbdev_init (&i915->drm); -if (ret) -return ret; -/* Only enable hotplug handling once the fbdev is fully set up. */ intel_hpd_init (i915);intel_hpd_poll_disable (i915);
@@ -392,16 +388,6 @@ void intel_display_driver_register(struct drm_i915_private *i915)intel_display_debugfs_register (i915); -/* -* Some ports require correctly set-up hpd registers for -* detection to work properly (leading to ghost connected -* connector status), e.g. VGA on gm45. Hence we can only set -* up the initial fbdev config after hpd irqs are fully -* enabled. We do it last so that the async config cannot run -* before the connectors are registered. -*/ -intel_fbdev_initial_config_async (i915); -/* * We need to coordinate the hotplugs with the asynchronous * fbdev configuration, for which we use the
@@ -445,9 +431,6 @@ void intel_display_driver_remove_noirq(struct drm_i915_private *i915)*/ intel_hpd_poll_fini (i915); -/* poll work can call into fbdev, hence clean that up afterwards */ -intel_fbdev_fini (i915); -intel_unregister_dsm_handler ();/* flush any delayed tasks or pending work */
@@ -484,7 +467,6 @@ void intel_display_driver_unregister(struct drm_i915_private *i915)if (!HAS_DISPLAY (i915))return ; -intel_fbdev_unregister (i915);intel_audio_deinit (i915);/*
drivers/gpu/drm/i915/display/intel_fbdev.c +79 -101
288 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_fbdev.h +2 -18
@@ -14,27 +14,11 @@ struct intel_fbdev;struct intel_framebuffer ;#ifdef CONFIG_DRM_FBDEV_EMULATION -int intel_fbdev_init (struct drm_device *dev); -void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv); -void intel_fbdev_unregister (struct drm_i915_private *dev_priv); -void intel_fbdev_fini (struct drm_i915_private *dev_priv); +void intel_fbdev_setup (struct drm_i915_private *dev_priv);void intel_fbdev_set_suspend (struct drm_device *dev,int state,bool synchronous);struct intel_framebuffer *intel_fbdev_framebuffer (struct intel_fbdev *fbdev);#else -static inline int intel_fbdev_init (struct drm_device *dev) -{ -return 0 ; -} - -static inline void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) -{ -} - -static inline void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ -} - -static inline void intel_fbdev_fini (struct drm_i915_private *dev_priv) +static inline void intel_fbdev_setup (struct drm_i915_private *dev_priv) { }
drivers/gpu/drm/i915/i915_driver.c +2 -0
@@ -817,6 +817,8 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent) i915->do_release = true; +intel_fbdev_setup (i915); +return 0 ; out_cleanup_gem:
Signature · 1 line
2.42.0
Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client
Hi Thomas, couple of minor comments and a question below.
Quoted 3 lines · Thomas Zimmermann
Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to
i915_fbdev_setup()after i915 has registered its
intel_fbdev_setup
Quoted 301 lines
DRM device. Just like similar code in other drivers, i915 fbdev emulation now acts as a regular DRM client.
The fbdev client setup consists of the initial preparation and the hot-plugging of the display. The latter creates the fbdev device and sets up the fbdev framebuffer. The setup performs display hot-plugging once. If no display can be detected, DRM probe helpers re-run the detection on each hotplug event.
A call to
drm_dev_unregister()releases the client automatically. No further action is required within i915. If the fbdev framebuffer has been fully set up, struct fb_ops.fb_destroy implements the release. For partially initialized emulation, the fbdev client reverts the initial setup.v3:
* as before, silently ignore devices without displays v2:
* letdrm_client_register()handle initial hotplug
* fix driver name in error message (Jani)
* fix non-fbdev build (kernel test robot)Signed-off-by Thomas Zimmermann <[email protected]>---
drivers/gpu/drm/i915/display/intel_display.c | 1 - .../drm/i915/display/intel_display_driver.c | 18 -- drivers/gpu/drm/i915/display/intel_fbdev.c | 180 ++++++++-------- --
drivers/gpu/drm/i915/display/intel_fbdev.h | 20 +- drivers/gpu/drm/i915/i915_driver.c | 2 +5 files changed, 83 insertions(+), 138 deletions(-)drivers/gpu/drm/i915/display/intel_display.c +0
-1@@ -81,7 +81,6 @@ #include "intel_dvo.h" #include "intel_fb.h" #include "intel_fbc.h" -#include "intel_fbdev.h" #include "intel_fdi.h" #include "intel_fifo_underrun.h" #include "intel_frontbuffer.h"drivers/gpu/drm/i915/display/intel_display_driver.c +0
-0@@ -364,10 +364,6 @@ int intel_display_driver_probe(struct drm_i915_private *i915)
intel_overlay_setup(i915);
- ret =intel_fbdev_init(&i915->drm);
- if (ret)
- return ret;
-
/* Only enable hotplug handling once the fbdev is fully set up. */
intel_hpd_init(i915);intel_hpd_poll_disable(i915);drivers/gpu/drm/i915/display/intel_display_driver.c +0
-0@@ -392,16 +388,6 @@ void intel_display_driver_register(struct drm_i915_private *i915)
intel_display_debugfs_register(i915);
- /*
- * Some ports require correctly set-up hpd registers for - * detection to work properly (leading to ghost connected - * connector status), e.g. VGA on gm45. Hence we can only set
- * up the initial fbdev config after hpd irqs are fully - * enabled. We do it last so that the async config cannot run - * before the connectors are registered.
- */
- intel_fbdev_initial_config_async(i915);
-
/*
* We need to coordinate the hotplugs with the asynchronous
* fbdev configuration, for which we use thedrivers/gpu/drm/i915/display/intel_display_driver.c +0
-0@@ -445,9 +431,6 @@ void intel_display_driver_remove_noirq(structdrm_i915_private *i915) */ intel_hpd_poll_fini(i915);
- /* poll work can call into fbdev, hence clean that up afterwards */
- intel_fbdev_fini(i915);
-
intel_unregister_dsm_handler();
/* flush any delayed tasks or pending work */drivers/gpu/drm/i915/display/intel_display_driver.c +0
-0@@ -484,7 +467,6 @@ void intel_display_driver_unregister(struct drm_i915_private *i915) if (!HAS_DISPLAY(i915)) return;
- intel_fbdev_unregister(i915);
intel_audio_deinit(i915);
/*drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -24,7 +24,6 @@* David Airlie */
-#include <linux/async.h>
#include <linux/console.h>
#include <linux/delay.h>
#include <linux/errno.h>drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -39,6 +38,7 @@ #include <linux/vga_switcheroo.h>
#include <drm/drm_crtc.h>
+#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_helper.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem_framebuffer_helper.h>drivers/gpu/drm/i915/display/intel_fbdev.c +0
-1@@ -58,7 +58,6 @@ struct intel_fbdev { struct intel_framebuffer *fb; struct i915_vma *vma; unsigned long vma_flags; - async_cookie_t cookie; int preferred_bpp;
/* Whether or not fbdev hpd processing is temporarily suspended */drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -135,6 +134,26 @@ static int intel_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma) return i915_gem_fb_mmap(obj, vma); }drivers/gpu/drm/i915/display/intel_fbdev.c +4
-0+static void intel_fbdev_fb_destroy (struct fb_info *info) +{ + struct drm_fb_helper *fb_helper = info->par; + struct intel_fbdev *ifbdev = container_of(fb_helper, struct
intel_fbdev, helper);drivers/gpu/drm/i915/display/intel_fbdev.c +6
-0+ + drm_fb_helper_fini(&ifbdev->helper); + + /* +* We rely on the object-free to release the VMA pinning for +* the info->screen_base mmaping. Leaking the VMA is simpler than
+ * trying to rectify all the possible error paths leading here.
+ */
+ intel_unpin_fb_vma(ifbdev->vma,ifbdev->vma_flags); + drm_framebuffer_remove(&ifbdev->fb->base);drivers/gpu/drm/i915/display/intel_fbdev.c +6
-0+ + drm_client_release(&fb_helper->client); + drm_fb_helper_unprepare(&ifbdev->helper); + kfree(ifbdev); +} +static const struct
fb_opsintelfb_ops= { .owner =THIS_MODULE,__FB_DEFAULT_DEFERRED_OPS_RDWR(intel_fbdev),drivers/gpu/drm/i915/display/intel_fbdev.c +1
-0@@ -144,6 +163,7 @@ static const struct fb_ops intelfb_ops = { .fb_pan_display = intel_fbdev_pan_display, __FB_DEFAULT_DEFERRED_OPS_DRAW(intel_fbdev), .fb_mmap = intel_fbdev_mmap, + .fb_destroy = intel_fbdev_fb_destroy, };
static int intelfb_alloc(structdrm_fb_helper*helper,drivers/gpu/drm/i915/display/intel_fbdev.c +0
-1@@ -212,7 +232,6 @@ static int intelfb_create(struct drm_fb_helper *helper, struct intel_framebuffer *intel_fb = ifbdev->fb; struct drm_device *dev = helper->dev; struct drm_i915_private *dev_priv = to_i915(dev); - struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev); struct i915_ggtt *ggtt = to_gt(dev_priv)->ggtt; const struct i915_gtt_view view = {.type =
I915_GTT_VIEW_NORMAL,drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -337,7 +356,7 @@ static int intelfb_create(struct drm_fb_helper *helper, ifbdev->vma_flags = flags;
intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref); - vga_switcheroo_client_fb_set(pdev, info);
+
return 0;
out_unpin:drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -363,26 +382,6 @@ static const struct drm_fb_helper_funcs intel_fb_helper_funcs = { .fb_dirty = intelfb_dirty, };drivers/gpu/drm/i915/display/intel_fbdev.c +0
-4-static void intel_fbdev_destroy (struct intel_fbdev *ifbdev) -{ - /* We rely on the object-free to release the VMA pinning for -* the info->screen_base mmaping. Leaking the VMA is simpler than
- * trying to rectify all the possible error paths leading here.
- */drivers/gpu/drm/i915/display/intel_fbdev.c +0
-14- - drm_fb_helper_fini(&ifbdev->helper); - - if (ifbdev->vma) - intel_unpin_fb_vma(ifbdev->vma, ifbdev->vma_flags); - - if (ifbdev->fb) - drm_framebuffer_remove(&ifbdev->fb->base); - - drm_client_release(&ifbdev->helper.client); - drm_fb_helper_unprepare(&ifbdev->helper); - kfree(ifbdev); -} -/*
* Build anintel_fbdevstruct using a BIOS allocated framebuffer, if possible.
* The core display code will have read out the current plane configuration,drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -546,16 +545,6 @@ static void intel_fbdev_suspend_worker(struct work_struct *work) true); }drivers/gpu/drm/i915/display/intel_fbdev.c +0
-6-static void intel_fbdev_sync (struct intel_fbdev *ifbdev) -{ - if (!ifbdev->cookie) - return; - - /* Only serialises with all preceding async calls, hence +1*/
- async_synchronize_cookie(ifbdev->cookie + 1); - ifbdev->cookie = 0;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-2-} -/* Suspends/resumes fbdev processing of incoming HPD events. When resuming HPD
* processing, fbdev will perform a full connector reprobe if a hotplug event
* was received while HPD was suspended.drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -646,8 +635,6 @@ static void intel_fbdev_output_poll_changed(struct drm_device *dev) if (!ifbdev) return;
- intel_fbdev_sync(ifbdev);
-
mutex_lock(&ifbdev->hpd_lock);
send_hpd = !ifbdev->hpd_suspended;
ifbdev->hpd_waiting = true;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -664,7 +651,6 @@ static void intel_fbdev_restore_mode(struct drm_i915_private *dev_priv) if (!ifbdev) return;
- intel_fbdev_sync(ifbdev);
if (!ifbdev->vma)
return;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -677,7 +663,20 @@ static void intel_fbdev_restore_mode(structdrm_i915_private *dev_priv) */
static voidintel_fbdev_client_unregister(struct drm_client_dev *client)drivers/gpu/drm/i915/display/intel_fbdev.c +2
-1-{ } +{ + struct drm_fb_helper *fb_helper =
drm_fb_helper_from_client(client);
+ structdrm_device*dev =fb_helper->dev; + structpci_dev*pdev =to_pci_dev(dev->dev);drivers/gpu/drm/i915/display/intel_fbdev.c +10
-0+ + if (fb_helper->info) { + vga_switcheroo_client_fb_set(pdev, NULL); + drm_fb_helper_unregister_info(fb_helper); + } else { + drm_fb_helper_unprepare(fb_helper); + drm_client_release(&fb_helper->client); + kfree(fb_helper); + } +}
static intintel_fbdev_client_restore(struct drm_client_dev *client){drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -691,9 +690,36 @@ static int intel_fbdev_client_restore(struct drm_client_dev *client)
static intintel_fbdev_client_hotplug(struct drm_client_dev *client){
- intel_fbdev_output_poll_changed(client->dev);
+ structdrm_fb_helper*fb_helper=drm_fb_helper_from_client(client);
+ structdrm_device*dev =client->dev;
+ structpci_dev*pdev =to_pci_dev(dev->dev);
+ int ret;drivers/gpu/drm/i915/display/intel_fbdev.c +2
-0+ + if (dev->fb_helper) {
drivers/gpu/drm/i915/display/intel_fbdev.c static int intel_fbdev_client_restore(struct drm_client_dev *client) · line 708
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +10
-0+ intel_fbdev_output_poll_changed(dev); + return 0; + } + + ret = drm_fb_helper_init(dev, fb_helper); + if (ret) + goto err_drm_err; + + if (!drm_drv_uses_atomic_modeset(dev)) + drm_helper_disable_unused_functions(dev);
Can you please explain why this is needed here?
Quoted 23 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +6
-0+ + ret = drm_fb_helper_initial_config(fb_helper); + if (ret) + goto err_drm_fb_helper_fini; + + vga_switcheroo_client_fb_set(pdev, fb_helper->info);
return 0;drivers/gpu/drm/i915/display/intel_fbdev.c +5
-0+ +err_drm_fb_helper_fini: + drm_fb_helper_fini(fb_helper); +err_drm_err: + drm_err(dev, "Failed to setup i915 fbdev emulation(ret=%d)\n", ret);
+ return ret;
}
static const structdrm_client_funcsintel_fbdev_client_funcs= {drivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -703,22 +729,23 @@ static const struct drm_client_funcs intel_fbdev_client_funcs = { .hotplug = intel_fbdev_client_hotplug, };
drivers/gpu/drm/i915/display/intel_fbdev.c static const struct drm_client_funcs intel_fbdev_client_funcs = { · line 732
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1-int intel_fbdev_init (struct drm_device *dev) +void intel_fbdev_setup (struct drm_i915_private *dev_priv)
Use i915 rather than dev_priv.
BR,
Jouni Högander
Quoted 168 lines
{
- structdrm_i915_private*dev_priv=to_i915(dev); + structdrm_device*dev =&dev_priv->drm;
structintel_fbdev*ifbdev;
int ret;
- if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv)))
- return-ENODEV;
+ if (!HAS_DISPLAY(dev_priv))
+ return;
ifbdev =kzalloc(sizeof(*ifbdev), GFP_KERNEL);
if (!ifbdev)
- return-ENOMEM;
-
- mutex_init(&ifbdev->hpd_lock);
+ return;
drm_fb_helper_prepare(dev,&ifbdev->helper, 32,&intel_fb_helper_funcs);
+ dev_priv->display.fbdev.fbdev = ifbdev;
+ INIT_WORK(&dev_priv->display.fbdev.suspend_work,intel_fbdev_suspend_worker);
+ mutex_init(&ifbdev->hpd_lock);
if (intel_fbdev_init_bios(dev, ifbdev))ifbdev->helper.preferred_bpp=ifbdev->preferred_bpp; elsedrivers/gpu/drm/i915/display/intel_fbdev.c +0
-0@@ -726,68 +753,19 @@ int intel_fbdev_init(struct drm_device *dev)
ret = drm_client_init(dev,&ifbdev->helper.client, "i915- fbdev",
&intel_fbdev_client_funcs); - if (ret)
+ if (ret) {
+ drm_err(dev, "Failed to register client: %d\n", ret); gotoerr_drm_fb_helper_unprepare;
+ }
- ret =drm_fb_helper_init(dev, &ifbdev->helper);
- if (ret)
- gotoerr_drm_client_release;
-
- dev_priv->display.fbdev.fbdev = ifbdev;
- INIT_WORK(&dev_priv->display.fbdev.suspend_work,intel_fbdev_suspend_worker);
+ drm_client_register(&ifbdev->helper.client);
- return 0;
+ return;
-err_drm_client_release:
- drm_client_release(&ifbdev->helper.client);err_drm_fb_helper_unprepare:
drm_fb_helper_unprepare(&ifbdev->helper);
+ mutex_destroy(&ifbdev->hpd_lock);
kfree(ifbdev);
- return ret;drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -static void intel_fbdev_initial_config(void *data, async_cookie_tcookie)
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-4-{ - struct intel_fbdev *ifbdev = data; - - /* Due to peculiar init order wrt to hpd handling this isseparate. */
- if (drm_fb_helper_initial_config(&ifbdev->helper)) - intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7-{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10-} - -void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10- - if (!current_is_async()) - intel_fbdev_sync(ifbdev); - - drm_fb_helper_unregister_info(&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-5- - if (!ifbdev) - return; - - intel_fbdev_destroy(ifbdev);}
structintel_framebuffer*intel_fbdev_framebuffer(structintel_fbdev*fbdev)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-0@@ -14,27 +14,11 @@ struct intel_fbdev; struct intel_framebuffer;
#ifdefCONFIG_DRM_FBDEV_EMULATIONdrivers/gpu/drm/i915/display/intel_fbdev.h +0
-2-int intel_fbdev_init (struct drm_device *dev); -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv);drivers/gpu/drm/i915/display/intel_fbdev.h +1
-2-void intel_fbdev_unregister (struct drm_i915_private *dev_priv); -void intel_fbdev_fini (struct drm_i915_private *dev_priv); +void intel_fbdev_setup (struct drm_i915_private *dev_priv);void
intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous);
structintel_framebuffer*intel_fbdev_framebuffer(structintel_fbdev*fbdev);
#elsedrivers/gpu/drm/i915/display/intel_fbdev.h +0
-6-static inline int intel_fbdev_init (struct drm_device *dev) -{ - return 0; -} - -static inline void intel_fbdev_initial_config_async(struct
drm_i915_private*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_unregister(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_fini(struct drm_i915_private
*dev_priv)
+static inline voidintel_fbdev_setup(struct drm_i915_private *dev_priv)
{
}drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -817,6 +817,8 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
i915->do_release = true;
+ intel_fbdev_setup(i915);
+
return 0;
out_cleanup_gem:
Thomas Zimmermann
maintainerRe: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client
Hi
Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
[...]
Quoted 5 lines
Quoted 3 lines
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ drm_helper_disable_unused_functions(dev);Can you please explain why this is needed here?
This disables some parts of the mode-setting pipeline and is required for drivers with non-atomic commits. AFAICT atomic mode setting is not supported on some very old Intel chips. [1] I'll leave a short comment on the code.
[1] https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/i915/intel_device_info.c#L399
Best regard
Thomas
Quoted 202 lines
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +11
-0+ + ret = drm_fb_helper_initial_config(fb_helper); + if (ret) + goto err_drm_fb_helper_fini; + + vga_switcheroo_client_fb_set(pdev, fb_helper->info); return 0; + +err_drm_fb_helper_fini: + drm_fb_helper_fini(fb_helper); +err_drm_err: + drm_err(dev, "Failed to setup i915 fbdev emulation(ret=%d)\n", ret);
+ return ret;
}static const struct
drm_client_funcsintel_fbdev_client_funcs= {drivers/gpu/drm/i915/display/intel_fbdev.c static const struct drm_client_funcs · line 733
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1@@ -703,22 +729,23 @@ static const struct drm_client_funcs intel_fbdev_client_funcs = { .hotplug = intel_fbdev_client_hotplug, }; -int intel_fbdev_init (struct drm_device *dev) +void intel_fbdev_setup (struct drm_i915_private *dev_priv)Use i915 rather than
dev_priv.BR,
Jouni Högander
Quoted 168 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-6{ - struct drm_i915_private *dev_priv = to_i915(dev); + struct drm_device *dev = &dev_priv->drm; struct intel_fbdev *ifbdev; int ret; - if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv))) - return -ENODEV; + if (!HAS_DISPLAY(dev_priv)) + return; ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); if (!ifbdev) - return -ENOMEM; - - mutex_init(&ifbdev->hpd_lock); + return; drm_fb_helper_prepare(dev, &ifbdev->helper, 32, &intel_fb_helper_funcs); + dev_priv->display.fbdev.fbdev = ifbdev; + INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + mutex_init(&ifbdev->hpd_lock);if (
intel_fbdev_init_bios(dev, ifbdev))ifbdev->helper.preferred_bpp=ifbdev->preferred_bpp; elsedrivers/gpu/drm/i915/display/intel_fbdev.c +6
-18@@ -726,68 +753,19 @@ int intel_fbdev_init(struct drm_device *dev) ret = drm_client_init(dev, &ifbdev->helper.client, "i915- fbdev", &intel_fbdev_client_funcs); - if (ret) + if (ret) { + drm_err(dev, "Failed to register client: %d\n", ret); goto err_drm_fb_helper_unprepare; + } - ret = drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) - goto err_drm_client_release; - - dev_priv->display.fbdev.fbdev = ifbdev; - INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + drm_client_register(&ifbdev->helper.client); - return 0; + return; -err_drm_client_release: - drm_client_release(&ifbdev->helper.client); err_drm_fb_helper_unprepare: drm_fb_helper_unprepare(&ifbdev->helper); + mutex_destroy(&ifbdev->hpd_lock); kfree(ifbdev); - return ret; -} - -static void intel_fbdev_initial_config (void *data,async_cookie_t cookie) -{ - struct intel_fbdev *ifbdev = data; - - /* Due to peculiar init order wrt to hpd handling this isseparate. */
- if (drm_fb_helper_initial_config(&ifbdev->helper)) - intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7-{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10-} - -void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10- - if (!current_is_async()) - intel_fbdev_sync(ifbdev); - - drm_fb_helper_unregister_info(&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-5- - if (!ifbdev) - return; - - intel_fbdev_destroy(ifbdev); } struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev*fbdev)
drivers/gpu/drm/i915/display/intel_fbdev.h +1
-14@@ -14,27 +14,11 @@ struct intel_fbdev; struct intel_framebuffer; #ifdef CONFIG_DRM_FBDEV_EMULATION -int intel_fbdev_init (struct drm_device *dev); -void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv); -void intel_fbdev_unregister (struct drm_i915_private *dev_priv); -void intel_fbdev_fini (struct drm_i915_private *dev_priv); +void intel_fbdev_setup (struct drm_i915_private *dev_priv); void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous); struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev *fbdev); #else -static inline int intel_fbdev_init (struct drm_device *dev) -{ - return 0; -} - -static inline void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) -{ -} - -static inline void intel_fbdev_unregister(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_fini(struct drm_i915_private
*dev_priv)
+static inline voidintel_fbdev_setup(struct drm_i915_private *dev_priv)
{
}drivers/gpu/drm/i915/i915_driver.c +2
-0@@ -817,6 +817,8 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent) i915->do_release = true; + intel_fbdev_setup(i915); + return 0;out_cleanup_gem:
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Re: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client
Quoted 8 lines · Thomas Zimmermann
Hi
Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
[...]Quoted 4 lines
Quoted 3 lines
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ drm_helper_disable_unused_functions(dev);
Quoted 6 lines
Quoted 1 line
Can you please explain why this is needed here?
This disables some parts of the mode-setting pipeline and is required for drivers with non-atomic commits. AFAICT atomic mode setting is not supported on some very old Intel chips. [1] I'll leave a short comment on the code.
We don't expose the atomic uapi because the watermark code is kinda sketchy for the old chips, but internally i915 is 100% atomic.
Quoted 217 lines
[1]
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/i915/intel_device_info.c#L399Best regard
ThomasQuoted 202 lines
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +11
-0+ + ret = drm_fb_helper_initial_config(fb_helper); + if (ret) + goto err_drm_fb_helper_fini; + + vga_switcheroo_client_fb_set(pdev, fb_helper->info); return 0; + +err_drm_fb_helper_fini: + drm_fb_helper_fini(fb_helper); +err_drm_err: + drm_err(dev, "Failed to setup i915 fbdev emulation(ret=%d)\n", ret);
+ return ret;
}static const struct
drm_client_funcsintel_fbdev_client_funcs= {drivers/gpu/drm/i915/display/intel_fbdev.c static const struct drm_client_funcs · line 733
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1@@ -703,22 +729,23 @@ static const struct drm_client_funcs intel_fbdev_client_funcs = { .hotplug = intel_fbdev_client_hotplug, }; -int intel_fbdev_init (struct drm_device *dev) +void intel_fbdev_setup (struct drm_i915_private *dev_priv)Use i915 rather than
dev_priv.BR,
Jouni Högander
Quoted 168 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-6{ - struct drm_i915_private *dev_priv = to_i915(dev); + struct drm_device *dev = &dev_priv->drm; struct intel_fbdev *ifbdev; int ret; - if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv))) - return -ENODEV; + if (!HAS_DISPLAY(dev_priv)) + return; ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); if (!ifbdev) - return -ENOMEM; - - mutex_init(&ifbdev->hpd_lock); + return; drm_fb_helper_prepare(dev, &ifbdev->helper, 32, &intel_fb_helper_funcs); + dev_priv->display.fbdev.fbdev = ifbdev; + INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + mutex_init(&ifbdev->hpd_lock);if (
intel_fbdev_init_bios(dev, ifbdev))ifbdev->helper.preferred_bpp=ifbdev->preferred_bpp; elsedrivers/gpu/drm/i915/display/intel_fbdev.c +6
-18@@ -726,68 +753,19 @@ int intel_fbdev_init(struct drm_device *dev) ret = drm_client_init(dev, &ifbdev->helper.client, "i915- fbdev", &intel_fbdev_client_funcs); - if (ret) + if (ret) { + drm_err(dev, "Failed to register client: %d\n", ret); goto err_drm_fb_helper_unprepare; + } - ret = drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) - goto err_drm_client_release; - - dev_priv->display.fbdev.fbdev = ifbdev; - INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + drm_client_register(&ifbdev->helper.client); - return 0; + return; -err_drm_client_release: - drm_client_release(&ifbdev->helper.client); err_drm_fb_helper_unprepare: drm_fb_helper_unprepare(&ifbdev->helper); + mutex_destroy(&ifbdev->hpd_lock); kfree(ifbdev); - return ret; -} - -static void intel_fbdev_initial_config (void *data,async_cookie_t cookie) -{ - struct intel_fbdev *ifbdev = data; - - /* Due to peculiar init order wrt to hpd handling this isseparate. */
- if (drm_fb_helper_initial_config(&ifbdev->helper)) - intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7-{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10-} - -void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10- - if (!current_is_async()) - intel_fbdev_sync(ifbdev); - - drm_fb_helper_unregister_info(&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-5- - if (!ifbdev) - return; - - intel_fbdev_destroy(ifbdev); } struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev*fbdev)
drivers/gpu/drm/i915/display/intel_fbdev.h +1
-14@@ -14,27 +14,11 @@ struct intel_fbdev; struct intel_framebuffer; #ifdef CONFIG_DRM_FBDEV_EMULATION -int intel_fbdev_init (struct drm_device *dev); -void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv); -void intel_fbdev_unregister (struct drm_i915_private *dev_priv); -void intel_fbdev_fini (struct drm_i915_private *dev_priv); +void intel_fbdev_setup (struct drm_i915_private *dev_priv); void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous); struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev *fbdev); #else -static inline int intel_fbdev_init (struct drm_device *dev) -{ - return 0; -} - -static inline void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) -{ -} - -static inline void intel_fbdev_unregister(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_fini(struct drm_i915_private
*dev_priv)
+static inline voidintel_fbdev_setup(struct drm_i915_private *dev_priv)
{
}drivers/gpu/drm/i915/i915_driver.c +2
-0@@ -817,6 +817,8 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent) i915->do_release = true; + intel_fbdev_setup(i915); + return 0;out_cleanup_gem:
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Signature · 2 lines
Ville Syrjälä Intel
Thomas Zimmermann
maintainerRe: [PATCH v5 7/7] drm/i915: Implement fbdev emulation as in-kernel client
Hi
Am 01.11.23 um 10:25 schrieb Ville Syrjälä:
Quoted 11 lines · Thomas Zimmermann
Quoted 10 lines
Hi
Am 25.10.23 um 13:36 schrieb Hogander, Jouni:
[...]Quoted 5 lines
Quoted 3 lines
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ drm_helper_disable_unused_functions(dev);Can you please explain why this is needed here?
Quoted 7 lines
Quoted 4 lines
This disables some parts of the mode-setting pipeline and is required for drivers with non-atomic commits. AFAICT atomic mode setting is not supported on some very old Intel chips. [1] I'll leave a short comment on the code.
We don't expose the atomic uapi because the watermark code is kinda sketchy for the old chips, but internally i915 is 100% atomic.
Great, thanks. I'll drop that code then.
Best regards
Thomas
Quoted 222 lines
Quoted 218 lines
[1]
https://elixir.bootlin.com/linux/v6.6/source/drivers/gpu/drm/i915/intel_device_info.c#L399Best regard
ThomasQuoted 202 lines
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +11
-0+ + ret = drm_fb_helper_initial_config(fb_helper); + if (ret) + goto err_drm_fb_helper_fini; + + vga_switcheroo_client_fb_set(pdev, fb_helper->info); return 0; + +err_drm_fb_helper_fini: + drm_fb_helper_fini(fb_helper); +err_drm_err: + drm_err(dev, "Failed to setup i915 fbdev emulation(ret=%d)\n", ret);
+ return ret;
}static const struct drm_client_funcs intel_fbdev_client_funcs = {drivers/gpu/drm/i915/display/intel_fbdev.c static const struct drm_client_funcs · line 733
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1@@ -703,22 +729,23 @@ static const struct drm_client_funcs intel_fbdev_client_funcs = { .hotplug = intel_fbdev_client_hotplug, }; -int intel_fbdev_init (struct drm_device *dev) +void intel_fbdev_setup (struct drm_i915_private *dev_priv)Use i915 rather than
dev_priv.BR,
Jouni Högander
Quoted 168 lines
drivers/gpu/drm/i915/display/intel_fbdev.c +7
-6{ - struct drm_i915_private *dev_priv = to_i915(dev); + struct drm_device *dev = &dev_priv->drm; struct intel_fbdev *ifbdev; int ret; - if (drm_WARN_ON(dev, !HAS_DISPLAY(dev_priv))) - return -ENODEV; + if (!HAS_DISPLAY(dev_priv)) + return; ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); if (!ifbdev) - return -ENOMEM; - - mutex_init(&ifbdev->hpd_lock); + return; drm_fb_helper_prepare(dev, &ifbdev->helper, 32, &intel_fb_helper_funcs); + dev_priv->display.fbdev.fbdev = ifbdev; + INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + mutex_init(&ifbdev->hpd_lock);if (intel_fbdev_init_bios(dev, ifbdev)) ifbdev->helper.preferred_bpp = ifbdev->preferred_bpp; elsedrivers/gpu/drm/i915/display/intel_fbdev.c +6
-18@@ -726,68 +753,19 @@ int intel_fbdev_init(struct drm_device *dev) ret = drm_client_init(dev, &ifbdev->helper.client, "i915- fbdev", &intel_fbdev_client_funcs); - if (ret) + if (ret) { + drm_err(dev, "Failed to register client: %d\n", ret); goto err_drm_fb_helper_unprepare; + } - ret = drm_fb_helper_init(dev, &ifbdev->helper); - if (ret) - goto err_drm_client_release; - - dev_priv->display.fbdev.fbdev = ifbdev; - INIT_WORK(&dev_priv->display.fbdev.suspend_work, intel_fbdev_suspend_worker); + drm_client_register(&ifbdev->helper.client); - return 0; + return; -err_drm_client_release: - drm_client_release(&ifbdev->helper.client); err_drm_fb_helper_unprepare: drm_fb_helper_unprepare(&ifbdev->helper); + mutex_destroy(&ifbdev->hpd_lock); kfree(ifbdev); - return ret; -} - -static void intel_fbdev_initial_config (void *data,async_cookie_t cookie) -{ - struct intel_fbdev *ifbdev = data; - - /* Due to peculiar init order wrt to hpd handling this isseparate. */
- if (drm_fb_helper_initial_config(&ifbdev->helper)) - intel_fbdev_unregister(to_i915(ifbdev->helper.dev));drivers/gpu/drm/i915/display/intel_fbdev.c +0
-3-} - -void intel_fbdev_initial_config_async(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.c +0
-7-{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - ifbdev->cookie = async_schedule(intel_fbdev_initial_config,ifbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10-} - -void intel_fbdev_unregister (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = dev_priv->display.fbdev.fbdev; - - if (!ifbdev) - return; - - intel_fbdev_set_suspend(&dev_priv->drm,
FBINFO_STATE_SUSPENDED, true);drivers/gpu/drm/i915/display/intel_fbdev.c +0
-10- - if (!current_is_async()) - intel_fbdev_sync(ifbdev); - - drm_fb_helper_unregister_info(&ifbdev->helper); -} - -void intel_fbdev_fini (struct drm_i915_private *dev_priv) -{ - struct intel_fbdev *ifbdev = fetch_and_zero(&dev_priv-Quoted 1 line
display.fbdev.fbdev);
drivers/gpu/drm/i915/display/intel_fbdev.c +0
-5- - if (!ifbdev) - return; - - intel_fbdev_destroy(ifbdev); } struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev*fbdev)
drivers/gpu/drm/i915/display/intel_fbdev.h +1
-14@@ -14,27 +14,11 @@ struct intel_fbdev; struct intel_framebuffer; #ifdef CONFIG_DRM_FBDEV_EMULATION -int intel_fbdev_init (struct drm_device *dev); -void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv); -void intel_fbdev_unregister (struct drm_i915_private *dev_priv); -void intel_fbdev_fini (struct drm_i915_private *dev_priv); +void intel_fbdev_setup (struct drm_i915_private *dev_priv); void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous); struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev *fbdev); #else -static inline int intel_fbdev_init (struct drm_device *dev) -{ - return 0; -} - -static inline void intel_fbdev_initial_config_async (struct drm_i915_private *dev_priv) -{ -} - -static inline void intel_fbdev_unregister(struct drm_i915_private
*dev_priv)drivers/gpu/drm/i915/display/intel_fbdev.h +0
-4-{ -} - -static inline void intel_fbdev_fini(struct drm_i915_private
*dev_priv)
+static inline voidintel_fbdev_setup(struct drm_i915_private *dev_priv)
{
}drivers/gpu/drm/i915/i915_driver.c +2
-0@@ -817,6 +817,8 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent) i915->do_release = true; + intel_fbdev_setup(i915); + return 0;out_cleanup_gem:
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Convert fbdev to DRM client (rev5)
In reply to Thomas Zimmermann== Series Details ==
== Series Details ==
Series: drm/i915: Convert fbdev to DRM client (rev5)
URL : https://patchwork.freedesktop.org/series/115714/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:148:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:150:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:154:26: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:156:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:174:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:176:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:180:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:182:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:186:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:188:9: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:192:35: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:16: warning: unreplaced symbol 'oldbit' +./arch/x86/include/asm/bitops.h:195:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:237:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:239:9: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return' +./arch/x86/include/asm/bitops.h:92:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:100:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:100:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:105:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:107:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:108:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:109:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:111:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:111:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:112:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:112:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:121:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:128:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:166:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:168:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:169:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:170:9: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:19: warning: unreplaced symbol 'val' +./include/asm-generic/bitops/generic-non-atomic.h:172:25: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:172:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:28:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:31:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:33:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:37:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:39:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:40:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:42:16: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:55:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:57:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:58:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:60:15: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:73:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:75:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:76:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:77:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:79:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:79:20: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:17: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:80:23: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:80:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:93:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/generic-non-atomic.h:95:9: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/generic-non-atomic.h:96:9: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:97:9: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:10: warning: unreplaced symbol 'p' +./include/asm-generic/bitops/generic-non-atomic.h:99:14: warning: unreplaced symbol 'old' +./include/asm-generic/bitops/generic-non-atomic.h:99:21: warning: unreplaced symbol 'mask' +./include/asm-generic/bitops/instrumented-non-atomic.h:100:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:112:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:115:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:127:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:130:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:139:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:142:9: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:42:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:58:1: warning: unreplaced symbol 'return' +./include/asm-generic/bitops/instrumented-non-atomic.h:97:1: warning: unreplaced symbol 'return'
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Convert fbdev to DRM client (rev5)
In reply to Thomas Zimmermann== Series Details ==
== Series Details ==
Series: drm/i915: Convert fbdev to DRM client (rev5)
URL : https://patchwork.freedesktop.org/series/115714/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13687 -> Patchwork_115714v5
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (2): fi-hsw-4770 bat-dg2-9
Missing (2): fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_115714v5 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/fi-hsw-4770/igt@[email protected]
* igt@gem_mmap@basic:
- bat-dg2-9: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@gem_mmap_gtt@basic:
- bat-dg2-9: NOTRUN -> [SKIP][3] ([i915#4077]) +2 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@gem_render_tiled_blits@basic:
- bat-dg2-9: NOTRUN -> [SKIP][4] ([i915#4079]) +1 other test skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-dg2-9: NOTRUN -> [SKIP][5] ([i915#6621])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][6] -> [ABORT][7] ([i915#9414])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/bat-mtlp-8/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-mtlp-8/igt@i915_selftest@[email protected]
- bat-mtlp-6: [PASS][8] -> [ABORT][9] ([i915#9414])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/bat-mtlp-6/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-mtlp-6/igt@i915_selftest@[email protected]
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][10] ([i915#5190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][11] ([i915#4215] / [i915#5190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- bat-dg2-9: NOTRUN -> [SKIP][12] ([i915#4212]) +6 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg2-9: NOTRUN -> [SKIP][13] ([i915#4212] / [i915#5608])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][14] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-9: NOTRUN -> [SKIP][15] ([fdo#109285])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-9: NOTRUN -> [SKIP][16] ([i915#5274])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@kms_psr@sprite_plane_onoff:
- bat-dg2-9: NOTRUN -> [SKIP][17] ([i915#1072]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-9: NOTRUN -> [SKIP][18] ([i915#3555])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-9: NOTRUN -> [SKIP][19] ([i915#3708])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-9: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4077]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-dg2-9: NOTRUN -> [SKIP][21] ([i915#3291] / [i915#3708]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-9/igt@[email protected]
#### Possible fixes ####
* igt@kms_chamelium_edid@hdmi-edid-read:
- {bat-dg2-13}: [DMESG-WARN][22] ([i915#7952]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/bat-dg2-13/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/bat-dg2-13/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952
[i915#9414]: https://gitlab.freedesktop.org/drm/intel/issues/9414
Build changes
-------------
* Linux: CI_DRM_13687 -> Patchwork_115714v5
CI-20190529: 20190529
CI_DRM_13687: e2d29b46ca6d480bc3bc328a7775c3028bc1e5c8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7506: 4fdf544bd0a38c5a100ef43c30171827e1c8c442 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115714v5: e2d29b46ca6d480bc3bc328a7775c3028bc1e5c8 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7f0bf322bb2d drm/i915: Implement fbdev emulation as in-kernel client 8110b65a1588 drm/i915: Implement fbdev client callbacks b446659f9ecd drm/i915: Initialize fbdev DRM client with callback functions dbde7388f460 drm/i915: Move fbdev functions503ed58efc3a drm/client: Export drm_client_dev_unregister() e682999ad561 drm/client: Do not acquire module reference 44af5244059c drm/i915: Unregister in-kernel clients
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Convert fbdev to DRM client (rev5)
In reply to Thomas Zimmermann== Series Details ==
== Series Details ==
Series: drm/i915: Convert fbdev to DRM client (rev5)
URL : https://patchwork.freedesktop.org/series/115714/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13687_full -> Patchwork_115714v5_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_115714v5_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_115714v5_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_115714v5_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_ccs:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] +131 other tests dmesg-warn
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl2/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_ccs.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_ccs.html
* {igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-3} (NEW):
- shard-dg2: NOTRUN -> [SKIP][3] +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-6/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-3.html
- shard-dg1: NOTRUN -> [SKIP][4] +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-3.html
#### Warnings ####
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-dp-1:
- shard-apl: [FAIL][5] ([i915#2521]) -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl4/igt@kms_async_flips@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@kms_async_flips@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-b-hdmi-a-4}:
- shard-dg1: NOTRUN -> [SKIP][7] +19 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-16/igt@kms_plane_scaling@[email protected]
* {igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-1}:
- shard-rkl: NOTRUN -> [SKIP][8] +5 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-1.html
* {igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-b-hdmi-a-3}:
- shard-dg2: NOTRUN -> [SKIP][9] +3 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@kms_plane_scaling@[email protected]
* {igt@kms_plane_scaling@plane-upscale-factor-0-25-with-pixel-format@pipe-c-dp-1}:
- shard-apl: [PASS][10] -> [DMESG-WARN][11] +7 other tests dmesg-warn
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl4/igt@kms_plane_scaling@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@kms_plane_scaling@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_13687_full and Patchwork_115714v5_full:
### New IGT tests (20) ###
* igt@kms_lease@cursor-implicit-plane@pipe-a-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@cursor-implicit-plane@pipe-b-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@cursor-implicit-plane@pipe-c-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@cursor-implicit-plane@pipe-d-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@setcrtc-implicit-plane@pipe-a-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@setcrtc-implicit-plane@pipe-b-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@setcrtc-implicit-plane@pipe-c-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@setcrtc-implicit-plane@pipe-d-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-hdmi-a-3:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-b-hdmi-a-3:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-3:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-d-hdmi-a-3:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-b-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-c-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-d-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-20x20-with-pixel-format@pipe-a-hdmi-a-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-20x20-with-pixel-format@pipe-b-hdmi-a-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-20x20-with-pixel-format@pipe-c-hdmi-a-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@plane-upscale-20x20-with-pixel-format@pipe-d-hdmi-a-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_115714v5_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@object-reloc-keep-cache:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#8411])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@drm_fdinfo@most-busy-check-all@bcs0:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#8414]) +9 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@drm_fdinfo@[email protected]
* igt@drm_fdinfo@virtual-busy-idle-all:
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#8414])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: [PASS][15] -> [ABORT][16] ([i915#8190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl3/igt@gem_barrier_race@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl3/igt@gem_barrier_race@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][17] -> [FAIL][18] ([i915#6268])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-rkl-2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-1/igt@[email protected]
* igt@gem_ctx_param@set-priority-not-supported:
- shard-dg2: NOTRUN -> [SKIP][19] ([fdo#109314])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_ctx_persistence@hang:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#1099])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb5/igt@[email protected]
* igt@gem_ctx_sseu@invalid-args:
- shard-tglu: NOTRUN -> [SKIP][21] ([i915#280])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@gem_ctx_sseu@mmap-args:
- shard-dg2: NOTRUN -> [SKIP][22] ([i915#280])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_eio@hibernate:
- shard-dg2: NOTRUN -> [ABORT][23] ([i915#7975] / [i915#8213])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][24] -> [FAIL][25] ([i915#5784])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-16/igt@[email protected]
* igt@gem_exec_balancer@bonded-true-hang:
- shard-dg2: NOTRUN -> [SKIP][26] ([i915#4812]) +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_exec_fair@basic-none:
- shard-mtlp: NOTRUN -> [SKIP][27] ([i915#4473] / [i915#4771])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][28] -> [FAIL][29] ([i915#2842])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl1/igt@gem_exec_fair@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][30] -> [FAIL][31] ([i915#2842])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-glk5/igt@gem_exec_fair@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#3539] / [i915#4852])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@gem_exec_flush@basic-uc-set-default:
- shard-dg2: NOTRUN -> [SKIP][33] ([i915#3539]) +3 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@gem_exec_reloc@basic-softpin:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#3281]) +11 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_exec_reloc@basic-write-gtt-noreloc:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#3281]) +1 other test skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-contexts:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#4537] / [i915#4812]) +1 other test skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg1: [PASS][37] -> [ABORT][38] ([i915#7975] / [i915#8213])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-16/igt@gem_exec_suspend@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-14/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_whisper@basic-forked-all:
- shard-snb: [PASS][39] -> [ABORT][40] ([i915#8865])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-snb4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb7/igt@[email protected]
* igt@gem_fenced_exec_thrash@no-spare-fences-interruptible:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#4860]) +1 other test skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-tglu: NOTRUN -> [SKIP][42] ([i915#4613])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@gem_mmap@pf-nonblock:
- shard-dg2: NOTRUN -> [SKIP][43] ([i915#4083]) +1 other test skip
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@gem_mmap_gtt@basic-small-bo-tiledx:
- shard-dg2: NOTRUN -> [SKIP][44] ([i915#4077]) +5 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@gem_mmap_gtt@hang-user:
- shard-mtlp: NOTRUN -> [SKIP][45] ([i915#4077]) +4 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads-display:
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#3282]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gem_pwrite@basic-random:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#3282]) +5 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-mtlp: NOTRUN -> [SKIP][48] ([i915#4270])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#4270]) +1 other test skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#8428]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gem_set_tiling_vs_blt@untiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#4079]) +1 other test skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#3297]) +2 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap:
- shard-mtlp: NOTRUN -> [SKIP][53] ([i915#3297])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-dg2: NOTRUN -> [SKIP][54] ([i915#3297] / [i915#4880])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gen7_exec_parse@basic-allowed:
- shard-tglu: NOTRUN -> [SKIP][55] ([fdo#109289]) +1 other test skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-dg2: NOTRUN -> [SKIP][56] ([fdo#109289])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@gen9_exec_parse@bb-oversize:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#2856]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglu: NOTRUN -> [SKIP][58] ([i915#2527] / [i915#2856])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@gen9_exec_parse@secure-batches:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#2856])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@i915_fb_tiling:
- shard-dg2: NOTRUN -> [SKIP][60] ([i915#4881])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@i915_fb_tiling.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#7091])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: [PASS][62] -> [INCOMPLETE][63] ([i915#9407])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-11/igt@i915_pm_freq_api@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-6/igt@i915_pm_freq_api@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-dg1: [PASS][64] -> [FAIL][65] ([i915#3591])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@i915_pm_rc6_residency@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-16/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [PASS][66] -> [SKIP][67] ([i915#1397]) +1 other test skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-rkl-6/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-7/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-mtlp: NOTRUN -> [SKIP][68] ([fdo#109293])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-dg2: [PASS][69] -> [SKIP][70] ([i915#1397])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-10/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-3/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg2: NOTRUN -> [SKIP][71] ([i915#1397])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
- shard-dg1: [PASS][72] -> [SKIP][73] ([i915#1397]) +1 other test skip
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-15/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-19/igt@[email protected]
* igt@i915_pm_rps@min-max-config-loaded:
- shard-mtlp: NOTRUN -> [SKIP][74] ([i915#6621])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@i915_query@test-query-geometry-subslices:
- shard-tglu: NOTRUN -> [SKIP][75] ([i915#5723])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@i915_selftest@mock@memory_region:
- shard-mtlp: NOTRUN -> [DMESG-WARN][76] ([i915#9311])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@i915_selftest@mock@memory_region.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][77] ([i915#8502] / [i915#8709]) +11 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-4-mc_ccs.html
* igt@kms_async_flips@crc@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][78] ([i915#8247]) +3 other tests fail
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-16/igt@kms_async_flips@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][79] ([i915#1769] / [i915#3555]) +1 other test skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html
* igt@kms_big_fb@4-tiled-32bpp-rotate-270:
- shard-dg2: NOTRUN -> [SKIP][80] ([fdo#111614]) +1 other test skip
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-tglu: NOTRUN -> [SKIP][81] ([fdo#111615] / [i915#5286])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-mtlp: NOTRUN -> [SKIP][82] ([fdo#111614])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglu: [PASS][83] -> [FAIL][84] ([i915#3743]) +2 other tests fail
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#5190]) +8 other tests skip
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglu: NOTRUN -> [SKIP][86] ([fdo#111615]) +1 other test skip
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-mtlp: NOTRUN -> [SKIP][87] ([fdo#111615]) +4 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#4538] / [i915#5190]) +3 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][89] ([i915#5354] / [i915#6095]) +15 other tests skip
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc:
- shard-tglu: NOTRUN -> [SKIP][90] ([i915#3689] / [i915#5354] / [i915#6095])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][91] ([i915#3689] / [i915#5354]) +7 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][92] ([i915#3689] / [i915#3886] / [i915#5354]) +9 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][93] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][94] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095]) +3 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][95] ([i915#3886] / [i915#5354] / [i915#6095]) +1 other test skip
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-random-ccs-data-4_tiled_dg2_rc_ccs:
- shard-tglu: NOTRUN -> [SKIP][96] ([i915#5354] / [i915#6095]) +5 other tests skip
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_ccs@pipe-d-random-ccs-data-4_tiled_dg2_rc_ccs.html
* igt@kms_chamelium_color@ctm-0-75:
- shard-mtlp: NOTRUN -> [SKIP][97] ([fdo#111827])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_chamelium_color@ctm-blue-to-red:
- shard-dg2: NOTRUN -> [SKIP][98] ([fdo#111827])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_chamelium_color@ctm-max:
- shard-glk: NOTRUN -> [SKIP][99] ([fdo#109271]) +13 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk2/igt@[email protected]
* igt@kms_chamelium_edid@hdmi-edid-stress-resolution-non-4k:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#7828]) +5 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_chamelium_frames@vga-frame-dump:
- shard-tglu: NOTRUN -> [SKIP][101] ([i915#7828])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd:
- shard-mtlp: NOTRUN -> [SKIP][102] ([i915#7828]) +2 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@kms_content_protection@dp-mst-type-1:
- shard-dg2: NOTRUN -> [SKIP][103] ([i915#3299])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-mtlp: NOTRUN -> [SKIP][104] ([i915#6944]) +1 other test skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-dg2: NOTRUN -> [SKIP][105] ([i915#3359])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-512x512:
- shard-mtlp: NOTRUN -> [SKIP][106] ([i915#3359])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-max-size:
- shard-mtlp: NOTRUN -> [SKIP][107] ([i915#3555] / [i915#8814])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1:
- shard-snb: NOTRUN -> [DMESG-WARN][108] ([i915#8841]) +4 other tests dmesg-warn
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb5/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
- shard-mtlp: NOTRUN -> [SKIP][109] ([i915#3546]) +1 other test skip
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-mtlp: NOTRUN -> [SKIP][110] ([fdo#111767] / [i915#3546])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-dg2: NOTRUN -> [INCOMPLETE][111] ([i915#2295])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-dg2: NOTRUN -> [SKIP][112] ([fdo#109274] / [i915#5354]) +2 other tests skip
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][113] -> [FAIL][114] ([i915#2346])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-glk3/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk4/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][115] ([i915#3804])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-4/igt@kms_dither@[email protected]
* igt@kms_dsc@dsc-with-bpc:
- shard-tglu: NOTRUN -> [SKIP][116] ([i915#3555] / [i915#3840])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-snb: NOTRUN -> [SKIP][117] ([fdo#109271] / [fdo#111767])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning:
- shard-dg2: NOTRUN -> [SKIP][118] ([fdo#109274]) +2 other tests skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][119] ([i915#3637]) +2 other tests skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@kms_flip@basic-plain-flip@b-dp1:
- shard-apl: [PASS][120] -> [DMESG-WARN][121] ([i915#8585])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl4/igt@kms_flip@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1:
- shard-apl: [PASS][122] -> [DMESG-WARN][123] ([i915#1982])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl2/igt@kms_flip@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][124] ([i915#2672]) +1 other test skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][125] ([i915#2672]) +4 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-dg2: NOTRUN -> [SKIP][126] ([fdo#109285])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][127] ([i915#5354]) +40 other tests skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][128] ([i915#8708]) +2 other tests skip
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu:
- shard-dg2: [PASS][129] -> [FAIL][130] ([i915#6880]) +1 other test fail
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-10/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][131] ([i915#3458]) +11 other tests skip
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][132] ([i915#8708]) +6 other tests skip
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-mtlp: NOTRUN -> [SKIP][133] ([i915#1825]) +13 other tests skip
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-tglu: NOTRUN -> [SKIP][134] ([fdo#109280]) +5 other tests skip
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-dg2: NOTRUN -> [SKIP][135] ([i915#3555] / [i915#8228])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-rkl: NOTRUN -> [SKIP][136] ([i915#3555] / [i915#8228])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][137] ([i915#180] / [i915#9392])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl2/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-mtlp: [PASS][138] -> [ABORT][139] ([i915#9262]) +1 other test abort
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-8/igt@kms_plane@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-2/igt@kms_plane@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-dg2: [PASS][140] -> [FAIL][141] ([fdo#103375])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-2/igt@kms_plane@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-5/igt@kms_plane@[email protected]
* igt@kms_plane_lowres@tiling-yf:
- shard-mtlp: NOTRUN -> [SKIP][142] ([i915#3555] / [i915#8821])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-3:
- shard-dg1: NOTRUN -> [FAIL][143] ([i915#8292])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][144] ([i915#5176]) +1 other test skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-7/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][145] ([fdo#109271]) +170 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb4/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-c-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][146] ([i915#5235]) +3 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][147] ([i915#5235]) +15 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-3/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-b-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][148] ([i915#5235]) +3 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][149] ([i915#5235]) +15 other tests skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-18/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4.html
* igt@kms_prime@basic-crc-hybrid:
- shard-mtlp: NOTRUN -> [SKIP][150] ([i915#6524])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2: NOTRUN -> [SKIP][151] ([i915#658]) +1 other test skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_psr@dpms:
- shard-dg2: NOTRUN -> [SKIP][152] ([i915#1072]) +5 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglu: NOTRUN -> [SKIP][153] ([fdo#110189]) +6 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-tglu: NOTRUN -> [SKIP][154] ([fdo#111615] / [i915#5289])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-dg2: NOTRUN -> [SKIP][155] ([i915#4235] / [i915#5190])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
* igt@kms_rotation_crc@sprite-rotation-270:
- shard-mtlp: NOTRUN -> [SKIP][156] ([i915#4235])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_scaling_modes@scaling-mode-center:
- shard-dg2: NOTRUN -> [SKIP][157] ([i915#3555]) +3 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@[email protected]
* igt@kms_tiled_display@basic-test-pattern:
- shard-tglu: NOTRUN -> [SKIP][158] ([i915#8623])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak-pipe-a:
- shard-snb: [PASS][159] -> [FAIL][160] ([i915#9196])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-snb1/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-snb1/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak-pipe-b:
- shard-mtlp: [PASS][161] -> [FAIL][162] ([i915#9196])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-5/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak-pipe-c:
- shard-apl: [PASS][163] -> [FAIL][164] ([i915#9196])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl6/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl3/igt@[email protected]
- shard-dg2: NOTRUN -> [FAIL][165] ([i915#9196])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@[email protected]
- shard-dg1: [PASS][166] -> [FAIL][167] ([i915#9196])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-15/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-19/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak-pipe-d:
- shard-tglu: [PASS][168] -> [FAIL][169] ([i915#9196]) +1 other test fail
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-6/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-3/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-glk: NOTRUN -> [SKIP][170] ([fdo#109271] / [i915#2437])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk2/igt@[email protected]
* igt@perf@enable-disable@0-rcs0:
- shard-dg2: [PASS][171] -> [FAIL][172] ([i915#8724])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-7/igt@perf@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-11/igt@perf@[email protected]
* igt@perf_pmu@cpu-hotplug:
- shard-mtlp: NOTRUN -> [SKIP][173] ([i915#8850])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@[email protected]
* igt@perf_pmu@rc6@other-idle-gt0:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#8516])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-7/igt@perf_pmu@[email protected]
* igt@prime_udl:
- shard-mtlp: NOTRUN -> [SKIP][175] ([fdo#109291])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@prime_udl.html
* igt@prime_vgem@basic-read:
- shard-mtlp: NOTRUN -> [SKIP][176] ([i915#3708]) +1 other test skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@[email protected]
* igt@v3d/v3d_get_param@get-bad-flags:
- shard-dg2: NOTRUN -> [SKIP][177] ([i915#2575]) +8 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@v3d/[email protected]
* igt@v3d/v3d_submit_cl@multisync-out-syncs:
- shard-tglu: NOTRUN -> [SKIP][178] ([fdo#109315] / [i915#2575])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@v3d/[email protected]
* igt@v3d/v3d_submit_cl@valid-submission:
- shard-mtlp: NOTRUN -> [SKIP][179] ([i915#2575]) +5 other tests skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@v3d/[email protected]
* igt@vc4/vc4_dmabuf_poll@poll-read-waits-until-write-done:
- shard-dg2: NOTRUN -> [SKIP][180] ([i915#7711]) +5 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-10/igt@vc4/[email protected]
* igt@vc4/vc4_purgeable_bo@free-purged-bo:
- shard-mtlp: NOTRUN -> [SKIP][181] ([i915#7711]) +3 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@vc4/[email protected]
* igt@vc4/vc4_wait_bo@used-bo-0ns:
- shard-tglu: NOTRUN -> [SKIP][182] ([i915#2575]) +1 other test skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@vc4/[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][183] ([i915#7742]) -> [PASS][184]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-rkl-2/igt@drm_fdinfo@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-1/igt@drm_fdinfo@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [FAIL][185] ([i915#6268]) -> [PASS][186]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-6/igt@[email protected]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-3/igt@[email protected]
* igt@gem_ctx_persistence@engines-hostile@vcs0:
- shard-mtlp: [ABORT][187] ([i915#9414]) -> [PASS][188]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-1/igt@gem_ctx_persistence@[email protected]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-1/igt@gem_ctx_persistence@[email protected]
* igt@gem_eio@hibernate:
- shard-tglu: [ABORT][189] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][190]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-10/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-8/igt@[email protected]
* igt@gem_eio@kms:
- shard-dg1: [FAIL][191] ([i915#5784]) -> [PASS][192]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-16/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-14/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][193] ([i915#2846]) -> [PASS][194]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-glk5/igt@[email protected]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk6/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [FAIL][195] ([i915#2842]) -> [PASS][196]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-3/igt@gem_exec_fair@[email protected]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-wb:
- shard-mtlp: [DMESG-FAIL][197] ([i915#8962]) -> [PASS][198]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-4/igt@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-5/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-dg2: [INCOMPLETE][199] ([i915#9138]) -> [PASS][200]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-5/igt@[email protected]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [INCOMPLETE][201] ([i915#5566]) -> [PASS][202]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-glk4/igt@[email protected]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk2/igt@[email protected]
* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [SKIP][203] ([i915#1397]) -> [PASS][204]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-rkl-1/igt@[email protected]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-7/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-2:
- shard-glk: [FAIL][205] ([i915#2521]) -> [PASS][206]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-glk3/igt@kms_async_flips@[email protected]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-glk4/igt@kms_async_flips@[email protected]
* igt@kms_atomic_interruptible@universal-setplane-cursor@edp-1-pipe-a:
- shard-mtlp: [ABORT][207] -> [PASS][208]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-4/igt@kms_atomic_interruptible@[email protected]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-7/igt@kms_atomic_interruptible@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-tglu: [FAIL][209] ([i915#3743]) -> [PASS][210]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@forked-move@all-pipes:
- shard-mtlp: [DMESG-WARN][211] ([i915#2017]) -> [PASS][212]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-4/igt@kms_cursor_legacy@[email protected]
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-2/igt@kms_cursor_legacy@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
- shard-dg2: [FAIL][213] ([i915#6880]) -> [PASS][214]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-dp-1:
- shard-apl: [INCOMPLETE][215] ([i915#1982] / [i915#9392]) -> [PASS][216]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl1/igt@kms_pipe_crc_basic@[email protected]
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl2/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-dg2: [FAIL][217] ([IGT#2]) -> [PASS][218]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-2/igt@kms_sysfs_edid_timing.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-11/igt@kms_sysfs_edid_timing.html
* igt@kms_universal_plane@cursor-fb-leak-pipe-b:
- shard-apl: [FAIL][219] ([i915#9196]) -> [PASS][220]
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-apl1/igt@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-apl6/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-dg2: [FAIL][221] ([fdo#103375]) -> [PASS][222] +1 other test pass
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-5/igt@[email protected]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-2/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-dg1: [DMESG-WARN][223] ([i915#1982] / [i915#4391] / [i915#4423]) -> [PASS][224]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@[email protected]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@[email protected]
#### Warnings ####
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg1: [DMESG-WARN][225] ([i915#4936] / [i915#5493]) -> [DMESG-WARN][226] ([i915#1982] / [i915#4936] / [i915#5493])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-15/igt@gem_lmem_swapping@[email protected]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-19/igt@gem_lmem_swapping@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][227] ([i915#8617]) -> [DMESG-WARN][228] ([i915#1982] / [i915#8617])
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg2-11/igt@[email protected]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg2-11/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglu: [FAIL][229] ([i915#2681] / [i915#3591]) -> [WARN][230] ([i915#2681]) +1 other test warn
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-tglu-8/igt@i915_pm_rc6_residency@[email protected]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-tglu-4/igt@i915_pm_rc6_residency@[email protected]
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_ccs:
- shard-dg1: [SKIP][231] ([i915#3689] / [i915#4423] / [i915#5354] / [i915#6095]) -> [SKIP][232] ([i915#3689] / [i915#5354] / [i915#6095])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_ccs.html
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_ccs.html
* igt@kms_chamelium_hpd@hdmi-hpd-enable-disable-mode:
- shard-dg1: [SKIP][233] ([i915#4423] / [i915#7828]) -> [SKIP][234] ([i915#7828])
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@[email protected]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][235] ([fdo#109285]) -> [SKIP][236] ([fdo#109285] / [i915#4098])
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-rkl-6/igt@[email protected]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-rkl-2/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-mtlp: [ABORT][237] ([i915#9262]) -> [DMESG-WARN][238] ([i915#9262])
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-8/igt@kms_plane@[email protected]
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-2/igt@kms_plane@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- shard-dg1: [SKIP][239] ([i915#1072] / [i915#4078]) -> [SKIP][240] ([i915#1072])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-18/igt@kms_psr@primary_mmap_gtt.html
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-17/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@primary_page_flip:
- shard-dg1: [SKIP][241] ([i915#1072]) -> [SKIP][242] ([i915#1072] / [i915#4078])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-15/igt@kms_psr@primary_page_flip.html
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-18/igt@kms_psr@primary_page_flip.html
* igt@kms_scaling_modes@scaling-mode-full-aspect:
- shard-dg1: [SKIP][243] ([i915#3555] / [i915#4423]) -> [SKIP][244] ([i915#3555])
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-dg1-17/igt@[email protected]
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-dg1-12/igt@[email protected]
* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-mtlp: [TIMEOUT][245] ([i915#8521]) -> [ABORT][246] ([i915#8521] / [i915#8865])
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13687/shard-mtlp-2/igt@sysfs_preempt_timeout@[email protected]
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/shard-mtlp-3/igt@sysfs_preempt_timeout@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5978]: https://gitlab.freedesktop.org/drm/intel/issues/5978
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7091]: https://gitlab.freedesktop.org/drm/intel/issues/7091
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8190]: https://gitlab.freedesktop.org/drm/intel/issues/8190
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8521]: https://gitlab.freedesktop.org/drm/intel/issues/8521
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
[i915#8617]: https://gitlab.freedesktop.org/drm/intel/issues/8617
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8724]: https://gitlab.freedesktop.org/drm/intel/issues/8724
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8821]: https://gitlab.freedesktop.org/drm/intel/issues/8821
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
[i915#8850]: https://gitlab.freedesktop.org/drm/intel/issues/8850
[i915#8865]: https://gitlab.freedesktop.org/drm/intel/issues/8865
[i915#8962]: https://gitlab.freedesktop.org/drm/intel/issues/8962
[i915#9067]: https://gitlab.freedesktop.org/drm/intel/issues/9067
[i915#9138]: https://gitlab.freedesktop.org/drm/intel/issues/9138
[i915#9196]: https://gitlab.freedesktop.org/drm/intel/issues/9196
[i915#9226]: https://gitlab.freedesktop.org/drm/intel/issues/9226
[i915#9227]: https://gitlab.freedesktop.org/drm/intel/issues/9227
[i915#9261]: https://gitlab.freedesktop.org/drm/intel/issues/9261
[i915#9262]: https://gitlab.freedesktop.org/drm/intel/issues/9262
[i915#9311]: https://gitlab.freedesktop.org/drm/intel/issues/9311
[i915#9337]: https://gitlab.freedesktop.org/drm/intel/issues/9337
[i915#9392]: https://gitlab.freedesktop.org/drm/intel/issues/9392
[i915#9407]: https://gitlab.freedesktop.org/drm/intel/issues/9407
[i915#9412]: https://gitlab.freedesktop.org/drm/intel/issues/9412
[i915#9414]: https://gitlab.freedesktop.org/drm/intel/issues/9414
Build changes
-------------
* Linux: CI_DRM_13687 -> Patchwork_115714v5
CI-20190529: 20190529
CI_DRM_13687: e2d29b46ca6d480bc3bc328a7775c3028bc1e5c8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7506: 4fdf544bd0a38c5a100ef43c30171827e1c8c442 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_115714v5: e2d29b46ca6d480bc3bc328a7775c3028bc1e5c8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v5/index.html