Change in openvpn[master]: manage: Make sure various management flags are treated as unsigned
A message that is not in the archive (sent off-list or not yet received): gerrit.1753360288000.I0937165c5efa95136bd951345a076e33e396f26a@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
to review the following change.
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
---
M src/openvpn/manage.h
M src/openvpn/options.h
2 files changed, 40 insertions(+), 40 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/1
src/openvpn/manage.h +37 -37
@@ -25,24 +25,24 @@#define MANAGE_H /* management_open flags */ -#define MF_SERVER (1<<0) -#define MF_QUERY_PASSWORDS (1<<1) -#define MF_HOLD (1<<2) -#define MF_SIGNAL (1<<3) -#define MF_FORGET_DISCONNECT (1<<4) -#define MF_CONNECT_AS_CLIENT (1<<5) -#define MF_CLIENT_AUTH (1<<6) -/* #define MF_CLIENT_PF (1<<7) *REMOVED FEATURE* */ -#define MF_UNIX_SOCK (1<<8) -#define MF_EXTERNAL_KEY (1<<9) -#define MF_EXTERNAL_KEY_NOPADDING (1<<10) -#define MF_EXTERNAL_KEY_PKCS1PAD (1<<11) -#define MF_UP_DOWN (1<<12) -#define MF_QUERY_REMOTE (1<<13) -#define MF_QUERY_PROXY (1<<14) -#define MF_EXTERNAL_CERT (1<<15) -#define MF_EXTERNAL_KEY_PSSPAD (1<<16) -#define MF_EXTERNAL_KEY_DIGEST (1<<17) +#define MF_SERVER (1u<<0) +#define MF_QUERY_PASSWORDS (1u<<1) +#define MF_HOLD (1u<<2) +#define MF_SIGNAL (1u<<3) +#define MF_FORGET_DISCONNECT (1u<<4) +#define MF_CONNECT_AS_CLIENT (1u<<5) +#define MF_CLIENT_AUTH (1u<<6) +/* #define MF_CLIENT_PF (1u<<7) *REMOVED FEATURE* */ +#define MF_UNIX_SOCK (1u<<8) +#define MF_EXTERNAL_KEY (1u<<9) +#define MF_EXTERNAL_KEY_NOPADDING (1u<<10) +#define MF_EXTERNAL_KEY_PKCS1PAD (1u<<11) +#define MF_UP_DOWN (1u<<12) +#define MF_QUERY_REMOTE (1u<<13) +#define MF_QUERY_PROXY (1u<<14) +#define MF_EXTERNAL_CERT (1u<<15) +#define MF_EXTERNAL_KEY_PSSPAD (1u<<16) +#define MF_EXTERNAL_KEY_DIGEST (1u<<17)#ifdef ENABLE_MANAGEMENT
@@ -64,9 +64,9 @@struct man_def_auth_context {unsigned long cid; -#define DAF_CONNECTION_ESTABLISHED (1<<0) -#define DAF_CONNECTION_CLOSED (1<<1) -#define DAF_INITIAL_AUTH (1<<2) +#define DAF_CONNECTION_ESTABLISHED (1u<<0) +#define DAF_CONNECTION_CLOSED (1u<<1) +#define DAF_INITIAL_AUTH (1u<<2)unsigned int flags;unsigned int mda_key_id_counter;
@@ -116,23 +116,23 @@union log_entry_union u; }; -#define LOG_PRINT_LOG_PREFIX (1<<0) -#define LOG_PRINT_ECHO_PREFIX (1<<1) -#define LOG_PRINT_STATE_PREFIX (1<<2) +#define LOG_PRINT_LOG_PREFIX (1u<<0) +#define LOG_PRINT_ECHO_PREFIX (1u<<1) +#define LOG_PRINT_STATE_PREFIX (1u<<2) -#define LOG_PRINT_INT_DATE (1<<3) -#define LOG_PRINT_MSG_FLAGS (1<<4) -#define LOG_PRINT_STATE (1<<5) -#define LOG_PRINT_LOCAL_IP (1<<6) +#define LOG_PRINT_INT_DATE (1u<<3) +#define LOG_PRINT_MSG_FLAGS (1u<<4) +#define LOG_PRINT_STATE (1u<<5) +#define LOG_PRINT_LOCAL_IP (1u<<6) -#define LOG_PRINT_CRLF (1<<7) -#define LOG_FATAL_NOTIFY (1<<8) +#define LOG_PRINT_CRLF (1u<<7) +#define LOG_FATAL_NOTIFY (1u<<8) -#define LOG_PRINT_INTVAL (1<<9) +#define LOG_PRINT_INTVAL (1u<<9) -#define LOG_PRINT_REMOTE_IP (1<<10) +#define LOG_PRINT_REMOTE_IP (1u<<10) -#define LOG_ECHO_TO_LOG (1<<11) +#define LOG_ECHO_TO_LOG (1u<<11)const char *log_entry_print (const struct log_entry *e,unsigned int flags,struct gc_arena *gc);
@@ -174,7 +174,7 @@ {void *arg; -#define MCF_SERVER (1<<0)/* is OpenVPN being run as a server? */ +#define MCF_SERVER (1u<<0)/* is OpenVPN being run as a server? */ unsigned int flags;void (*status) (void *arg,const int version,struct status_output *so);
@@ -257,9 +257,9 @@int client_gid;/* flags for handling the management interface "signal" command */ -#define MANSIG_IGNORE_USR1_HUP (1<<0) -#define MANSIG_MAP_USR1_TO_HUP (1<<1) -#define MANSIG_MAP_USR1_TO_TERM (1<<2) +#define MANSIG_IGNORE_USR1_HUP (1u<<0) +#define MANSIG_MAP_USR1_TO_HUP (1u<<1) +#define MANSIG_MAP_USR1_TO_TERM (1u<<2)unsigned int mansig; };
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1<<0) -#define CE_MAN_QUERY_PROXY (1<<1) +#define CE_DISABLED (1u<<0) +#define CE_MAN_QUERY_PROXY (1u<<1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
to look at the new patch set (#4).
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
---
M src/openvpn/manage.h
M src/openvpn/options.h
2 files changed, 40 insertions(+), 40 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/4
src/openvpn/manage.h +37 -37
@@ -24,24 +24,24 @@#define MANAGE_H /* management_open flags */ -#define MF_SERVER (1 << 0) -#define MF_QUERY_PASSWORDS (1 << 1) -#define MF_HOLD (1 << 2) -#define MF_SIGNAL (1 << 3) -#define MF_FORGET_DISCONNECT (1 << 4) -#define MF_CONNECT_AS_CLIENT (1 << 5) -#define MF_CLIENT_AUTH (1 << 6) -/* #define MF_CLIENT_PF (1<<7) *REMOVED FEATURE* */ -#define MF_UNIX_SOCK (1 << 8) -#define MF_EXTERNAL_KEY (1 << 9) -#define MF_EXTERNAL_KEY_NOPADDING (1 << 10) -#define MF_EXTERNAL_KEY_PKCS1PAD (1 << 11) -#define MF_UP_DOWN (1 << 12) -#define MF_QUERY_REMOTE (1 << 13) -#define MF_QUERY_PROXY (1 << 14) -#define MF_EXTERNAL_CERT (1 << 15) -#define MF_EXTERNAL_KEY_PSSPAD (1 << 16) -#define MF_EXTERNAL_KEY_DIGEST (1 << 17) +#define MF_SERVER (1u << 0) +#define MF_QUERY_PASSWORDS (1u << 1) +#define MF_HOLD (1u << 2) +#define MF_SIGNAL (1u << 3) +#define MF_FORGET_DISCONNECT (1u << 4) +#define MF_CONNECT_AS_CLIENT (1u << 5) +#define MF_CLIENT_AUTH (1u << 6) +/* #define MF_CLIENT_PF (1u << 7) *REMOVED FEATURE* */ +#define MF_UNIX_SOCK (1u << 8) +#define MF_EXTERNAL_KEY (1u << 9) +#define MF_EXTERNAL_KEY_NOPADDING (1u << 10) +#define MF_EXTERNAL_KEY_PKCS1PAD (1u << 11) +#define MF_UP_DOWN (1u << 12) +#define MF_QUERY_REMOTE (1u << 13) +#define MF_QUERY_PROXY (1u << 14) +#define MF_EXTERNAL_CERT (1u << 15) +#define MF_EXTERNAL_KEY_PSSPAD (1u << 16) +#define MF_EXTERNAL_KEY_DIGEST (1u << 17)#ifdef ENABLE_MANAGEMENT
@@ -64,9 +64,9 @@ {unsigned long cid; -#define DAF_CONNECTION_ESTABLISHED (1 << 0) -#define DAF_CONNECTION_CLOSED (1 << 1) -#define DAF_INITIAL_AUTH (1 << 2) +#define DAF_CONNECTION_ESTABLISHED (1u << 0) +#define DAF_CONNECTION_CLOSED (1u << 1) +#define DAF_INITIAL_AUTH (1u << 2)unsigned int flags;unsigned int mda_key_id_counter;
@@ -117,23 +117,23 @@union log_entry_union u; }; -#define LOG_PRINT_LOG_PREFIX (1 << 0) -#define LOG_PRINT_ECHO_PREFIX (1 << 1) -#define LOG_PRINT_STATE_PREFIX (1 << 2) +#define LOG_PRINT_LOG_PREFIX (1u << 0) +#define LOG_PRINT_ECHO_PREFIX (1u << 1) +#define LOG_PRINT_STATE_PREFIX (1u << 2) -#define LOG_PRINT_INT_DATE (1 << 3) -#define LOG_PRINT_MSG_FLAGS (1 << 4) -#define LOG_PRINT_STATE (1 << 5) -#define LOG_PRINT_LOCAL_IP (1 << 6) +#define LOG_PRINT_INT_DATE (1u << 3) +#define LOG_PRINT_MSG_FLAGS (1u << 4) +#define LOG_PRINT_STATE (1u << 5) +#define LOG_PRINT_LOCAL_IP (1u << 6) -#define LOG_PRINT_CRLF (1 << 7) -#define LOG_FATAL_NOTIFY (1 << 8) +#define LOG_PRINT_CRLF (1u << 7) +#define LOG_FATAL_NOTIFY (1u << 8) -#define LOG_PRINT_INTVAL (1 << 9) +#define LOG_PRINT_INTVAL (1u << 9) -#define LOG_PRINT_REMOTE_IP (1 << 10) +#define LOG_PRINT_REMOTE_IP (1u << 10) -#define LOG_ECHO_TO_LOG (1 << 11) +#define LOG_ECHO_TO_LOG (1u << 11)const char *log_entry_print (const struct log_entry *e,unsigned int flags,struct gc_arena *gc);
@@ -175,7 +175,7 @@ {void *arg; -#define MCF_SERVER (1 << 0)/* is OpenVPN being run as a server? */ +#define MCF_SERVER (1u << 0)/* is OpenVPN being run as a server? */ unsigned int flags;void (*status)(void *arg,const int version,struct status_output *so);
@@ -253,9 +253,9 @@int client_gid;/* flags for handling the management interface "signal" command */ -#define MANSIG_IGNORE_USR1_HUP (1 << 0) -#define MANSIG_MAP_USR1_TO_HUP (1 << 1) -#define MANSIG_MAP_USR1_TO_TERM (1 << 2) +#define MANSIG_IGNORE_USR1_HUP (1u << 0) +#define MANSIG_MAP_USR1_TO_HUP (1u << 1) +#define MANSIG_MAP_USR1_TO_TERM (1u << 2)unsigned int mansig; };
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newpatchset
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
to look at the new patch set (#7).
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
---
M src/openvpn/init.c
M src/openvpn/manage.h
M src/openvpn/options.h
3 files changed, 41 insertions(+), 41 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/7
src/openvpn/init.c +1 -1
@@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK) == CE_MAN_QUERY_REMOTE_QUERY) { -int flags =0 ; +unsigned int flags =0 ;if (!strcmp (p[1 ],"ACCEPT" )) { flags =CE_MAN_QUERY_REMOTE_ACCEPT ;
src/openvpn/manage.h +37 -37
109 lines not on this page · raw message
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newpatchset
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email )
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Tue, 26 Aug 2025 12:43:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH v9 1/1 manage: Make sure various management flags are treated as unsigned
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1105
This mail reflects revision 9 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>
src/openvpn/init.c +1 -1
@@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK) == CE_MAN_QUERY_REMOTE_QUERY) { -int flags =0 ; +unsigned int flags =0 ;if (!strcmp (p[1 ],"ACCEPT" )) { flags =CE_MAN_QUERY_REMOTE_ACCEPT ;
src/openvpn/manage.h +37 -37
109 lines not on this page · raw message
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
[Openvpn-devel] [PATCH applied] Re: manage: Make sure various management flags are treated as unsigned
Stared at code. This one looks a bit more complex than the trivial ones merged already, but it really isn't - it's just more groups of defines (with the largest number being "1<<17"), and a single "flags" variable changing to "unsigned". BB tested this, but not really excercising the management interface... but I'll have to do that anyway in the context of gerrit #869.
Your patch has been applied to the master branch.
commit cd58786548554263d18531f570d5350ec667fa0c
Author: Frank Lichtenheld Date: Tue Aug 26 20:48:57 2025 +0200
manage: Make sure various management flags are treated as unsigned
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32687.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
Attention is currently required from: flichtenheld.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
to look at the new patch set (#10).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
---
M src/openvpn/init.c
M src/openvpn/manage.h
M src/openvpn/options.h
3 files changed, 41 insertions(+), 41 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/10
src/openvpn/init.c +1 -1
@@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK) == CE_MAN_QUERY_REMOTE_QUERY) { -int flags =0 ; +unsigned int flags =0 ;if (!strcmp (p[1 ],"ACCEPT" )) { flags =CE_MAN_QUERY_REMOTE_ACCEPT ;
src/openvpn/manage.h +37 -37
109 lines not on this page · raw message
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 10
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newpatchset
cron2 has uploaded a new patch set (#11) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32687.html
---
M src/openvpn/init.c
M src/openvpn/manage.h
M src/openvpn/options.h
3 files changed, 41 insertions(+), 41 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1105/11
src/openvpn/init.c +1 -1
@@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK) == CE_MAN_QUERY_REMOTE_QUERY) { -int flags =0 ; +unsigned int flags =0 ;if (!strcmp (p[1 ],"ACCEPT" )) { flags =CE_MAN_QUERY_REMOTE_ACCEPT ;
src/openvpn/manage.h +37 -37
109 lines not on this page · raw message
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email )
Change subject: manage: Make sure various management flags are treated as unsigned
......................................................................
manage: Make sure various management flags are treated as unsigned
The variables that hold them are already unsigned, make sure the flags are as well to avoid spurious conversion warnings.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32687.html
---
M src/openvpn/init.c
M src/openvpn/manage.h
M src/openvpn/options.h
3 files changed, 41 insertions(+), 41 deletions(-)
src/openvpn/init.c +1 -1
@@ -370,7 +370,7 @@ && ((ce->flags >> CE_MAN_QUERY_REMOTE_SHIFT) & CE_MAN_QUERY_REMOTE_MASK) == CE_MAN_QUERY_REMOTE_QUERY) { -int flags =0 ; +unsigned int flags =0 ;if (!strcmp (p[1 ],"ACCEPT" )) { flags =CE_MAN_QUERY_REMOTE_ACCEPT ;
src/openvpn/manage.h +37 -37
109 lines not on this page · raw message
src/openvpn/options.h +3 -3
@@ -147,14 +147,14 @@int explicit_exit_notification;/* Explicitly tell peer when we are exiting via OCC_EXIT or [RESTART] message */ -#define CE_DISABLED (1 << 0) -#define CE_MAN_QUERY_PROXY (1 << 1) +#define CE_DISABLED (1u << 0) +#define CE_MAN_QUERY_PROXY (1u << 1)#define CE_MAN_QUERY_REMOTE_UNDEF 0#define CE_MAN_QUERY_REMOTE_QUERY 1#define CE_MAN_QUERY_REMOTE_ACCEPT 2#define CE_MAN_QUERY_REMOTE_MOD 3#define CE_MAN_QUERY_REMOTE_SKIP 4 -#define CE_MAN_QUERY_REMOTE_MASK (0x07) +#define CE_MAN_QUERY_REMOTE_MASK (0x07u)#define CE_MAN_QUERY_REMOTE_SHIFT (2)unsigned int flags;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1105?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0937165c5efa95136bd951345a076e33e396f26a
Gerrit-Change-Number: 1105
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged