pds-vfio-pci driver
Subsystems (9)
Brett Creeley
maintainerv14 cover pds-vfio-pci driver
This is a patchset for a new vendor specific VFIO driver (pds-vfio-pci) for use with the AMD/Pensando Distributed Services Card (DSC). This driver makes use of the pds_core driver.
This driver will use the pds_core device's adminq as the VFIO control path to the DSC. In order to make adminq calls, the VFIO instance makes use of functions exported by the pds_core driver.
In order to receive events from pds_core, the pds-vfio-pci driver registers to a private notifier. This is needed for various events that come from the device.
An ASCII diagram of a VFIO instance looks something like this and can be used with the VFIO subsystem to provide the VF device VFIO and live migration support.
.------. .-----------------------.
| QEMU |--| VM .-------------. |
'......' | | Eth VF | |
| | .-------------. |
| | | SR-IOV VF | |
| | '-------------' |
| '------------||---------'
.--------------. ||
|/dev/<vfio_fd>| ||
'--------------' ||
Host Userspace | ||
=================================================== ||
Host Kernel | ||
.--------. ||
|vfio-pci| ||
'--------' ||
.------------------. || ||
| | exported API |<----+ || ||
| '--------------| | || ||
| | .--------------. ||
| pds_core |--->| pds-vfio-pci | ||
'------------------' | '--------------' ||
|| | || ||
09:00.0 notifier 09:00.1 ||
== PCI ===============================================||=====
|| || ||
.----------. .----------. ||
,-----| PF |----------| VF |-------------------,
| '----------' |'----------' VF |
| DSC | data/control |
| | path |
-----------------------------------------------------------The pds-vfio-pci driver is targeted to reside in drivers/vfio/pci/pds. It makes use of and introduces new files in the common include/linux/pds include directory.
Changes:
v14:
- Various fixes/suggestions by Shameerali Kolothum Thodi:
- Rework pds_vfio_dirty_enable() to only set dirty enabled if enabling dirty tracking was successful, which reduced many unnecessary goto statements
- Various fixes/suggestions by Jason Gunthrope
- Make use of pci_iov_get_pf_drvdata() when getting the PF's drvdata when calling into the pds_core driver
- Base the patch series on Alex Williamson's vfio/next tree
- Remove cached struct pdsc in vfio_dev.h and make use of pdsc_get_pf_drvdata()->pci_iov_get_pf_drvdata() when the PF's drvdata is needed
- Add a small rework patch for pds_core that requires passing the PF's drvdata instead of a VF's struct pci_dev to register/unregister as a client, which increased the total number of patches from 7 to 8 in this series
v13:
https://lore.kernel.org/netdev/ZMtlR%[email protected]/
- Various fixes/suggestions by Kevin Tian:
- Fix commit message for patch 1/7
- Re-order pds_vfio_init_device() so no unrolling of vfio_pci_core_init_dev() is necessary
- Update #define to align with live migration via VFIO
- Change dev_info() to dev_err() on a failed AQ command
- Rename AQ command from PDS_LM_CMD_STATUS to PDS_LM_CMD_STATE_SIZE and rename the associated structures
- Various fixes/suggestions by Simon Horman:
- Fix RCT issue
- Don't check for null before calling vfree()
v12:
https://lore.kernel.org/netdev/[email protected]/
- Fix htmldocs issue reported by Simon Horman
v11:
https://lore.kernel.org/netdev/[email protected]/
- Various fixes/suggestions by Kevin Tian:
- Update commit message on patch 1/7 to mention ethernet VF
- Fix formatting
- Check return of pci_iov_vf_id() for error
- Update MODULE_AUTHOR to be myself
- Remove double print of pci_id
- Set fast_poll=true for PDS_LM_CMD_RESUME
- Update comments around SUSPEND and SUSPEND_STATUS operations
- Get rid of pds_vfio_deferred_reset() and just perform the operations inline to the only caller
- Rework pds_vfio_state_mutex_unlock() to be simpler
- Rework comments in pds_vfio_recovery()
- Append "vfio" to the end of PDS_LM_DEV_NAME
- Remove req_len from pds_vfio_client_adminq_cmd()
- Remove unused completion structures in pds_adminq.h
- Fix comment above creating VFs to specify pds_core as the PF device
- Various fixes/suggestions by Alex Williamson:
- Removed cached pci_id from pds_vfio_device structure
- Rename from pds_vfio to pds-vfio-pci
- Various fixes/suggestions by Shameerali Kolothum Thodi:
- Fix checking return of pds_client_register()
- Use bool argument for flags instead of u64 on pds_vfio_client_adminq_cmd()
- Fix support for VFIO_MIGRATION_P2P
- Improve member name alignment in pds_adminq.h
- Rework Kconfig based on latest changes from Alex Williamson
v10:
https://lore.kernel.org/netdev/[email protected]/
- Various fixes/suggestions by Jason Gunthorpe
- Simplify pds_vfio_get_lm_file() based on fpga_mgr_buf_load()
- Clean-ups/fixes based on clang-format
- Remove any double goto labels
- Name goto labels baesed on what needs to be cleaned/freed instead of a "call from" scheme
- Fix any goto unwind ordering issues
- Make sure call dma_map_single() after data is written to memory in pds_vfio_dma_map_lm_file()
- Don't use bitmap_zalloc() for the dirty bitmaps
- Use vzalloc() for dirty bitmaps and refactor how the bitmaps are DMA'd to and from the device in pds_vfio_dirty_seq_ack()
- Remove unnecessary goto in pds_vfio_dirty_disable()
v9:
https://lore.kernel.org/netdev/[email protected]/
- Various fixes/suggestions by Alex Williamson
- Fix how ID is generated in client registration
- Add helper functions to get the VF's struct device and struct pci_dev pointers instead of caching the struct pci dev
- Remove redundant pds_vfio_lm_state() function and remove any places this was being called
- Fix multi-line comments to follow standard convention
- Remove confusing comments in pds_vfio_step_device_state_locked() since the driver's migration states align with the VFIO documentation
- Validate pdsc returned from pdsc_get_pf_struct()
- Various fixes/suggestions by Jason Gunthorpe
- Use struct pdsc instead of void *
- Use {} instead of {0} for structure initialization
- Use unions on the stack instead of casting to the union when sending AQ commands, which required including pds_lm.h in pds_adminq.h
- Replace use of dma_alloc_coherent() when creating the sgl DMA entries for the LM file
- Remove cached struct device *coredev and instead use pci_physfn() to get the pds_core's struct device pointer
- Drop the recovery work item and call pds_vfio_recovery() directly from the notifier callback
- Remove unnecessary #define for "pds_vfio_lm" and just use the string inline to the anon_inode_getfile() argument
- Fix LM file reference counting
- Move initialization of some struct members to when the struct is being initialized for AQ commands
- Make use of GFP_KERNEL_ACCOUNT where it makes sense
- Replace PDS_VFIO_DRV_NAME with KBUILD_MODNAME
- Update to latest pds_core exported functions
- Remove duplicated prototypes for pds_vfio_dma_logging_[start|stop|report] from lm.h
- Hold pds_vfio->state_mutex while starting, stopping, and reporting dirty page tracking in pds_vfio_dma_logging_[start|stop|report]
- Remove duplicate PDS_DEV_TYPE_LM_STR define from pds_lm.h that's already included in pds_common.h
- Replace use of dma_alloc_coherent() when creating the sgl DMA entries for the dirty bitmaps
v8:
https://lore.kernel.org/netdev/[email protected]/
- provide default iommufd callbacks for bind_iommufd, unbind_iommufd, and attach_ioas for the VFIO device as suggested by Shameerali Kolothum Thodi
v7:
https://lore.kernel.org/netdev/[email protected]/
- Disable and clean up dirty page tracking when the VFIO device is closed
- Various improvements suggested by Simon Horman:
- Fix RCT in vfio_combine_iova_ranges()
- Simplify function exit paths by removing unnecessary goto labels
- Cleanup pds_vifo_print_guest_region_info() by adding a goto label for freeing memory, which allowed for reduced indentation on a for loop
- Where possible use C99 style for loops
v6:
https://lore.kernel.org/netdev/[email protected]/
- As suggested by Alex Williamson, use pci_domain_nr() macro to make sure the pds_vfio client's devname is unique
- Remove unnecessary forward declaration and include
- Fix copyright comment to use correct company name
- Remove "." from struct documentation for consistency
v5:
https://lore.kernel.org/netdev/[email protected]/
- Fix SPDX comments in .h files
- Remove adminqcq argument from pdsc_post_adminq() uses
- Unregister client on vfio_pci_core_register_device() failure
- Other minor checkpatch issues
v4:
https://lore.kernel.org/netdev/[email protected]/
- Update cover letter ASCII diagram to reflect new driver architecture
- Remove auxiliary driver implementation
- Use pds_core's exported functions to communicate with the device
- Implement and register notifier for events from the device/pds_core
- Use module_pci_driver() macro since auxiliary driver configuration is no longer needed in __init/__exit
v3:
https://lore.kernel.org/netdev/[email protected]/
- Update copyright year to 2023 and use "Advanced Micro Devices, Inc." for the company name
- Clarify the fact that AMD/Pensando's VFIO solution is device type agnostic, which aligns with other current VFIO solutions
- Add line in drivers/vfio/pci/Makefile to build pds_vfio
- Move documentation to amd sub-directory
- Remove some dead code due to the pds_core implementation of listening to BIND/UNBIND events
- Move a dev_dbg() to a previous patch in the series
- Add implementation for vfio_migration_ops.migration_get_data_size to return the maximum possible device state size
RFC to v2:
https://lore.kernel.org/all/[email protected]/
- Implement state transitions for VFIO_MIGRATION_P2P flag
- Improve auxiliary driver probe by returning EPROBE_DEFER when the PCI driver is not set up correctly
- Add pointer to docs in Documentation/networking/device_drivers/ethernet/index.rst
RFC:
https://lore.kernel.org/all/[email protected]/
Brett Creeley (8):
vfio: Commonize combine_ranges for use in other VFIO drivers vfio/pds: Initial support for pds VFIO driver
pds_core: Require callers of register/unregister to pass PF drvdata vfio/pds: register with the pds_core PF
vfio/pds: Add VFIO live migration support
vfio/pds: Add support for dirty page tracking
vfio/pds: Add support for firmware recovery
vfio/pds: Add Kconfig and documentation
.../ethernet/amd/pds_vfio_pci.rst | 79 +++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 + drivers/net/ethernet/amd/pds_core/auxbus.c | 20 +- drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/mlx5/cmd.c | 48 +- drivers/vfio/pci/pds/Kconfig | 19 + drivers/vfio/pci/pds/Makefile | 11 + drivers/vfio/pci/pds/cmds.c | 509 ++++++++++++++++ drivers/vfio/pci/pds/cmds.h | 25 + drivers/vfio/pci/pds/dirty.c | 564 ++++++++++++++++++ drivers/vfio/pci/pds/dirty.h | 39 ++ drivers/vfio/pci/pds/lm.c | 434 ++++++++++++++ drivers/vfio/pci/pds/lm.h | 41 ++ drivers/vfio/pci/pds/pci_drv.c | 209 +++++++ drivers/vfio/pci/pds/pci_drv.h | 9 + drivers/vfio/pci/pds/vfio_dev.c | 227 +++++++ drivers/vfio/pci/pds/vfio_dev.h | 39 ++ drivers/vfio/vfio_main.c | 47 ++ include/linux/pds/pds_adminq.h | 375 ++++++++++++ include/linux/pds/pds_common.h | 9 +- include/linux/vfio.h | 3 + 23 files changed, 2654 insertions(+), 65 deletions(-) create mode 100644 Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst create mode 100644 drivers/vfio/pci/pds/Kconfig create mode 100644 drivers/vfio/pci/pds/Makefile create mode 100644 drivers/vfio/pci/pds/cmds.c create mode 100644 drivers/vfio/pci/pds/cmds.h create mode 100644 drivers/vfio/pci/pds/dirty.c create mode 100644 drivers/vfio/pci/pds/dirty.h create mode 100644 drivers/vfio/pci/pds/lm.c create mode 100644 drivers/vfio/pci/pds/lm.h create mode 100644 drivers/vfio/pci/pds/pci_drv.c create mode 100644 drivers/vfio/pci/pds/pci_drv.h create mode 100644 drivers/vfio/pci/pds/vfio_dev.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.h
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 1/8 vfio: Commonize combine_ranges for use in other VFIO drivers
Currently only Mellanox uses the combine_ranges function. The new pds_vfio driver also needs this function. So, move it to a common location for other vendor drivers to use.
Also, fix RCT ordering while moving/renaming the function.
--- drivers/vfio/pci/mlx5/cmd.c | 48 +------------------------------------ drivers/vfio/vfio_main.c | 47 ++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 3 +++ 3 files changed, 51 insertions(+), 47 deletions(-)
drivers/vfio/pci/mlx5/cmd.c +1 -47
@@ -732,52 +732,6 @@ void mlx5fv_cmd_clean_migf_resources(struct mlx5_vf_migration_file *migf)mlx5vf_cmd_dealloc_pd (migf); } -static void combine_ranges (struct rb_root_cached *root,u32 cur_nodes, -u32 req_nodes) -{ -struct interval_tree_node *prev, *curr, *comb_start, *comb_end; -unsigned long min_gap; -unsigned long curr_gap; - -/* Special shortcut when a single range is required */ -if (req_nodes ==1 ) { -unsigned long last; - - curr = comb_start =interval_tree_iter_first (root,0 ,ULONG_MAX ); -while (curr) { - last = curr->last; - prev = curr; - curr =interval_tree_iter_next (curr,0 ,ULONG_MAX ); -if (prev != comb_start) -interval_tree_remove (prev, root); - } - comb_start->last = last; -return ; - } - -/* Combine ranges which have the smallest gap */ -while (cur_nodes > req_nodes) { - prev =NULL ; - min_gap =ULONG_MAX ; - curr =interval_tree_iter_first (root,0 ,ULONG_MAX ); -while (curr) { -if (prev) { - curr_gap = curr->start - prev->last; -if (curr_gap < min_gap) { - min_gap = curr_gap; - comb_start = prev; - comb_end = curr; - } - } - prev = curr; - curr =interval_tree_iter_next (curr,0 ,ULONG_MAX ); - } - comb_start->last = comb_end->last; -interval_tree_remove (comb_end, root); - cur_nodes--; - } -} -static int mlx5vf_create_tracker (struct mlx5_core_dev *mdev,struct mlx5vf_pci_core_device *mvdev,struct rb_root_cached *ranges,u32 nnodes)
@@ -800,7 +754,7 @@ static int mlx5vf_create_tracker(struct mlx5_core_dev *mdev,int i;if (num_ranges > max_num_range) { -combine_ranges (ranges, nnodes, max_num_range); +vfio_combine_iova_ranges (ranges, nnodes, max_num_range); num_ranges = max_num_range; }
drivers/vfio/vfio_main.c +47 -0
53 lines not on this page · raw message
include/linux/vfio.h +3 -0
@@ -283,6 +283,9 @@ int vfio_mig_get_next_state(struct vfio_device *device,enum vfio_device_mig_state new_fsm, enum vfio_device_mig_state *next_fsm); +void vfio_combine_iova_ranges (struct rb_root_cached *root,u32 cur_nodes, +u32 req_nodes); +/* * External user API */
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 2/8 vfio/pds: Initial support for pds VFIO driver
In reply to Brett CreeleyThis is the initial framework for the new pds-vfio-pci device driver. This does the very basics of registering the PDS PCI device and configuring it as a VFIO PCI device.
With this change, the VF device can be bound to the pds-vfio-pci driver on the host and presented to the VM as an ethernet VF.
--- drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/pds/Makefile | 8 ++++ drivers/vfio/pci/pds/pci_drv.c | 68 ++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/vfio_dev.c | 75 +++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/vfio_dev.h | 19 +++++++++ 5 files changed, 172 insertions(+) create mode 100644 drivers/vfio/pci/pds/Makefile create mode 100644 drivers/vfio/pci/pds/pci_drv.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.h
drivers/vfio/pci/Makefile +2 -0
@@ -11,3 +11,5 @@ obj-$(CONFIG_VFIO_PCI) += vfio-pci.o obj-$(CONFIG_MLX5_VFIO_PCI) += mlx5/ obj-$(CONFIG_HISI_ACC_VFIO_PCI) += hisilicon/ + +obj-$(CONFIG_PDS_VFIO_PCI) += pds/
drivers/vfio/pci/pds/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 Advanced Micro Devices, Inc. + +obj-$(CONFIG_PDS_VFIO_PCI) += pds-vfio-pci.o + +pds-vfio-pci-y := \ + pci_drv.o \ + vfio_dev.o
drivers/vfio/pci/pds/pci_drv.c new file +68 -0
68 lines not on this page · raw message
drivers/vfio/pci/pds/vfio_dev.c new file +75 -0
75 lines not on this page · raw message
drivers/vfio/pci/pds/vfio_dev.h new file +19 -0
@@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _VFIO_DEV_H_ +#define _VFIO_DEV_H_ + +#include <linux/pci.h> +#include <linux/vfio_pci_core.h> + +struct pds_vfio_pci_device { +struct vfio_pci_core_device vfio_coredev; + +int vf_id; +}; + +const struct vfio_device_ops *pds_vfio_ops_info (void ); +struct pds_vfio_pci_device *pds_vfio_pci_drvdata (struct pci_dev *pdev); + +#endif /* _VFIO_DEV_H_ */
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 3/8 pds_core: Require callers of register/unregister to pass PF drvdata
In reply to Brett CreeleyPass a pointer to the PF's private data structure rather than bouncing in and out of the PF's PCI function address.
--- drivers/net/ethernet/amd/pds_core/auxbus.c | 20 +++++--------------- include/linux/pds/pds_common.h | 6 ++++-- 2 files changed, 9 insertions(+), 17 deletions(-)
drivers/net/ethernet/amd/pds_core/auxbus.c +5 -15
@@ -14,18 +14,13 @@* Return: 0 on success, or * negative for error */ -int pds_client_register (struct pci_dev *pf_pdev,char *devname) +int pds_client_register (struct pdsc *pf,char *devname) {union pds_core_adminq_comp comp = {};union pds_core_adminq_cmd cmd = {}; -struct pdsc *pf;int err;u16 ci; - pf =pci_get_drvdata (pf_pdev); -if (pf->state) -return -ENXIO ; - cmd.client_reg.opcode =PDS_AQ_CMD_CLIENT_REG ;strscpy (cmd.client_reg.devname, devname,sizeof (cmd.client_reg.devname));
@@ -59,17 +54,12 @@ EXPORT_SYMBOL_GPL(pds_client_register);* Return: 0 on success, or * negative for error */ -int pds_client_unregister (struct pci_dev *pf_pdev,u16 client_id) +int pds_client_unregister (struct pdsc *pf,u16 client_id) {union pds_core_adminq_comp comp = {};union pds_core_adminq_cmd cmd = {}; -struct pdsc *pf;int err; - pf =pci_get_drvdata (pf_pdev); -if (pf->state) -return -ENXIO ; - cmd.client_unreg.opcode =PDS_AQ_CMD_CLIENT_UNREG ; cmd.client_unreg.client_id =cpu_to_le16 (client_id);
@@ -198,7 +188,7 @@ int pdsc_auxbus_dev_del(struct pdsc *cf, struct pdsc *pf) padev = pf->vfs[cf->vf_id].padev;if (padev) { -pds_client_unregister (pf->pdev, padev->client_id); +pds_client_unregister (pf, padev->client_id);auxiliary_device_delete (&padev->aux_dev);auxiliary_device_uninit (&padev->aux_dev); padev->client_id =0 ;
@@ -243,7 +233,7 @@ int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf)*/ snprintf (devname,sizeof (devname),"%s.%s.%d" ,PDS_CORE_DRV_NAME , pf->viftype_status[vt].name, cf->uid); - client_id =pds_client_register (pf->pdev, devname); + client_id =pds_client_register (pf, devname);if (client_id <0 ) { err = client_id; goto out_unlock;
@@ -252,7 +242,7 @@ int pdsc_auxbus_dev_add(struct pdsc *cf, struct pdsc *pf) padev =pdsc_auxbus_dev_register (cf, pf, client_id, pf->viftype_status[vt].name);if (IS_ERR (padev)) { -pds_client_unregister (pf->pdev, client_id); +pds_client_unregister (pf, client_id); err =PTR_ERR (padev); goto out_unlock; }
include/linux/pds/pds_common.h +4 -2
@@ -41,9 +41,11 @@ enum pds_core_vif_types {#define PDS_VDPA_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_VDPA_STR +struct pdsc ; +int pdsc_register_notify (struct notifier_block *nb);void pdsc_unregister_notify (struct notifier_block *nb);void *pdsc_get_pf_struct (struct pci_dev *vf_pdev); -int pds_client_register (struct pci_dev *pf_pdev,char *devname); -int pds_client_unregister (struct pci_dev *pf_pdev,u16 client_id); +int pds_client_register (struct pdsc *pf,char *devname); +int pds_client_unregister (struct pdsc *pf,u16 client_id);#endif /* _PDS_COMMON_H_ */
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 4/8 vfio/pds: register with the pds_core PF
In reply to Brett CreeleyThe pds_core driver will supply adminq services, so find the PF and register with the DSC services.
Use the following commands to enable a VF:
echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs
--- drivers/vfio/pci/pds/Makefile | 1 + drivers/vfio/pci/pds/cmds.c | 54 +++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/cmds.h | 10 ++++++ drivers/vfio/pci/pds/pci_drv.c | 14 +++++++++ drivers/vfio/pci/pds/pci_drv.h | 9 ++++++ drivers/vfio/pci/pds/vfio_dev.c | 13 +++++++- drivers/vfio/pci/pds/vfio_dev.h | 3 ++ include/linux/pds/pds_common.h | 3 +- 8 files changed, 105 insertions(+), 2 deletions(-) create mode 100644 drivers/vfio/pci/pds/cmds.c create mode 100644 drivers/vfio/pci/pds/cmds.h create mode 100644 drivers/vfio/pci/pds/pci_drv.h
drivers/vfio/pci/pds/Makefile +1 -0
@@ -4,5 +4,6 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds-vfio-pci.o pds-vfio-pci-y := \ + cmds.o \ pci_drv.o \ vfio_dev.o
drivers/vfio/pci/pds/cmds.c new file +54 -0
54 lines not on this page · raw message
drivers/vfio/pci/pds/cmds.h new file +10 -0
@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _CMDS_H_ +#define _CMDS_H_ + +int pds_vfio_register_client_cmd (struct pds_vfio_pci_device *pds_vfio); +void pds_vfio_unregister_client_cmd (struct pds_vfio_pci_device *pds_vfio); + +#endif /* _CMDS_H_ */
drivers/vfio/pci/pds/pci_drv.c +14 -0
@@ -8,9 +8,13 @@#include <linux/types.h> #include <linux/vfio.h> +#include <linux/pds/pds_common.h> #include <linux/pds/pds_core_if.h> +#include <linux/pds/pds_adminq.h> #include "vfio_dev.h" +#include "pci_drv.h" +#include "cmds.h" #define PDS_VFIO_DRV_DESCRIPTION "AMD/Pensando VFIO Device Driver"#define PCI_VENDOR_ID_PENSANDO 0x1dd8
@@ -32,8 +36,17 @@ static int pds_vfio_pci_probe(struct pci_dev *pdev,if (err) goto out_put_vdev; + err =pds_vfio_register_client_cmd (pds_vfio); +if (err) { +dev_err (&pdev->dev,"failed to register as client: %pe\n" , +ERR_PTR (err)); + goto out_unregister_coredev; + } +return 0 ; +out_unregister_coredev: +vfio_pci_core_unregister_device (&pds_vfio->vfio_coredev); out_put_vdev:vfio_put_device (&pds_vfio->vfio_coredev.vdev);return err;
@@ -43,6 +56,7 @@ static void pds_vfio_pci_remove(struct pci_dev *pdev) {struct pds_vfio_pci_device *pds_vfio =pds_vfio_pci_drvdata (pdev); +pds_vfio_unregister_client_cmd (pds_vfio);vfio_pci_core_unregister_device (&pds_vfio->vfio_coredev);vfio_put_device (&pds_vfio->vfio_coredev.vdev); }
drivers/vfio/pci/pds/pci_drv.h new file +9 -0
@@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _PCI_DRV_H +#define _PCI_DRV_H + +#include <linux/pci.h> + +#endif /* _PCI_DRV_H */
drivers/vfio/pci/pds/vfio_dev.c +12 -1
@@ -6,6 +6,11 @@#include "vfio_dev.h" +struct pci_dev *pds_vfio_to_pci_dev (struct pds_vfio_pci_device *pds_vfio) +{ +return pds_vfio->vfio_coredev.pdev; +} +struct pds_vfio_pci_device *pds_vfio_pci_drvdata (struct pci_dev *pdev) {struct vfio_pci_core_device *core_device =dev_get_drvdata (&pdev->dev);
@@ -20,7 +25,7 @@ static int pds_vfio_init_device(struct vfio_device *vdev) container_of(vdev, struct pds_vfio_pci_device, vfio_coredev.vdev);struct pci_dev *pdev =to_pci_dev (vdev->dev); -int err, vf_id; +int err, vf_id, pci_id; vf_id =pci_iov_vf_id (pdev);if (vf_id <0 )
@@ -32,6 +37,12 @@ static int pds_vfio_init_device(struct vfio_device *vdev) pds_vfio->vf_id = vf_id; + pci_id =PCI_DEVID (pdev->bus->number, pdev->devfn); +dev_dbg (&pdev->dev, +"%s: PF %#04x VF %#04x vf_id %d domain %d pds_vfio %p\n" , + __func__,pci_dev_id (pdev->physfn), pci_id, vf_id, +pci_domain_nr (pdev->bus), pds_vfio); +return 0 ; }
drivers/vfio/pci/pds/vfio_dev.h +3 -0
@@ -11,9 +11,12 @@ struct pds_vfio_pci_device {struct vfio_pci_core_device vfio_coredev;int vf_id; + u16 client_id; };const struct vfio_device_ops *pds_vfio_ops_info (void );struct pds_vfio_pci_device *pds_vfio_pci_drvdata (struct pci_dev *pdev); +struct pci_dev *pds_vfio_to_pci_dev (struct pds_vfio_pci_device *pds_vfio); +#endif /* _VFIO_DEV_H_ */
include/linux/pds/pds_common.h +2 -1
@@ -34,12 +34,13 @@ enum pds_core_vif_types {#define PDS_DEV_TYPE_CORE_STR "Core"#define PDS_DEV_TYPE_VDPA_STR "vDPA" -#define PDS_DEV_TYPE_VFIO_STR "VFio" +#define PDS_DEV_TYPE_VFIO_STR "vfio"#define PDS_DEV_TYPE_ETH_STR "Eth"#define PDS_DEV_TYPE_RDMA_STR "RDMA"#define PDS_DEV_TYPE_LM_STR "LM"#define PDS_VDPA_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_VDPA_STR +#define PDS_VFIO_LM_DEV_NAME PDS_CORE_DRV_NAME "." PDS_DEV_TYPE_LM_STR "." PDS_DEV_TYPE_VFIO_STRstruct pdsc ;
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 5/8 vfio/pds: Add VFIO live migration support
In reply to Brett CreeleyAdd live migration support via the VFIO subsystem. The migration implementation aligns with the definition from uapi/vfio.h and uses the pds_core PF's adminq for device configuration.
The ability to suspend, resume, and transfer VF device state data is included along with the required admin queue command structures and implementations.
PDS_LM_CMD_SUSPEND and PDS_LM_CMD_SUSPEND_STATUS are added to support the VF device suspend operation.
PDS_LM_CMD_RESUME is added to support the VF device resume operation.
PDS_LM_CMD_STATE_SIZE is added to determine the exact size of the VF device state data.
PDS_LM_CMD_SAVE is added to get the VF device state data.
PDS_LM_CMD_RESTORE is added to restore the VF device with the previously saved data from PDS_LM_CMD_SAVE.
PDS_LM_CMD_HOST_VF_STATUS is added to notify the DSC/firmware when a migration is in/not-in progress from the host's perspective. The DSC/firmware can use this to clear/setup any necessary state related to a migration.
--- drivers/vfio/pci/pds/Makefile | 1 + drivers/vfio/pci/pds/cmds.c | 330 ++++++++++++++++++++++++ drivers/vfio/pci/pds/cmds.h | 8 +- drivers/vfio/pci/pds/lm.c | 434 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/lm.h | 41 +++ drivers/vfio/pci/pds/pci_drv.c | 13 + drivers/vfio/pci/pds/vfio_dev.c | 120 ++++++++- drivers/vfio/pci/pds/vfio_dev.h | 11 + include/linux/pds/pds_adminq.h | 197 +++++++++++++++ 9 files changed, 1153 insertions(+), 2 deletions(-) create mode 100644 drivers/vfio/pci/pds/lm.c create mode 100644 drivers/vfio/pci/pds/lm.h
drivers/vfio/pci/pds/Makefile +1 -0
@@ -5,5 +5,6 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds-vfio-pci.o pds-vfio-pci-y := \ cmds.o \ + lm.o \ pci_drv.o \ vfio_dev.o
drivers/vfio/pci/pds/cmds.c +330 -0
345 lines not on this page · raw message
drivers/vfio/pci/pds/cmds.h +7 -1
@@ -6,5 +6,11 @@int pds_vfio_register_client_cmd (struct pds_vfio_pci_device *pds_vfio);void pds_vfio_unregister_client_cmd (struct pds_vfio_pci_device *pds_vfio); - +int pds_vfio_suspend_device_cmd (struct pds_vfio_pci_device *pds_vfio,u8 type); +int pds_vfio_resume_device_cmd (struct pds_vfio_pci_device *pds_vfio,u8 type); +int pds_vfio_get_lm_state_size_cmd (struct pds_vfio_pci_device *pds_vfio,u64 *size); +int pds_vfio_get_lm_state_cmd (struct pds_vfio_pci_device *pds_vfio); +int pds_vfio_set_lm_state_cmd (struct pds_vfio_pci_device *pds_vfio); +void pds_vfio_send_host_vf_lm_status_cmd (struct pds_vfio_pci_device *pds_vfio, +enum pds_lm_host_vf_status vf_status);#endif /* _CMDS_H_ */
drivers/vfio/pci/pds/lm.c new file +434 -0
434 lines not on this page · raw message
drivers/vfio/pci/pds/lm.h new file +41 -0
41 lines not on this page · raw message
drivers/vfio/pci/pds/pci_drv.c +13 -0
@@ -67,11 +67,24 @@ static const struct pci_device_id pds_vfio_pci_table[] = { };MODULE_DEVICE_TABLE (pci, pds_vfio_pci_table); +static void pds_vfio_pci_aer_reset_done (struct pci_dev *pdev) +{ +struct pds_vfio_pci_device *pds_vfio =pds_vfio_pci_drvdata (pdev); + +pds_vfio_reset (pds_vfio); +} + +static const struct pci_error_handlers pds_vfio_pci_err_handlers = { + .reset_done = pds_vfio_pci_aer_reset_done, + .error_detected = vfio_pci_core_aer_err_detected, +}; +static struct pci_driver pds_vfio_pci_driver = { .name =KBUILD_MODNAME , .id_table = pds_vfio_pci_table, .probe = pds_vfio_pci_probe, .remove = pds_vfio_pci_remove, + .err_handler = &pds_vfio_pci_err_handlers, .driver_managed_dma = true, };
drivers/vfio/pci/pds/vfio_dev.c +119 -1
160 lines not on this page · raw message
drivers/vfio/pci/pds/vfio_dev.h +11 -0
@@ -7,16 +7,27 @@#include <linux/pci.h> #include <linux/vfio_pci_core.h> +#include "lm.h" +struct pds_vfio_pci_device {struct vfio_pci_core_device vfio_coredev; +struct pds_vfio_lm_file *save_file; +struct pds_vfio_lm_file *restore_file; +struct mutex state_mutex;/* protect migration state */ +enum vfio_device_mig_state state; +spinlock_t reset_lock;/* protect reset_done flow */ +u8 deferred_reset; +int vf_id;u16 client_id; };const struct vfio_device_ops *pds_vfio_ops_info (void );struct pds_vfio_pci_device *pds_vfio_pci_drvdata (struct pci_dev *pdev); +void pds_vfio_reset (struct pds_vfio_pci_device *pds_vfio);struct pci_dev *pds_vfio_to_pci_dev (struct pds_vfio_pci_device *pds_vfio); +struct device *pds_vfio_to_dev (struct pds_vfio_pci_device *pds_vfio);#endif /* _VFIO_DEV_H_ */
include/linux/pds/pds_adminq.h +197 -0
215 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v14 vfio 5/8] vfio/pds: Add VFIO live migration support
On Mon, 7 Aug 2023 13:57:52 -0700
Brett Creeley <[email protected]> wrote:
...
Quoted 25 lines
drivers/vfio/pci/pds/cmds.c +25
-0+static int +pds_vfio_suspend_wait_device_cmd (struct pds_vfio_pci_device *pds_vfio) +{ +union pds_core_adminq_cmd cmd = { + .lm_suspend_status = { + .opcode =PDS_LM_CMD_SUSPEND_STATUS , + .vf_id =cpu_to_le16 (pds_vfio->vf_id), + }, + }; +struct device *dev =pds_vfio_to_dev (pds_vfio); +union pds_core_adminq_comp comp = {}; +unsigned long time_limit; +unsigned long time_start; +unsigned long time_done; +int err; + + time_start = jiffies; + time_limit = time_start +HZ *SUSPEND_TIMEOUT_S ; +do { + err =pds_vfio_client_adminq_cmd (pds_vfio, &cmd, &comp, true); +if (err != -EAGAIN ) +break ; + +msleep (SUSPEND_CHECK_INTERVAL_MS ); + }while (time_before (jiffies, time_limit));
drivers/vfio/pci/pds/cmds.c void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio) · line 122
Quoted 10 lines
drivers/vfio/pci/pds/cmds.c +10
-0+ + time_done = jiffies; +dev_dbg (dev,"%s: vf%u: Suspend comp received in %d msecs\n" , __func__, + pds_vfio->vf_id,jiffies_to_msecs (time_done - time_start)); + +/* Check the results */ +if (time_after_eq (time_done, time_limit)) { +dev_err (dev,"%s: vf%u: Suspend comp timeout\n" , __func__, + pds_vfio->vf_id); + err = -ETIMEDOUT ;
If the command completes successfully but exceeds the time limit this turns a success into a failure. Is that desired? Thanks,
Alex
Re: [PATCH v14 vfio 5/8] vfio/pds: Add VFIO live migration support
Quoted 45 lines · Alex Williamson
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Mon, 7 Aug 2023 13:57:52 -0700
Brett Creeley <[email protected]> wrote:
...Quoted 25 lines
drivers/vfio/pci/pds/cmds.c +25
-0+static int +pds_vfio_suspend_wait_device_cmd (struct pds_vfio_pci_device *pds_vfio) +{ +union pds_core_adminq_cmd cmd = { + .lm_suspend_status = { + .opcode =PDS_LM_CMD_SUSPEND_STATUS , + .vf_id =cpu_to_le16 (pds_vfio->vf_id), + }, + }; +struct device *dev =pds_vfio_to_dev (pds_vfio); +union pds_core_adminq_comp comp = {}; +unsigned long time_limit; +unsigned long time_start; +unsigned long time_done; +int err; + + time_start = jiffies; + time_limit = time_start +HZ *SUSPEND_TIMEOUT_S ; +do { + err =pds_vfio_client_adminq_cmd (pds_vfio, &cmd, &comp, true); +if (err != -EAGAIN ) +break ; + +msleep (SUSPEND_CHECK_INTERVAL_MS ); + }while (time_before (jiffies, time_limit));drivers/vfio/pci/pds/cmds.c void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio) · line 122
Quoted 10 lines
drivers/vfio/pci/pds/cmds.c +10
-0+ + time_done = jiffies; +dev_dbg (dev,"%s: vf%u: Suspend comp received in %d msecs\n" , __func__, + pds_vfio->vf_id,jiffies_to_msecs (time_done - time_start)); + +/* Check the results */ +if (time_after_eq (time_done, time_limit)) { +dev_err (dev,"%s: vf%u: Suspend comp timeout\n" , __func__, + pds_vfio->vf_id); + err = -ETIMEDOUT ;If the command completes successfully but exceeds the time limit this turns a success into a failure. Is that desired? Thanks,
Quoted 2 lines
Alex
Yes, this is the desired behavior. Based on the testing we have done and downtime expectations for live migration it seems like the suspend operation timing out after 5 seconds is reasonable behavior. It could succeed, but that could also be the case if the timeout value was 10, 20, 30, or more seconds. Even so, it seems like we don't want to keep spinning in the driver forever and we also don't want to further increase the VM downtime.
Thanks,
Brett
Brett Creeley
maintainerPATCH v14 6/8 vfio/pds: Add support for dirty page tracking
In reply to Brett CreeleyIn order to support dirty page tracking, the driver has to implement the VFIO subsystem's vfio_log_ops. This includes log_start, log_stop, and log_read_and_clear.
All of the tracker resources are allocated and dirty tracking on the device is started during log_start. The resources are cleaned up and dirty tracking on the device is stopped during log_stop. The dirty pages are determined and reported during log_read_and_clear.
In order to support these callbacks admin queue commands are used. All of the adminq queue command structures and implementations are included as part of this patch.
PDS_LM_CMD_DIRTY_STATUS is added to query the current status of dirty tracking on the device. This includes if it's enabled (i.e. number of regions being tracked from the device's perspective) and the maximum number of regions supported from the device's perspective.
PDS_LM_CMD_DIRTY_ENABLE is added to enable dirty tracking on the specified number of regions and their iova ranges.
PDS_LM_CMD_DIRTY_DISABLE is added to disable dirty tracking for all regions on the device.
PDS_LM_CMD_READ_SEQ and PDS_LM_CMD_DIRTY_WRITE_ACK are added to support reading and acknowledging the currently dirtied pages.
--- drivers/vfio/pci/pds/Makefile | 1 + drivers/vfio/pci/pds/cmds.c | 125 +++++++ drivers/vfio/pci/pds/cmds.h | 9 + drivers/vfio/pci/pds/dirty.c | 564 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/dirty.h | 39 +++ drivers/vfio/pci/pds/lm.c | 2 +- drivers/vfio/pci/pds/vfio_dev.c | 12 +- drivers/vfio/pci/pds/vfio_dev.h | 4 + include/linux/pds/pds_adminq.h | 178 ++++++++++ 9 files changed, 932 insertions(+), 2 deletions(-) create mode 100644 drivers/vfio/pci/pds/dirty.c create mode 100644 drivers/vfio/pci/pds/dirty.h
drivers/vfio/pci/pds/Makefile +1 -0
@@ -5,6 +5,7 @@ obj-$(CONFIG_PDS_VFIO_PCI) += pds-vfio-pci.o pds-vfio-pci-y := \ cmds.o \ + dirty.o \ lm.o \ pci_drv.o \ vfio_dev.o
drivers/vfio/pci/pds/cmds.c +125 -0
128 lines not on this page · raw message
drivers/vfio/pci/pds/cmds.h +9 -0
@@ -13,4 +13,13 @@ int pds_vfio_get_lm_state_cmd(struct pds_vfio_pci_device *pds_vfio);int pds_vfio_set_lm_state_cmd (struct pds_vfio_pci_device *pds_vfio);void pds_vfio_send_host_vf_lm_status_cmd (struct pds_vfio_pci_device *pds_vfio,enum pds_lm_host_vf_status vf_status); +int pds_vfio_dirty_status_cmd (struct pds_vfio_pci_device *pds_vfio, +u64 regions_dma,u8 *max_regions, +u8 *num_regions); +int pds_vfio_dirty_enable_cmd (struct pds_vfio_pci_device *pds_vfio, +u64 regions_dma,u8 num_regions); +int pds_vfio_dirty_disable_cmd (struct pds_vfio_pci_device *pds_vfio); +int pds_vfio_dirty_seq_ack_cmd (struct pds_vfio_pci_device *pds_vfio, +u64 sgl_dma,u16 num_sge,u32 offset, +u32 total_len,bool read_seq);#endif /* _CMDS_H_ */
drivers/vfio/pci/pds/dirty.c new file +564 -0
564 lines not on this page · raw message
drivers/vfio/pci/pds/dirty.h new file +39 -0
@@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright(c) 2023 Advanced Micro Devices, Inc. */ + +#ifndef _DIRTY_H_ +#define _DIRTY_H_ + +struct pds_vfio_bmp_info { +unsigned long *bmp; +u32 bmp_bytes; +struct pds_lm_sg_elem *sgl; +dma_addr_t sgl_addr; +u16 num_sge; +}; + +struct pds_vfio_dirty { +struct pds_vfio_bmp_info host_seq; +struct pds_vfio_bmp_info host_ack; +u64 region_size; +u64 region_start; +u64 region_page_size; +bool is_enabled; +}; + +struct pds_vfio_pci_device ; + +bool pds_vfio_dirty_is_enabled (struct pds_vfio_pci_device *pds_vfio); +void pds_vfio_dirty_set_enabled (struct pds_vfio_pci_device *pds_vfio); +void pds_vfio_dirty_set_disabled (struct pds_vfio_pci_device *pds_vfio); +void pds_vfio_dirty_disable (struct pds_vfio_pci_device *pds_vfio, +bool send_cmd); + +int pds_vfio_dma_logging_report (struct vfio_device *vdev,unsigned long iova, +unsigned long length, +struct iova_bitmap *dirty); +int pds_vfio_dma_logging_start (struct vfio_device *vdev, +struct rb_root_cached *ranges,u32 nnodes, +u64 *page_size); +int pds_vfio_dma_logging_stop (struct vfio_device *vdev); +#endif /* _DIRTY_H_ */
drivers/vfio/pci/pds/lm.c +1 -1
@@ -371,7 +371,7 @@ pds_vfio_step_device_state_locked(struct pds_vfio_pci_device *pds_vfio,if (cur ==VFIO_DEVICE_STATE_STOP_COPY && next ==VFIO_DEVICE_STATE_STOP ) {pds_vfio_put_save_file (pds_vfio); -pds_vfio_send_host_vf_lm_status_cmd (pds_vfio,PDS_LM_STA_NONE ); +pds_vfio_dirty_disable (pds_vfio, true);return NULL ; }
drivers/vfio/pci/pds/vfio_dev.c +11 -1
@@ -5,6 +5,7 @@#include <linux/vfio_pci_core.h> #include "lm.h" +#include "dirty.h" #include "vfio_dev.h" struct pci_dev *pds_vfio_to_pci_dev (struct pds_vfio_pci_device *pds_vfio)
@@ -25,7 +26,7 @@ struct pds_vfio_pci_device *pds_vfio_pci_drvdata(struct pci_dev *pdev) vfio_coredev); } -static void pds_vfio_state_mutex_unlock (struct pds_vfio_pci_device *pds_vfio) +void pds_vfio_state_mutex_unlock (struct pds_vfio_pci_device *pds_vfio) { again:spin_lock (&pds_vfio->reset_lock);
@@ -35,6 +36,7 @@ static void pds_vfio_state_mutex_unlock(struct pds_vfio_pci_device *pds_vfio) pds_vfio->state =VFIO_DEVICE_STATE_RUNNING ;pds_vfio_put_restore_file (pds_vfio);pds_vfio_put_save_file (pds_vfio); +pds_vfio_dirty_disable (pds_vfio, false); }spin_unlock (&pds_vfio->reset_lock); goto again;
@@ -117,6 +119,12 @@ static const struct vfio_migration_ops pds_vfio_lm_ops = { .migration_get_data_size = pds_vfio_get_device_state_size }; +static const struct vfio_log_ops pds_vfio_log_ops = { + .log_start = pds_vfio_dma_logging_start, + .log_stop = pds_vfio_dma_logging_stop, + .log_read_and_clear = pds_vfio_dma_logging_report, +}; +static int pds_vfio_init_device (struct vfio_device *vdev) { struct pds_vfio_pci_device *pds_vfio =
@@ -137,6 +145,7 @@ static int pds_vfio_init_device(struct vfio_device *vdev) vdev->migration_flags =VFIO_MIGRATION_STOP_COPY |VFIO_MIGRATION_P2P ; vdev->mig_ops = &pds_vfio_lm_ops; + vdev->log_ops = &pds_vfio_log_ops; pci_id =PCI_DEVID (pdev->bus->number, pdev->devfn); dev_dbg(&pdev->dev,
@@ -175,6 +184,7 @@ static void pds_vfio_close_device(struct vfio_device *vdev)mutex_lock (&pds_vfio->state_mutex);pds_vfio_put_restore_file (pds_vfio);pds_vfio_put_save_file (pds_vfio); +pds_vfio_dirty_disable (pds_vfio, true);mutex_unlock (&pds_vfio->state_mutex);mutex_destroy (&pds_vfio->state_mutex);vfio_pci_core_close_device (vdev);
drivers/vfio/pci/pds/vfio_dev.h +4 -0
@@ -7,6 +7,7 @@#include <linux/pci.h> #include <linux/vfio_pci_core.h> +#include "dirty.h" #include "lm.h" struct pds_vfio_pci_device {
@@ -14,6 +15,7 @@ struct pds_vfio_pci_device {struct pds_vfio_lm_file *save_file;struct pds_vfio_lm_file *restore_file; +struct pds_vfio_dirty dirty;struct mutex state_mutex;/* protect migration state */ enum vfio_device_mig_state state;spinlock_t reset_lock;/* protect reset_done flow */
@@ -23,6 +25,8 @@ struct pds_vfio_pci_device {u16 client_id; }; +void pds_vfio_state_mutex_unlock (struct pds_vfio_pci_device *pds_vfio); +const struct vfio_device_ops *pds_vfio_ops_info (void );struct pds_vfio_pci_device *pds_vfio_pci_drvdata (struct pci_dev *pdev);void pds_vfio_reset (struct pds_vfio_pci_device *pds_vfio);
include/linux/pds/pds_adminq.h +178 -0
202 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
On Mon, 7 Aug 2023 13:57:53 -0700
Brett Creeley <[email protected]> wrote:
...
Quoted 41 lines
drivers/vfio/pci/pds/dirty.c new file +41
-0+static int pds_vfio_dirty_enable (struct pds_vfio_pci_device *pds_vfio, +struct rb_root_cached *ranges,u32 nnodes, +u64 *page_size) +{ +struct pci_dev *pdev = pds_vfio->vfio_coredev.pdev; +struct device *pdsc_dev = &pci_physfn (pdev)->dev; +struct pds_vfio_dirty *dirty = &pds_vfio->dirty; +u64 region_start, region_size, region_page_size; +struct pds_lm_dirty_region_info *region_info; +struct interval_tree_node *node =NULL ; +u8 max_regions =0 , num_regions; +dma_addr_t regions_dma =0 ; +u32 num_ranges = nnodes; +u32 page_count; +u16 len; +int err; + +dev_dbg (&pdev->dev,"vf%u: Start dirty page tracking\n" , + pds_vfio->vf_id); + +if (pds_vfio_dirty_is_enabled (pds_vfio)) +return -EINVAL ; + +/* find if dirty tracking is disabled, i.e. num_regions == 0 */ + err =pds_vfio_dirty_status_cmd (pds_vfio,0 , &max_regions, + &num_regions); +if (err <0 ) { +dev_err (&pdev->dev,"Failed to get dirty status, err %pe\n" , +ERR_PTR (err)); +return err; + }else if (num_regions) { +dev_err (&pdev->dev, +"Dirty tracking already enabled for %d regions\n" , + num_regions); +return -EEXIST ; + }else if (!max_regions) { +dev_err (&pdev->dev, +"Device doesn't support dirty tracking, max_regions %d\n" , + max_regions); +return -EOPNOTSUPP ; + }
drivers/vfio/pci/pds/dirty.c line 228
Quoted 10 lines
drivers/vfio/pci/pds/dirty.c new file +10
-0+ +/* +* Only support 1 region for now. If there are any large gaps in the +* VM's address regions, then this would be a waste of memory as we are +* generating 2 bitmaps (ack/seq) from the min address to the max +* address of the VM's address regions. In the future, if we support +* more than one region in the device/driver we can split the bitmaps +* on the largest address region gaps. We can do this split up to the +* max_regions times returned from the dirty_status command. +*/
Isn't this a pretty unfortunately limitation given QEMU makes a 1TB hole on AMD hosts? Or maybe I misunderstand.
https://gitlab.com/qemu-project/qemu/-/commit/8504f129450b909c88e199ca44facd35d38ba4de
Thanks,
Alex
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 61 lines · Alex Williamson
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Mon, 7 Aug 2023 13:57:53 -0700
Brett Creeley <[email protected]> wrote:
...Quoted 41 lines
drivers/vfio/pci/pds/dirty.c new file +41
-0+static int pds_vfio_dirty_enable (struct pds_vfio_pci_device *pds_vfio, +struct rb_root_cached *ranges,u32 nnodes, +u64 *page_size) +{ +struct pci_dev *pdev = pds_vfio->vfio_coredev.pdev; +struct device *pdsc_dev = &pci_physfn (pdev)->dev; +struct pds_vfio_dirty *dirty = &pds_vfio->dirty; +u64 region_start, region_size, region_page_size; +struct pds_lm_dirty_region_info *region_info; +struct interval_tree_node *node =NULL ; +u8 max_regions =0 , num_regions; +dma_addr_t regions_dma =0 ; +u32 num_ranges = nnodes; +u32 page_count; +u16 len; +int err; + +dev_dbg (&pdev->dev,"vf%u: Start dirty page tracking\n" , + pds_vfio->vf_id); + +if (pds_vfio_dirty_is_enabled (pds_vfio)) +return -EINVAL ; + +/* find if dirty tracking is disabled, i.e. num_regions == 0 */ + err =pds_vfio_dirty_status_cmd (pds_vfio,0 , &max_regions, + &num_regions); +if (err <0 ) { +dev_err (&pdev->dev,"Failed to get dirty status, err %pe\n" , +ERR_PTR (err)); +return err; + }else if (num_regions) { +dev_err (&pdev->dev, +"Dirty tracking already enabled for %d regions\n" , + num_regions); +return -EEXIST ; + }else if (!max_regions) { +dev_err (&pdev->dev, +"Device doesn't support dirty tracking, max_regions %d\n" , + max_regions); +return -EOPNOTSUPP ; + }drivers/vfio/pci/pds/dirty.c line 228
Quoted 10 lines
drivers/vfio/pci/pds/dirty.c new file +10
-0+ +/* +* Only support 1 region for now. If there are any large gaps in the +* VM's address regions, then this would be a waste of memory as we are +* generating 2 bitmaps (ack/seq) from the min address to the max +* address of the VM's address regions. In the future, if we support +* more than one region in the device/driver we can split the bitmaps +* on the largest address region gaps. We can do this split up to the +* max_regions times returned from the dirty_status command. +*/ Isn't this a pretty unfortunately limitation given QEMU makes a 1TB hole on AMD hosts? Or maybe I misunderstand.
Quoted 5 lines
https://gitlab.com/qemu-project/qemu/-/commit/8504f129450b909c88e199ca44facd35d38ba4de
Thanks,
Alex
Yes, this is currently an unfortunate limitation. However, our device is flexible enough to support >1 regions. There has been some work in this area, but we aren't quite there yet. The goal was to get this initial support accepted and submit follow on work to support >1 regions.
Thanks,
Brett
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 64 lines · On Wed, 9 Aug 2023 08:44:44 -0700 Brett Creeley <[email protected]> wrote:
Quoted 63 lines · Alex Williamson
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Mon, 7 Aug 2023 13:57:53 -0700
Brett Creeley <[email protected]> wrote:
...Quoted 41 lines
drivers/vfio/pci/pds/dirty.c new file +41
-0+static int pds_vfio_dirty_enable (struct pds_vfio_pci_device *pds_vfio, +struct rb_root_cached *ranges,u32 nnodes, +u64 *page_size) +{ +struct pci_dev *pdev = pds_vfio->vfio_coredev.pdev; +struct device *pdsc_dev = &pci_physfn (pdev)->dev; +struct pds_vfio_dirty *dirty = &pds_vfio->dirty; +u64 region_start, region_size, region_page_size; +struct pds_lm_dirty_region_info *region_info; +struct interval_tree_node *node =NULL ; +u8 max_regions =0 , num_regions; +dma_addr_t regions_dma =0 ; +u32 num_ranges = nnodes; +u32 page_count; +u16 len; +int err; + +dev_dbg (&pdev->dev,"vf%u: Start dirty page tracking\n" , + pds_vfio->vf_id); + +if (pds_vfio_dirty_is_enabled (pds_vfio)) +return -EINVAL ; + +/* find if dirty tracking is disabled, i.e. num_regions == 0 */ + err =pds_vfio_dirty_status_cmd (pds_vfio,0 , &max_regions, + &num_regions); +if (err <0 ) { +dev_err (&pdev->dev,"Failed to get dirty status, err %pe\n" , +ERR_PTR (err)); +return err; + }else if (num_regions) { +dev_err (&pdev->dev, +"Dirty tracking already enabled for %d regions\n" , + num_regions); +return -EEXIST ; + }else if (!max_regions) { +dev_err (&pdev->dev, +"Device doesn't support dirty tracking, max_regions %d\n" , + max_regions); +return -EOPNOTSUPP ; + }drivers/vfio/pci/pds/dirty.c line 228
Quoted 10 lines
drivers/vfio/pci/pds/dirty.c new file +10
-0+ +/* +* Only support 1 region for now. If there are any large gaps in the +* VM's address regions, then this would be a waste of memory as we are +* generating 2 bitmaps (ack/seq) from the min address to the max +* address of the VM's address regions. In the future, if we support +* more than one region in the device/driver we can split the bitmaps +* on the largest address region gaps. We can do this split up to the +* max_regions times returned from the dirty_status command. +*/ Isn't this a pretty unfortunately limitation given QEMU makes a 1TB hole on AMD hosts? Or maybe I misunderstand.
https://gitlab.com/qemu-project/qemu/-/commit/8504f129450b909c88e199ca44facd35d38ba4de
Quoted 8 lines
Quoted 3 lines
Thanks,
AlexYes, this is currently an unfortunate limitation. However, our device is flexible enough to support >1 regions. There has been some work in this area, but we aren't quite there yet. The goal was to get this initial support accepted and submit follow on work to support >1 regions.
Ok, good that this is temporary.
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
Alex
Jason Gunthorpe
reviewerRe: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 2 lines · Alex Williamson
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
I've looked at it a few times now, I think it is OK, aside from the nvme issue.
Jason
Tian, Kevin
reviewerRE: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 11 lines
From: Jason Gunthorpe <[email protected]>
Sent: Thursday, August 10, 2023 2:06 AMQuoted 2 lines · Alex Williamson
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
I've looked at it a few times now, I think it is OK, aside from the nvme issue.
My only concern is the duplication of backing storage management of the migration file which I didn't take time to review.
If all others are fine to leave it as is then I will not insist.
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 8 lines · Kevin
Quoted 8 lines
From: Jason Gunthorpe <[email protected]>
Sent: Thursday, August 10, 2023 2:06 AMQuoted 2 lines · Alex Williamson
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
Quoted 8 lines
Quoted 3 lines
I've looked at it a few times now, I think it is OK, aside from the nvme issue.
My only concern is the duplication of backing storage management of the migration file which I didn't take time to review.
If all others are fine to leave it as is then I will not insist.
There's leverage now if you feel strongly about it, but code consolidation could certainly come later.
Are either of you willing to provide a R-b?
What are we looking for relative to NVMe? AIUI, the first couple revisions of this series specified an NVMe device ID, then switched to a wildcard, then settled on an Ethernet device ID, all with no obvious changes that would suggest support is limited to a specific device type. I think we're therefore concerned that migration of an NVMe VF could be enabled by overriding/adding device IDs, whereas we'd like to standardize NVMe migration to avoid avoid incompatible implementations.
It's somewhat a strange requirement since we have no expectation of compatibility between vendors for any other device type, but how far are we going to take it? Is it enough that the device table here only includes the Ethernet VF ID or do we want to actively prevent what might be a trivial enabling of migration for another device type because we envision it happening through an industry standard that currently doesn't exist? Sorry if I'm not familiar with the dynamics of the NVMe working group or previous agreements. Thanks,
Alex
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 18 lines · Alex Williamson
Quoted 15 lines · Kevin
Quoted 11 lines
From: Jason Gunthorpe <[email protected]>
Sent: Thursday, August 10, 2023 2:06 AMQuoted 2 lines · Alex Williamson
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
I've looked at it a few times now, I think it is OK, aside from the nvme issue.
My only concern is the duplication of backing storage management of the migration file which I didn't take time to review.
Quoted 6 lines
Quoted 1 line
If all others are fine to leave it as is then I will not insist.
There's leverage now if you feel strongly about it, but code consolidation could certainly come later.
Are either of you willing to provide a R-b?
The code structure is good enough (though I agree with Kevin), so sure:
Quoted 7 lines
What are we looking for relative to NVMe? AIUI, the first couple revisions of this series specified an NVMe device ID, then switched to a wildcard, then settled on an Ethernet device ID, all with no obvious changes that would suggest support is limited to a specific device type. I think we're therefore concerned that migration of an NVMe VF could be enabled by overriding/adding device IDs, whereas we'd like to standardize NVMe migration to avoid avoid incompatible implementations.
Yeah
Quoted 8 lines
It's somewhat a strange requirement since we have no expectation of compatibility between vendors for any other device type, but how far are we going to take it? Is it enough that the device table here only includes the Ethernet VF ID or do we want to actively prevent what might be a trivial enabling of migration for another device type because we envision it happening through an industry standard that currently doesn't exist? Sorry if I'm not familiar with the dynamics of the NVMe working group or previous agreements. Thanks,
I don't really have a solid answer. Christoph and others in the NVMe space are very firm that NVMe related things must go through standards, I think that is their right.
It does not seem good to allow undermining that approach.
On the flip side, if we are going to allow this driver, why are we not letting them enable their full device functionality with all their non-compliant VF/PF combinations? They shouldn't have to hide what they are actually doing just to get merged.
If we want to block anything it should be to block the PCI spec non-compliance of having PF/VF IDs that are different.
Jason
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 49 lines · On Thu, 10 Aug 2023 14:19:40 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 18 lines · Alex Williamson
Quoted 15 lines · Kevin
Quoted 11 lines
From: Jason Gunthorpe <[email protected]>
Sent: Thursday, August 10, 2023 2:06 AMQuoted 2 lines · Alex Williamson
Shameer, Kevin, Jason, Yishai, I'm hoping one or more of you can approve this series as well. Thanks,
I've looked at it a few times now, I think it is OK, aside from the nvme issue.
My only concern is the duplication of backing storage management of the migration file which I didn't take time to review.
Quoted 6 lines
Quoted 1 line
If all others are fine to leave it as is then I will not insist.
There's leverage now if you feel strongly about it, but code consolidation could certainly come later.
Are either of you willing to provide a R-b?
The code structure is good enough (though I agree with Kevin), so sure:
Reviewed-by Jason Gunthorpe <[email protected]>Quoted 7 lines
What are we looking for relative to NVMe? AIUI, the first couple revisions of this series specified an NVMe device ID, then switched to a wildcard, then settled on an Ethernet device ID, all with no obvious changes that would suggest support is limited to a specific device type. I think we're therefore concerned that migration of an NVMe VF could be enabled by overriding/adding device IDs, whereas we'd like to standardize NVMe migration to avoid avoid incompatible implementations.
Yeah
Quoted 8 lines
It's somewhat a strange requirement since we have no expectation of compatibility between vendors for any other device type, but how far are we going to take it? Is it enough that the device table here only includes the Ethernet VF ID or do we want to actively prevent what might be a trivial enabling of migration for another device type because we envision it happening through an industry standard that currently doesn't exist? Sorry if I'm not familiar with the dynamics of the NVMe working group or previous agreements. Thanks,
Quoted 5 lines
I don't really have a solid answer. Christoph and others in the NVMe space are very firm that NVMe related things must go through standards, I think that is their right.
It does not seem good to allow undermining that approach.
If we wanted to enforce something like this the probe function could reject NVMe class devices, but...
Quoted 4 lines
On the flip side, if we are going to allow this driver, why are we not letting them enable their full device functionality with all their non-compliant VF/PF combinations? They shouldn't have to hide what they are actually doing just to get merged.
This. Is it enough that this appears to implement device type agnostic migration support for devices hosted by this distributed services card and NVMe happens to be one of those device types? Is that a high enough bar that this is not simply a vendor specific NVMe migration implementation?
Quoted 2 lines
If we want to block anything it should be to block the PCI spec non-compliance of having PF/VF IDs that are different.
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
This field contains the Device ID that should be presented for every VF to the SI.
VF Device ID may be different from the PF Device ID...
That? Thanks,
Alex
Jason Gunthorpe
reviewerRe: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 9 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
This field contains the Device ID that should be presented for every VF to the SI.
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Jason
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 6 lines · On Thu, 10 Aug 2023 14:43:04 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 4 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
Quoted 8 lines
Quoted 5 lines
This field contains the Device ID that should be presented for every VF to the SI.
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
7.5.1.1.6 Class Code Register (Offset 09h)
...
The field in a PF and its associated VFs must return the same value when read.
Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Alex
Jason Gunthorpe
reviewerRe: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 20 lines · Alex Williamson
Quoted 6 lines · On Thu, 10 Aug 2023 14:43:04 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 4 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
Quoted 8 lines
Quoted 5 lines
This field contains the Device ID that should be presented for every VF to the SI.
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
Quoted 8 lines
7.5.1.1.6 Class Code Register (Offset 09h)
...
The field in a PF and its associated VFs must return the same value when read.Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of the spec then I predict we will see more vendors follow this approach.
Jason
Tian, Kevin
reviewerRE: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 30 lines
From: Jason Gunthorpe <[email protected]>
Sent: Friday, August 11, 2023 2:12 AMQuoted 10 lines · Alex Williamson
Quoted 7 lines · On Thu, 10 Aug 2023 14:43:04 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 5 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
This field contains the Device ID that should be presented for every VF
to the SI.
Quoted 15 lines
Quoted 7 lines
Quoted 4 lines
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
7.5.1.1.6 Class Code Register (Offset 09h)
...
The field in a PF and its associated VFs must return the same value when read.
Quoted 7 lines
Quoted 3 lines
Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of the spec then I predict we will see more vendors follow this approach.
Looks PCI core assumes the class code must be same across VFs (though not cross PF/VF). And it even violates the spec to require Revision ID and Subsystem ID must be same too:
static void pci_read_vf_config_common(struct pci_dev *virtfn)
{
struct pci_dev *physfn = virtfn->physfn;
/*
* Some config registers are the same across all associated VFs.
* Read them once from VF0 so we can skip reading them from the
* other VFs.
*
* PCIe r4.0, sec 9.3.4.1, technically doesn't require all VFs to
* have the same Revision ID and Subsystem ID, but we assume they
* do.
*/
pci_read_config_dword(virtfn, PCI_CLASS_REVISION,
&physfn->sriov->class);
pci_read_config_byte(virtfn, PCI_HEADER_TYPE,
&physfn->sriov->hdr_type);
pci_read_config_word(virtfn, PCI_SUBSYSTEM_VENDOR_ID,
&physfn->sriov->subsystem_vendor);
pci_read_config_word(virtfn, PCI_SUBSYSTEM_ID,
&physfn->sriov->subsystem_device);
}Does AMD distributed card provide multiple PF's each for a class of VF's or a single PF for all VF's?
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 68 lines · Kevin
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Quoted 30 lines
From: Jason Gunthorpe <[email protected]>
Sent: Friday, August 11, 2023 2:12 AMQuoted 10 lines · Alex Williamson
Quoted 7 lines · On Thu, 10 Aug 2023 14:43:04 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 5 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
This field contains the Device ID that should be presented for every VF
to the SI.
Quoted 15 lines
Quoted 7 lines
Quoted 4 lines
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
7.5.1.1.6 Class Code Register (Offset 09h) ... The field in a PF and its associated VFs must return the same value when read.Quoted 7 lines
Quoted 3 lines
Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of the spec then I predict we will see more vendors follow this approach.
Looks PCI core assumes the class code must be same across VFs (though not cross PF/VF). And it even violates the spec to require Revision ID and Subsystem ID must be same too:
static void
pci_read_vf_config_common(struct pci_dev *virtfn){ struct pci_dev *physfn = virtfn->physfn; /* * Some config registers are the same across all associated VFs. * Read them once from VF0 so we can skip reading them from the * other VFs. * * PCIe r4.0, sec 9.3.4.1, technically doesn't require all VFs to * have the same Revision ID and Subsystem ID, but we assume they * do. */ pci_read_config_dword(virtfn, PCI_CLASS_REVISION, &physfn->sriov->class); pci_read_config_byte(virtfn, PCI_HEADER_TYPE, &physfn->sriov->hdr_type); pci_read_config_word(virtfn, PCI_SUBSYSTEM_VENDOR_ID, &physfn->sriov->subsystem_vendor); pci_read_config_word(virtfn, PCI_SUBSYSTEM_ID, &physfn->sriov->subsystem_device); }
Quoted 2 lines
Does AMD distributed card provide multiple PF's each for a class of VF's or a single PF for all VF's?
Hey Kevin,
The AMD Pensando DSC provides multiple PFs for each class of VFs.
All of our production devices will meet the assumptions of the pci core function above that all VFs match VF0 for those common fields.
I've been out for a few days so apologies for the delayed response.
Thanks,
Brett
Tian, Kevin
reviewerRE: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 77 lines
From: Brett Creeley <[email protected]>
Sent: Tuesday, August 15, 2023 2:42 AMQuoted 1 line · Kevin
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Quoted 9 lines
Quoted 9 lines
From: Jason Gunthorpe <[email protected]>
Sent: Friday, August 11, 2023 2:12 AMQuoted 3 lines · Alex Williamson
On Thu, 10 Aug 2023 14:43:04 -0300
Jason Gunthorpe <[email protected]> wrote:Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Alex Williamson
Quoted 6 lines
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
This field contains the Device ID that should be presented for every
VF
Quoted 51 lines
Quoted 16 lines
to the SI.
Quoted 15 lines
Quoted 7 lines
Quoted 4 lines
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
7.5.1.1.6 Class Code Register (Offset 09h) ... The field in a PF and its associated VFs must return the same value when read.Quoted 7 lines
Quoted 3 lines
Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of the spec then I predict we will see more vendors follow this approach.
Looks PCI core assumes the class code must be same across VFs (though not cross PF/VF). And it even violates the spec to require Revision ID and Subsystem ID must be same too:
static void
pci_read_vf_config_common(struct pci_dev *virtfn){ struct pci_dev *physfn = virtfn->physfn; /* * Some config registers are the same across all associated VFs. * Read them once from VF0 so we can skip reading them from the * other VFs. * * PCIe r4.0, sec 9.3.4.1, technically doesn't require all VFs to * have the same Revision ID and Subsystem ID, but we assume they * do. */ pci_read_config_dword(virtfn, PCI_CLASS_REVISION, &physfn->sriov->class); pci_read_config_byte(virtfn, PCI_HEADER_TYPE, &physfn->sriov->hdr_type); pci_read_config_word(virtfn, PCI_SUBSYSTEM_VENDOR_ID, &physfn->sriov->subsystem_vendor); pci_read_config_word(virtfn, PCI_SUBSYSTEM_ID, &physfn->sriov->subsystem_device); }Quoted 2 lines
Does AMD distributed card provide multiple PF's each for a class of VF's or a single PF for all VF's?
Quoted 8 lines
Hey Kevin,
The AMD Pensando DSC provides multiple PFs for each class of VFs. All of our production devices will meet the assumptions of the pci core function above that all VFs match VF0 for those common fields.
I've been out for a few days so apologies for the delayed response.
Sounds good. No more open then. 😊
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
In reply to Jason GunthorpeQuoted 26 lines · On Thu, 10 Aug 2023 15:11:43 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 25 lines · Alex Williamson
Quoted 6 lines · On Thu, 10 Aug 2023 14:43:04 -0300 Jason Gunthorpe <[email protected]> wrote:
Quoted 4 lines · Alex Williamson
PCI Express® Base Specification Revision 6.0.1, pg 1461:
9.3.3.11 VF Device ID (Offset 1Ah)
Quoted 8 lines
Quoted 5 lines
This field contains the Device ID that should be presented for every VF to the SI.
VF Device ID may be different from the PF Device ID...
That? Thanks,
NVMe matches using the class code, IIRC there is language requiring the class code to be the same.
Ok, yes:
7.5.1.1.6 Class Code Register (Offset 09h)
...
The field in a PF and its associated VFs must return the same value when read.
Quoted 6 lines
Quoted 3 lines
Seems limiting, but it's indeed there. We've got a lot of cleanup to do if we're going to start rejecting drivers for devices with PCI spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of the spec then I predict we will see more vendors follow this approach.
The NVMe driver will claim PCI_CLASS_STORAGE_EXPRESS devices, but there are also various vendor/device IDs in the table, some for the purpose of setting driver data with quirks, some not. So I think the spec compliant behavior here would be that the VF replicates the PF class code and we'd simply need to add the vendor/device explicitly to the id table.
TBH, I can see why this spec requirement might get overlooked, it's a rather arbitrary restriction of the VF device. Thanks,
Alex
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
In reply to Jason GunthorpeQuoted 9 lines · Jason Gunthorpe
Quoted 8 lines
It's somewhat a strange requirement since we have no expectation of compatibility between vendors for any other device type, but how far are we going to take it? Is it enough that the device table here only includes the Ethernet VF ID or do we want to actively prevent what might be a trivial enabling of migration for another device type because we envision it happening through an industry standard that currently doesn't exist? Sorry if I'm not familiar with the dynamics of the NVMe working group or previous agreements. Thanks,
Quoted 3 lines
I don't really have a solid answer. Christoph and others in the NVMe space are very firm that NVMe related things must go through standards, I think that is their right.
Yes, anything that uses a class code needs a standardized way of being managed. That is very different from say mlx5 which is obviously controlled by Mellanox.
So I don't think any vfio driver except for the plain passthrough ones should bind anything but very specific PCI IDs.
And AMD really needs to join the NVMe working group where the passthrough work is happening right now. If you need help finding the right persons at AMD to work with NVMe send me a mail offline, I can point you to them.
Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Quoted 21 lines · Christoph Hellwig
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Quoted 9 lines · Jason Gunthorpe
Quoted 8 lines
It's somewhat a strange requirement since we have no expectation of compatibility between vendors for any other device type, but how far are we going to take it? Is it enough that the device table here only includes the Ethernet VF ID or do we want to actively prevent what might be a trivial enabling of migration for another device type because we envision it happening through an industry standard that currently doesn't exist? Sorry if I'm not familiar with the dynamics of the NVMe working group or previous agreements. Thanks,
Quoted 3 lines
I don't really have a solid answer. Christoph and others in the NVMe space are very firm that NVMe related things must go through standards, I think that is their right.
Yes, anything that uses a class code needs a standardized way of being managed. That is very different from say mlx5 which is obviously controlled by Mellanox.
Quoted 7 lines
So I don't think any vfio driver except for the plain passthrough ones should bind anything but very specific PCI IDs.
And AMD really needs to join the NVMe working group where the passthrough work is happening right now. If you need help finding the right persons at AMD to work with NVMe send me a mail offline, I can point you to them.
Hi Christoph,
We have folks at AMD participating in NVMe working groups and are aware of TPARs related to NVMe live migration. We’re checking to be sure they are up to speed on the discussions and will reach out to you if they need help getting further involved.
As I mentioned in another response, I've been out for a few days so apologies for the delayed response.
Thanks for your help,
Brett
Brett Creeley
maintainerPATCH v14 7/8 vfio/pds: Add support for firmware recovery
In reply to Brett CreeleyIt's possible that the device firmware crashes and is able to recover due to some configuration and/or other issue. If a live migration is in progress while the firmware crashes, the live migration will fail. However, the VF PCI device should still be functional post crash recovery and subsequent migrations should go through as expected.
When the pds_core device notices that firmware crashes it sends an event to all its client drivers. When the pds_vfio driver receives this event while migration is in progress it will request a deferred reset on the next migration state transition. This state transition will report failure as well as any subsequent state transition requests from the VMM/VFIO. Based on uapi/vfio.h the only way out of VFIO_DEVICE_STATE_ERROR is by issuing VFIO_DEVICE_RESET. Once this reset is done, the migration state will be reset to VFIO_DEVICE_STATE_RUNNING and migration can be performed.
If the event is received while no migration is in progress (i.e. the VM is in normal operating mode), then no actions are taken and the migration state remains VFIO_DEVICE_STATE_RUNNING.
--- drivers/vfio/pci/pds/pci_drv.c | 114 ++++++++++++++++++++++++++++++++ drivers/vfio/pci/pds/vfio_dev.c | 17 ++++- drivers/vfio/pci/pds/vfio_dev.h | 2 + 3 files changed, 131 insertions(+), 2 deletions(-)
drivers/vfio/pci/pds/pci_drv.c +114 -0
@@ -19,6 +19,113 @@#define PDS_VFIO_DRV_DESCRIPTION "AMD/Pensando VFIO Device Driver"#define PCI_VENDOR_ID_PENSANDO 0x1dd8 +static void pds_vfio_recovery (struct pds_vfio_pci_device *pds_vfio) +{ +bool deferred_reset_needed = false; + +/* +* Documentation states that the kernel migration driver must not +* generate asynchronous device state transitions outside of +* manipulation by the user or the VFIO_DEVICE_RESET ioctl. +* +* Since recovery is an asynchronous event received from the device, +* initiate a deferred reset. Issue a deferred reset in the following +* situations: +* 1. Migration is in progress, which will cause the next step of +* the migration to fail. +* 2. If the device is in a state that will be set to +* VFIO_DEVICE_STATE_RUNNING on the next action (i.e. VM is +* shutdown and device is in VFIO_DEVICE_STATE_STOP). +*/ +mutex_lock (&pds_vfio->state_mutex); +if ((pds_vfio->state !=VFIO_DEVICE_STATE_RUNNING && + pds_vfio->state !=VFIO_DEVICE_STATE_ERROR ) || + (pds_vfio->state ==VFIO_DEVICE_STATE_RUNNING && +pds_vfio_dirty_is_enabled (pds_vfio))) + deferred_reset_needed = true; +mutex_unlock (&pds_vfio->state_mutex); + +/* +* On the next user initiated state transition, the device will +* transition to the VFIO_DEVICE_STATE_ERROR. At this point it's the user's +* responsibility to reset the device. +* +* If a VFIO_DEVICE_RESET is requested post recovery and before the next +* state transition, then the deferred reset state will be set to +* VFIO_DEVICE_STATE_RUNNING. +*/ +if (deferred_reset_needed) { +spin_lock (&pds_vfio->reset_lock); + pds_vfio->deferred_reset = true; + pds_vfio->deferred_reset_state =VFIO_DEVICE_STATE_ERROR ; +spin_unlock (&pds_vfio->reset_lock); + } +} + +static int pds_vfio_pci_notify_handler (struct notifier_block *nb, +unsigned long ecode,void *data) +{ +struct pds_vfio_pci_device *pds_vfio = + container_of(nb, struct pds_vfio_pci_device, nb); +struct device *dev =pds_vfio_to_dev (pds_vfio); +union pds_core_notifyq_comp *event = data; + +dev_dbg (dev,"%s: event code %lu\n" , __func__, ecode); + +/* +* We don't need to do anything for RESET state==0 as there is no notify +* or feedback mechanism available, and it is possible that we won't +* even see a state==0 event since the pds_core recovery is pending. +* +* Any requests from VFIO while state==0 will fail, which will return +* error and may cause migration to fail. +*/ +if (ecode ==PDS_EVENT_RESET ) { +dev_info (dev,"%s: PDS_EVENT_RESET event received, state==%d\n" , + __func__, event->reset.state); +/* +* pds_core device finished recovery and sent us the +* notification (state == 1) to allow us to recover +*/ +if (event->reset.state ==1 ) +pds_vfio_recovery (pds_vfio); + } + +return 0 ; +} + +static int +pds_vfio_pci_register_event_handler (struct pds_vfio_pci_device *pds_vfio) +{ +struct device *dev =pds_vfio_to_dev (pds_vfio); +struct notifier_block *nb = &pds_vfio->nb; +int err; + +if (!nb->notifier_call) { + nb->notifier_call = pds_vfio_pci_notify_handler; + err =pdsc_register_notify (nb); +if (err) { + nb->notifier_call =NULL ; +dev_err (dev, +"failed to register pds event handler: %pe\n" , +ERR_PTR (err)); +return -EINVAL ; + } +dev_dbg (dev,"pds event handler registered\n" ); + } + +return 0 ; +} + +static void +pds_vfio_pci_unregister_event_handler (struct pds_vfio_pci_device *pds_vfio) +{ +if (pds_vfio->nb.notifier_call) { +pdsc_unregister_notify (&pds_vfio->nb); + pds_vfio->nb.notifier_call =NULL ; + } +} +static int pds_vfio_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {
@@ -43,8 +150,14 @@ static int pds_vfio_pci_probe(struct pci_dev *pdev, goto out_unregister_coredev; } + err =pds_vfio_pci_register_event_handler (pds_vfio); +if (err) + goto out_unregister_client; +return 0 ; +out_unregister_client: +pds_vfio_unregister_client_cmd (pds_vfio); out_unregister_coredev:vfio_pci_core_unregister_device (&pds_vfio->vfio_coredev); out_put_vdev:
@@ -56,6 +169,7 @@ static void pds_vfio_pci_remove(struct pci_dev *pdev) {struct pds_vfio_pci_device *pds_vfio =pds_vfio_pci_drvdata (pdev); +pds_vfio_pci_unregister_event_handler (pds_vfio);pds_vfio_unregister_client_cmd (pds_vfio);vfio_pci_core_unregister_device (&pds_vfio->vfio_coredev);vfio_put_device (&pds_vfio->vfio_coredev.vdev);
drivers/vfio/pci/pds/vfio_dev.c +15 -2
@@ -33,11 +33,12 @@ void pds_vfio_state_mutex_unlock(struct pds_vfio_pci_device *pds_vfio)if (pds_vfio->deferred_reset) { pds_vfio->deferred_reset = false;if (pds_vfio->state ==VFIO_DEVICE_STATE_ERROR ) { - pds_vfio->state =VFIO_DEVICE_STATE_RUNNING ;pds_vfio_put_restore_file (pds_vfio);pds_vfio_put_save_file (pds_vfio);pds_vfio_dirty_disable (pds_vfio, false); } + pds_vfio->state = pds_vfio->deferred_reset_state; + pds_vfio->deferred_reset_state =VFIO_DEVICE_STATE_RUNNING ;spin_unlock (&pds_vfio->reset_lock); goto again; }
@@ -49,6 +50,7 @@ void pds_vfio_reset(struct pds_vfio_pci_device *pds_vfio) {spin_lock (&pds_vfio->reset_lock); pds_vfio->deferred_reset = true; + pds_vfio->deferred_reset_state =VFIO_DEVICE_STATE_RUNNING ;if (!mutex_trylock (&pds_vfio->state_mutex)) {spin_unlock (&pds_vfio->reset_lock);return ;
@@ -67,7 +69,14 @@ pds_vfio_set_device_state(struct vfio_device *vdev,struct file *res =NULL ;mutex_lock (&pds_vfio->state_mutex); -while (new_state != pds_vfio->state) { +/* +* only way to transition out of VFIO_DEVICE_STATE_ERROR is via +* VFIO_DEVICE_RESET, so prevent the state machine from running since +* vfio_mig_get_next_state() will throw a WARN_ON() when transitioning +* from VFIO_DEVICE_STATE_ERROR to any other state +*/ +while (pds_vfio->state !=VFIO_DEVICE_STATE_ERROR && + new_state != pds_vfio->state) {enum vfio_device_mig_state next_state; int err = vfio_mig_get_next_state(vdev, pds_vfio->state,
@@ -89,6 +98,9 @@ pds_vfio_set_device_state(struct vfio_device *vdev, } }pds_vfio_state_mutex_unlock (pds_vfio); +/* still waiting on a deferred_reset */ +if (pds_vfio->state ==VFIO_DEVICE_STATE_ERROR ) + res =ERR_PTR (-EIO );return res; }
@@ -169,6 +181,7 @@ static int pds_vfio_open_device(struct vfio_device *vdev)mutex_init (&pds_vfio->state_mutex); pds_vfio->state =VFIO_DEVICE_STATE_RUNNING ; + pds_vfio->deferred_reset_state =VFIO_DEVICE_STATE_RUNNING ;vfio_pci_core_finish_enable (&pds_vfio->vfio_coredev);
drivers/vfio/pci/pds/vfio_dev.h +2 -0
@@ -20,6 +20,8 @@ struct pds_vfio_pci_device {enum vfio_device_mig_state state;spinlock_t reset_lock;/* protect reset_done flow */ u8 deferred_reset; +enum vfio_device_mig_state deferred_reset_state; +struct notifier_block nb;int vf_id;u16 client_id;
Signature · 1 line
2.17.1
Brett Creeley
maintainerPATCH v14 8/8 vfio/pds: Add Kconfig and documentation
In reply to Brett CreeleyAdd Kconfig entries and pds-vfio-pci.rst. Also, add an entry in the MAINTAINERS file for this new driver.
It's not clear where documentation for vendor specific VFIO drivers should live, so just re-use the current amd ethernet location.
--- .../ethernet/amd/pds_vfio_pci.rst | 79 +++++++++++++++++++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 ++ drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/pds/Kconfig | 19 +++++ 5 files changed, 108 insertions(+) create mode 100644 Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst create mode 100644 drivers/vfio/pci/pds/Kconfig
Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst new file +79 -0
@@ -0,0 +1,79 @@ +.. SPDX-License-Identifier: GPL-2.0+ +.. note: can be edited and viewed with /usr/bin/formiko-vim + +========================================================== +PCI VFIO driver for the AMD/Pensando(R) DSC adapter family +========================================================== + +AMD/Pensando Linux VFIO PCI Device Driver +Copyright(c) 2023 Advanced Micro Devices, Inc. + +Overview +======== + +The ``pds-vfio-pci`` module is a PCI driver that supports Live Migration +capable Virtual Function (VF) devices in the DSC hardware. + +Using the device +================ + +The pds-vfio-pci device is enabled via multiple configuration steps and +depends on the ``pds_core`` driver to create and enable SR-IOV Virtual +Function devices. + +Shown below are the steps to bind the driver to a VF and also to the +associated auxiliary device created by the ``pds_core`` driver. This +example assumes the pds_core and pds-vfio-pci modules are already +loaded. + +.. code-block:: bash + :name: example-setup-script + + #!/bin/bash + + PF_BUS="0000:60" + PF_BDF="0000:60:00.0" + VF_BDF="0000:60:00.1" + + # Prevent non-vfio VF driver from probing the VF device + echo 0 > /sys/class/pci_bus/$PF_BUS/device/$PF_BDF/sriov_drivers_autoprobe + + # Create single VF for Live Migration via pds_core + echo 1 > /sys/bus/pci/drivers/pds_core/$PF_BDF/sriov_numvfs + + # Allow the VF to be bound to the pds-vfio-pci driver + echo "pds-vfio-pci" > /sys/class/pci_bus/$PF_BUS/device/$VF_BDF/driver_override + + # Bind the VF to the pds-vfio-pci driver + echo "$VF_BDF" > /sys/bus/pci/drivers/pds-vfio-pci/bind + +After performing the steps above, a file in /dev/vfio/<iommu_group> +should have been created. + + +Enabling the driver +=================== + +The driver is enabled via the standard kernel configuration system, +using the make command:: + + make oldconfig/menuconfig/etc. + +The driver is located in the menu structure at: + + -> Device Drivers + -> VFIO Non-Privileged userspace driver framework + -> VFIO support for PDS PCI devices + +Support +======= + +For general Linux networking support, please use the netdev mailing +list, which is monitored by Pensando personnel:: + + [email protected] + +For more specific support needs, please use the Pensando driver support +email:: + + [email protected]
Documentation/networking/device_drivers/ethernet/index.rst +1 -0
@@ -16,6 +16,7 @@ Contents: altera/altera_tse amd/pds_core amd/pds_vdpa + amd/pds_vfio_pci aquantia/atlantic chelsio/cxgb cirrus/cs89x0
MAINTAINERS +7 -0
@@ -22348,6 +22348,13 @@ S: Maintained P: Documentation/driver-api/vfio-pci-device-specific-driver-acceptance.rst F: drivers/vfio/pci/*/ +VFIO PDS PCI DRIVER +M: Brett Creeley <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst +F: drivers/vfio/pci/pds/ + VFIO PLATFORM DRIVER M: Eric Auger <[email protected]> L: [email protected]
drivers/vfio/pci/Kconfig +2 -0
@@ -63,4 +63,6 @@ source "drivers/vfio/pci/mlx5/Kconfig" source "drivers/vfio/pci/hisilicon/Kconfig" +source "drivers/vfio/pci/pds/Kconfig" + endmenu
drivers/vfio/pci/pds/Kconfig new file +19 -0
@@ -0,0 +1,19 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 Advanced Micro Devices, Inc. + +config PDS_VFIO_PCI + tristate "VFIO support for PDS PCI devices" + depends on PDS_CORE + select VFIO_PCI_CORE + help + This provides generic PCI support for PDS devices using the VFIO + framework. + + More specific information on this driver can be + found in + <file:Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst>. + + To compile this driver as a module, choose M here. The module + will be called pds-vfio-pci. + + If you don't know what to do here, say N.
Signature · 1 line
2.17.1
Quoted 62 lines
-----Original Message-----
From: Brett Creeley [mailto:[email protected]]
Sent: 07 August 2023 21:58
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Shameerali Kolothum Thodi <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: [PATCH v14 vfio 0/8] pds-vfio-pci driverThis is a patchset for a new vendor specific VFIO driver (pds-vfio-pci) for use with the AMD/Pensando Distributed Services Card (DSC). This driver makes use of the
pds_coredriver.This driver will use the
pds_coredevice's adminq as the VFIO control path to the DSC. In order to make adminq calls, the VFIO instance makes use of functions exported by thepds_coredriver.In order to receive events from
pds_core, the pds-vfio-pci driver registers to a private notifier. This is needed for various events that come from the device.An ASCII diagram of a VFIO instance looks something like this and can be used with the VFIO subsystem to provide the VF device VFIO and live migration support.
.------. .-----------------------. | QEMU |--| VM .-------------. | '......' | | Eth VF | | | | .-------------. | | | | SR-IOV VF | | | | '-------------' | | '------------||---------' .--------------. || |/dev/<vfio_fd>| || '--------------' || Host Userspace | || =================================================== || Host Kernel | || .--------. || |vfio-pci| || '--------' || .------------------. || || | | exported API |<----+ || || | '--------------| | || || | | .--------------. || | pds_core |--->| pds-vfio-pci | || '------------------' | '--------------' || || | || || 09:00.0 notifier 09:00.1 || == PCI ===============================================||===== || || || .----------. .----------. || ,-----| PF |----------| VF |-------------------, | '----------' |'----------' VF | | DSC | data/control | | | path | -----------------------------------------------------------
Quoted 3 lines
The pds-vfio-pci driver is targeted to reside in
drivers/vfio/pci/pds. It makes use of and introduces new files in the commoninclude/linux/pdsinclude directory.
Looks fine to me.
For series,
Thanks,
Shameer
Quoted 52 lines
From: Brett Creeley <[email protected]>
Sent: Tuesday, August 8, 2023 4:58 AMThis is a patchset for a new vendor specific VFIO driver (pds-vfio-pci) for use with the AMD/Pensando Distributed Services Card (DSC). This driver makes use of the
pds_coredriver.This driver will use the
pds_coredevice's adminq as the VFIO control path to the DSC. In order to make adminq calls, the VFIO instance makes use of functions exported by thepds_coredriver.In order to receive events from
pds_core, the pds-vfio-pci driver registers to a private notifier. This is needed for various events that come from the device.An ASCII diagram of a VFIO instance looks something like this and can be used with the VFIO subsystem to provide the VF device VFIO and live migration support.
.------. .-----------------------. | QEMU |--| VM .-------------. | '......' | | Eth VF | | | | .-------------. | | | | SR-IOV VF | | | | '-------------' | | '------------||---------' .--------------. || |/dev/<vfio_fd>| || '--------------' || Host Userspace | || =================================================== || Host Kernel | || .--------. || |vfio-pci| || '--------' || .------------------. || || | | exported API |<----+ || || | '--------------| | || || | | .--------------. || | pds_core |--->| pds-vfio-pci | || '------------------' | '--------------' || || | || || 09:00.0 notifier 09:00.1 || == PCI ===============================================||===== || || || .----------. .----------. || ,-----| PF |----------| VF |-------------------, | '----------' |'----------' VF | | DSC | data/control | | | path | -----------------------------------------------------------
Quoted 4 lines
The pds-vfio-pci driver is targeted to reside in
drivers/vfio/pci/pds. It makes use of and introduces new files in the commoninclude/linux/pdsinclude directory.
the series looks good now.
Alex Williamson
AppliedQuoted 39 lines · On Mon, 7 Aug 2023 13:57:47 -0700 Brett Creeley <[email protected]> wrote:
Brett Creeley (8):
vfio: Commonizecombine_rangesfor use in other VFIO drivers vfio/pds: Initial support for pds VFIO driver
pds_core: Require callers of register/unregister to pass PF drvdata vfio/pds: register with thepds_corePF
vfio/pds: Add VFIO live migration support
vfio/pds: Add support for dirty page tracking
vfio/pds: Add support for firmware recovery
vfio/pds: AddKconfigand documentation.../ethernet/amd/pds_vfio_pci.rst | 79 +++ .../device_drivers/ethernet/index.rst | 1 + MAINTAINERS | 7 + drivers/net/ethernet/amd/pds_core/auxbus.c | 20 +- drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/mlx5/cmd.c | 48 +- drivers/vfio/pci/pds/Kconfig | 19 + drivers/vfio/pci/pds/Makefile | 11 + drivers/vfio/pci/pds/cmds.c | 509 ++++++++++++++++ drivers/vfio/pci/pds/cmds.h | 25 + drivers/vfio/pci/pds/dirty.c | 564 ++++++++++++++++++ drivers/vfio/pci/pds/dirty.h | 39 ++ drivers/vfio/pci/pds/lm.c | 434 ++++++++++++++ drivers/vfio/pci/pds/lm.h | 41 ++ drivers/vfio/pci/pds/pci_drv.c | 209 +++++++ drivers/vfio/pci/pds/pci_drv.h | 9 + drivers/vfio/pci/pds/vfio_dev.c | 227 +++++++ drivers/vfio/pci/pds/vfio_dev.h | 39 ++ drivers/vfio/vfio_main.c | 47 ++ include/linux/pds/pds_adminq.h | 375 ++++++++++++ include/linux/pds/pds_common.h | 9 +- include/linux/vfio.h | 3 + 23 files changed, 2654 insertions(+), 65 deletions(-) create mode 100644 Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci.rst create mode 100644 drivers/vfio/pci/pds/Kconfig create mode 100644 drivers/vfio/pci/pds/Makefile create mode 100644 drivers/vfio/pci/pds/cmds.c create mode 100644 drivers/vfio/pci/pds/cmds.h
Quoted 9 lines
create mode 100644 drivers/vfio/pci/pds/dirty.c create mode 100644 drivers/vfio/pci/pds/dirty.h create mode 100644 drivers/vfio/pci/pds/lm.c create mode 100644 drivers/vfio/pci/pds/lm.h create mode 100644 drivers/vfio/pci/pds/pci_drv.c create mode 100644 drivers/vfio/pci/pds/pci_drv.h create mode 100644 drivers/vfio/pci/pds/vfio_dev.c create mode 100644 drivers/vfio/pci/pds/vfio_dev.h
Applied to vfio next branch for v6.6. Thanks!
Alex