Skip to contentSkip to conversation

Fix reserved Feature bits numbering

PATCH Superseded Max Gurtovoy 4 participants 15 messages Aug 1, 2021 – Jan 3, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix reserved Feature bits numbering

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 5c70a3c..e9a32fa 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}
Signature · 1 line
2.21.0
#2 lore raw
In reply to Max Gurtovoy
Quoted 13 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index 5c70a3c..e9a32fa 100644

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 103

Quoted 6 lines
content.tex +1 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 6 lines
content.tex +1 -1
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#3 lore raw
Quoted 18 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index 5c70a3c..e9a32fa 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
Quoted 4 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 103

Quoted 3 lines
content.tex +1 -1
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

Quoted 7 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 7 lines
content.tex +1 -1
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#4 lore raw
Quoted 24 lines · Max Gurtovoy
Quoted 18 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index 5c70a3c..e9a32fa 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
Quoted 4 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 103

Quoted 3 lines
content.tex +1 -1
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Quoted 8 lines
Quoted 8 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 8 lines
content.tex +1 -1
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#5 lore raw
Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy
Quoted 22 lines · Cornelia Huck
Quoted 13 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index 5c70a3c..e9a32fa 100644

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 103

Quoted 6 lines
content.tex +1 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 7 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
content.tex +1 -1
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}
#6 lore raw

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 28 lines · Cornelia Huck
Quoted 26 lines · Max Gurtovoy
Quoted 24 lines · Cornelia Huck
Quoted 17 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue 
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 7 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.
\end{description}

\begin{note}

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#7 lore raw
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Hmm. Is there a git issue for this?

Quoted 56 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 28 lines · Cornelia Huck
Quoted 26 lines · Max Gurtovoy
Quoted 24 lines · Cornelia Huck
Quoted 17 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue 
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 7 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.
\end{description}

\begin{note}

#8 lore raw
Quoted 5 lines · Michael S. Tsirkin
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Hmm. Is there a git issue for this?

Not that I'm aware of. Who should open it ?

Quoted 50 lines
Quoted 50 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 27 lines · Cornelia Huck
Quoted 25 lines · Max Gurtovoy
Quoted 24 lines · Cornelia Huck
Quoted 17 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
   content.tex | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
   \begin{description}
   \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 6 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.
\end{description}

   \begin{note}
#9 lore raw
Quoted 9 lines · Max Gurtovoy
Quoted 5 lines · Michael S. Tsirkin
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Hmm. Is there a git issue for this?

Not that I'm aware of. Who should open it ?

Please do if possible.

Quoted 48 lines
Quoted 48 lines
Quoted 48 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy
Quoted 23 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
   content.tex | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
   \begin{description}
   \item[0 to 23] Feature bits for the specific device type
-\item[24 to 37] Feature bits reserved for extensions to the queue
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 6 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.
\end{description}
\begin{note}

#10 lore raw
Quoted 10 lines · Michael S. Tsirkin
Quoted 7 lines · Max Gurtovoy
Quoted 5 lines · Michael S. Tsirkin
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Hmm. Is there a git issue for this?

Not that I'm aware of. Who should open it ?

Please do if possible.

Done.

Issue #128.

Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 46 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy
Quoted 23 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
    content.tex | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
    \begin{description}
    \item[0 to 23] Feature bits for the specific device type
-\item[24 to 37] Feature bits reserved for extensions to the queue
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 6 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.

    \end{description}
    \begin{note}
#11 lore raw
Quoted 8 lines · Max Gurtovoy
Quoted 6 lines · Michael S. Tsirkin
Quoted 5 lines · Max Gurtovoy
Quoted 4 lines · Michael S. Tsirkin
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Hmm. Is there a git issue for this?

Not that I'm aware of. Who should open it ?

Please do if possible.

Done.

Issue #128.

Thanks and now you follow

https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues

Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 46 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy
Quoted 23 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
    content.tex | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
    \begin{description}
    \item[0 to 23] Feature bits for the specific device type
-\item[24 to 37] Feature bits reserved for extensions to the queue
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 6 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.

    \end{description}
    \begin{note}
#12 lore raw
In reply to Max Gurtovoy
Quoted 8 lines · Max Gurtovoy
Quoted 6 lines · Michael S. Tsirkin
Quoted 5 lines · Max Gurtovoy
Quoted 4 lines · Michael S. Tsirkin
Quoted 3 lines · Max Gurtovoy

Hi MST/Cornelia,
Can you please update on the status of this patch ?
It's open for few months and I'm wondering if there is something wrong with it ?

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line

Hmm. Is there a git issue for this?

Not that I'm aware of. Who should open it ?

Please do if possible.

Done.

Issue #128.

Note that at the moment the issue itself is empty, the only content is in the comments.

Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 46 lines
Quoted 46 lines

-----Original Message-----
From: Michael S. Tsirkin <[email protected]>
Sent: Monday, August 16, 2021 5:40 PM
To: Cornelia Huck <[email protected]>
Cc: Max Gurtovoy <[email protected]>; [email protected]; [email protected]; [email protected]; Oren Duer <[email protected]>
Subject: Re: [virtio-comment] Re: [PATCH 1/1] Fix reserved Feature bits numbering

Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy
Quoted 23 lines · Cornelia Huck
Quoted 16 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
    content.tex | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
content.tex index 5c70a3c..e9a32fa renamed from content.tex +0 -0

100644

content.tex +0 -1
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
    \begin{description}
    \item[0 to 23] Feature bits for the specific device type
-\item[24 to 37] Feature bits reserved for extensions to the queue
Quoted 4 lines

and
+\item[24 to 39] Feature bits reserved for extensions to the queue +and
feature negotiation mechanisms

I'm wondering whether we should do s/reserved/used/ here?

Quoted 6 lines
Quoted 4 lines

I'm just fixing a bug here. You can take this patch and create another one with the above suggestion on top.

I'm ok with your suggestion.

So... any opinions on whether this should get a proper vote? [I won't be able to handle that in the next weeks. Michael?]

Feature bit numbering is an important enough matter that I'd say let's have an issue for this please, and I will do a ballot.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

-\item[38 and above] Feature bits reserved for future extensions. +\item[40 and above] Feature bits reserved for future extensions.

    \end{description}
    \begin{note}
#13 lore raw
In reply to Max Gurtovoy
Quoted 15 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -0
index 5c70a3c..e9a32fa 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -2
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}

Sigh, I just noticed that we also missed to adjust this for the new VIRTIO_F_RING_RESET feature bit :(

Obviously not your fault, but could you please post an updated version for us to vote on?

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#14 lore raw
Quoted 26 lines · Cornelia Huck
Quoted 24 lines · Max Gurtovoy

This should have been updated during VIRTIO_F_NOTIFICATION_DATA and VIRTIO_F_NOTIF_CONFIG_DATA standartization.

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 5c70a3c..e9a32fa 100644
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  \begin{description}
  \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 39] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[40 and above] Feature bits reserved for future extensions.
  \end{description}
 
Quoted 6 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 1 line
content.tex +0 -0
  \begin{note}

Sigh, I just noticed that we also missed to adjust this for the new VIRTIO_F_RING_RESET feature bit :(

Obviously not your fault, but could you please post an updated version for us to vote on?

Yes sure.

Sending v2.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/