Skip to contentSkip to conversation

s390 (8/8): export sys_wait4.

PATCH Pete Zaitcev 2 participants 4 messages Dec 12, 2002

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

+EXPORT_SYMBOL(sys_wait4);

Martin, hold on just a second. Last I checked, sys_wait4 was used ONLY by a moronic code in ipvs, _and_ there was a comment by the author above it "we are too lazy to do it properly". Do you have a better reason to export it?

-- Pete

#1 lore raw
Quoted 6 lines · Pete Zaitcev
Quoted 1 line

+EXPORT_SYMBOL(sys_wait4);

Martin, hold on just a second. Last I checked, sys_wait4 was used ONLY by a moronic code in ipvs, _and_ there was a comment by the author above it "we are too lazy to do it properly". Do you have a better reason to export it?

Guess I'm the malefactor this time since I've sent this patch to Martin after some email exchanges with a guy that wanted LVS to work on a s390. I reckon I will fix the said moronic code to use a syscall wrapper for sys_wait4() so we don't step on anyone's toes.

Regards,
Roberto Nibali, ratz

Signature · 1 line
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq'|dc
#2 lore raw
Quoted 10 lines

Date: Thu, 12 Dec 2002 22:19:21 +0100
From: Roberto Nibali <[email protected]>

Quoted 6 lines
Quoted 1 line

+EXPORT_SYMBOL(sys_wait4);

Martin, hold on just a second. Last I checked, sys_wait4 was used ONLY by a moronic code in ipvs, _and_ there was a comment by the author above it "we are too lazy to do it properly". Do you have a better reason to export it?

Quoted 4 lines

Guess I'm the malefactor this time since I've sent this patch to Martin after some email exchanges with a guy that wanted LVS to work on a s390. I reckon I will fix the said moronic code to use a syscall wrapper for sys_wait4() so we don't step on anyone's toes.

I should not have called it moronic. Everyone has schedule constraints. I am wondering though, if the LVS and ipvs module are maintained actively. Perhaps I owe them a patch.

-- Pete

#3 lore raw
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

+EXPORT_SYMBOL(sys_wait4);

Martin, hold on just a second. Last I checked, sys_wait4 was used ONLY by a moronic code in ipvs, _and_ there was a comment by the author above it "we are too lazy to do it properly". Do you have a better reason to export it?

Guess I'm the malefactor this time since I've sent this patch to Martin after some email exchanges with a guy that wanted LVS to work on a s390. I reckon I will fix the said moronic code to use a syscall wrapper for sys_wait4() so we don't step on anyone's toes.

I should not have called it moronic. Everyone has schedule

Don't worry about it. We haven't always been too kind with lost RH piranha users in the past either ;).

Quoted 2 lines

constraints. I am wondering though, if the LVS and ipvs module are maintained actively. Perhaps I owe them a patch.

LVS and its kernel modules are definitely actively maintained all the way from 2.2.x to 2.5.x kernels and if you want I'll make you a 2.0.x kernel version too. It's just that recently everybody got a bit busy and thus new releases tend to follow each other in increasing time intervals.

A patch would always be very welcome of course.

Best regards,
Roberto Nibali, ratz

Signature · 1 line
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq'|dc