Add ported sensor chip driver: asb100
PATCH 1/1 Add ported sensor chip driver: asb100
Hi Greg,
Please queue this up, hopefully for 2.6.1.
OBTW: OK to *not* copy LKML when I send you patches? Since they're visible when you send them up to Linus it seems redundant...
* * * * *
This patch adds support for the ASB100 Bach sensor chip, which is found on some Asus mainboards. The port corresponds to lm_sensors CVS revision 1.5. The patch applies to and was tested against 2.6.1-rc1.
include/linux/i2c-id.h +1 -0
@@ -154,6 +154,7 @@#define I2C_DRIVERID_W83627HF 1038#define I2C_DRIVERID_LM85 1039#define I2C_DRIVERID_LM83 1040 +#define I2C_DRIVERID_ASB100 1043/* * ---- Adapter types ----------------------------------------------------
drivers/i2c/chips/Kconfig +11 -0
@@ -21,6 +21,17 @@ This driver can also be built as a module. If so, the module will be called adm1021. +config SENSORS_ASB100 + tristate "Asus ASB100 Bach" + depends on I2C && EXPERIMENTAL + select I2C_SENSOR + help + If you say yes here you get support for the ASB100 Bach sensor + chip found on some Asus mainboards. + + This driver can also be built as a module. If so, the module + will be called asb100. + config SENSORS_EEPROM tristate "EEPROM (DIMM) reader" depends on I2C && EXPERIMENTAL
drivers/i2c/chips/Makefile +1 -0
@@ -6,6 +6,7 @@ obj-$(CONFIG_SENSORS_W83781D) += w83781d.o obj-$(CONFIG_SENSORS_ADM1021) += adm1021.o +obj-$(CONFIG_SENSORS_ASB100) += asb100.o obj-$(CONFIG_SENSORS_EEPROM) += eeprom.o obj-$(CONFIG_SENSORS_IT87) += it87.o obj-$(CONFIG_SENSORS_LM75) += lm75.o
drivers/i2c/chips/asb100.c new file +1052 -0
1,052 lines not on this page · raw message
Regards,
Signature · 2 lines
Mark M. Hoffman [email protected]
PATCH 1/1 Add ported sensor chip driver: asb100
Quoted 3 lines · Mark M. Hoffman
Hi Greg,
Please queue this up, hopefully for 2.6.1.
As we are currently on the -rc portion of the 2.6.1 development cycle, I'll wait for this one until 2.6.1 is out, so it will make it into 2.6.2, hopefully. Is that ok?
Quoted 3 lines
OBTW: OK to *not* copy LKML when I send you patches? Since they're visible when you send them up to Linus it seems redundant...
That's fine to do, and probably recommended.
thanks,
greg k-h
PATCH 1/1 Add ported sensor chip driver: asb100
In reply to Mark M. HoffmanQuoted 8 lines · Greg KH
Quoted 3 lines · Mark M. Hoffman
Hi Greg,
Please queue this up, hopefully for 2.6.1.
As we are currently on the -rc portion of the 2.6.1 development cycle, I'll wait for this one until 2.6.1 is out, so it will make it into 2.6.2, hopefully. Is that ok?
Sure. 2.6.1 was wishful thinking on my part.
Quoted 5 lines
Quoted 3 lines
OBTW: OK to *not* copy LKML when I send you patches? Since they're visible when you send them up to Linus it seems redundant...
That's fine to do, and probably recommended.
I'll still cc the sensors list, of course.
Regards,
Signature · 2 lines
Mark M. Hoffman [email protected]
PATCH 1/1 Add ported sensor chip driver: asb100
In reply to Mark M. Hoffmandrivers/i2c/chips/Makefile line 12
Quoted 10 lines
drivers/i2c/chips/Makefile +1
-0@@ -6,6 +6,7 @@ obj-$(CONFIG_SENSORS_W83781D) += w83781d.o obj-$(CONFIG_SENSORS_ADM1021) += adm1021.o +obj-$(CONFIG_SENSORS_ASB100) += asb100.o obj-$(CONFIG_SENSORS_EEPROM) += eeprom.o obj-$(CONFIG_SENSORS_IT87) += it87.o obj-$(CONFIG_SENSORS_LM75) += lm75.o
Shouldn't the asb100 be listed first, the same way the w83781d is, since it has subclients? I would even put asb100 before w83781d, since for now the w83781d driver will try to handle ASB100 chips too, thus preventing the asb100 driver from being used if both drivers are built-in.
Signature · 2 lines
Jean Delvare http://www.ensicaen.ismra.fr/~delvare/
PATCH 1/1 Add ported sensor chip driver: asb100
In reply to Mark M. HoffmanQuoted 4 lines · Jean Delvare
Shouldn't the asb100 be listed first, the same way the w83781d is, since it has subclients? I would even put asb100 before w83781d, since for now the w83781d driver will try to handle ASB100 chips too, thus preventing the asb100 driver from being used if both drivers are built-in.
You're right, thanks. Greg, please apply...
* * * * *
This patch fixes the link order for asb100 sensors chip driver.
drivers/i2c/chips/Makefile renamed from drivers/i2c/chips/Makefile.orig +2 -2
@@ -2,11 +2,11 @@ # Makefile for the kernel hardware sensors chip drivers. # -# w83781d goes first, as it can override other driver's addresses. +# asb100, then w83781d go first, as they can override other drivers' addresses. +obj-$(CONFIG_SENSORS_ASB100) += asb100.o obj-$(CONFIG_SENSORS_W83781D) += w83781d.o obj-$(CONFIG_SENSORS_ADM1021) += adm1021.o -obj-$(CONFIG_SENSORS_ASB100) += asb100.o obj-$(CONFIG_SENSORS_EEPROM) += eeprom.o obj-$(CONFIG_SENSORS_IT87) += it87.o obj-$(CONFIG_SENSORS_LM75) += lm75.o
Signature · 2 lines
Mark M. Hoffman [email protected]
Greg KH
AppliedPATCH 1/1 Add ported sensor chip driver: asb100
In reply to Mark M. HoffmanQuoted 8 lines · Mark M. Hoffman
Hi Greg,
Please queue this up, hopefully for 2.6.1.
OBTW: OK to *not* copy LKML when I send you patches? Since they're visible when you send them up to Linus it seems redundant...
Quoted 6 lines
* * * * *
This patch adds support for the ASB100 Bach sensor chip, which is found on some Asus mainboards. The port corresponds to
lm_sensorsCVS revision 1.5. The patch applies to and was tested against 2.6.1-rc1.
Applied, thanks.
greg k-h
Greg KH
AppliedPATCH 1/1 Add ported sensor chip driver: asb100
In reply to Mark M. HoffmanQuoted 7 lines · Mark M. Hoffman
Quoted 4 lines · Jean Delvare
Shouldn't the asb100 be listed first, the same way the w83781d is, since it has subclients? I would even put asb100 before w83781d, since for now the w83781d driver will try to handle ASB100 chips too, thus preventing the asb100 driver from being used if both drivers are built-in.
Quoted 5 lines
You're right, thanks. Greg, please apply...
* * * * *
This patch fixes the link order for asb100 sensors chip driver.
Applied, thanks.
greg k-h