video/saa6752hs: replace
Subsystems (2)
PATCH 1/1 video/saa6752hs: replace
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/media/video/saa7134/saa6752hs.c +2 -4
@@ -168,13 +168,11 @@ static int saa6752hs_chip_command(struct }// wait a bit -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /100 ); +msleep (10 ); }// delay a bit to let encoder settle -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /20 ); +msleep (50 );// done return status;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors