Skip to contentSkip to conversation

Remove last reference to LDFLAGS_BLOB

PATCH In review Brian Gerst 4 participants 4 messages Oct 20, 2004 – Oct 30, 2004 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove last reference to LDFLAGS_BLOB

Nothing uses LDFLAGS_BLOB anymore, now that the arm binutils are fixed.

--
Brian Gerst

arch/m32r/Makefile +0 -1
diff -urN linux-2.6.9-bk/arch/m32r/Makefile linux/arch/m32r/Makefile
@@ -5,7 +5,6 @@
 LDFLAGS		:=
 OBJCOPYFLAGS	:= -O binary -R .note -R .comment -S
 LDFLAGS_vmlinux	:= -e startup_32
-LDFLAGS_BLOB	:= --format binary --oformat elf32-m32r
 
 CFLAGS += -pipe -fno-schedule-insns
 CFLAGS_KERNEL += -mmodel=medium
usr/initramfs_data.S +0 -22
diff -urN linux-2.6.9-bk/usr/initramfs_data.S linux/usr/initramfs_data.S
@@ -1,28 +1,6 @@
 /*
   initramfs_data includes the compressed binary that is the
   filesystem used for early user space.
-  Note: Older versions of "as" (prior to binutils 2.11.90.0.23
-  released on 2001-07-14) dit not support .incbin.
-  If you are forced to use older binutils than that then the
-  following trick can be applied to create the resulting binary:
-
-
-  ld -m elf_i386  --format binary --oformat elf32-i386 -r \
-  -T initramfs_data.scr initramfs_data.cpio.gz -o initramfs_data.o
-   ld -m elf_i386  -r -o built-in.o initramfs_data.o
-
-  initramfs_data.scr looks like this:
-SECTIONS
-{
-       .init.ramfs : { *(.data) }
-}
-
-  The above example is for i386 - the parameters vary from architectures.
-  Eventually look up LDFLAGS_BLOB in an older version of the
-  arch/$(ARCH)/Makefile to see the flags used before .incbin was introduced.
-
-  Using .incbin has the advantage over ld that the correct flags are set
-  in the ELF header, as required by certain architectures.
 */
 
 .section .init.ramfs,"a"
#1 lore raw
Quoted 1 line · Brian Gerst

Nothing uses LDFLAGS_BLOB anymore, now that the arm binutils are fixed.

No it hasn't. We still have problems with ARM binutils. As I said at the time, forcing us to upgrade _will_ cause major problems.

Essentially, all ARM binutils post 2.11.90 to date remain broken in one way or another.

I should've been stronger to veto the obsolescence of 2.11.90 for kernel building.

Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
#2 lore raw
In reply to Brian Gerst

No, do not remove that initramfs_data.S section!

People with older binutils (like me) rely on it.

Make it obsolete on 2.7.x.

Quoted 48 lines · Brian Gerst

Nothing uses LDFLAGS_BLOB anymore, now that the arm binutils are fixed.

--
Brian Gerst

diff -urN linux-2.6.9-bk/arch/m32r/Makefile linux/arch/m32r/Makefile

arch/m32r/Makefile +0 -1
@@ -5,7 +5,6 @@
 LDFLAGS		:=
 OBJCOPYFLAGS	:= -O binary -R .note -R .comment -S
 LDFLAGS_vmlinux	:= -e startup_32
-LDFLAGS_BLOB	:= --format binary --oformat elf32-m32r
 
 CFLAGS += -pipe -fno-schedule-insns
 CFLAGS_KERNEL += -mmodel=medium

diff -urN linux-2.6.9-bk/usr/initramfs_data.S linux/usr/initramfs_data.S

usr/initramfs_data.S +0 -22
@@ -1,28 +1,6 @@
 /*
   initramfs_data includes the compressed binary that is the
   filesystem used for early user space.
-  Note: Older versions of "as" (prior to binutils 2.11.90.0.23
-  released on 2001-07-14) dit not support .incbin.
-  If you are forced to use older binutils than that then the
-  following trick can be applied to create the resulting binary:
-
-
-  ld -m elf_i386  --format binary --oformat elf32-i386 -r \
-  -T initramfs_data.scr initramfs_data.cpio.gz -o initramfs_data.o
-   ld -m elf_i386  -r -o built-in.o initramfs_data.o
-
-  initramfs_data.scr looks like this:
-SECTIONS
-{
-       .init.ramfs : { *(.data) }
-}
-
-  The above example is for i386 - the parameters vary from architectures.
-  Eventually look up LDFLAGS_BLOB in an older version of the
-  arch/$(ARCH)/Makefile to see the flags used before .incbin was introduced.
-
-  Using .incbin has the advantage over ld that the correct flags are set
-  in the ELF header, as required by certain architectures.
 */
 
 .section .init.ramfs,"a"
#3 lore raw
Quoted 2 lines · Marcelo Tosatti

No, do not remove that initramfs_data.S section!

It's in a comment section??

Anyway for now I only removed the assignment in m32r Makefile.

Sam