ppc: fix build with O=$(output_dir)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · On Thu, Oct 21, 2004 at 05:56:14PM +0000, [email protected] wrote:
ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, [email protected]
[PATCH] ppc: fix build with O=$(output_dir)
Recent changes to
arch/ppc/boot/lib/MakefilecauseCC
arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
Assembler messages:
FATAL: can't createarch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directorywhen building a ppc kernel using O=$(output_dir) with
CONFIG_ZLIB_INFLATE=n, because the $(output_dir)/lib/zlib_inflate directory doesn't get created.
Quoted 6 lines
This patch, which makes
arch/ppc/boot/lib/Makefilecreate the directory if needed, is one fix for the problem.Signed-off-by Roland Dreier <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>
Can we back this out please? As I noted on lkml once I saw this, it still doesn't fix the problem of overwriting files in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c -> ./foo.o looks quite bad (it's 2 calls if we want checker to get invoked, one if we skip doing that). At the end of the thread, both Roland and I were hoping Sam knew of a clever solution to this.
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Quoted 13 lines · On Thu, Oct 21, 2004 at 05:56:14PM +0000, [email protected] wrote:
ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, [email protected]
[PATCH] ppc: fix build with O=$(output_dir)
Recent changes to
arch/ppc/boot/lib/MakefilecauseCC
arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
Assembler messages:
FATAL: can't createarch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directorywhen building a ppc kernel using O=$(output_dir) with
CONFIG_ZLIB_INFLATE=n, because the $(output_dir)/lib/zlib_inflate directory doesn't get created.
Quoted 6 lines
This patch, which makes
arch/ppc/boot/lib/Makefilecreate the directory if needed, is one fix for the problem.Signed-off-by Roland Dreier <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>
Can we back this out please? As I noted on lkml once I saw this, it still doesn't fix the problem of overwriting files in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c -> ./foo.o looks quite bad (it's 2 calls if we want checker to get invoked, one if we skip doing that). At the end of the thread, both Roland and I were hoping Sam knew of a clever solution to this.
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Tom> Can we back this out please? As I noted on lkml once I saw Tom> this, it still doesn't fix the problem of overwriting files Tom> in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit Tom> rules for lib/zlib_inflate/foo.c
-> ./foo.o looks quite bad (it's 2 calls if we want checker to get Tom> invoked, one if we skip doing that). At the end of the Tom> thread, both Roland and I were hoping Sam knew of a clever Tom> solution to this.
I can't really object to backing this out, but I'll just point out that without this patch, in the situations where mainline builds at all, it still overwrites files in lib/zlib_inflate/. (And builds with O=xxx don't work at all)
It might make more sense to leave this patch in for now and beg Sam for a better fix in the future.
Thanks,
Roland