Skip to contentSkip to conversation

ppc: fix build with O=$(output_dir)

PATCH Tom Rini 2 participants 3 messages Oct 21, 2004 – Oct 22, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tom Rini

author
#1 lore raw
Quoted 13 lines · On Thu, Oct 21, 2004 at 05:56:14PM +0000, [email protected] wrote:

ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, [email protected]

[PATCH] ppc: fix build with O=$(output_dir)

Recent changes to arch/ppc/boot/lib/Makefile cause

CC arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
Assembler messages:
FATAL: can't create arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directory

when building a ppc kernel using O=$(output_dir) with CONFIG_ZLIB_INFLATE=n, because the $(output_dir)/lib/zlib_inflate directory doesn't get created.

Quoted 6 lines

This patch, which makes arch/ppc/boot/lib/Makefile create the directory if needed, is one fix for the problem.

Can we back this out please? As I noted on lkml once I saw this, it still doesn't fix the problem of overwriting files in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c -> ./foo.o looks quite bad (it's 2 calls if we want checker to get invoked, one if we skip doing that). At the end of the thread, both Roland and I were hoping Sam knew of a clever solution to this.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
author
#2 lore raw
In reply to a message not in the archive
Quoted 13 lines · On Thu, Oct 21, 2004 at 05:56:14PM +0000, [email protected] wrote:

ChangeSet 1.2040, 2004/10/21 10:56:14-07:00, [email protected]

[PATCH] ppc: fix build with O=$(output_dir)

Recent changes to arch/ppc/boot/lib/Makefile cause

CC arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
Assembler messages:
FATAL: can't create arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directory

when building a ppc kernel using O=$(output_dir) with CONFIG_ZLIB_INFLATE=n, because the $(output_dir)/lib/zlib_inflate directory doesn't get created.

Quoted 6 lines

This patch, which makes arch/ppc/boot/lib/Makefile create the directory if needed, is one fix for the problem.

Can we back this out please? As I noted on lkml once I saw this, it still doesn't fix the problem of overwriting files in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit rules for lib/zlib_inflate/foo.c -> ./foo.o looks quite bad (it's 2 calls if we want checker to get invoked, one if we skip doing that). At the end of the thread, both Roland and I were hoping Sam knew of a clever solution to this.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#3 lore raw

Tom> Can we back this out please? As I noted on lkml once I saw Tom> this, it still doesn't fix the problem of overwriting files Tom> in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit Tom> rules for lib/zlib_inflate/foo.c
-> ./foo.o looks quite bad (it's 2 calls if we want checker to get Tom> invoked, one if we skip doing that). At the end of the Tom> thread, both Roland and I were hoping Sam knew of a clever Tom> solution to this.

I can't really object to backing this out, but I'll just point out that without this patch, in the situations where mainline builds at all, it still overwrites files in lib/zlib_inflate/. (And builds with O=xxx don't work at all)

It might make more sense to leave this patch in for now and beg Sam for a better fix in the future.

Thanks,
Roland