Skip to contentSkip to conversation

drivers/net/* - compile warning cleanup

PATCH In review Stephen Biggs 3 participants 4 messages Feb 14, 2005 – Feb 15, 2005

Subsystems (2)
Network drivers Kernel janitors
lore
Share & tools
lore

Stephen Biggs

author
#0 lore raw

PATCH 9/21 drivers/net/* - compile warning cleanup

Description: compile warning cleanup - silence compiler warning for unused function that is either actually used as a driver function in a table or is truly unused

Signed-off-by Stephen Biggs <[email protected]>
drivers/net/ibmlana.c +1 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/net/ibmlana.c linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c
@@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
 
 static int startslot;		/* counts through slots when probing multiple devices */
 
-static int ibmlana_probe(struct net_device *dev)
+static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
 {
 	int slot, z;
 	int base = 0, irq = 0, iobase = 0, memlen = 0;

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning

On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

drivers/net/ibmlana.c static void ibmlana_set_multicast_list(s · line 904

Quoted 11 lines

Description: compile warning cleanup - silence compiler warning for unused function that is either actually used as a driver function in a table or is truly unused

+++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200

drivers/net/ibmlana.c +1 -1
@@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
 
 static int startslot;		/* counts through slots when probing multiple devices */
 
-static int ibmlana_probe(struct net_device *dev)
+static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)

It's called in init_module(). I guess you only tried this in the built-in case ?

Dave

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw

Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning

In reply to Stephen Biggs
Quoted 9 lines · Dave Jones

On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 7 lines

Description: compile warning cleanup - silence compiler warning for unused function that is either actually used as a driver function in a table or is truly unused

+++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200

(quoted diff) +0 -0
@@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
Quoted 6 lines

drivers/net/ibmlana.c static void ibmlana_set_multicast_list(s · line 904

Quoted 4 lines
drivers/net/ibmlana.c +1 -1
 static int startslot;		/* counts through slots when probing multiple devices */
 
-static int ibmlana_probe(struct net_device *dev)
+static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)

It's called in init_module(). I guess you only tried this in the built-in case ?

It compiles both with allyesconfig and allmodconfig. The "unused" attribute is a better solution than #ifdef MODULE.

Please consider applying.

Quoted 4 lines

Dave

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw

Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning

In reply to Stephen Biggs

On Tue, Feb 15, 2005 at 08:42:55AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 13 lines · Dave Jones
Quoted 12 lines · Stephen Biggs

Content-Description: Mail message body

Quoted 9 lines

Description: compile warning cleanup - silence compiler warning for unused function that is either actually used as a driver function in a table or is truly unused

+++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200

drivers/net/ibmlana.c +0 -0
@@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
 
 static int startslot;		/* counts through slots when probing multiple devices */
Quoted 7 lines
Quoted 4 lines

drivers/net/ibmlana.c static void ibmlana_set_multicast_list(s · line 904

Quoted 2 lines
drivers/net/ibmlana.c +1 -1
-static int ibmlana_probe(struct net_device *dev)
+static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)

It's called in init_module(). I guess you only tried this in the built-in case ?

It compiles both with allyesconfig and allmodconfig. The "unused" attribute is a better solution than #ifdef MODULE.

It's not. It's a big mess.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors