Skip to content

compile warning cleanup

Stephen Biggs kernel-janitors 1 version In review

Get series with b4
b4 am 42113C2B.13655.52B883@localhost

Versions newest first

  1. v1 Latest20 of 21 patches 12 repliesIn review

20 of 21 patches are in this archive. The cover letter announces 21.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21arch/i386/math-emu/* - compile warningarch/i386/math-emu/fpu_entry.c arch/i386/math-emu/reg_ld_str.c+44 -110 replies
2/21drivers/block/* - compile warningdrivers/block/cciss_scsi.c+2 -11 reply
3/21drivers/char/* - compile warningdrivers/char/mxser.c+0 -10 replies
4/21drivers/ide/* - compile warning cleanupdrivers/ide/ide-tape.c+13 -20 replies
5/21drivers/isdn/hisax/* - compile warningdrivers/isdn/hisax/config.c+12 -20 replies
6/21drivers/isdn/i4l/* - compile warningdrivers/isdn/i4l/isdn_common.c drivers/isdn/i4l/isdn_ppp.c drivers/isdn/i4l/isdn_v110.c+8 -30 replies
7/21drivers/isdn/pcbit/* - compile warningdrivers/isdn/pcbit/drv.c+9 -60 replies
8/21drivers/isdn/sc/* - compile warningdrivers/isdn/sc/init.c drivers/isdn/sc/shmem.c+7 -70 replies
9/21drivers/net/* - compile warning cleanupdrivers/net/ibmlana.c+1 -13 replies
10/21drivers/net/tulip/* - compile warningdrivers/net/tulip/dmfe.c+2 -20 replies
11/21drivers/scsi/* - compile warningdrivers/scsi/53c700.h drivers/scsi/BusLogic.c drivers/scsi/NCR5380.c +10 more+102 -724 replies
12/21drivers/scsi/aic7xxx/* - compiledrivers/scsi/aic7xxx/aic79xx_osm.c drivers/scsi/aic7xxx/aic7xxx_osm.c+4 -20 replies
14/21drivers/telephony/* - compile warningdrivers/telephony/ixj.c drivers/telephony/ixj.h+2 -112 replies
15/21drivers/usb/image/* - compile warningdrivers/usb/image/microtek.c+6 -20 replies
16/21fs/* - compile warning cleanupfs/binfmt_elf.c+9 -40 replies
17/21include/linux/* - compile warninginclude/linux/ixjuser.h include/linux/module.h+4 -22 replies
18/21kernel/* - compile warning cleanupkernel/module.c+4 -10 replies
19/21kernel/* - compile warning cleanupnet/ipv6/ip6_flowlabel.c+7 -30 replies
20/21sound/oss/emu10k1/* - compile warningsound/oss/emu10k1/cardwi.c sound/oss/emu10k1/passthrough.c+18 -70 replies
21/21sound/usb/usx2y/* - compile warningsound/usb/usx2y/usbusx2yaudio.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [KJ] [PATCH][RESUBMIT][0/21] compile warning cleanup

Hello all,

After taking into consideration all of the fine feedback I received from my first ever attempt at submitting a series of patches, I am now applying this feedback and am submitting patches that will hopefully pass the test and be applied.

I am resubmitting the entire series, even those that did not receive any feedback at all and are unchanged, since I received no notification that they were to be applied.

I have created these patches against the linux-2.6.11-rc3-mm2 tree since, while I am aware of the 2.6.11-rc4 patch, there is no corresponding patch for the -mm tree. Is this the right way to go? If not, please advise and I'll resubmit yet again.

Please note my solution (patch #17 in this series) to the unused table structures in some poorly written drivers that always assume that they will be compiled as modules. I changed include/linux/modules.h to create an alias to remove the warning. This works for all the compilation. The advantages to this patch are 1:, that it removes the warnings, and 2:, the source files themselves do not have to be changed because of this problem. The disadvantages are 1:, it removes the warning so a module writer will not be apprised of the fact that there is a minor problem, and 2, it pollutes the global name space. The patch also keeps the same status as before with the warning, that is, it still compiles the table into the code, so the kernel will drag around this unused data.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors