drivers/telephony/* - compile warning
PATCH 14/21 drivers/telephony/* - compile warning
Description: compile warning cleanup - remove unmaintained rcs char strings from source and handle the occurrences of their use
drivers/telephony/ixj.c +2 -9
@@ -41,9 +41,6 @@* ***************************************************************************/ -static char ixj_c_rcsid[] ="$Id: ixj.c,v 4.7 2001/08/13 06:19:33 craigs Exp $" ; -static char ixj_c_revision[] ="$Revision: 4.7 $" ; -/* * $Log: ixj.c,v $ *
@@ -6172,8 +6169,7 @@ static int ixj_ioctl(struct inode *inode retval = j->serial;break ;case IXJCTL_VERSION : -if (copy_to_user (argp, ixj_c_revision,strlen (ixj_c_revision))) - retval = -EFAULT ; +sprintf (argp,"\nDriver version %i.%i.%i" ,IXJ_VER_MAJOR ,IXJ_VER_MINOR ,IXJ_BLD_VER );break ;case PHONE_RING_CADENCE : j->ring_cadence = arg;
@@ -7168,9 +7164,6 @@ static int ixj_get_status_proc(char *bufint cnt;IXJ *j; len =0 ; - len +=sprintf (buf + len,"%s" , ixj_c_rcsid); - len +=sprintf (buf + len,"\n%s" , ixj_h_rcsid); - len +=sprintf (buf + len,"\n%s" , ixjuser_h_rcsid); len +=sprintf (buf + len,"\nDriver version %i.%i.%i" ,IXJ_VER_MAJOR ,IXJ_VER_MINOR ,IXJ_BLD_VER ); len +=sprintf (buf + len,"\nsizeof IXJ struct %Zd bytes" ,sizeof (IXJ )); len +=sprintf (buf + len,"\nsizeof DAA struct %Zd bytes" ,sizeof (DAA_REGS ));
@@ -7790,7 +7783,7 @@ static int __init ixj_init(void)if ((probe =ixj_probe_pci (&cnt)) <0 ) {return probe; } -printk ("%s\n" , ixj_c_rcsid); +printk (KERN_INFO "ixj driver initialized.\n" );create_proc_read_entry ("ixj" ,0 ,NULL , ixj_read_proc,NULL );return probe; }
drivers/telephony/ixj.h +0 -2
@@ -38,8 +38,6 @@* TO PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. * *****************************************************************************/ -static char ixj_h_rcsid[] ="$Id: ixj.h,v 4.1 2001/08/04 14:49:27 craigs Exp $" ; -#define IXJ_VERSION 3031#include <linux/version.h>
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Re: [KJ] [PATCH][RESUBMIT][14/21] drivers/telephony/* - compile
drivers/telephony/ixj.c static int ixj_ioctl(struct inode *inode · line 6172
Quoted 6 lines · Stephen Biggs
drivers/telephony/ixj.c +1
-2-if (copy_to_user (argp, ixj_c_revision,strlen (ixj_c_revision))) - retval = -EFAULT ; +sprintf (argp,"\nDriver version %i.%i.%i" ,IXJ_VER_MAJOR ,IXJ_VER_MINOR ,IXJ_BLD_VER );
argp is a userspace pointer. You _can't_ simply write to it.
char tmpbuf[...]; sprintf(tmpbuf, "version %i ...", MAJOR, ...); if (copy_to_user(argp, tmpbuf, ...)) ... Alexey
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Re: [KJ] [PATCH][RESUBMIT][14/21] drivers/telephony/* - compile
In reply to Stephen BiggsQuoted 10 lines · Alexey Dobriyan
drivers/telephony/ixj.c static int ixj_ioctl(struct inode *inode · line 6172
Quoted 6 lines · Stephen Biggs
drivers/telephony/ixj.c +1
-2-if (copy_to_user (argp, ixj_c_revision,strlen (ixj_c_revision))) - retval = -EFAULT ; +sprintf (argp,"\nDriver version %i.%i.%i" ,IXJ_VER_MAJOR ,IXJ_VER_MINOR ,IXJ_BLD_VER );argp is a userspace pointer. You _can't_ simply write to it.
*** ARRGGH *** Yes... I just simply screwed up on this one... sorry for the noise to the list!
Quoted 9 lines
char tmpbuf[...]; sprintf(tmpbuf, "version %i ...", MAJOR, ...); if (copy_to_user(argp, tmpbuf, ...)) ... Alexey
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors