Skip to contentSkip to conversation

include/linux/* - compile warning

PATCH In review Stephen Biggs 2 participants 3 messages Feb 14, 2005 – Feb 15, 2005

Subsystems (2)
Kernel janitors Module support
lore
Share & tools
lore

Stephen Biggs

author
#0 lore raw

PATCH 17/21 include/linux/* - compile warning

Description: compile warning cleanup - remove unmaintained rcs char string, extinguish warning for module structure that is still live when module is compiled into the kernel

Signed-off-by Stephen Biggs <[email protected]>
include/linux/ixjuser.h +0 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm2/include/linux/ixjuser.h
@@ -42,7 +42,6 @@
  *
  *****************************************************************************/
 
-static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
 
 #include <linux/telephony.h>
include/linux/module.h +4 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h
@@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
 extern struct module __this_module;
 #define THIS_MODULE (&__this_module)
 #else  /* !MODULE */
-#define MODULE_GENERIC_TABLE(gtype,name)
+#define MODULE_GENERIC_TABLE(gtype,name)			\
+extern const struct gtype##_id __not_mod_##name##_unused	\
+  __attribute__ ((unused, weak, alias(__stringify(name))))
+
 #define THIS_MODULE ((struct module *)0)
 #endif

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 4 lines · Stephen Biggs

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h

include/linux/module.h extern const struct gtype##_id __mod_##g · line 92

Quoted 10 lines
include/linux/module.h +4 -1
@@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
 extern struct module __this_module;
 #define THIS_MODULE (&__this_module)
 #else  /* !MODULE */
-#define MODULE_GENERIC_TABLE(gtype,name)
+#define MODULE_GENERIC_TABLE(gtype,name)			\
+extern const struct gtype##_id __not_mod_##name##_unused	\
+  __attribute__ ((unused, weak, alias(__stringify(name))))
+
 #define THIS_MODULE ((struct module *)0)
 #endif

Yeah, nice job with this.

But split it out into a separate patch (remember, one patch per individual "thing" you want to change.)

thanks,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw
In reply to Stephen Biggs
Quoted 18 lines · Greg KH
Quoted 4 lines · Stephen Biggs

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/include/linux/module.h linux-2.6.11-rc3-mm2/include/linux/module.h

include/linux/module.h extern const struct gtype##_id __mod_##g · line 92

Quoted 10 lines
include/linux/module.h +4 -1
@@ -84,7 +84,10 @@ extern const struct gtype##_id __mod_##g
 extern struct module __this_module;
 #define THIS_MODULE (&__this_module)
 #else  /* !MODULE */
-#define MODULE_GENERIC_TABLE(gtype,name)
+#define MODULE_GENERIC_TABLE(gtype,name)			\
+extern const struct gtype##_id __not_mod_##name##_unused	\
+  __attribute__ ((unused, weak, alias(__stringify(name))))
+
 #define THIS_MODULE ((struct module *)0)
 #endif

Yeah, nice job with this.

Quoted 2 lines

But split it out into a separate patch (remember, one patch per individual "thing" you want to change.)

Done.

Quoted 5 lines

thanks,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors