Skip to contentSkip to conversation

fix hang on Qube2700 boot

PATCH Applied Peter Horton 2 participants 4 messages Apr 10, 2005 – Apr 11, 2005 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 fix hang on Qube2700 boot

The Qube2700 boot hangs because the old "prom" style console is unconditionally enabled. Drop the "prom" console code from the build. It would only be used if no "console=" line was supplied and in that case the current 8250 code defaults to using ttyS0 at 9600 anyway (assuming a port exists).

--

arch/mips/cobalt/Makefile +1 -1
Index: linux/arch/mips/cobalt/Makefile
===================================================================
@@ -2,6 +2,6 @@
 # Makefile for the Cobalt micro systems family specific parts of the kernel
 #
 
-obj-y	 := irq.o int-handler.o reset.o setup.o promcon.o
+obj-y	 := irq.o int-handler.o reset.o setup.o
 
 EXTRA_AFLAGS := $(CFLAGS)
#1 lore raw
Quoted 5 lines · Peter Horton

The Qube2700 boot hangs because the old "prom" style console is unconditionally enabled. Drop the "prom" console code from the build. It would only be used if no "console=" line was supplied and in that case the current 8250 code defaults to using ttyS0 at 9600 anyway (assuming a port exists).

Ok, applied - but that leaves the unused arch/mips/cobalt/promcon.c around. Guess it should die as well?

Ralf

#2 lore raw
Quoted 12 lines · Ralf Baechle
Quoted 7 lines · Peter Horton

The Qube2700 boot hangs because the old "prom" style console is unconditionally enabled. Drop the "prom" console code from the build. It would only be used if no "console=" line was supplied and in that case the current 8250 code defaults to using ttyS0 at 9600 anyway (assuming a port exists).

Quoted 5 lines

Ok, applied - but that leaves the unused arch/mips/cobalt/promcon.c around. Guess it should die as well?

Yep, probably. It was handy for debugging very early boot, but it's not worth cluttering the tree with it.

P.

#3 lore raw
Quoted 5 lines · Peter Horton
Quoted 3 lines

Ok, applied - but that leaves the unused arch/mips/cobalt/promcon.c around. Guess it should die as well?

Yep, probably. It was handy for debugging very early boot, but it's not worth cluttering the tree with it.

Theese days it'd probably be a matter of days until one self-proclaimed code police man's scripts would notice and send a patch ;-)

Ralf