Skip to contentSkip to conversation

dell_rbu driver depends on x86[64]

PATCH Dave Jones 2 participants 5 messages Nov 18, 2005 – Nov 19, 2005

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

This driver only appears on IA32 & EM64T boxes.

drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
@@ -60,6 +60,7 @@ config EFI_PCDP
 
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your
#1 lore raw
Quoted 8 lines · Dave Jones

This driver only appears on IA32 & EM64T boxes.

drivers/firmware/Kconfig config EFI_PCDP · line 66

Quoted 7 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
@@ -60,6 +60,7 @@ config EFI_PCDP
 
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your

Does it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.

author
#2 lore raw
Quoted 10 lines · Andrew Morton
Quoted 9 lines · Dave Jones

This driver only appears on IA32 & EM64T boxes.

drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +0 -0
@@ -60,6 +60,7 @@ config EFI_PCDP
 
Quoted 9 lines

drivers/firmware/Kconfig config EFI_PCDP · line 66

Quoted 6 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your

Does it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.

If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.

Dave

#3 lore raw
Quoted 22 lines · Dave Jones
Quoted 10 lines · Andrew Morton
Quoted 9 lines · Dave Jones

This driver only appears on IA32 & EM64T boxes.

drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +0 -0
@@ -60,6 +60,7 @@ config EFI_PCDP
 
Quoted 9 lines

drivers/firmware/Kconfig config EFI_PCDP · line 66

Quoted 6 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your

Does it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.

Quoted 5 lines

If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.

Where's the advantage in removing it from non-x86 builds?

author
#4 lore raw
Quoted 23 lines · Andrew Morton
Quoted 22 lines · Dave Jones
Quoted 19 lines · Andrew Morton
Quoted 8 lines · Dave Jones

This driver only appears on IA32 & EM64T boxes.

drivers/firmware/Kconfig config EFI_PCDP · line 66

Quoted 7 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
@@ -60,6 +60,7 @@ config EFI_PCDP
 
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your

Does it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.

Quoted 6 lines
Quoted 4 lines

If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.

Where's the advantage in removing it from non-x86 builds?

One less pointless option showing up in configs.
Just like we don't have countless other arch-specific drivers showing up under non-native archs. Why is this one different ?

Dave