dell_rbu driver depends on x86[64]
This driver only appears on IA32 & EM64T boxes.
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1 -0
@@ -60,6 +60,7 @@ config EFI_PCDP config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" + depends on X86 select FW_LOADER help Say m if you want to have the option of updating the BIOS for your
Quoted 8 lines · Dave Jones
This driver only appears on IA32 & EM64T boxes.
Signed-off-by Dave Jones <[email protected]>
drivers/firmware/Kconfig config EFI_PCDP · line 66
Quoted 7 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1
-0@@ -60,6 +60,7 @@ config EFI_PCDP config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" + depends on X86 select FW_LOADER help Say m if you want to have the option of updating the BIOS for your
Does it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.
Quoted 10 lines · Andrew Morton
Quoted 9 lines · Dave Jones
This driver only appears on IA32 & EM64T boxes.
Signed-off-by Dave Jones <[email protected]>drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +0
-0@@ -60,6 +60,7 @@ config EFI_PCDP
Quoted 9 lines
drivers/firmware/Kconfig config EFI_PCDP · line 66
Quoted 6 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1
-0config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" + depends on X86 select FW_LOADER help Say m if you want to have the option of updating the BIOS for yourDoes it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.
If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.
Dave
Quoted 22 lines · Dave Jones
Quoted 10 lines · Andrew Morton
Quoted 9 lines · Dave Jones
This driver only appears on IA32 & EM64T boxes.
Signed-off-by Dave Jones <[email protected]>drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +0
-0@@ -60,6 +60,7 @@ config EFI_PCDPQuoted 9 lines
drivers/firmware/Kconfig config EFI_PCDP · line 66
Quoted 6 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1
-0config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" + depends on X86 select FW_LOADER help Say m if you want to have the option of updating the BIOS for yourDoes it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.
Quoted 5 lines
If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.
Where's the advantage in removing it from non-x86 builds?
Quoted 23 lines · Andrew Morton
Quoted 22 lines · Dave Jones
Quoted 19 lines · Andrew Morton
Quoted 8 lines · Dave Jones
This driver only appears on IA32 & EM64T boxes.
Signed-off-by Dave Jones <[email protected]>drivers/firmware/Kconfig config EFI_PCDP · line 66
Quoted 7 lines
drivers/firmware/Kconfig renamed from drivers/firmware/Kconfig~ +1
-0@@ -60,6 +60,7 @@ config EFI_PCDP config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" + depends on X86 select FW_LOADER help Say m if you want to have the option of updating the BIOS for yourDoes it not compile on other architectures? If it does, there's an argument for leaving it there, for compile coverage.
Quoted 6 lines
Quoted 4 lines
If this were a "only works on non-x86" driver, I'd agree, but x86 drivers probably get way more coverage than any arch already, so I don't we really gain much by having this available on archs that can't run it.
Where's the advantage in removing it from non-x86 builds?
One less pointless option showing up in configs.
Just like we don't have countless other arch-specific drivers showing up under non-native archs. Why is this one different ?
Dave