Skip to contentSkip to conversation

2.6.16rc1 ia64 missing symbol..

PATCH In review Dave Jones 3 participants 7 messages Jan 17, 2006 – Jan 20, 2006

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

CONFIG_SERIAL_SGI_IOC3=m
CONFIG_SGI_IOC3=m

Dave

#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Dave" == Dave Jones <[email protected]> writes:

Dave> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol Dave> ioc3_unregister_submodule CONFIG_SERIAL_SGI_IOC3=m Dave> CONFIG_SGI_IOC3=m

Just tried it and it works fine for me:

margin:~ # insmod ioc3.ko
margin:~ # insmod ioc3_serial.ko
margin:~ #

This is with the latest git tree from Linus this morning.

Cheers,
Jes

author
#2 lore raw
Quoted 6 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Dave" == Dave Jones <[email protected]> writes:

Dave> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol Dave> ioc3_unregister_submodule CONFIG_SERIAL_SGI_IOC3=m Dave> CONFIG_SGI_IOC3=m

Quoted 7 lines

Just tried it and it works fine for me:

margin:~ # insmod ioc3.ko
margin:~ # insmod ioc3_serial.ko
margin:~ #

This is with the latest git tree from Linus this morning.

I still see problems with the latest Linus tree.

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_disable kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_gpcr_set kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_ack kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_register_submodule kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_enable kernel/drivers/pci/hotplug/rpaphp.ko needs unknown symbol pci_claim_resource

full .config at http://people.redhat.com/davej/ia64.config

Dave

#3 lore raw

PATCH 1/1 drivers/sn/ must be entered for CONFIG_SGI_IOC3

In reply to Dave Jones
Quoted 4 lines · Dave Jones

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

CONFIG_SERIAL_SGI_IOC3=m
CONFIG_SGI_IOC3=m

The untested patch below should fix it.

Quoted 1 line

Dave

cu
Adrian

<-- snip -->

drivers/Makefile renamed from drivers/Makefile.old +1 -0
@@ -70,6 +70,7 @@
 obj-$(CONFIG_CPU_FREQ)		+= cpufreq/
 obj-$(CONFIG_MMC)		+= mmc/
 obj-$(CONFIG_INFINIBAND)	+= infiniband/
+obj-$(CONFIG_SGI_IOC3)		+= sn/
 obj-$(CONFIG_SGI_IOC4)		+= sn/
 obj-y				+= firmware/
 obj-$(CONFIG_CRYPTO)		+= crypto/
#4 lore raw

Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Adrian" = Adrian Bunk <[email protected]> writes:

Quoted 4 lines · Dave Jones
Quoted 4 lines

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m

Adrian> The untested patch below should fix it.

Actually I think this is more appropriate so we don't end up with 17 cases that add drivers/sn to the build lib.

Dave, does this solve the problem?

Cheers,
Jes

Include drivers/sn when CONFIG_IA64_SGI_SN2 or CONFIG_IA64_GENERIC is enabled.

----

 arch/ia64/Kconfig |    3 +++
 drivers/Makefile  |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

Index: linux-2.6/arch/ia64/Kconfig =================================--- linux-2.6.orig/arch/ia64/Kconfig +++ linux-2.6/arch/ia64/Kconfig
@@ -374,6 +374,9 @@
To use this option, you have to ensure that the "/proc file system support" (CONFIG_PROC_FS) is enabled, too.

+config SGI_SN
+ def_bool y if (IA64_SGI_SN2 || IA64_GENERIC)
+
source "drivers/firmware/Kconfig"

source "fs/Kconfig.binfmt"
Index: linux-2.6/drivers/Makefile =================================--- linux-2.6.orig/drivers/Makefile +++ linux-2.6/drivers/Makefile
@@ -69,7 +69,7 @@
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_INFINIBAND) += infiniband/
-obj-$(CONFIG_SGI_IOC4) += sn/
+obj-$(CONFIG_SGI_SN) += sn/
obj-y += firmware/
obj-$(CONFIG_CRYPTO) += crypto/
obj-$(CONFIG_SUPERH) += sh/

#5 lore raw

Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

Quoted 6 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Adrian" = Adrian Bunk <[email protected]> writes:

Quoted 3 lines · Dave Jones
Quoted 3 lines

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

Quoted 7 lines
Quoted 1 line
Quoted 1 line

CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m

Adrian> The untested patch below should fix it.

Actually I think this is more appropriate so we don't end up with 17 cases that add drivers/sn to the build lib.
...

I haven't tested your patch, but I agree that it's a better approach than my patch.

Quoted 3 lines

Cheers,
Jes
...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#6 lore raw

Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3

In reply to Jes Sorensen
Quoted 6 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Adrian" = Adrian Bunk <[email protected]> writes:

Quoted 3 lines · Dave Jones
Quoted 3 lines

kernel/drivers/serial/ioc3_serial.ko needs unknown symbol ioc3_unregister_submodule

Quoted 8 lines
Quoted 1 line
Quoted 1 line

CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m

Adrian> The untested patch below should fix it.

Actually I think this is more appropriate so we don't end up with 17 cases that add drivers/sn to the build lib.

Dave, does this solve the problem?

Yep, looks like it.

Dave