Skip to contentSkip to conversation

Add ATI smbus to PIIX4

PATCH New Rudolf Marek 2 participants 3 messages Mar 12, 2006 – Mar 13, 2006

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 Add ATI smbus to PIIX4

Hi Rudolf,

Quoted 2 lines

This patch is just more cleaner version of the earlier. Please test it (who has ATI chipset) I did not compile it (lack of time), but I belive it is OK

Compiles fine, but I'd have the following comments:

Documentation/i2c/busses/i2c-piix4

Quoted 5 lines
Documentation/i2c/busses/i2c-piix4 +2 -0
(...)
+  * ATI IXP southbridges IXP200, IXP300, IXP400
+    Datasheet: N/A

"N/A" usually stands for "not applicable", which isn't relevant here; "Not publicly available" would be better.

drivers/i2c/busses/Kconfig

Quoted 5 lines
drivers/i2c/busses/Kconfig +1 -1
(...)
-	tristate "Intel PIIX4"
+	tristate "Intel PIIX4/ATI/Serverworks/Broadcom"

This formulation is a bit confusing, as it suggests that ATI, Serverwords and Broadcom are chips made by Intel ;) I'd go for "Intel PIIX4 and compatible".

Quoted 6 lines
drivers/i2c/busses/Kconfig +1 -2
 	  If you say yes to this option, support will be included for the Intel
 	  PIIX4 family of mainboard I2C interfaces.  Specifically, the following
-	  versions of the chipset are supported (note that Serverworks is part
-	  of Broadcom):
+	  versions of the chipset are supported:
 	    Intel PIIX4

drivers/i2c/busses/Kconfig

Quoted 10 lines
drivers/i2c/busses/Kconfig +4 -1
 	    Intel 440MX
+	    ATI IXP200
+	    ATI IXP300
+	    ATI IXP400
+	    Broadcom HT-1000
 	    Serverworks OSB4
 	    Serverworks CSB5
 	    Serverworks CSB6
-	    Serverworks HT-1000
 	    SMSC Victory66

Please back out the Serverworks vs. Broadcom changes. Not only I don't see them as useful, but more importantly they don't belong to that patch.

Otherwise the patch has all I wanted, thanks, good job.

Signature · 1 line
Jean Delvare
#2 lore raw

PATCH 1/1 Add ATI smbus to PIIX4

In reply to Rudolf Marek

Hi,

Quoted 1 line

Compiles fine, but I'd have the following comments:

Good.

Quoted 2 lines

"N/A" usually stands for "not applicable", which isn't relevant here; "Not publicly available" would be better.

I always thought it is not avail...

Quoted 12 lines

drivers/i2c/busses/Kconfig

Quoted 7 lines
drivers/i2c/busses/Kconfig +1 -1
(...)
-	tristate "Intel PIIX4"
+	tristate "Intel PIIX4/ATI/Serverworks/Broadcom"

This formulation is a bit confusing, as it suggests that ATI, Serverwords and Broadcom are chips made by Intel ;) I'd go for "Intel PIIX4 and compatible".

Fixed

Quoted 15 lines
Quoted 15 lines

If you say yes to this option, support will be included for the Intel PIIX4 family of mainboard I2C interfaces. Specifically, the following

drivers/i2c/busses/Kconfig +1 -2
-	  versions of the chipset are supported (note that Serverworks is part
-	  of Broadcom):
+	  versions of the chipset are supported:
	    Intel PIIX4
	    Intel 440MX
drivers/i2c/busses/Kconfig +4 -0
+	    ATI IXP200
+	    ATI IXP300
+	    ATI IXP400
+	    Broadcom HT-1000

Serverworks OSB4
Serverworks CSB5

Quoted 8 lines
Quoted 3 lines

Serverworks CSB6

drivers/i2c/busses/Kconfig +0 -1
-	    Serverworks HT-1000

SMSC Victory66

Please back out the Serverworks vs. Broadcom changes. Not only I don't see them as useful, but more importantly they don't belong to that patch.

OK, I thought bit tidy up can be done...

Quoted 1 line

Otherwise the patch has all I wanted, thanks, good job.

Tnx ;)

This patch adds the ATI IXP southbridges support to i2c-piix4, as it turned out those chips are compatible with it.

Signed-off-by Rudolf Marek <r.marek at sh.cvut.cz>

Regards,
Rudolf
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: piix4_add_ati2
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060313/2f60ea06/piix4_add_ati2.pl