Skip to contentSkip to conversation

minor Makefile fix

PATCH New Aron Griffis 1 participant 1 message Mar 21, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 minor Makefile fix

The patch below prevents a stray error message in the case that either DISTDIR or DESTDIR is empty, by preventing readlink from being called in that case.

Another option would be to use readlink -s, but that has the undesirable effect of staying silent in situations other than empty DISTDIR/DESTDIR

tools/examples/Makefile Tue Mar 21 16:53:04 2006 -0500 renamed from tools/examples/Makefile Mon Mar 20 09:56:58 2006 -0700 +2 -2
diff -r 9afd25b90af4 tools/examples/Makefile
@@ -38,8 +38,8 @@ UDEV_RULES_DIR = /etc/udev
 UDEV_RULES_DIR = /etc/udev
 UDEV_RULES = xen-backend.rules
 
-DI = $(shell readlink -f $(DISTDIR))
-DE = $(shell readlink -f $(DESTDIR))
+DI = $(if $(DISTDIR),$(shell readlink -f $(DISTDIR)),)
+DE = $(if $(DESTDIR),$(shell readlink -f $(DESTDIR)),)
 ifeq ($(findstring $(DI),$(DE)),$(DI))
 HOTPLUGS=install-hotplug install-udev
 else

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel