compile error in ieee80211_ioctl.c
Subsystems (2)
PATCH 1/1 compile error in ieee80211_ioctl.c
Hello:
I sent this patch earlier and got no response, so I'm sending it again.
I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c into a module:
CC [M] net/d80211/ieee80211_ioctl.onet/d80211/ieee80211_ioctl.c:33: error: syntax error before string constant net/d80211/ieee80211_ioctl.c:33: warning: type defaults to int' in declaration of MODULE_PARM' net/d80211/ieee80211_ioctl.c:33: warning: function declaration isn't a prototype net/d80211/ieee80211_ioctl.c:33: warning: data definition has no type or storage class net/d80211/ieee80211_ioctl.c:43: error: syntax error before string constant net/d80211/ieee80211_ioctl.c:43: warning: type defaults to int' in declaration of MODULE_PARM' net/d80211/ieee80211_ioctl.c:43: warning: function declaration isn't a prototype net/d80211/ieee80211_ioctl.c:43: warning: data definition has no type or storage class make[2]: *** [net/d80211/ieee80211_ioctl.o] Error 1
make[1]: *** [net/d80211] Error 2
make: *** [net] Error 2
This patch fixes it.
net/d80211/ieee80211_ioctl.c +2 -2
@@ -30,7 +30,7 @@ #include "aes_ccm.h"static int ieee80211_regdom =0x10 ;/* FCC */ -MODULE_PARM (ieee80211_regdom,"i" ); +module_param (ieee80211_regdom, int,0x10 );MODULE_PARM_DESC (ieee80211_regdom,"IEEE 802.11 regulatory domain; 64=MKK" );/*
@@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE* module. */ static int ieee80211_japan_5ghz/* = 0 */ ; -MODULE_PARM (ieee80211_japan_5ghz,"i" ); +module_param (ieee80211_japan_5ghz, int,0 );MODULE_PARM_DESC (ieee80211_japan_5ghz,"Vendor-updated firmware for 5 GHz" );
I code, therefore I am
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Quoted 3 lines · On Tue, 25 Apr 2006 14:04:50 -0700 (PDT) Alex Davis wrote:
Hello:
I sent this patch earlier and got no response, so I'm sending it again.
There was at least one reply, from me.
The third parameter of module_param() is being misused in your patch. It represents a "permission" value, such as 0, 0444, 0644, etc. Or you can use existing #defined values for it.
Quoted 35 lines
I cloned
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
last night and got compile errors while compilingnet/d80211/ieee80211_ioctl.cinto a module:CC [M]
net/d80211/ieee80211_ioctl.onet/d80211/ieee80211_ioctl.c:33: error: syntax error before string constantnet/d80211/ieee80211_ioctl.c:33: warning: type defaults toint' in declaration ofMODULE_PARM'net/d80211/ieee80211_ioctl.c:33: warning: function declaration isn't a prototypenet/d80211/ieee80211_ioctl.c:33: warning: data definition has no type or storage classnet/d80211/ieee80211_ioctl.c:43: error: syntax error before string constantnet/d80211/ieee80211_ioctl.c:43: warning: type defaults toint' in declaration ofMODULE_PARM'net/d80211/ieee80211_ioctl.c:43: warning: function declaration isn't a prototypenet/d80211/ieee80211_ioctl.c:43: warning: data definition has no type or storage class make[2]: *** [net/d80211/ieee80211_ioctl.o] Error 1
make[1]: *** [net/d80211] Error 2
make: *** [net] Error 2This patch fixes it.
Signed-off-by Alex Davis <[email protected]>net/d80211/ieee80211_ioctl.c +1
-1@@ -30,7 +30,7 @@ #include "aes_ccm.h"static int ieee80211_regdom =0x10 ;/* FCC */ -MODULE_PARM (ieee80211_regdom,"i" ); +module_param (ieee80211_regdom, int,0x10 );MODULE_PARM_DESC (ieee80211_regdom,"IEEE 802.11 regulatory domain; 64=MKK" );/*
net/d80211/ieee80211_ioctl.c MODULE_PARM_DESC(ieee80211_regdom, "IEEE · line 44
Quoted 6 lines
net/d80211/ieee80211_ioctl.c +1
-1@@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE* module. */ static int ieee80211_japan_5ghz/* = 0 */ ; -MODULE_PARM (ieee80211_japan_5ghz,"i" ); +module_param (ieee80211_japan_5ghz, int,0 );MODULE_PARM_DESC (ieee80211_japan_5ghz,"Vendor-updated firmware for 5 GHz" );
---
~Randy
Quoted 8 lines · Alex Davis
Hello:
I sent this patch earlier and got no response, so I'm sending it again.
I cloned
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
last night and got compile errors while compilingnet/d80211/ieee80211_ioctl.cinto a module:
You may want to wait a little longer before getting huffy...your original post was on Sunday afternoon (<48 hours ago). You need to address Randy's concerns as well.
Thanks,
John
Signature · 2 lines
John W. Linville [email protected]
Quoted 10 lines · --- "John W. Linville
Quoted 8 lines · Alex Davis
Hello:
I sent this patch earlier and got no response, so I'm sending it again.
I cloned
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git
last night and got compile errors while compilingnet/d80211/ieee80211_ioctl.cinto a module:
Quoted 5 lines
You need to address Randy's concerns as well.
Thanks,
John
Here is an updated patch which addresses Randy's issues. I'm currently running this with no problems:
net/d80211/ieee80211_ioctl.c +2 -2
@@ -30,7 +30,7 @@ #include "aes_ccm.h"static int ieee80211_regdom =0x10 ;/* FCC */ -MODULE_PARM (ieee80211_regdom,"i" ); +module_param (ieee80211_regdom, int,0666 );MODULE_PARM_DESC (ieee80211_regdom,"IEEE 802.11 regulatory domain; 64=MKK" );/*
@@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE* module. */ static int ieee80211_japan_5ghz/* = 0 */ ; -MODULE_PARM (ieee80211_japan_5ghz,"i" ); +module_param (ieee80211_japan_5ghz, int,0666 );MODULE_PARM_DESC (ieee80211_japan_5ghz,"Vendor-updated firmware for 5 GHz" );
Quoted 3 lines
John W. Linville
[email protected]
I code, therefore I am
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Quoted 5 lines · Alex Davis
Here is an updated patch which addresses Randy's issues. I'm currently running this with no problems:
[...]
+module_param(ieee80211_regdom, int, 0666);
MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK");
NAK. Those parameters should not be writable yet.
Please see
http://marc.theaimsgroup.com/?l=linux-netdev&m=114565040832451&w=2 for the correct patch (hopefully John will pull it soon).
Jiri
Signature · 2 lines
Jiri Benc SUSE Labs
Quoted 7 lines · Jiri Benc
Quoted 5 lines · Alex Davis
Here is an updated patch which addresses Randy's issues. I'm currently running this with no problems:
[...]
+module_param(ieee80211_regdom, int, 0666);
MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK");
Quoted 5 lines
NAK. Those parameters should not be writable yet.
Please see
http://marc.theaimsgroup.com/?l=linux-netdev&m=114565040832451&w=2 for the correct patch (hopefully John will pull it soon).
This has now been addressed.
Thanks!
John
Signature · 2 lines
John W. Linville [email protected]
iwconfig shows Encrypt key off when using WEP.
I'm using the latest wireless dev git. wireless tools version 28. wpa_supplicant 0.4.8 .
Here's the output of iwconfig wlan0:
wlan0 IEEE 802.11g ESSID:"mysid"
Mode:Managed Frequency:2.437 GHz Access Point: xx:xx.....
RTS thr:off Fragment thr=2346 BEncryption key:off <--- should be 'on'
Here's lspci -v:
2:03.0 Network controller: Broadcom Corporation BCM4309 802.11a/b/g (rev 03)
Subsystem: Dell Truemobile 1450 MiniPCI
Flags: bus master, fast devsel, latency 32, IRQ 7
Memory at fafee000 (32-bit, non-prefetchable) [size=8K]
Here's the dmesg output from loading the module:
21428.599628] bcm43xx_d80211 driver
[21428.609511] ACPI: PCI Interrupt 0000:02:03.0[A] -> Link [LNKB] -> GSI 7 (level, low) -> IRQ 7 [21428.615559] bcm43xx_d80211: Chip ID 0x4306, rev 0x3 [21428.615561] bcm43xx_d80211: Number of cores: 5 [21428.615566] bcm43xx_d80211: Core 0: ID 0x800, rev 0x4, vendor 0x4243, enabled [21428.615574] bcm43xx_d80211: Core 1: ID 0x812, rev 0x5, vendor 0x4243, disabled [21428.615582] bcm43xx_d80211: Core 2: ID 0x80d, rev 0x2, vendor 0x4243, enabled [21428.615590] bcm43xx_d80211: Core 3: ID 0x807, rev 0x2, vendor 0x4243, disabled [21428.615597] bcm43xx_d80211: Core 4: ID 0x804, rev 0x9, vendor 0x4243, enabled [21428.618895] bcm43xx_d80211: PHY connected [21428.618907] bcm43xx_d80211: Detected PHY: Version: 2, Type 2, Revision 2 [21428.618928] bcm43xx_d80211: Detected Radio: ID: 2205017f (Manuf: 17f Ver: 2050 Rev: 2) [21428.618943] bcm43xx_d80211: Radio turned off [21428.618970] bcm43xx_d80211: Radio turned off [21428.689486] wmaster0: Selected rate control algorithm 'simple' [21428.789510] bcm43xx_d80211: PHY connected [21428.992261] bcm43xx_d80211: Radio turned on [21429.186760] bcm43xx_d80211: Chip initialized [21429.186974] bcm43xx_d80211: DMA initialized [21429.186985] bcm43xx_d80211: 80211 cores initialized [21429.187199] bcm43xx_d80211: Keys cleared [21429.187239] wmaster0: Does not support passive scan, disabled
Here's my wep.conf file:
# Static WEP keys
ctrl_interface=/var/run/wpa_supplicant
network={
ssid="mysid"
auth_alg=OPEN
key_mgmt=NONE
wep_key0=111111919191919191919
wep_tx_keyidx=0
}Here's the wpa_supplicant command:wpa_supplicant -D wext -c ~/wep.conf -i wlan0
Other than that, it's been working perfectly.
Thanks
I code, therefore I am
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com