Skip to contentSkip to conversation

ixgb: driver update to 1.0.104-k4

PATCH In review Kok, Auke 2 participants 5 messages May 25, 2006 – May 26, 2006

Subsystems (2)
lore
Share & tools
lore

Kok, Auke

author
#0 lore raw

cover ixgb: driver update to 1.0.104-k4

Hi,

This is another resend of patches sent earlier by Jeff Kirsher and completes the resend for 1.0.104-kX.

Summary:

[1] add performance enhancements to the buffer_info struct
[2] implement copybreak
[3] increment version to 1.0.104-k4

These changes are available through git.

git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 ixgb-1.0.104-k4

these patches are against
netdev-2.6#upstream c49022b28187de43af673d9c3a31743dd9228c7a

Cheers,

Auke

---
 drivers/net/ixgb/ixgb.h      |    1 
 drivers/net/ixgb/ixgb_main.c |   96 ++++++++++++++++++++++++++++--------------
 2 files changed, 66 insertions(+), 31 deletions(-)

--
Auke Kok <[email protected]>

author
#1 lore raw

PATCH 1/3 ixgb: add performance enhancements to the buffer_info struct

o modify the rx refill logic and tail bump
o add counter for failures

---

 drivers/net/ixgb/ixgb.h      |    1 +
 drivers/net/ixgb/ixgb_main.c |   74 +++++++++++++++++++++++++-----------------
 2 files changed, 45 insertions(+), 30 deletions(-)
drivers/net/ixgb/ixgb.h +1 -0
index b9c37fd..bdbaf5a 100644
@@ -200,6 +200,7 @@ struct ixgb_adapter {
 	struct ixgb_hw hw;
 	u16 msg_enable;
 	struct ixgb_hw_stats stats;
+	uint32_t alloc_rx_buff_failed;
 #ifdef CONFIG_PCI_MSI
 	boolean_t have_msi;
 #endif
drivers/net/ixgb/ixgb_main.c +44 -30

131 lines not on this page · raw message

--
Auke Kok <[email protected]>

author
#2 lore raw

PATCH 2/3 ixgb: use rx copybreak/skb recycle

In reply to Kok, Auke

o use rx copybreak/skb recycle

---

 drivers/net/ixgb/ixgb_main.c |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
drivers/net/ixgb/ixgb_main.c +20 -0
index 27034b3..0e23994 100644
@@ -1990,6 +1990,26 @@ ixgb_clean_rx_irq(struct ixgb_adapter *a
 			goto rxdesc_done;
 		}
 
+		/* code added for copybreak, this should improve
+		 * performance for small packets with large amounts
+		 * of reassembly being done in the stack */
+#define IXGB_CB_LENGTH 256
+		if (length < IXGB_CB_LENGTH) {
+			struct sk_buff *new_skb =
+			    dev_alloc_skb(length + NET_IP_ALIGN);
+			if (new_skb) {
+				skb_reserve(new_skb, NET_IP_ALIGN);
+				new_skb->dev = netdev;
+				memcpy(new_skb->data - NET_IP_ALIGN,
+				       skb->data - NET_IP_ALIGN,
+				       length + NET_IP_ALIGN);
+				/* save the skb in buffer_info as good */
+				buffer_info->skb = skb;
+				skb = new_skb;
+			}
+		}
+		/* end copybreak code */
+
 		/* Good Receive */
 		skb_put(skb, length);
 

--
Auke Kok <[email protected]>

author
#3 lore raw

PATCH 3/3 ixgb: increment version to 1.0.104-k4

In reply to Kok, Auke

Increment the driver version to 1.0.104-k4

---

 drivers/net/ixgb/ixgb_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ixgb/ixgb_main.c +1 -1
index 0e23994..0a0c876 100644
@@ -52,7 +52,7 @@ static char ixgb_driver_string[] = "Inte
 #else
 #define DRIVERNAPI "-NAPI"
 #endif
-#define DRV_VERSION		"1.0.104-k2"DRIVERNAPI
+#define DRV_VERSION		"1.0.104-k4"DRIVERNAPI
 char ixgb_driver_version[] = DRV_VERSION;
 static char ixgb_copyright[] = "Copyright (c) 1999-2005 Intel Corporation.";
 

--
Auke Kok <[email protected]>

#4 lore raw
In reply to Kok, Auke
Quoted 8 lines · Auke

Hi,

This is another resend of patches sent earlier by Jeff Kirsher and completes the resend for 1.0.104-kX.

Summary:

Quoted 8 lines

[1] add performance enhancements to the buffer_info struct
[2] implement copybreak
[3] increment version to 1.0.104-k4

These changes are available through git.

git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 ixgb-1.0.104-k4

pulled