commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL'
open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway. Adrian, care to submit a patch to kill this senseless export entirely?
Ingo Molnar
Acked-byQuoted 7 lines · Christoph Hellwig
open_softirqjust enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum ininclude/linux/interrupt.hanyway. Adrian, care to submit a patch to kill this senseless export entirely?
good point.
Ingo
PATCH 1/1 unexport open_softirq
Christoph Hellwig:open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway.
kernel/softirq.c renamed from kernel/softirq.c.old +0 -2
@@ -311,8 +311,6 @@ softirq_vec[nr].action = action; } -EXPORT_UNUSED_SYMBOL (open_softirq);/* June 2006 */ -/* Tasklets */ struct tasklet_head {